Message ID | 20221015140447.55221-3-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp656872wrs; Sat, 15 Oct 2022 07:09:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6+qwUrirKuRZLn4S8/e8s7VaWpKQPk5q7mWObpdacYJPcI4yeBtNcTkMcNw3GTABoHCiEJ X-Received: by 2002:a17:90b:1644:b0:20d:459b:9d81 with SMTP id il4-20020a17090b164400b0020d459b9d81mr3597052pjb.196.1665842990584; Sat, 15 Oct 2022 07:09:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665842990; cv=none; d=google.com; s=arc-20160816; b=TrP3v0/hsg3dQt11gRfimKFR0eXpSqgic9LqoIhqLW+VQzm05IEFivBCrt7jf4mpNl RDhBIazojIerIz4EpSBnI7FGMOHfZZstKOVUhQPzb3+36758sIxec1+uPcjX1L18a1Ly cFnGqABwT4yn4T26QVrbsgZJwyIfcLt3dAsuK/003Z06cMmcRDOP1FKy8sruBUom1UJ6 3DfPvDjKpjmecQQS5vmbPWvHCyVN5f9yiV+Txuu8YJSf1d9s8N3jtghghfbEFWLvdb9V 0epvat5WrXTIKUr7yvd2ExWHgRHog14DSWUYKUFLle+JnTT5eHFOowFHTJNi1Lv+tyu+ okjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EYgNOPB2ou2QU09N065JCjsFs4GUgDaOF6Ag64S/wVc=; b=NmzmJqUrdExLbRKh2sQemptpVhpNImcCKV7vG/Z5yDDYziN7Ibf5YzXn6xlBwx6Wyi HmZsOLylvXSHQJWZnAaA5mUqFHHo6kzC8NpIL3c1kFpYQ6zWpd6XH+WXuHpnqNU0m9ci SXrDqW5Kti6mhszM7eqWKL9s+j8B6ypJbakptJH1zMP1PxZHH2zUAu/Jk5rMnEuco2GE MVyNKLdkZoQszGd+4ct1PQXdd4v0qJlxz6hz0gfPS6PfHzwtuLBLt4kGke7VPu42d/RA JfrUE8dgKekwAqg8aOI2Zu2Gs6Zz/wnwpd5NTqVkv+4nl4lMV1xv8LrIFo7coFsSzV/w PNLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Ud/w3bMW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i4-20020a170902c94400b0017a0c197f3fsi7043381pla.335.2022.10.15.07.09.38; Sat, 15 Oct 2022 07:09:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Ud/w3bMW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbiJOOFa (ORCPT <rfc822;rhyswoolcott@gmail.com> + 99 others); Sat, 15 Oct 2022 10:05:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbiJOOFX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 15 Oct 2022 10:05:23 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21AAB2CDEB for <linux-kernel@vger.kernel.org>; Sat, 15 Oct 2022 07:05:22 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id x13so4200025qkg.11 for <linux-kernel@vger.kernel.org>; Sat, 15 Oct 2022 07:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EYgNOPB2ou2QU09N065JCjsFs4GUgDaOF6Ag64S/wVc=; b=Ud/w3bMWnByY+ubVBteDK8+NuzzWFrNAMvoeQTFka+kW068kMHwt16riEPTZwjz2Yd Qb7XPXqLamRfrc5ra6AuhRYROt34DAkztH3jp9lRjUNuHadeikIj+pLRsXZTLLBsklXH SQ/Wbfp2gdCLzixYOWDHc9YUqZPP1QUnf9oIyAPAQ1U5ZAGQM3SpzQA63R0u++Z1MbJn +fec0HaXmt5VvK+m3HgFOyj0lGtPZHmZkxmS/km4KMbRfwcmdKNw7hVAIW25v9cHoA/2 JYmFtEys8Vv5vgRoZee4OBlEIIMSBBL9dJKIxPwYR3T/FUxXMo6gIaJdWfSiRdoU7HTq ojBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EYgNOPB2ou2QU09N065JCjsFs4GUgDaOF6Ag64S/wVc=; b=1WDHjqdwc288Mw1kLkwBmGAEmYhjIkhvWv+EmxEB33lpnhHFNjcvT52VY8s0U+R8XQ NJIQPkOEskCCKzKEJdWI+vutPSyZGDdhLZm3msdPvE5Lk0pBxdHSKHiiWmDR0vx4px37 tGtr0vEGPMs2eb4h5Xp2Z9YG+ONo9ZwcB+Y9P9p04lSiUjc9AzFrridM2XTd5AH4AAU6 jOjeoER6XmjgqETFAiSRwxQAKu6UiEp2rMa+dAQAJqoIxOeHsZfMnJ4jQOBnlkpR3mVw pQ3dGYFU3kAzSccKpwQx7dS75va7GfnC+dAnMgTR4h6uJBvmIDkUYa0wpvJQ3f+5MH6O Na4A== X-Gm-Message-State: ACrzQf0IXszPj6dsnM0yhcv0d8QJrS0/JpW7cg+GIPgJFByMkXduIQmf KRF10f5wuWqUBiTP+ZoQ4UUcIQ== X-Received: by 2002:a05:620a:298a:b0:6ce:7aa7:f01f with SMTP id r10-20020a05620a298a00b006ce7aa7f01fmr1834266qkp.611.1665842721806; Sat, 15 Oct 2022 07:05:21 -0700 (PDT) Received: from krzk-bin.hsd1.pa.comcast.net ([2601:42:0:3450:161:5720:79e9:9739]) by smtp.gmail.com with ESMTPSA id s21-20020a05620a29d500b006bb78d095c5sm4958022qkp.79.2022.10.15.07.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Oct 2022 07:05:20 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Richard Acayan <mailingradian@gmail.com>, Melody Olvera <quic_molvera@quicinc.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 2/5] dmaengine: qcom: gpi: document preferred SM6350 binding Date: Sat, 15 Oct 2022 10:04:44 -0400 Message-Id: <20221015140447.55221-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221015140447.55221-1-krzysztof.kozlowski@linaro.org> References: <20221015140447.55221-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746762979258510373?= X-GMAIL-MSGID: =?utf-8?q?1746762979258510373?= |
Series |
dma/arm64: qcom: use one compatible also for 0x10000 offset
|
|
Commit Message
Krzysztof Kozlowski
Oct. 15, 2022, 2:04 p.m. UTC
Devices with ee offset of 0x10000 should rather bind with SM6350
compatible, so the list will not unnecessarily grow for compatible
devices.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/dma/qcom/gpi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Comments
> Devices with ee offset of 0x10000 should rather bind with SM6350 > compatible, so the list will not unnecessarily grow for compatible > devices. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/dma/qcom/gpi.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index f8e19e6e6117..061add832295 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) > } > > static const struct of_device_id gpi_of_match[] = { > - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, > { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, > { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, > /* > - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as > - * fallback and not need their own entries here. This comment is from the dependency series [1]. Why would we need to add it just to remove it here? I was not notified that the dependency was applied anywhere (except as a base for other series) so it's not set in stone. Let's just drop the original patch that this comment originates from to prevent needlessly adding and removing the same lines at once. [1] https://lore.kernel.org/linux-arm-msm/20221007213640.85469-4-mailingradian@gmail.com/ > + * Do not grow the list for compatible devices. Instead use > + * qcom,sdm845-gpi-dma (for ee_offset = 0x0) or qcom,sm6350-gpi-dma > + * (for ee_offset = 0x10000). > */ > + { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, > { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 }, > { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 }, > { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 }, > -- > 2.34.1 >
On 17/10/2022 17:23, Richard Acayan wrote: >> Devices with ee offset of 0x10000 should rather bind with SM6350 >> compatible, so the list will not unnecessarily grow for compatible >> devices. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> drivers/dma/qcom/gpi.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c >> index f8e19e6e6117..061add832295 100644 >> --- a/drivers/dma/qcom/gpi.c >> +++ b/drivers/dma/qcom/gpi.c >> @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) >> } >> >> static const struct of_device_id gpi_of_match[] = { >> - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, >> { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, >> { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, >> /* >> - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as >> - * fallback and not need their own entries here. > > This comment is from the dependency series [1]. Why would we need to add it just > to remove it here? I was not notified that the dependency was applied anywhere > (except as a base for other series) so it's not set in stone. Let's just drop > the original patch that this comment originates from to prevent needlessly > adding and removing the same lines at once. I don't remove the comment, I re-phrase it to be better suited for final code. Best regards, Krzysztof
> On 17/10/2022 17:23, Richard Acayan wrote: >>> Devices with ee offset of 0x10000 should rather bind with SM6350 >>> compatible, so the list will not unnecessarily grow for compatible >>> devices. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> drivers/dma/qcom/gpi.c | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c >>> index f8e19e6e6117..061add832295 100644 >>> --- a/drivers/dma/qcom/gpi.c >>> +++ b/drivers/dma/qcom/gpi.c >>> @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) >>> } >>> >>> static const struct of_device_id gpi_of_match[] = { >>> - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, >>> { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, >>> { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, >>> /* >>> - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as >>> - * fallback and not need their own entries here. >> >> This comment is from the dependency series [1]. Why would we need to add it just >> to remove it here? I was not notified that the dependency was applied anywhere >> (except as a base for other series) so it's not set in stone. Let's just drop >> the original patch that this comment originates from to prevent needlessly >> adding and removing the same lines at once. > > I don't remove the comment, I re-phrase it to be better suited for final > code. Yes, I didn't word that exactly right. I still think the patch that adds this is now useless if it's just going to be replaced. Do you think I should keep the patch that this comment originates from, even though we already know exactly how its substantial contents will be replaced? We can't modify history and drop commits on kernel trees, but I can still send a v6 series that drops the original comment. > > Best regards, > Krzysztof >
On 17/10/2022 18:00, Richard Acayan wrote: >> On 17/10/2022 17:23, Richard Acayan wrote: >>>> Devices with ee offset of 0x10000 should rather bind with SM6350 >>>> compatible, so the list will not unnecessarily grow for compatible >>>> devices. >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> drivers/dma/qcom/gpi.c | 7 ++++--- >>>> 1 file changed, 4 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c >>>> index f8e19e6e6117..061add832295 100644 >>>> --- a/drivers/dma/qcom/gpi.c >>>> +++ b/drivers/dma/qcom/gpi.c >>>> @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) >>>> } >>>> >>>> static const struct of_device_id gpi_of_match[] = { >>>> - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, >>>> { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, >>>> { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, >>>> /* >>>> - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as >>>> - * fallback and not need their own entries here. >>> >>> This comment is from the dependency series [1]. Why would we need to add it just >>> to remove it here? I was not notified that the dependency was applied anywhere >>> (except as a base for other series) so it's not set in stone. Let's just drop >>> the original patch that this comment originates from to prevent needlessly >>> adding and removing the same lines at once. >> >> I don't remove the comment, I re-phrase it to be better suited for final >> code. > > Yes, I didn't word that exactly right. I still think the patch that adds this is > now useless if it's just going to be replaced. Do you think I should keep the > patch that this comment originates from, even though we already know exactly how > its substantial contents will be replaced? > > We can't modify history and drop commits on kernel trees, but I can still send > a v6 series that drops the original comment. Sure. You can make it then: * Do not grow the list for compatible devices. Instead use * qcom,sdm845-gpi-dma (for ee_offset = 0x0). And my patch will just change one line. We can also keep it like: * Do not grow the list for compatible devices. Instead use * proper fallback compatibles. Best regards, Krzysztof
> On 17/10/2022 18:00, Richard Acayan wrote: >>> On 17/10/2022 17:23, Richard Acayan wrote: >>>>> Devices with ee offset of 0x10000 should rather bind with SM6350 >>>>> compatible, so the list will not unnecessarily grow for compatible >>>>> devices. >>>>> >>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> --- >>>>> drivers/dma/qcom/gpi.c | 7 ++++--- >>>>> 1 file changed, 4 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c >>>>> index f8e19e6e6117..061add832295 100644 >>>>> --- a/drivers/dma/qcom/gpi.c >>>>> +++ b/drivers/dma/qcom/gpi.c >>>>> @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) >>>>> } >>>>> >>>>> static const struct of_device_id gpi_of_match[] = { >>>>> - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, >>>>> { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, >>>>> { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, >>>>> /* >>>>> - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as >>>>> - * fallback and not need their own entries here. >>>> >>>> This comment is from the dependency series [1]. Why would we need to add it just >>>> to remove it here? I was not notified that the dependency was applied anywhere >>>> (except as a base for other series) so it's not set in stone. Let's just drop >>>> the original patch that this comment originates from to prevent needlessly >>>> adding and removing the same lines at once. >>> >>> I don't remove the comment, I re-phrase it to be better suited for final >>> code. >> >> Yes, I didn't word that exactly right. I still think the patch that adds this is >> now useless if it's just going to be replaced. Do you think I should keep the >> patch that this comment originates from, even though we already know exactly how >> its substantial contents will be replaced? >> >> We can't modify history and drop commits on kernel trees, but I can still send >> a v6 series that drops the original comment. > > Sure. You can make it then: > > * Do not grow the list for compatible devices. Instead use > * qcom,sdm845-gpi-dma (for ee_offset = 0x0). If you don't want me to drop the original patch completely, then there is no need to make any changes at all to the driver patches IMHO. I originally thought we only needed one patch for the driver (yours) but you seem to have a really good reason not to drop the original patch. Sorry for asking. I guess you can add this if you want: Acked-by: Richard Acayan <mailingradian@gmail.com> > > And my patch will just change one line. > > We can also keep it like: > > * Do not grow the list for compatible devices. Instead use > * proper fallback compatibles. > > Best regards, > Krzysztof >
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c index f8e19e6e6117..061add832295 100644 --- a/drivers/dma/qcom/gpi.c +++ b/drivers/dma/qcom/gpi.c @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) } static const struct of_device_id gpi_of_match[] = { - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, /* - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as - * fallback and not need their own entries here. + * Do not grow the list for compatible devices. Instead use + * qcom,sdm845-gpi-dma (for ee_offset = 0x0) or qcom,sm6350-gpi-dma + * (for ee_offset = 0x10000). */ + { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },