gcov: annotate uncovered branches [PR107537]

Message ID ccd68154-65bc-bd4b-be6b-cf71d00ee8e6@gmx.de
State Accepted
Headers
Series gcov: annotate uncovered branches [PR107537] |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Michael Förderer Dec. 14, 2022, 8:03 p.m. UTC
  Dear all,

this is a patch to print the gcov annotations (fallthrough or throw) als
to uncovered branches.


Best regards,

Michael
From b65cfc8a837cd9d1b6421978865210e59ba62e0e Mon Sep 17 00:00:00 2001
From: Spacetown <michael.foerderer@gmx.de>
Date: Sun, 4 Dec 2022 21:03:34 +0100
Subject: [PATCH] gcov: annotate uncovered branches [PR107537]
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

gcc/ChangeLog:
    PR gcc/107537
	* gcov.cc (output_branch_count): Add annotation '(fallthrough)' or '(throw)' also to uncovered branches.

Signed-off-by: Michael Förderer <michael.foerderer@gmx.de>
---
 gcc/gcov.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
  

Comments

Martin Liška Dec. 15, 2022, 11 a.m. UTC | #1
On 12/14/22 21:03, Michael Förderer via Gcc-patches wrote:
> Dear all,
> 
> this is a patch to print the gcov annotations (fallthrough or throw) als
> to uncovered branches.

Hey.

It's fine and I've just pushed the revision on your behalf:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=c263c3eba8953c341cd8ac2d0a5f2b8f38623016

Thanks for you contribution.
Martin

> 
> 
> Best regards,
> 
> Michael
  

Patch

diff --git a/gcc/gcov.cc b/gcc/gcov.cc
index 9cf1071166f..5314be8a887 100644
--- a/gcc/gcov.cc
+++ b/gcc/gcov.cc
@@ -2893,7 +2893,9 @@  output_branch_count (FILE *gcov_file, int ix, const arc_info *arc)
 		 arc->fall_through ? " (fallthrough)"
 		 : arc->is_throw ? " (throw)" : "");
       else
-	fnotice (gcov_file, "branch %2d never executed", ix);
+	fnotice (gcov_file, "branch %2d never executed%s", ix,
+     arc->fall_through ? " (fallthrough)"
+		 : arc->is_throw ? " (throw)" : "");
 
       if (flag_verbose)
 	fnotice (gcov_file, " (BB %d)", arc->dst->id);