diff mbox series

jfs: remove redundant assignments to ipaimap and ipaimap2

Message ID 20221017215636.863916-1-colin.i.king@gmail.com
State New
Headers
Series jfs: remove redundant assignments to ipaimap and ipaimap2 |

Commit Message

Colin Ian King Oct. 17, 2022, 9:56 p.m. UTC 
  The pointers ipaimap and ipaimap2 are initialized with values that are
never read, they are re-assigned later when they are required. The
initializations are redundant and can be removed.

Cleans up two clang scan build warnings:
fs/jfs/jfs_umount.c:42:16: warning: Value stored to 'ipaimap' during
its initialization is never read [deadcode.DeadStores]

fs/jfs/jfs_umount.c:43:16: warning: Value stored to 'ipaimap2' during
its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/jfs/jfs_umount.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dave Kleikamp Oct. 17, 2022, 10:39 p.m. UTC | #1 
On 10/17/22 4:56PM, Colin Ian King wrote:
> The pointers ipaimap and ipaimap2 are initialized with values that are
> never read, they are re-assigned later when they are required. The
> initializations are redundant and can be removed.

Hmm. Or we can remove the later assignments. That would seem more 
consistent with the ipbmap and ipimap.

> 
> Cleans up two clang scan build warnings:
> fs/jfs/jfs_umount.c:42:16: warning: Value stored to 'ipaimap' during
> its initialization is never read [deadcode.DeadStores]
> 
> fs/jfs/jfs_umount.c:43:16: warning: Value stored to 'ipaimap2' during
> its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   fs/jfs/jfs_umount.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_umount.c b/fs/jfs/jfs_umount.c
> index 3e8b13e6aa01..cc4d7e6e8a4b 100644
> --- a/fs/jfs/jfs_umount.c
> +++ b/fs/jfs/jfs_umount.c
> @@ -39,8 +39,8 @@ int jfs_umount(struct super_block *sb)
>   	struct jfs_sb_info *sbi = JFS_SBI(sb);
>   	struct inode *ipbmap = sbi->ipbmap;
>   	struct inode *ipimap = sbi->ipimap;
> -	struct inode *ipaimap = sbi->ipaimap;
> -	struct inode *ipaimap2 = sbi->ipaimap2;
> +	struct inode *ipaimap;
> +	struct inode *ipaimap2;
>   	struct jfs_log *log;
>   	int rc = 0;
>
diff mbox series

Patch

diff --git a/fs/jfs/jfs_umount.c b/fs/jfs/jfs_umount.c
index 3e8b13e6aa01..cc4d7e6e8a4b 100644
--- a/fs/jfs/jfs_umount.c
+++ b/fs/jfs/jfs_umount.c
@@ -39,8 +39,8 @@  int jfs_umount(struct super_block *sb)
 	struct jfs_sb_info *sbi = JFS_SBI(sb);
 	struct inode *ipbmap = sbi->ipbmap;
 	struct inode *ipimap = sbi->ipimap;
-	struct inode *ipaimap = sbi->ipaimap;
-	struct inode *ipaimap2 = sbi->ipaimap2;
+	struct inode *ipaimap;
+	struct inode *ipaimap2;
 	struct jfs_log *log;
 	int rc = 0;