Message ID | 20221213221227.56560374@gandalf.local.home |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp507865wrn; Tue, 13 Dec 2022 19:14:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf4KfB3MRCrO0Ue/ozdzYw+z3XA2UHcVlSdFd8WzOTVNBUdT2IsUwY5O3+AKNDIW/kGWCjKx X-Received: by 2002:a17:90a:7646:b0:219:756b:ec1e with SMTP id s6-20020a17090a764600b00219756bec1emr23425881pjl.28.1670987651867; Tue, 13 Dec 2022 19:14:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670987651; cv=none; d=google.com; s=arc-20160816; b=rJ8Yso59cNdqHnbUslQE/wSWAY3RPrD6yEyxfFDtSjI/mlLjojGVsGxKORsltTlAdg 9x7umSaRB+BWpsHPd1+buN4Uq6virjaUkUw3yWE63foJEuak5Ed05S6cI/2nU0tKnaE9 rbTqsVqbqKr5PmGGr1gaNgu1bldyrPz+h9s/Tbr/FIMTdUznWwfZEvggoBtbUb4MXUqj z8eOrYb/BEY+7YJ0oWFlScvg4bpwMxJZsZtt5hp3/FqnXuxLoPZ89ylsX39fKoIWos3v e2acNPK6W8dDKCi93NFumU83TIvIfaLlf6gZYeQxX8fcdJbT/ZrNwUi2SSHY5hSV9QVO rxTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date; bh=BjfMHfz2KdQD+95cDCmTfD6BoXMTPjWeHyK58rB2AZk=; b=hJtZKGW6r6qb/QV8qzkk8fB3fjNFh9SCKSbPvvY6+qIbYFQHqz6QwkuPkhYaVLQIT3 oNy9QDvpD4MHxZ7XcMd0jI+Gm3JbI0of8EoTG2tavGGJFD+unHuyKZP4NWvsrEYYUoLl BZOgEW4z8OW17T1s9jDKLZHFAIHvhP8cFlrzJ0u99z7vlkBCHNjYkdlbqnQgeaWombEF uf/FjDomOfn2jLaTuN0ogjVIXLFvr5oddvIzCAerOKBieU1eKxGUQRX+pOA5ssmw5laY ojXh2tJi/1eLLfjj/gM0h+CQzwOTTIK/IRCLa0kSDSfeGdS/KqCwOii1I4FMhUeIvrmY 8UMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l17-20020a656811000000b0046f9f498732si14131139pgt.303.2022.12.13.19.13.58; Tue, 13 Dec 2022 19:14:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236827AbiLNDMh (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com> + 99 others); Tue, 13 Dec 2022 22:12:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbiLNDMf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 13 Dec 2022 22:12:35 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCC852705; Tue, 13 Dec 2022 19:12:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E9479CE17E2; Wed, 14 Dec 2022 03:12:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77004C433EF; Wed, 14 Dec 2022 03:12:29 +0000 (UTC) Date: Tue, 13 Dec 2022 22:12:27 -0500 From: Steven Rostedt <rostedt@goodmis.org> To: LKML <linux-kernel@vger.kernel.org>, Linux Trace Kernel <linux-trace-kernel@vger.kernel.org> Cc: Masami Hiramatsu <mhiramat@kernel.org>, Andrew Morton <akpm@linux-foundation.org> Subject: [PATCH] tracing: Fix cpumask() example typo Message-ID: <20221213221227.56560374@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752157548107590395?= X-GMAIL-MSGID: =?utf-8?q?1752157548107590395?= |
Series |
tracing: Fix cpumask() example typo
|
|
Commit Message
Steven Rostedt
Dec. 14, 2022, 3:12 a.m. UTC
From: "Steven Rostedt (Google)" <rostedt@goodmis.org> The sample code for using cpumask used the wrong field for the __get_cpumask() helper. It used "cpus" which is the bitmask (but would still give a proper example) instead of the "cpum" that was there to be used. Although it produces the same output, fix it, because it's an example and is confusing in how to properly use the cpumask() macro. Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> --- samples/trace_events/trace-events-sample.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Tue, 13 Dec 2022 22:12:27 -0500 Steven Rostedt <rostedt@goodmis.org> wrote: > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > > The sample code for using cpumask used the wrong field for the > __get_cpumask() helper. It used "cpus" which is the bitmask (but would > still give a proper example) instead of the "cpum" that was there to be > used. > > Although it produces the same output, fix it, because it's an example and > is confusing in how to properly use the cpumask() macro. > Looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thanks, > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> > --- > samples/trace_events/trace-events-sample.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h > index fb4548a44153..1c6b843b8c4e 100644 > --- a/samples/trace_events/trace-events-sample.h > +++ b/samples/trace_events/trace-events-sample.h > @@ -359,7 +359,7 @@ TRACE_EVENT(foo_bar, > __print_array(__get_dynamic_array(list), > __get_dynamic_array_len(list) / sizeof(int), > sizeof(int)), > - __get_str(str), __get_bitmask(cpus), __get_cpumask(cpus), > + __get_str(str), __get_bitmask(cpus), __get_cpumask(cpum), > __get_str(vstr)) > ); > > -- > 2.35.1 >
On Tue, 13 Dec 2022 22:12:27 -0500 Steven Rostedt <rostedt@goodmis.org> wrote: > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > > The sample code for using cpumask used the wrong field for the > __get_cpumask() helper. It used "cpus" which is the bitmask (but would > still give a proper example) instead of the "cpum" that was there to be > used. > > Although it produces the same output, fix it, because it's an example and > is confusing in how to properly use the cpumask() macro. > Looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thanks, > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> > --- > samples/trace_events/trace-events-sample.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h > index fb4548a44153..1c6b843b8c4e 100644 > --- a/samples/trace_events/trace-events-sample.h > +++ b/samples/trace_events/trace-events-sample.h > @@ -359,7 +359,7 @@ TRACE_EVENT(foo_bar, > __print_array(__get_dynamic_array(list), > __get_dynamic_array_len(list) / sizeof(int), > sizeof(int)), > - __get_str(str), __get_bitmask(cpus), __get_cpumask(cpus), > + __get_str(str), __get_bitmask(cpus), __get_cpumask(cpum), > __get_str(vstr)) > ); > > -- > 2.35.1 >
diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h index fb4548a44153..1c6b843b8c4e 100644 --- a/samples/trace_events/trace-events-sample.h +++ b/samples/trace_events/trace-events-sample.h @@ -359,7 +359,7 @@ TRACE_EVENT(foo_bar, __print_array(__get_dynamic_array(list), __get_dynamic_array_len(list) / sizeof(int), sizeof(int)), - __get_str(str), __get_bitmask(cpus), __get_cpumask(cpus), + __get_str(str), __get_bitmask(cpus), __get_cpumask(cpum), __get_str(vstr)) );