Message ID | 20221015140447.55221-2-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp656174wrs; Sat, 15 Oct 2022 07:08:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5HmRHQGS1+b6/436kpSctAQQieppy5udqE5BJumqSzxdkd0hUvQKbpPKfdzjJC4qi7gtO3 X-Received: by 2002:a05:6a02:18f:b0:44a:3972:898d with SMTP id bj15-20020a056a02018f00b0044a3972898dmr2691681pgb.525.1665842901368; Sat, 15 Oct 2022 07:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665842901; cv=none; d=google.com; s=arc-20160816; b=Vl3fviPD6b0K9DSzLvvJBCsTrHlVpaQwT0gwEck8NJ0tl6Nv4TmuiJrBBbTRT8OMpw kvSOXWAk7aLl1znXj6vD5dRoLwbd1dALlGkq42dk/iZlN03qugRQGwBnn9QLjElI9HUR 6i+221uKZagHA2Ch7I9kfiobSwTkT1rwP+dnxJhIYIc8cIrKojeWgrejJzPauBHg2aib EH/eAfHZRZvBBXpQCv5HL1ohrO+y5BHyRLo5vHvu7lQbWN/fXBWR2f/HxdLAzK115I8x RYKQe4WxEu9qTYg9SHn53v6Xa9M4PuEi0N9Xx0pHl94NxanA5Nv9wMg+HKCnmpUtz4d5 0+2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bxQPINt+WD8WuWGRIKOof3DJAfj05njiHZmcwReVibA=; b=Dx3eG2TBUxZxnP2K28H7ft/qGLHzLz40F0q2mM1o/vhKdSL+6JG2G5a+4rICPbkGrP TJX/jtQTOr1VSmJWSqvgRmWbS38TPx9Kc0QNJnktaqkvu/CwSNyB2hNko1esW4DSW1wD AIfV+IUq2WWKhGqtqPOwBc8SWbm5VYRuhpocEJB3n8unJo6QfgG8VBdkz5JNqBLCfsKb f5jFo/nuY8AuF9A7374jWDztr3aIadTFwHgoamaTXS2Pu9cJKzRoeMGwiYPh/VwbR1Ze bcgScgnMMaBJDYBSIbUzOWw4eeCeBV2Jr16EzVPtIBHEXyOrj4wSsXgnfQrFLqLHTKRG qObA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="yZ/y5Cys"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 202-20020a6214d3000000b005634e5369bdsi5594947pfu.209.2022.10.15.07.08.02; Sat, 15 Oct 2022 07:08:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="yZ/y5Cys"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbiJOOF0 (ORCPT <rfc822;rhyswoolcott@gmail.com> + 99 others); Sat, 15 Oct 2022 10:05:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbiJOOFW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 15 Oct 2022 10:05:22 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFC5D2D74A for <linux-kernel@vger.kernel.org>; Sat, 15 Oct 2022 07:05:20 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id a5so4207758qkl.6 for <linux-kernel@vger.kernel.org>; Sat, 15 Oct 2022 07:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bxQPINt+WD8WuWGRIKOof3DJAfj05njiHZmcwReVibA=; b=yZ/y5Cys1uIvd1d84CoC8Sw3LmvRXIQ9X05Zp7sAY9BPQHYQW4BOgLaN5q8mO9jXHP YGayNBP6G6f2KR35YOqkpU345nbUzFq+r86wXek9O57trfy08SYyYUljH6UNDV7WZ/Md dU9hlBYNp+VF/zAPpNXlqR8PGpyVhgTOjZLtTlbNh+XHv1/Yyd4jiNR3TPEJjYQiQGvh o1/s4AH+p6Ncm9gc612XF8Gm6oMDTJH0nHb3sDzAxUF7T2vRYY2uLdRzoTVhIUrv4T2K fXX/5Ef8qbtwVe/cZqtEGZYOwEZ0ToCPsi5OnH7NnZUB/i5dCCOJTBhJUOuxRgUV3BwO 2GNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bxQPINt+WD8WuWGRIKOof3DJAfj05njiHZmcwReVibA=; b=G/hP3HDhmsufgy2eKTTNCJF2KRx0We6a/Ir0Xn/UMEH9q5tpXaRCzDVtYg2KGKGTuO YStxcgLV86CVJ23oj5A+/mG6HWW5G2JbC2QBloiFv/m/cSwZv3mLKNQztAIC5MDKSdIX nH/ZEfSFJm7iQL21W35UxD7mgqa67wGYr/UNU70FOiIqyozrCFg7sREz3QrXT7WyW+Bv j8qgUvQXDq64p5w3+jEMUU7Io01G0pxaB33QdLDbq2YtpSNPRrdrTNG7ptdCy8t5hoCL cwgHJHHr8hlXQ8Kl9RiF0ktCIbwZhjXPTmvBPX9QTAhXV7nV2ARY/lohfmbmP3EGWVGG CUgg== X-Gm-Message-State: ACrzQf1X62oqxcTMik2NsfhvDdQ6Xu9S73bBodvOH+6I2Lmhv4xRF97N mn6x8pdvWEDuQVRWqC8PhGeWYw== X-Received: by 2002:a05:620a:126d:b0:6ea:cff7:3832 with SMTP id b13-20020a05620a126d00b006eacff73832mr1865407qkl.694.1665842719902; Sat, 15 Oct 2022 07:05:19 -0700 (PDT) Received: from krzk-bin.hsd1.pa.comcast.net ([2601:42:0:3450:161:5720:79e9:9739]) by smtp.gmail.com with ESMTPSA id s21-20020a05620a29d500b006bb78d095c5sm4958022qkp.79.2022.10.15.07.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Oct 2022 07:05:19 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Richard Acayan <mailingradian@gmail.com>, Melody Olvera <quic_molvera@quicinc.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 1/5] dt-bindings: dma: qcom: gpi: use sm6350 fallback Date: Sat, 15 Oct 2022 10:04:43 -0400 Message-Id: <20221015140447.55221-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221015140447.55221-1-krzysztof.kozlowski@linaro.org> References: <20221015140447.55221-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746762885845493157?= X-GMAIL-MSGID: =?utf-8?q?1746762885845493157?= |
Series |
dma/arm64: qcom: use one compatible also for 0x10000 offset
|
|
Commit Message
Krzysztof Kozlowski
Oct. 15, 2022, 2:04 p.m. UTC
Several devices like SM6350, SM8150 and SC7280 are actually compatible,
so use one compatible fallback for all of them.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
Comments
On 15-10-22, 10:04, Krzysztof Kozlowski wrote: > Several devices like SM6350, SM8150 and SC7280 are actually compatible, > so use one compatible fallback for all of them. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml > index 750b40c32213..0c2894498845 100644 > --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml > @@ -20,12 +20,14 @@ properties: > compatible: > oneOf: > - enum: > - - qcom,sc7280-gpi-dma > - qcom,sdm845-gpi-dma > - qcom,sm6350-gpi-dma > - - qcom,sm8350-gpi-dma > - - qcom,sm8450-gpi-dma > - > + - items: > + - enum: > + - qcom,sc7280-gpi-dma > + - qcom,sm8350-gpi-dma > + - qcom,sm8450-gpi-dma > + - const: qcom,sm6350-gpi-dma I think it makes sense but can we document this in binding as well that why people should use these two compatibles. I am fine with this being comments here.. > - items: > - enum: > - qcom,sdm670-gpi-dma > -- > 2.34.1
On Sat, 15 Oct 2022 10:04:43 -0400, Krzysztof Kozlowski wrote: > Several devices like SM6350, SM8150 and SC7280 are actually compatible, > so use one compatible fallback for all of them. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
> Several devices like SM6350, SM8150 and SC7280 are actually compatible, > so use one compatible fallback for all of them. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml > index 750b40c32213..0c2894498845 100644 > --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml > @@ -20,12 +20,14 @@ properties: > compatible: > oneOf: > - enum: > - - qcom,sc7280-gpi-dma > - qcom,sdm845-gpi-dma > - qcom,sm6350-gpi-dma > - - qcom,sm8350-gpi-dma > - - qcom,sm8450-gpi-dma > - If you don't want this empty line here, you can still ask for it to be removed in the original patch. It doesn't look like it was applied yet. > + - items: > + - enum: > + - qcom,sc7280-gpi-dma > + - qcom,sm8350-gpi-dma > + - qcom,sm8450-gpi-dma > + - const: qcom,sm6350-gpi-dma > - items: > - enum: > - qcom,sdm670-gpi-dma > -- > 2.34.1 >
On 17/10/2022 17:10, Richard Acayan wrote: >> Several devices like SM6350, SM8150 and SC7280 are actually compatible, >> so use one compatible fallback for all of them. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml >> index 750b40c32213..0c2894498845 100644 >> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml >> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml >> @@ -20,12 +20,14 @@ properties: >> compatible: >> oneOf: >> - enum: >> - - qcom,sc7280-gpi-dma >> - qcom,sdm845-gpi-dma >> - qcom,sm6350-gpi-dma >> - - qcom,sm8350-gpi-dma >> - - qcom,sm8450-gpi-dma >> - > > If you don't want this empty line here, you can still ask for it to be removed > in the original patch. It doesn't look like it was applied yet. > Sure. Best regards, Krzysztof
On 17/10/2022 06:37, Vinod Koul wrote: > On 15-10-22, 10:04, Krzysztof Kozlowski wrote: >> Several devices like SM6350, SM8150 and SC7280 are actually compatible, >> so use one compatible fallback for all of them. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml >> index 750b40c32213..0c2894498845 100644 >> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml >> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml >> @@ -20,12 +20,14 @@ properties: >> compatible: >> oneOf: >> - enum: >> - - qcom,sc7280-gpi-dma >> - qcom,sdm845-gpi-dma >> - qcom,sm6350-gpi-dma >> - - qcom,sm8350-gpi-dma >> - - qcom,sm8450-gpi-dma >> - >> + - items: >> + - enum: >> + - qcom,sc7280-gpi-dma >> + - qcom,sm8350-gpi-dma >> + - qcom,sm8450-gpi-dma >> + - const: qcom,sm6350-gpi-dma > > I think it makes sense but can we document this in binding as well that > why people should use these two compatibles. I am fine with this being > comments here.. It is kind of implied (and maybe obvious) from the bindings - a list of two items, one enum and one fallback compatible. We usually do not document such patterns in the bindings with comments for that reason. If you insist, I can add it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml index 750b40c32213..0c2894498845 100644 --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml @@ -20,12 +20,14 @@ properties: compatible: oneOf: - enum: - - qcom,sc7280-gpi-dma - qcom,sdm845-gpi-dma - qcom,sm6350-gpi-dma - - qcom,sm8350-gpi-dma - - qcom,sm8450-gpi-dma - + - items: + - enum: + - qcom,sc7280-gpi-dma + - qcom,sm8350-gpi-dma + - qcom,sm8450-gpi-dma + - const: qcom,sm6350-gpi-dma - items: - enum: - qcom,sdm670-gpi-dma