diff mbox series

[v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node

Message ID 20221017185105.2279129-1-caleb.connolly@linaro.org
State New
Headers
Series [v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node |

Commit Message

Caleb Connolly Oct. 17, 2022, 6:51 p.m. UTC 
  Document the rradc node name, like adc-tm it's only used on a few
platforms, so differentiate it from the standard adc node.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---

V1: https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
Changes since v1:
 * Add a new node instead of using the adc@ node
 * no longer depend on Luca's patch
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rob Herring Oct. 17, 2022, 7:42 p.m. UTC | #1 
On Mon, Oct 17, 2022 at 1:52 PM Caleb Connolly
<caleb.connolly@linaro.org> wrote:
>
> Document the rradc node name, like adc-tm it's only used on a few
> platforms, so differentiate it from the standard adc node.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>
> V1: https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
> Changes since v1:
>  * Add a new node instead of using the adc@ node
>  * no longer depend on Luca's patch
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
>  1 file changed, 4 insertions(+)

Doesn't apply to rc1.

Rob
Krzysztof Kozlowski Oct. 17, 2022, 8:13 p.m. UTC | #2 
On 17/10/2022 14:51, Caleb Connolly wrote:
> Document the rradc node name, like adc-tm it's only used on a few
> platforms, so differentiate it from the standard adc node.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> 
> V1: https://lore.kernel.org/linux-arm-msm/20221016175757.1911016-1-caleb.connolly@linaro.org/
> Changes since v1:
>  * Add a new node instead of using the adc@ node
>  * no longer depend on Luca's patch

This is not what I proposed. The node name should stay adc as it is
generic. I propose to do it the same way as in
f4b632da13cf0ee39cdbd4ff08d1961ed50e3c14

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 65cbc6dee545..631141f99bce 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -101,6 +101,10 @@  patternProperties:
     type: object
     $ref: /schemas/thermal/qcom-spmi-adc-tm5.yaml#
 
+  "^rradc@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/iio/adc/qcom,spmi-rradc.yaml#
+
   "^audio-codec@[0-9a-f]+$":
     type: object
     additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet