Message ID | 20221207091112.2258674-1-guoren@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp70100wrr; Wed, 7 Dec 2022 01:13:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf47fkipip1re6FhmYqjnpQG55GYFoVNzQA2KOyGx0dWtaz/iavh7Td0KvVxaiWwWKzxr4jm X-Received: by 2002:a05:6402:22ab:b0:46a:abc8:8018 with SMTP id cx11-20020a05640222ab00b0046aabc88018mr49724611edb.369.1670404418071; Wed, 07 Dec 2022 01:13:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670404418; cv=none; d=google.com; s=arc-20160816; b=Vma+FsW39t6aE0xaTYVOwkzU8mUW3FlNf6uCenlPI3YWFb1mWDdcTnczscRTZ95GoE kjWAKmYzftf+fT05yB/ExjSc7SaqldItiLmpQkcE/4udxQQNm1+gZbIGyNN/7jsdl+s6 r9knBUZ2oY+CeuoHwQRAyHzabmqC7Syioh1aT8ZathjX/qlh+cELGhR/lFynxaNikeDs 6eAaCDd0u+juUZYpY4n0YPn4tbxGQm4INoT/ApLJ1O9WkAnMEvue1x3h5gTa3c01GfiV cBBdayGpoMB1HlYqSzW2oHOuBZKfbP7VHxIqmD0W8AhUxT9LPd4ewg7fdEtFCFMcjvDi Xh1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ATznMBCzL3S1Vo19pkEiQhIoSTouyv20amxek+BLbgA=; b=nmXFxilS1F972FcMty8pqzVdaYdsxrfw9QMzmS6q437pinA+7AqdnGvBCzv51IMaM9 SERnT5lbtcYcl8hWRja8vh8YUNCbrvzjaRGDXnc5EnLQgSgjoCbvScAxKcVaqqo61Nid KxcLeaDcvjVcD8iEyr0QKuZrdoqRDgs4OSQUDqHXAGhLcYnG5BdMKNnA4Kfltiwt3aJH 2JmWcZj+g/BHFLNR2pSYzByxNRy5wiVLqVyd+msIg703AFg4wkF3U3ZYqhJcH9ErOwSM /9h9roEe5DI95F99+KXR30oa28hiYEcclpqaXaXc037N3BSBI6Y4cvhFLxRTyekv9y8S ytww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="tl/xFYFy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb35-20020a170907162300b0078d9be7f100si11160938ejc.852.2022.12.07.01.13.15; Wed, 07 Dec 2022 01:13:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="tl/xFYFy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230102AbiLGJLx (ORCPT <rfc822;b08248@gmail.com> + 99 others); Wed, 7 Dec 2022 04:11:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbiLGJLd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 7 Dec 2022 04:11:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1E902EF49; Wed, 7 Dec 2022 01:11:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F45160AD9; Wed, 7 Dec 2022 09:11:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE5C7C433C1; Wed, 7 Dec 2022 09:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670404291; bh=+J9p7r7GyvB7mtC2Mdp1scaM+ReAbPChQfWFGWWj1h0=; h=From:To:Cc:Subject:Date:From; b=tl/xFYFy8V/+HKRLUzMbUO6Uee5tvFcSoxaeua2JXpWVeYh8NpSHm/4lKQONTO2w5 DpvaDNG1PV48NhUtybqbXDczK/IXTrnlGiv+mOtkAr2Lx7rPHg/X+9elCx2/ryxESZ Vvht0+A7QKoYiAyNEiEyvzlGKSXOgMLuYuRFgpKlfGyaIo9kfB3nlJZExSQXbsKKJV oOGJxqurKmJmyEPSXPWdukJtFIKY/n4of/0B5MpWU2k2sPXuuC/GeG60OuPndh7sLM 6FdsH46Ff8ySPucL2aQYCjRsgKCVIsWVami23clsBioEvq2Fzo6GjhmNxpSk7yBcpa kzHIDBzQ6d8rQ== From: guoren@kernel.org To: guoren@kernel.org, palmer@rivosinc.com, conor.dooley@microchip.com, liaochang1@huawei.com, lizhengyu3@huawei.com Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Guo Ren <guoren@linux.alibaba.com>, Conor Dooley <conor@kernel.org>, kernel test robot <lkp@intel.com> Subject: [PATCH] riscv: Fixup compile error with !MMU Date: Wed, 7 Dec 2022 04:11:12 -0500 Message-Id: <20221207091112.2258674-1-guoren@kernel.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751545983364261438?= X-GMAIL-MSGID: =?utf-8?q?1751545983364261438?= |
Series |
riscv: Fixup compile error with !MMU
|
|
Commit Message
Guo Ren
Dec. 7, 2022, 9:11 a.m. UTC
From: Guo Ren <guoren@linux.alibaba.com> Current nommu_virt_defconfig can't compile: In file included from arch/riscv/kernel/crash_core.c:3: arch/riscv/kernel/crash_core.c: In function 'arch_crash_save_vmcoreinfo': arch/riscv/kernel/crash_core.c:8:27: error: 'VA_BITS' undeclared (first use in this function) 8 | VMCOREINFO_NUMBER(VA_BITS); | ^~~~~~~ Add MMU dependency for KEXEC_FILE. Fixes: 6261586e0c91 ("RISC-V: Add kexec_file support") Reported-by: Conor Dooley <conor@kernel.org> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Guo Ren <guoren@kernel.org> Signed-off-by: Guo Ren <guoren@linux.alibaba.com> --- arch/riscv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Dec 07, 2022 at 04:11:12AM -0500, guoren@kernel.org wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > Current nommu_virt_defconfig can't compile: > > In file included from > arch/riscv/kernel/crash_core.c:3: > arch/riscv/kernel/crash_core.c: > In function 'arch_crash_save_vmcoreinfo': > arch/riscv/kernel/crash_core.c:8:27: > error: 'VA_BITS' undeclared (first use in this function) > 8 | VMCOREINFO_NUMBER(VA_BITS); > | ^~~~~~~ > > Add MMU dependency for KEXEC_FILE. > > Fixes: 6261586e0c91 ("RISC-V: Add kexec_file support") > Reported-by: Conor Dooley <conor@kernel.org> FWIW (but certainly don't resend for this) s/conor@kernel.org/conor.dooley@microchip.com Thanks for the quick fix, there's other issues w/ that config for me, but this fixed the kexec bits :) Tested-by: Conor Dooley <conor.dooley@microchip.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Guo Ren <guoren@kernel.org> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > --- > arch/riscv/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index ef8d66de5f38..91319044fd13 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -496,7 +496,7 @@ config KEXEC_FILE > select KEXEC_CORE > select KEXEC_ELF > select HAVE_IMA_KEXEC if IMA > - depends on 64BIT > + depends on 64BIT && MMU > help > This is new version of kexec system call. This system call is > file based and takes file descriptors as system call argument > -- > 2.36.1 >
On Wed, Dec 7, 2022 at 5:32 PM Conor Dooley <conor@kernel.org> wrote: > > On Wed, Dec 07, 2022 at 04:11:12AM -0500, guoren@kernel.org wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > > > Current nommu_virt_defconfig can't compile: > > > > In file included from > > arch/riscv/kernel/crash_core.c:3: > > arch/riscv/kernel/crash_core.c: > > In function 'arch_crash_save_vmcoreinfo': > > arch/riscv/kernel/crash_core.c:8:27: > > error: 'VA_BITS' undeclared (first use in this function) > > 8 | VMCOREINFO_NUMBER(VA_BITS); > > | ^~~~~~~ > > > > Add MMU dependency for KEXEC_FILE. > > > > Fixes: 6261586e0c91 ("RISC-V: Add kexec_file support") > > Reported-by: Conor Dooley <conor@kernel.org> > > FWIW (but certainly don't resend for this) > s/conor@kernel.org/conor.dooley@microchip.com > > Thanks for the quick fix, there's other issues w/ that config for me, > but this fixed the kexec bits :) > Tested-by: Conor Dooley <conor.dooley@microchip.com> Thx for the report and test. > > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Guo Ren <guoren@kernel.org> > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > --- > > arch/riscv/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > index ef8d66de5f38..91319044fd13 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -496,7 +496,7 @@ config KEXEC_FILE > > select KEXEC_CORE > > select KEXEC_ELF > > select HAVE_IMA_KEXEC if IMA > > - depends on 64BIT > > + depends on 64BIT && MMU > > help > > This is new version of kexec system call. This system call is > > file based and takes file descriptors as system call argument > > -- > > 2.36.1 > >
On Wed, 7 Dec 2022 04:11:12 -0500, guoren@kernel.org wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > Current nommu_virt_defconfig can't compile: > > In file included from > arch/riscv/kernel/crash_core.c:3: > arch/riscv/kernel/crash_core.c: > In function 'arch_crash_save_vmcoreinfo': > arch/riscv/kernel/crash_core.c:8:27: > error: 'VA_BITS' undeclared (first use in this function) > 8 | VMCOREINFO_NUMBER(VA_BITS); > | ^~~~~~~ > > [...] Applied, thanks! [1/1] riscv: Fixup compile error with !MMU https://git.kernel.org/palmer/c/c528ef0888b7 Best regards,
Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <palmer@rivosinc.com>: On Wed, 7 Dec 2022 04:11:12 -0500 you wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > Current nommu_virt_defconfig can't compile: > > In file included from > arch/riscv/kernel/crash_core.c:3: > arch/riscv/kernel/crash_core.c: > In function 'arch_crash_save_vmcoreinfo': > arch/riscv/kernel/crash_core.c:8:27: > error: 'VA_BITS' undeclared (first use in this function) > 8 | VMCOREINFO_NUMBER(VA_BITS); > | ^~~~~~~ > > [...] Here is the summary with links: - riscv: Fixup compile error with !MMU https://git.kernel.org/riscv/c/c528ef0888b7 You are awesome, thank you!
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index ef8d66de5f38..91319044fd13 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -496,7 +496,7 @@ config KEXEC_FILE select KEXEC_CORE select KEXEC_ELF select HAVE_IMA_KEXEC if IMA - depends on 64BIT + depends on 64BIT && MMU help This is new version of kexec system call. This system call is file based and takes file descriptors as system call argument