Message ID | 20221017020011.25016-6-shikemeng@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1227883wrs; Sun, 16 Oct 2022 19:01:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4XTFYAmml7Qyu1rZqZg4Ak4ruNrrD4PYN4MW+MfKhlXYG8pNzAiWw3LnNh97WDLR+XowVH X-Received: by 2002:a63:4f09:0:b0:440:4706:2299 with SMTP id d9-20020a634f09000000b0044047062299mr8698474pgb.115.1665972107427; Sun, 16 Oct 2022 19:01:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665972107; cv=none; d=google.com; s=arc-20160816; b=mb5CMqm76JdJYIH/jx7M2b863UrSGuZCpZS4MbMw8km7QOe1e8cBVjD5OEqXw5KfpM f3QJ87ozk4BzilKSyeIZxfQ/Xw2Sklc1cdar6YHTUo8wZSWnikAHBMp2onhfOzZhWKhy VA3Qiun7KshdUCVgyRBShj6r9Zgl0AYK/GhKX1wHLw7C6CWR+nOpyzXXfInPwofHuITi 7tnLHC5pYTb+jzqfH/gvdDX0kPw8eKJ0D2X9KU7ruTfN3FGqeZWA1shgOBNRuiZtAh1T JTIlN8oX/ylKlYG7Dqq/HPG47C+c8zaomcxhc4X3+bzChstvFpSqJVzE+tWbYMPaKtJV 3hgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=uKanzW/VwDYGlwmtj3P1eCv4AASwkrW5OeVn27zLGbc=; b=TzaHh4k6pVP5TsYHkEdy7YIcYW/vAffx/xt5D08z/OCNo5Q93yUJb9/aoaXWBEV/o5 KTozvEd3i0AB9fqinMrJm8g/Orf02Ae8uTJohSKLhn8eVM/WcRuvItwYKknVZTeSetNv g14D5JQebFhHc+xqfhH8nyqygJQFKXGY/j8bI2s5P9Mm6tbsGmTDTst0yo2ydZNxXs81 DxVvq2KnOuCR43GmqOLiEojuFZzDO6tMU2yFdNiQFAak9FSGeDIPpCuCRn/LQD/KrDZv TyDkeAXYOp8PWULO6ok0iN0bYgGOwnr0MhOJXSHhSJIx7oJWxzJf+EI2L+bXQiPvo9AF LmDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020a056a00149400b00554f1b32131si11112028pfu.362.2022.10.16.19.01.35; Sun, 16 Oct 2022 19:01:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbiJQCAi (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Sun, 16 Oct 2022 22:00:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230024AbiJQCAU (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 16 Oct 2022 22:00:20 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 238E326101; Sun, 16 Oct 2022 19:00:19 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MrKrN4WlhzJnTs; Mon, 17 Oct 2022 09:57:40 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 10:00:16 +0800 From: Kemeng Shi <shikemeng@huawei.com> To: <tj@kernel.org>, <axboe@kernel.dk>, <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: <shikemeng@huawei.com> Subject: [PATCH 5/8] blk-iocost: Correct comment in blk_iocost_init Date: Mon, 17 Oct 2022 10:00:08 +0800 Message-ID: <20221017020011.25016-6-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20221017020011.25016-1-shikemeng@huawei.com> References: <20221017020011.25016-1-shikemeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746898368660576250?= X-GMAIL-MSGID: =?utf-8?q?1746898368660576250?= |
Series |
A few cleanup and bugfix patches for blk-iocost
|
|
Commit Message
Kemeng Shi
Oct. 17, 2022, 2 a.m. UTC
There is no iocg_pd_init function. The pd_alloc_fn function pointer of
iocost policy is set with ioc_pd_init. Just correct it.
Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
---
block/blk-iocost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Oct 17, 2022 at 10:00:08AM +0800, Kemeng Shi wrote: > There is no iocg_pd_init function. The pd_alloc_fn function pointer of > iocost policy is set with ioc_pd_init. Just correct it. > > Signed-off-by: Kemeng Shi <shikemeng@huawei.com> Acked-by: Tejun Heo <tj@kernel.org> Thanks.
diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 761295ed9c5a..96c1571a8a1d 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -2880,7 +2880,7 @@ static int blk_iocost_init(struct gendisk *disk) spin_unlock_irq(&ioc->lock); /* - * rqos must be added before activation to allow iocg_pd_init() to + * rqos must be added before activation to allow ioc_pd_init() to * lookup the ioc from q. This means that the rqos methods may get * called before policy activation completion, can't assume that the * target bio has an iocg associated and need to test for NULL iocg.