Message ID | 20221210115704.97614-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1272008wrr; Sat, 10 Dec 2022 04:00:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf5BEspdEJRa/hvNXncT/27xkoZ1gKYjln60DaDB847tvXDh9/jtDDz0p+WIor83Lglqztm+ X-Received: by 2002:a17:90a:4814:b0:219:7742:9bcf with SMTP id a20-20020a17090a481400b0021977429bcfmr9499358pjh.40.1670673653048; Sat, 10 Dec 2022 04:00:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670673653; cv=none; d=google.com; s=arc-20160816; b=PExsUqr25fvKWrl59+Go2rSD6QhsrraMAhTTx+NhvrmQqmOspEsUaVxyUpBw3Cgzux 0t5K+pA6daOtjkiaHnn8t73z6dffSLI0Gpv9WMY7Wr8QYnL0sUbCJ3JdRo/KsTtbiNeC pl1pWqAZ6TGj09Vg0DGS9ZhfIlMhbX4bAp8KfpPm7PDTaJZRJR0soJN+3anuSLFDq03+ D1Zl8mMJyByymEBEhdyDY4vBQInz+KqBT+cIksnurtde1gTOBDCzr8BeWBuHulJu2m2g jpyJ6gKErnvtsNm3cA/CbObPv0MDbQ6FnZSAsfcN35L57SyGwf9ubc/RE0OQKi57CafW p/xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PXM/ZzQf3i83h9TWbUQNWzaHxNpC3fWU4P5IeO/SlrM=; b=ktOVpHqIojXdhiDsBjdeT4qE32q7wVnf97b4D8ZbzYkL8rnt4QKVxKDWGSC/SPkEWR 8vStfMKCMje+73bcBiCZFyxmIvT/kIOOdxszoML3XYZh9y99IyjwI2KWO8KFTHHWQgcI wOf1AK25yMR2Fl901MWYCH4ubDybbYVa1fIYRkhp1TBCsr8P2SWOwYkRhoNk/lQhaHJM Oy6Z3NabgtXzATGIvbNl7HsWsheS3bCRmJiE9h2+vgRMddOH42TXG+dRpzJcQToHQel3 isjOo6aaZ0E39oTTxAtWI/GLNunxrkrHQaxjH+tpJ2yvX61ihsxt0M3DP31/4zwSv9R1 wFsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="pi/xxaQJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g70-20020a636b49000000b00478e0f629a8si4106760pgc.269.2022.12.10.04.00.38; Sat, 10 Dec 2022 04:00:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="pi/xxaQJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbiLJL5M (ORCPT <rfc822;jz.zhangjin@gmail.com> + 99 others); Sat, 10 Dec 2022 06:57:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbiLJL5K (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 10 Dec 2022 06:57:10 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8446110B45 for <linux-kernel@vger.kernel.org>; Sat, 10 Dec 2022 03:57:09 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id s8so11048887lfc.8 for <linux-kernel@vger.kernel.org>; Sat, 10 Dec 2022 03:57:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PXM/ZzQf3i83h9TWbUQNWzaHxNpC3fWU4P5IeO/SlrM=; b=pi/xxaQJP3Gab0CcC8mIr8CIVqw5IgnkcLFWRo8KmH9qXJg6yESHyINGyzUKjb5fmF 0D89U8j6bo5hy1JIHnKczyEfHvL6STsIutwDlm+sLu5EPZqu1N3ALILNjj5POrY4p8Lt JXjU3Wp8BPvcAmXJ/rrLMBcK54xQoI202IXBhUeqj5haVaTHqRxsFxO0ZV3y6TrbgiZs cfkwd4hV7pP95Abx2fRmYiWg4L79WvsJyLi0Ep3gOKHK2wR7SY9bfphqLyUMWGRwV9zM k0DeR6a0Soq5xI1HdXlvkwP2R/QmtvrKmpnC+lHwI6kHPan2qYFPaj4fON1/cRlAPSfS WbKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PXM/ZzQf3i83h9TWbUQNWzaHxNpC3fWU4P5IeO/SlrM=; b=TuUTjM7YyJDldld1OqmVgNeYXCmDpjaDWq7Yq+lecuhC2tB3DoqyoZg9jgbn994B7d vnmWYCngSweik6Wk3r5D2OisqrXrLH+rlieDyYO+wM/7HQDCCbmMMdQqXAU3+TfsF3xr mRuDiuBFBpv1zJ2t3ewhghEAu/KP2MkbkBHvgvHWJQ45c5XH05RQ1SxMWmPY8pLZDtK8 rsajP1sqmW6lemxrGAkiGsEIQXRcb72zyoOcOUAJogKiZQ9OpiL1F4BP4koPhXD0wMFQ DiBe5aVTpkJca7ePP2R52qD71TRJWszeJFLuZuqD1gk1YsnKWNBuYgQAfoYERwaUP5hP cYlg== X-Gm-Message-State: ANoB5pnivAIC0toh7RLTQI6zu1XSi+FA/c2iOosLYW13jxtA5NVigKKj 2qGrRxGbd2lzw4lMqjXll4N6bg== X-Received: by 2002:a05:6512:3c99:b0:4b5:5f2e:3cc6 with SMTP id h25-20020a0565123c9900b004b55f2e3cc6mr4395279lfv.47.1670673427883; Sat, 10 Dec 2022 03:57:07 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u20-20020a2eb814000000b002778d482800sm578343ljo.59.2022.12.10.03.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Dec 2022 03:57:07 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node Date: Sat, 10 Dec 2022 12:57:01 +0100 Message-Id: <20221210115704.97614-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751828296619734575?= X-GMAIL-MSGID: =?utf-8?q?1751828296619734575?= |
Series |
[1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node
|
|
Commit Message
Krzysztof Kozlowski
Dec. 10, 2022, 11:57 a.m. UTC
The SoC node is a simple-bus and its schema expect to have nodes only
with unit addresses:
sc7180-trogdor-lazor-r3.dtb: soc@0: opp-table-qspi: {'compatible': ['operating-points-v2'], 'phandle': [[186]], 'opp-75000000':
... 'required-opps': [[47]]}} should not be valid under {'type': 'object'}
Move to top-level OPP tables:
- QUP which is shared between multiple nodes,
- QSPI which cannot be placed in its node due to address/size cells.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 ++++++++++++++--------------
1 file changed, 38 insertions(+), 38 deletions(-)
Comments
On 10.12.2022 12:57, Krzysztof Kozlowski wrote: > The SoC node is a simple-bus and its schema expect to have nodes only > with unit addresses: > > sc7180-trogdor-lazor-r3.dtb: soc@0: opp-table-qspi: {'compatible': ['operating-points-v2'], 'phandle': [[186]], 'opp-75000000': > ... 'required-opps': [[47]]}} should not be valid under {'type': 'object'} > > Move to top-level OPP tables: > - QUP which is shared between multiple nodes, > - QSPI which cannot be placed in its node due to address/size cells. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 ++++++++++++++-------------- > 1 file changed, 38 insertions(+), 38 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index ea886cf08b4d..735581097295 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -538,6 +538,44 @@ cpu6_opp16: opp-2553600000 { > }; > }; > > + qspi_opp_table: opp-table-qspi { > + compatible = "operating-points-v2"; > + > + opp-75000000 { > + opp-hz = /bits/ 64 <75000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-150000000 { > + opp-hz = /bits/ 64 <150000000>; > + required-opps = <&rpmhpd_opp_svs>; > + }; > + > + opp-300000000 { > + opp-hz = /bits/ 64 <300000000>; > + required-opps = <&rpmhpd_opp_nom>; > + }; > + }; > + > + qup_opp_table: opp-table-qup { > + compatible = "operating-points-v2"; > + > + opp-75000000 { > + opp-hz = /bits/ 64 <75000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-100000000 { > + opp-hz = /bits/ 64 <100000000>; > + required-opps = <&rpmhpd_opp_svs>; > + }; > + > + opp-128000000 { > + opp-hz = /bits/ 64 <128000000>; > + required-opps = <&rpmhpd_opp_nom>; > + }; > + }; > + > memory@80000000 { Sidenote: memory@ should be moved above opp-*, alphabetically For this: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > device_type = "memory"; > /* We expect the bootloader to fill in the size */ > @@ -739,25 +777,6 @@ opp-384000000 { > }; > }; > > - qup_opp_table: opp-table-qup { > - compatible = "operating-points-v2"; > - > - opp-75000000 { > - opp-hz = /bits/ 64 <75000000>; > - required-opps = <&rpmhpd_opp_low_svs>; > - }; > - > - opp-100000000 { > - opp-hz = /bits/ 64 <100000000>; > - required-opps = <&rpmhpd_opp_svs>; > - }; > - > - opp-128000000 { > - opp-hz = /bits/ 64 <128000000>; > - required-opps = <&rpmhpd_opp_nom>; > - }; > - }; > - > qupv3_id_0: geniqup@8c0000 { > compatible = "qcom,geni-se-qup"; > reg = <0 0x008c0000 0 0x6000>; > @@ -2655,25 +2674,6 @@ opp-202000000 { > }; > }; > > - qspi_opp_table: opp-table-qspi { > - compatible = "operating-points-v2"; > - > - opp-75000000 { > - opp-hz = /bits/ 64 <75000000>; > - required-opps = <&rpmhpd_opp_low_svs>; > - }; > - > - opp-150000000 { > - opp-hz = /bits/ 64 <150000000>; > - required-opps = <&rpmhpd_opp_svs>; > - }; > - > - opp-300000000 { > - opp-hz = /bits/ 64 <300000000>; > - required-opps = <&rpmhpd_opp_nom>; > - }; > - }; > - > qspi: spi@88dc000 { > compatible = "qcom,sc7180-qspi", "qcom,qspi-v1"; > reg = <0 0x088dc000 0 0x600>;
On 10/12/2022 13:29, Konrad Dybcio wrote: > > > On 10.12.2022 12:57, Krzysztof Kozlowski wrote: >> The SoC node is a simple-bus and its schema expect to have nodes only >> with unit addresses: >> >> sc7180-trogdor-lazor-r3.dtb: soc@0: opp-table-qspi: {'compatible': ['operating-points-v2'], 'phandle': [[186]], 'opp-75000000': >> ... 'required-opps': [[47]]}} should not be valid under {'type': 'object'} >> >> Move to top-level OPP tables: >> - QUP which is shared between multiple nodes, >> - QSPI which cannot be placed in its node due to address/size cells. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 ++++++++++++++-------------- >> 1 file changed, 38 insertions(+), 38 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index ea886cf08b4d..735581097295 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -538,6 +538,44 @@ cpu6_opp16: opp-2553600000 { >> }; >> }; >> >> + qspi_opp_table: opp-table-qspi { >> + compatible = "operating-points-v2"; >> + >> + opp-75000000 { >> + opp-hz = /bits/ 64 <75000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + }; >> + >> + opp-150000000 { >> + opp-hz = /bits/ 64 <150000000>; >> + required-opps = <&rpmhpd_opp_svs>; >> + }; >> + >> + opp-300000000 { >> + opp-hz = /bits/ 64 <300000000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + }; >> + }; >> + >> + qup_opp_table: opp-table-qup { >> + compatible = "operating-points-v2"; >> + >> + opp-75000000 { >> + opp-hz = /bits/ 64 <75000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + }; >> + >> + opp-100000000 { >> + opp-hz = /bits/ 64 <100000000>; >> + required-opps = <&rpmhpd_opp_svs>; >> + }; >> + >> + opp-128000000 { >> + opp-hz = /bits/ 64 <128000000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + }; >> + }; >> + >> memory@80000000 { > Sidenote: memory@ should be moved above opp-*, alphabetically > > For this: > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> You sure? Because before there is already opp for cpu... Best regards, Krzysztof
On 11.12.2022 21:14, Krzysztof Kozlowski wrote: > On 10/12/2022 13:29, Konrad Dybcio wrote: >> >> >> On 10.12.2022 12:57, Krzysztof Kozlowski wrote: >>> The SoC node is a simple-bus and its schema expect to have nodes only >>> with unit addresses: >>> >>> sc7180-trogdor-lazor-r3.dtb: soc@0: opp-table-qspi: {'compatible': ['operating-points-v2'], 'phandle': [[186]], 'opp-75000000': >>> ... 'required-opps': [[47]]}} should not be valid under {'type': 'object'} >>> >>> Move to top-level OPP tables: >>> - QUP which is shared between multiple nodes, >>> - QSPI which cannot be placed in its node due to address/size cells. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 ++++++++++++++-------------- >>> 1 file changed, 38 insertions(+), 38 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >>> index ea886cf08b4d..735581097295 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >>> @@ -538,6 +538,44 @@ cpu6_opp16: opp-2553600000 { >>> }; >>> }; >>> >>> + qspi_opp_table: opp-table-qspi { >>> + compatible = "operating-points-v2"; >>> + >>> + opp-75000000 { >>> + opp-hz = /bits/ 64 <75000000>; >>> + required-opps = <&rpmhpd_opp_low_svs>; >>> + }; >>> + >>> + opp-150000000 { >>> + opp-hz = /bits/ 64 <150000000>; >>> + required-opps = <&rpmhpd_opp_svs>; >>> + }; >>> + >>> + opp-300000000 { >>> + opp-hz = /bits/ 64 <300000000>; >>> + required-opps = <&rpmhpd_opp_nom>; >>> + }; >>> + }; >>> + >>> + qup_opp_table: opp-table-qup { >>> + compatible = "operating-points-v2"; >>> + >>> + opp-75000000 { >>> + opp-hz = /bits/ 64 <75000000>; >>> + required-opps = <&rpmhpd_opp_low_svs>; >>> + }; >>> + >>> + opp-100000000 { >>> + opp-hz = /bits/ 64 <100000000>; >>> + required-opps = <&rpmhpd_opp_svs>; >>> + }; >>> + >>> + opp-128000000 { >>> + opp-hz = /bits/ 64 <128000000>; >>> + required-opps = <&rpmhpd_opp_nom>; >>> + }; >>> + }; >>> + >>> memory@80000000 { >> Sidenote: memory@ should be moved above opp-*, alphabetically >> >> For this: >> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > You sure? Because before there is already opp for cpu... Which are called opp-table-cpuN and not cpuN-opp-table, 'm' comes before 'o'. Konrad > > Best regards, > Krzysztof >
On 12/12/2022 10:15, Konrad Dybcio wrote: >>>> + >>>> + qup_opp_table: opp-table-qup { >>>> + compatible = "operating-points-v2"; >>>> + >>>> + opp-75000000 { >>>> + opp-hz = /bits/ 64 <75000000>; >>>> + required-opps = <&rpmhpd_opp_low_svs>; >>>> + }; >>>> + >>>> + opp-100000000 { >>>> + opp-hz = /bits/ 64 <100000000>; >>>> + required-opps = <&rpmhpd_opp_svs>; >>>> + }; >>>> + >>>> + opp-128000000 { >>>> + opp-hz = /bits/ 64 <128000000>; >>>> + required-opps = <&rpmhpd_opp_nom>; >>>> + }; >>>> + }; >>>> + >>>> memory@80000000 { >>> Sidenote: memory@ should be moved above opp-*, alphabetically >>> >>> For this: >>> >>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> >> You sure? Because before there is already opp for cpu... > Which are called opp-table-cpuN and not cpuN-opp-table, 'm' comes > before 'o'. So you want to have broken order? opp-table-cpu memory opp-table-qup ? They are at least all together in my patch. Best regards, Krzysztof
On 12.12.2022 10:17, Krzysztof Kozlowski wrote: > On 12/12/2022 10:15, Konrad Dybcio wrote: >>>>> + >>>>> + qup_opp_table: opp-table-qup { >>>>> + compatible = "operating-points-v2"; >>>>> + >>>>> + opp-75000000 { >>>>> + opp-hz = /bits/ 64 <75000000>; >>>>> + required-opps = <&rpmhpd_opp_low_svs>; >>>>> + }; >>>>> + >>>>> + opp-100000000 { >>>>> + opp-hz = /bits/ 64 <100000000>; >>>>> + required-opps = <&rpmhpd_opp_svs>; >>>>> + }; >>>>> + >>>>> + opp-128000000 { >>>>> + opp-hz = /bits/ 64 <128000000>; >>>>> + required-opps = <&rpmhpd_opp_nom>; >>>>> + }; >>>>> + }; >>>>> + >>>>> memory@80000000 { >>>> Sidenote: memory@ should be moved above opp-*, alphabetically >>>> >>>> For this: >>>> >>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> >>> You sure? Because before there is already opp for cpu... >> Which are called opp-table-cpuN and not cpuN-opp-table, 'm' comes >> before 'o'. > > So you want to have broken order? > opp-table-cpu > memory > opp-table-qup > ? > > They are at least all together in my patch. No, I meant: memory opp-table-cpu opp-table-qup Konrad > > Best regards, > Krzysztof >
On 12/12/2022 10:18, Konrad Dybcio wrote: > > > On 12.12.2022 10:17, Krzysztof Kozlowski wrote: >> On 12/12/2022 10:15, Konrad Dybcio wrote: >>>>>> + >>>>>> + qup_opp_table: opp-table-qup { >>>>>> + compatible = "operating-points-v2"; >>>>>> + >>>>>> + opp-75000000 { >>>>>> + opp-hz = /bits/ 64 <75000000>; >>>>>> + required-opps = <&rpmhpd_opp_low_svs>; >>>>>> + }; >>>>>> + >>>>>> + opp-100000000 { >>>>>> + opp-hz = /bits/ 64 <100000000>; >>>>>> + required-opps = <&rpmhpd_opp_svs>; >>>>>> + }; >>>>>> + >>>>>> + opp-128000000 { >>>>>> + opp-hz = /bits/ 64 <128000000>; >>>>>> + required-opps = <&rpmhpd_opp_nom>; >>>>>> + }; >>>>>> + }; >>>>>> + >>>>>> memory@80000000 { >>>>> Sidenote: memory@ should be moved above opp-*, alphabetically >>>>> >>>>> For this: >>>>> >>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>> >>>> You sure? Because before there is already opp for cpu... >>> Which are called opp-table-cpuN and not cpuN-opp-table, 'm' comes >>> before 'o'. >> >> So you want to have broken order? >> opp-table-cpu >> memory >> opp-table-qup >> ? >> >> They are at least all together in my patch. > No, I meant: > > memory > opp-table-cpu > opp-table-qup OK, I'll correct the opp-table-cpu/memory order in separate patch. Best regards, Krzysztof
On Sat, 10 Dec 2022 12:57:01 +0100, Krzysztof Kozlowski wrote: > The SoC node is a simple-bus and its schema expect to have nodes only > with unit addresses: > > sc7180-trogdor-lazor-r3.dtb: soc@0: opp-table-qspi: {'compatible': ['operating-points-v2'], 'phandle': [[186]], 'opp-75000000': > ... 'required-opps': [[47]]}} should not be valid under {'type': 'object'} > > Move to top-level OPP tables: > - QUP which is shared between multiple nodes, > - QSPI which cannot be placed in its node due to address/size cells. > > [...] Applied, thanks! [1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node commit: 524dfd2ddbd74ed5b4cbb3e002984cf95878c827 [2/4] arm64: dts: qcom: sdm845: move DSI/QUP/QSPI opp tables out of SoC node commit: 85966125ecfe75735d8a02f00c83545aaad0ba88 [3/4] arm64: dts: qcom: sdm845: move sound node out of soc commit: d0b014a74823cc52dde447d0af61ff14fce5a785 [4/4] arm64: dts: qcom: sm8250: move sound and codec nodes out of soc commit: e5b8c08245307a82cdf180cd5d385a34ba1cfd9d Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index ea886cf08b4d..735581097295 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -538,6 +538,44 @@ cpu6_opp16: opp-2553600000 { }; }; + qspi_opp_table: opp-table-qspi { + compatible = "operating-points-v2"; + + opp-75000000 { + opp-hz = /bits/ 64 <75000000>; + required-opps = <&rpmhpd_opp_low_svs>; + }; + + opp-150000000 { + opp-hz = /bits/ 64 <150000000>; + required-opps = <&rpmhpd_opp_svs>; + }; + + opp-300000000 { + opp-hz = /bits/ 64 <300000000>; + required-opps = <&rpmhpd_opp_nom>; + }; + }; + + qup_opp_table: opp-table-qup { + compatible = "operating-points-v2"; + + opp-75000000 { + opp-hz = /bits/ 64 <75000000>; + required-opps = <&rpmhpd_opp_low_svs>; + }; + + opp-100000000 { + opp-hz = /bits/ 64 <100000000>; + required-opps = <&rpmhpd_opp_svs>; + }; + + opp-128000000 { + opp-hz = /bits/ 64 <128000000>; + required-opps = <&rpmhpd_opp_nom>; + }; + }; + memory@80000000 { device_type = "memory"; /* We expect the bootloader to fill in the size */ @@ -739,25 +777,6 @@ opp-384000000 { }; }; - qup_opp_table: opp-table-qup { - compatible = "operating-points-v2"; - - opp-75000000 { - opp-hz = /bits/ 64 <75000000>; - required-opps = <&rpmhpd_opp_low_svs>; - }; - - opp-100000000 { - opp-hz = /bits/ 64 <100000000>; - required-opps = <&rpmhpd_opp_svs>; - }; - - opp-128000000 { - opp-hz = /bits/ 64 <128000000>; - required-opps = <&rpmhpd_opp_nom>; - }; - }; - qupv3_id_0: geniqup@8c0000 { compatible = "qcom,geni-se-qup"; reg = <0 0x008c0000 0 0x6000>; @@ -2655,25 +2674,6 @@ opp-202000000 { }; }; - qspi_opp_table: opp-table-qspi { - compatible = "operating-points-v2"; - - opp-75000000 { - opp-hz = /bits/ 64 <75000000>; - required-opps = <&rpmhpd_opp_low_svs>; - }; - - opp-150000000 { - opp-hz = /bits/ 64 <150000000>; - required-opps = <&rpmhpd_opp_svs>; - }; - - opp-300000000 { - opp-hz = /bits/ 64 <300000000>; - required-opps = <&rpmhpd_opp_nom>; - }; - }; - qspi: spi@88dc000 { compatible = "qcom,sc7180-qspi", "qcom,qspi-v1"; reg = <0 0x088dc000 0 0x600>;