Message ID | 478d652b9f467d47685c1af72a876f34dd92710f.1666011479.git.drv@mailo.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1460776wrs; Mon, 17 Oct 2022 06:56:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5oLijiybyKuvOlPb7vsobwA3uCTattpwv6/RNKRF5JqpgXIfqdlB2dHEMKBBfF9gpDQ9aR X-Received: by 2002:a05:6402:2683:b0:45d:3c44:dad4 with SMTP id w3-20020a056402268300b0045d3c44dad4mr10380221edd.124.1666014982870; Mon, 17 Oct 2022 06:56:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666014982; cv=none; d=google.com; s=arc-20160816; b=P81A9cVwQUKV/9urXVKB2dbjlegU161r9U/qujmd0MoFMRW22pNFnSKYnTxh2Qqc/S 9rxZ192maZDl/wCU5/TvZ61335iOOocaKfbjs7wAWqNAWHEw0IELLKi4RoRUbR2uBLsR MJDJusGUqFWX/7ij7cOsbxS8vpwthnTjn8/xH/U4anfM4XMyn3+XCBfwT6EMpnZ0pAmg jNxb4dw/soI4gcp8BahMDYD+7WTxX4HaafYZPB9phDtqEfVLI0vGcEfg3fh7HnsFEHoX 5JQ8MES9h1heA+OYXfQc+a25if+ywF4R4NQyKdbGcm/mnDh9i77J39cidqx2rVKz8ldh 7nQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vyxGBPbQa0C6c83kXkBAJY9tq5PjRPcVLHMhfrAfkuE=; b=OlcJPOHqfNQXf2kgFaYfAf200i9I8zE55A6VYlSvA36pycPA2f1/DgG+kuGwpxXhtK WTfd0NFaNM+W0SNxGUJXP+cDhvn8qErOnGWbaG3/0Ya9NDT7Ukn5MLE59iz48JE2hDN6 80gYxRnqLS1DubJVyarOZl96kdRBhk39kAICZrc0RJrNmcnzeux7wG+Pgl47RQncKZjw rV/LUXEz1mscPh+1RY9FuJb8kyC7Su9jPqefWCsvN0RGGOSKyBzpWmhb1eTMaWHNb92A MVsbJeZHi5ETicC4C/pTTWBfBznqT4+2CaLdYcCDQ6OwGCkWTHB0Eibu6isExRxaBMbR Bcew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=V0nd46kD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q6-20020a17090676c600b0078da414a7cesi7758214ejn.149.2022.10.17.06.55.56; Mon, 17 Oct 2022 06:56:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=V0nd46kD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230149AbiJQNxZ (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Mon, 17 Oct 2022 09:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbiJQNxT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Oct 2022 09:53:19 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5A1F2A272 for <linux-kernel@vger.kernel.org>; Mon, 17 Oct 2022 06:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666014783; bh=HybS8E0BeM5WMbvxAEhVcL9Zbg+CAlIyM/FdRQVadmA=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=V0nd46kDfvvNQW9/BYUiNaqzLisfmayMxJ32LVhGkuWQME6HvaNwszkOY5nGfFnex 2R3rf7efqsVrSIei9H0jq6xG/cyJdtFG/RbBo+tmtLDGPUnJQHHeyD/NM2ktWD5qDs W/e50RHb6p11MoZPOxUvaHPKOGKE2L2ONJsswbfc= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via [213.182.55.206] Mon, 17 Oct 2022 15:53:03 +0200 (CEST) X-EA-Auth: WOVB4/nXVafQco/5wnIstFlXmW1pUWZgMbaqWNF0+qTbWPxDQEIECV7poO8kLqFZnvP2ycwsxNtRR8tRYgDBxGafyGWWdKHT Date: Mon, 17 Oct 2022 18:53:30 +0530 From: Deepak R Varma <drv@mailo.com> To: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, paskripkin@gmail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: [PATCH 3/4] staging: r8188eu: remove {} for single statement blocks Message-ID: <478d652b9f467d47685c1af72a876f34dd92710f.1666011479.git.drv@mailo.com> References: <cover.1666011479.git.drv@mailo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1666011479.git.drv@mailo.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746943326668366951?= X-GMAIL-MSGID: =?utf-8?q?1746943326668366951?= |
Series |
staging: r8188eu: trivial code cleanup patches
|
|
Commit Message
Deepak R Varma
Oct. 17, 2022, 1:23 p.m. UTC
As per the Linux kernel coding-style guidelines, there is no need to
use {} for single statement blocks. Address following checkpatch script
complaint:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/staging/r8188eu/core/rtw_br_ext.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.30.2
Comments
On Mon, 17 Oct 2022, Deepak R Varma wrote: > As per the Linux kernel coding-style guidelines, there is no need to > use {} for single statement blocks. Address following checkpatch script > complaint: > WARNING: braces {} are not necessary for single statement blocks It's nice to say something like "Problem identified using checkpatch". But putting the verbatim checkpatch message that says what you just said doesn't seem necessary. julia > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > drivers/staging/r8188eu/core/rtw_br_ext.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c > index 427da7e8ba4c..290affe50d0b 100644 > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c > @@ -655,9 +655,8 @@ void *scdb_findEntry(struct adapter *priv, unsigned char *ip_addr) > hash = __nat25_network_hash(network_addr); > db = priv->nethash[hash]; > while (db) { > - if (!memcmp(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN)) { > + if (!memcmp(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN)) > return (void *)db; > - } > > db = db->next_hash; > } > -- > 2.30.2 > > > > >
On Mon, Oct 17, 2022 at 03:57:16PM +0200, Julia Lawall wrote: > > > On Mon, 17 Oct 2022, Deepak R Varma wrote: > > > As per the Linux kernel coding-style guidelines, there is no need to > > use {} for single statement blocks. Address following checkpatch script > > complaint: > > WARNING: braces {} are not necessary for single statement blocks > > It's nice to say something like "Problem identified using checkpatch". > But putting the verbatim checkpatch message that says what you just said > doesn't seem necessary. Understood. That sounds better. Thank you Julia. Will include your feedback in the next revision. ./drv > > julia > > > > > Signed-off-by: Deepak R Varma <drv@mailo.com> > > --- > > drivers/staging/r8188eu/core/rtw_br_ext.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c > > index 427da7e8ba4c..290affe50d0b 100644 > > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c > > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c > > @@ -655,9 +655,8 @@ void *scdb_findEntry(struct adapter *priv, unsigned char *ip_addr) > > hash = __nat25_network_hash(network_addr); > > db = priv->nethash[hash]; > > while (db) { > > - if (!memcmp(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN)) { > > + if (!memcmp(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN)) > > return (void *)db; > > - } > > > > db = db->next_hash; > > } > > -- > > 2.30.2 > > > > > > > > > >
diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c index 427da7e8ba4c..290affe50d0b 100644 --- a/drivers/staging/r8188eu/core/rtw_br_ext.c +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c @@ -655,9 +655,8 @@ void *scdb_findEntry(struct adapter *priv, unsigned char *ip_addr) hash = __nat25_network_hash(network_addr); db = priv->nethash[hash]; while (db) { - if (!memcmp(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN)) { + if (!memcmp(db->networkAddr, network_addr, MAX_NETWORK_ADDR_LEN)) return (void *)db; - } db = db->next_hash; }