Message ID | 20221208030208.10841-1-liupeibao@loongson.cn |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp535302wrr; Wed, 7 Dec 2022 19:15:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf41wu61A4CHZWkspYHLZWmnBF7BG8YRNpUMquFAPGR4/1vO2vJPLihCeoF9hksq8Xsn/m8x X-Received: by 2002:a17:906:2e82:b0:7ae:44b2:cb7f with SMTP id o2-20020a1709062e8200b007ae44b2cb7fmr62710881eji.437.1670469347955; Wed, 07 Dec 2022 19:15:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670469347; cv=none; d=google.com; s=arc-20160816; b=aoBViEjf5tyxBs2RQvX1U2kZ6tf6FO+xHE5phsKuv8b2fgPxsnM/5dQKnpkUMGM11g oZV8+ziPaKsnZThDTaPZMVJbMMPjraozsKa+JlM92jRyobpLS4Z6+wPSXfyTDw7Q6wfg ktWhSAV4jv73HPfd6qfAoeJLI+6YVhhJglx8DfNsUzPjfvPxCJ0krpERR/NAs5CnBnph eNXSHBnNoOnV70ZREmhsAkm49QG6zmU4U0pnsziIZMWKM4yWITgNrzLKypI5Os5/lzEb z7ZpP0NH4CHZV/2OlkdhOp7sWruwFFEeHWFDkSEXsPa7DjNjPXn5wEwatSfZ4Ob58J2c XGWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=w7r1h9cE7IBCedr5KWB2i5pO9B0H4yuYTGvXPZU2ZbY=; b=QZDQH5XKMM8UFL9m8uix4KwZAQRvKkzq6UNLDlJYtPiuG/dsxlEsb8EOKay7Ok0Zbj 6R+5TGcdH9v9GjoDDT7yWC+dGCPXwf4D/5Q/eX2+QZ50yarSSKd35EE9qt2rtN5H+QoZ 78gX4uMIO6YIFy96HHWKtnyFVp9CuzQoBEnKrd2YGSaiIJPy5vxrZzRu55dnjgucHNGO eoyg5goCIMlduqYwS+kEVyuv1Of7URhV+i+E9GILnvgxSPxxZK352o1zg6GcmGhBjcsr pB5xI42TVzN9NLGugWFIbrBALHQcSY6VHHJxQvSFfhaIzK4O6pKx5MOGjEYn3BYzcpka x43w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 17-20020a170906059100b007ae74740fa4si13743316ejn.275.2022.12.07.19.15.24; Wed, 07 Dec 2022 19:15:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbiLHDDc (ORCPT <rfc822;foxyelen666@gmail.com> + 99 others); Wed, 7 Dec 2022 22:03:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbiLHDDJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 7 Dec 2022 22:03:09 -0500 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 37D3F9896C; Wed, 7 Dec 2022 19:02:18 -0800 (PST) Received: from loongson.cn (unknown [10.20.42.77]) by gateway (Coremail) with SMTP id _____8BxE_C5U5FjzAMEAA--.9736S3; Thu, 08 Dec 2022 11:02:17 +0800 (CST) Received: from loongson-PC.loongson.cn (unknown [10.20.42.77]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxTuCwU5Fjx6MnAA--.32070S2; Thu, 08 Dec 2022 11:02:16 +0800 (CST) From: Liu Peibao <liupeibao@loongson.cn> To: Rob Herring <robh@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Huacai Chen <chenhuacai@kernel.org>, WANG Xuerui <kernel@xen0n.name> Cc: Jianmin Lv <lvjianmin@loongson.cn>, Yinbo Zhu <zhuyinbo@loongson.cn>, wanghongliang <wanghongliang@loongson.cn>, Liu Peibao <liupeibao@loongson.cn>, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: interrupt-controller: loongarch: Fix mismathed compatible Date: Thu, 8 Dec 2022 11:02:08 +0800 Message-Id: <20221208030208.10841-1-liupeibao@loongson.cn> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8BxTuCwU5Fjx6MnAA--.32070S2 X-CM-SenderInfo: xolx1vpled0qxorr0wxvrqhubq/1tbiAQAOCmOQgmgMegACso X-Coremail-Antispam: 1Uk129KBjvJXoW7ZF4UtFW3GFWrGry5tr1DWrg_yoW8JF4fpF W7Ca9xWF4jqF15Aa1ktasYkrnxZFnxJrna9an7tw4xGr12g34UXFWj9F95JFWrWFZ7XrWU Zr1Fq3W0qasrJF7anT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU b28YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4 x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1l e2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4xG64xvF2 IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4U McvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwIxGrwCFx2 IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v2 6r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67 AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IY s7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr 0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j1WlkUUUUU= X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00,RCVD_IN_SBL_CSS, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751614067157640512?= X-GMAIL-MSGID: =?utf-8?q?1751614067157640512?= |
Series |
dt-bindings: interrupt-controller: loongarch: Fix mismathed compatible
|
|
Commit Message
Liu Peibao
Dec. 8, 2022, 3:02 a.m. UTC
The "compatible" doesn't match what the kernel is using. Fix it as
kernel using.
Fixes: 855d4ca4bdb3 ("irqchip: loongarch-cpu: add DT support")
Signed-off-by: Liu Peibao <liupeibao@loongson.cn>
---
.../loongarch,cpu-interrupt-controller.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 08/12/2022 04:02, Liu Peibao wrote: > The "compatible" doesn't match what the kernel is using. Fix it as > kernel using. > > Fixes: 855d4ca4bdb3 ("irqchip: loongarch-cpu: add DT support") Really? You just added these patches... 1. In the same time Loongson people keep pinging for accepting these: https://lore.kernel.org/all/e3bf1f8a-e37e-46e3-f9b3-20a9031d49e2@loongson.cn/ https://lore.kernel.org/all/f5d0f796-0147-8789-5bed-edf38b28229e@loongson.cn/ All the time - several pings, every week. 2. In the last weeks, two of your engineers sent the same driver (Loongson I2C) in the same time, with different names! For the same hardware. 3. Several other patches from Loongson, when posted on mailing lists, have multiple compile warnings. This suggests they were not really compiled properly (with different test configs, with W=1, smatch, sparse, coccinelle). There were so many compiler warnings, that I assume your patches should wait on mailing list for two weeks before starting any review. Otherwise it's a bit waste of reviewer's effort. Patches are welcomed but all this points on poor quality of submissions and sending anything, hoping it will get merged upstream, regardless of quality. I appreciate fixing the patch fast, it's a good sign, but maybe Loongson could a bit improve internal processes of review before sending and pinging on mailing list? Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 2022/12/8 下午4:42, Krzysztof Kozlowski wrote: > On 08/12/2022 04:02, Liu Peibao wrote: >> The "compatible" doesn't match what the kernel is using. Fix it as >> kernel using. >> >> Fixes: 855d4ca4bdb3 ("irqchip: loongarch-cpu: add DT support") > > Really? You just added these patches... > > 1. In the same time Loongson people keep pinging for accepting these: > https://lore.kernel.org/all/e3bf1f8a-e37e-46e3-f9b3-20a9031d49e2@loongson.cn/ > https://lore.kernel.org/all/f5d0f796-0147-8789-5bed-edf38b28229e@loongson.cn/ > > All the time - several pings, every week. > > 2. In the last weeks, two of your engineers sent the same driver > (Loongson I2C) in the same time, with different names! For the same > hardware. > > 3. Several other patches from Loongson, when posted on mailing lists, > have multiple compile warnings. This suggests they were not really > compiled properly (with different test configs, with W=1, smatch, > sparse, coccinelle). There were so many compiler warnings, that I assume > your patches should wait on mailing list for two weeks before starting > any review. Otherwise it's a bit waste of reviewer's effort. > > Patches are welcomed but all this points on poor quality of submissions > and sending anything, hoping it will get merged upstream, regardless of > quality. > > I appreciate fixing the patch fast, it's a good sign, but maybe Loongson > could a bit improve internal processes of review before sending and > pinging on mailing list? > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > Hi, Krzysztof As for me privately, I must say that I'm very appreciate patient helps and guides to us (some of us are new comers include me without more experience) from each maintainer and reviewer, thanks very much! From some patch series(include my patches), it literally seems that some low quality problem (e.g. since some reasons such as not familiar with rules of community patch, building warning by test robot checking and no internal review process) just as noise that bothered reviewers and consumed more time (back and forth), which is definitely due to our poor work in my opinion (though I'm not sure how others think about it). Have Loongson folks (especially new comers like me) put more efforts into patch work and learn about experience from reviewing process, the patch quality would be improved better. Again, thanks for pointing out some problems you mentioned above(e.g. same patch with different name from different Loongson people, frequently pinging and patch quality), I think I can feed back them to company to pay more attention and take steps to improve community work. Thanks! Jianmin Lv
diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongarch,cpu-interrupt-controller.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongarch,cpu-interrupt-controller.yaml index 2a1cf885c99d..81e4c0feb11e 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/loongarch,cpu-interrupt-controller.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/loongarch,cpu-interrupt-controller.yaml @@ -11,7 +11,7 @@ maintainers: properties: compatible: - const: loongarch,cpu-interrupt-controller + const: loongson,cpu-interrupt-controller '#interrupt-cells': const: 1 @@ -28,7 +28,7 @@ required: examples: - | interrupt-controller { - compatible = "loongarch,cpu-interrupt-controller"; + compatible = "loongson,cpu-interrupt-controller"; #interrupt-cells = <1>; interrupt-controller; };