Message ID | 20221207055405.30940-4-hayashi.kunihiko@socionext.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1346wrr; Tue, 6 Dec 2022 21:55:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf6rqW3c/N4AhzvwpYG2cDzwBnC7xB2LZgdCrjtmSQc7ssMlXqdIxz3WV1LyVtkfTe8kedH3 X-Received: by 2002:aa7:dc0c:0:b0:461:6f87:20bb with SMTP id b12-20020aa7dc0c000000b004616f8720bbmr80334401edu.300.1670392531888; Tue, 06 Dec 2022 21:55:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670392531; cv=none; d=google.com; s=arc-20160816; b=Y73K2wh2oKj7U8+oO2RlYiyPLCTcs6RTo0+Nn3Nb/FRt7Y4Fqp5nPH+Il08F/x2GqL VDE5SK6tIqIuH3RsQosy/P3wJCYOnw+Qnt+o30zY1mWhUfAZBbQHmlU0nYEhAkxxjCW4 darHCwVZxIF+B+1U5g9vZSSJkgHhnD7+4aT/Md4mCKP7EJxmu7eo/1i9L0MH4md/Pyjp kq+NbX+nT5ZgK9ywuytlNekmIX1KusemK8K0/z7idiCTfymUsdmx5VqKYgsLZVz25+PG M9sqC6eQwXZY8cFAYqW6hr2Xnc4F4EL4ZzyXCvDDf8wiwWao6z9duWmxpbSXcg2XGiqO +amg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=S4Re4qJ4xPLcmRYCxL5MTBaKdkJhcudU1O57S+x0Kf4=; b=Umyj7hKKje7Bey9RW9zMl9VNHAFyXorXa915R9qJjmRy22s+q0JZ9CMI99nTJIzPBX 9ydooa3Ms4f0FLz7oVB4AYMoZPh+SuCuFhzVXLQhScf5nX+yVwAt/wHyl5zDQpT2d4ib Z6GKllKmpcDVGMt6Pyza2Xei2fmInIZYb5CqeN70mgj1HQhTrqwlfup6Y/sTGp0nKlB+ 6HTTXgNe8Fa/YBYnXNwWw8M2jejg14Du263Ez9RSyO1ar6bm8XWZGTlnbRedx6AFkn8J L4kHu3kKk4XNVunYwlTkSLIsSlCCL63swFo1zT7Rn7/xnGVxjcyEvi1V5+pZUqUZABO5 U7Sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gv11-20020a1709072bcb00b007c115fb8501si1600470ejc.252.2022.12.06.21.55.08; Tue, 06 Dec 2022 21:55:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbiLGFyo (ORCPT <rfc822;b08248@gmail.com> + 99 others); Wed, 7 Dec 2022 00:54:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbiLGFyd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 7 Dec 2022 00:54:33 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DE65859142; Tue, 6 Dec 2022 21:54:31 -0800 (PST) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 07 Dec 2022 14:54:30 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 745DA2058B4F; Wed, 7 Dec 2022 14:54:30 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Wed, 7 Dec 2022 14:54:30 +0900 Received: from plum.e01.socionext.com (unknown [10.212.243.119]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 31FE91DA5; Wed, 7 Dec 2022 14:54:30 +0900 (JST) From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Masami Hiramatsu <mhiramat@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Subject: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example Date: Wed, 7 Dec 2022 14:53:52 +0900 Message-Id: <20221207055405.30940-4-hayashi.kunihiko@socionext.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221207055405.30940-1-hayashi.kunihiko@socionext.com> References: <20221207055405.30940-1-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751533519554731280?= X-GMAIL-MSGID: =?utf-8?q?1751533519554731280?= |
Series |
dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples
|
|
Commit Message
Kunihiko Hayashi
Dec. 7, 2022, 5:53 a.m. UTC
Rename the parent node to the generic node name "syscon".
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 07/12/2022 06:53, Kunihiko Hayashi wrote: > Rename the parent node to the generic node name "syscon". > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > index 14a8c0215cc6..186fc550af4c 100644 > --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > @@ -69,7 +69,7 @@ examples: > - | > // The UniPhier pinctrl should be a subnode of a "syscon" compatible node. > > - soc-glue@5f800000 { > + syscon@5f800000 { > compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon"; > reg = <0x5f800000 0x2000>; > Not visible in the diff but this is a poor example. It has only compatible! Drop the parent node instead and extend the pinctrl node to show complete picture of pinctrl. Best regards, Krzysztof
On 2022/12/08 17:07, Krzysztof Kozlowski wrote: > On 07/12/2022 06:53, Kunihiko Hayashi wrote: >> Rename the parent node to the generic node name "syscon". >> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml >> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml >> index 14a8c0215cc6..186fc550af4c 100644 >> --- >> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml >> +++ >> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml >> @@ -69,7 +69,7 @@ examples: >> - | >> // The UniPhier pinctrl should be a subnode of a "syscon" compatible >> node. >> >> - soc-glue@5f800000 { >> + syscon@5f800000 { >> compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", >> "syscon"; >> reg = <0x5f800000 0x2000>; >> > > Not visible in the diff but this is a poor example. It has only > compatible! Drop the parent node instead and extend the pinctrl node to > show complete picture of pinctrl. I should add some child nodes of groups and pin attributes as an example from the devicetree. Thank you, --- Best Regards Kunihiko Hayashi
diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml index 14a8c0215cc6..186fc550af4c 100644 --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml @@ -69,7 +69,7 @@ examples: - | // The UniPhier pinctrl should be a subnode of a "syscon" compatible node. - soc-glue@5f800000 { + syscon@5f800000 { compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon"; reg = <0x5f800000 0x2000>;