diff mbox series

[3/3] clk: at91: do not compile dt-compat.c for sama7g5 and sam9x60

Message ID 20221208114515.35179-4-claudiu.beznea@microchip.com
State New
Headers
Series clk: at91: mark ddr clocks as critical |

Commit Message

Claudiu Beznea Dec. 8, 2022, 11:45 a.m. UTC 
  There is no need to have dt-compat.c compiled for SAMA7G5 and SAM9X60
as there is no in kernel device tree that could use it. Thus avoid
compiling dt-compat.c for them.

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 drivers/clk/at91/Makefile | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Alexandre Belloni Dec. 8, 2022, 2:39 p.m. UTC | #1 
On 08/12/2022 13:45:15+0200, Claudiu Beznea wrote:
> There is no need to have dt-compat.c compiled for SAMA7G5 and SAM9X60
> as there is no in kernel device tree that could use it. Thus avoid
> compiling dt-compat.c for them.
> 

Isn't it time to drop dt-compat.c? I was going to send a patch after 6.1
is released

> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>  drivers/clk/at91/Makefile | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/clk/at91/Makefile b/drivers/clk/at91/Makefile
> index 79301e1c1c36..89061b85e7d2 100644
> --- a/drivers/clk/at91/Makefile
> +++ b/drivers/clk/at91/Makefile
> @@ -3,7 +3,7 @@
>  # Makefile for at91 specific clk
>  #
>  
> -obj-y += pmc.o sckc.o dt-compat.o
> +obj-y += pmc.o sckc.o
>  obj-y += clk-slow.o clk-main.o clk-pll.o clk-plldiv.o clk-master.o
>  obj-y += clk-system.o clk-peripheral.o clk-programmable.o
>  
> @@ -15,12 +15,12 @@ obj-$(CONFIG_HAVE_AT91_H32MX)		+= clk-h32mx.o
>  obj-$(CONFIG_HAVE_AT91_GENERATED_CLK)	+= clk-generated.o
>  obj-$(CONFIG_HAVE_AT91_I2S_MUX_CLK)	+= clk-i2s-mux.o
>  obj-$(CONFIG_HAVE_AT91_SAM9X60_PLL)	+= clk-sam9x60-pll.o
> -obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o
> +obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o dt-compat.o
>  obj-$(CONFIG_SOC_SAM9X60) += sam9x60.o
> -obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o
> -obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o
> -obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o
> +obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o dt-compat.o
> +obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o dt-compat.o
> +obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o dt-compat.o
>  obj-$(CONFIG_SOC_SAMA7G5) += sama7g5.o
> -- 
> 2.34.1
>
Claudiu Beznea Dec. 8, 2022, 3:17 p.m. UTC | #2 
On 08.12.2022 16:39, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 08/12/2022 13:45:15+0200, Claudiu Beznea wrote:
>> There is no need to have dt-compat.c compiled for SAMA7G5 and SAM9X60
>> as there is no in kernel device tree that could use it. Thus avoid
>> compiling dt-compat.c for them.
>>
> 
> Isn't it time to drop dt-compat.c? 

My assumption was that we need to guarantee that old device trees will
still work with newer kernels. Should we guarantee this only for a limited
period of time?

> I was going to send a patch after 6.1
> is released
> 
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>>  drivers/clk/at91/Makefile | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/clk/at91/Makefile b/drivers/clk/at91/Makefile
>> index 79301e1c1c36..89061b85e7d2 100644
>> --- a/drivers/clk/at91/Makefile
>> +++ b/drivers/clk/at91/Makefile
>> @@ -3,7 +3,7 @@
>>  # Makefile for at91 specific clk
>>  #
>>
>> -obj-y += pmc.o sckc.o dt-compat.o
>> +obj-y += pmc.o sckc.o
>>  obj-y += clk-slow.o clk-main.o clk-pll.o clk-plldiv.o clk-master.o
>>  obj-y += clk-system.o clk-peripheral.o clk-programmable.o
>>
>> @@ -15,12 +15,12 @@ obj-$(CONFIG_HAVE_AT91_H32MX)             += clk-h32mx.o
>>  obj-$(CONFIG_HAVE_AT91_GENERATED_CLK)        += clk-generated.o
>>  obj-$(CONFIG_HAVE_AT91_I2S_MUX_CLK)  += clk-i2s-mux.o
>>  obj-$(CONFIG_HAVE_AT91_SAM9X60_PLL)  += clk-sam9x60-pll.o
>> -obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o
>> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o
>> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o
>> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o
>> +obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o dt-compat.o
>> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o dt-compat.o
>> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o dt-compat.o
>> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o dt-compat.o
>>  obj-$(CONFIG_SOC_SAM9X60) += sam9x60.o
>> -obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o
>> -obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o
>> -obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o
>> +obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o dt-compat.o
>> +obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o dt-compat.o
>> +obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o dt-compat.o
>>  obj-$(CONFIG_SOC_SAMA7G5) += sama7g5.o
>> --
>> 2.34.1
>>
> 
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Claudiu Beznea Jan. 12, 2023, 10:28 a.m. UTC | #3 
On 08.12.2022 13:45, Claudiu Beznea wrote:
> There is no need to have dt-compat.c compiled for SAMA7G5 and SAM9X60
> as there is no in kernel device tree that could use it. Thus avoid
> compiling dt-compat.c for them.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Applied to clk-microchip, thanks!

> ---
>  drivers/clk/at91/Makefile | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/clk/at91/Makefile b/drivers/clk/at91/Makefile
> index 79301e1c1c36..89061b85e7d2 100644
> --- a/drivers/clk/at91/Makefile
> +++ b/drivers/clk/at91/Makefile
> @@ -3,7 +3,7 @@
>  # Makefile for at91 specific clk
>  #
>  
> -obj-y += pmc.o sckc.o dt-compat.o
> +obj-y += pmc.o sckc.o
>  obj-y += clk-slow.o clk-main.o clk-pll.o clk-plldiv.o clk-master.o
>  obj-y += clk-system.o clk-peripheral.o clk-programmable.o
>  
> @@ -15,12 +15,12 @@ obj-$(CONFIG_HAVE_AT91_H32MX)		+= clk-h32mx.o
>  obj-$(CONFIG_HAVE_AT91_GENERATED_CLK)	+= clk-generated.o
>  obj-$(CONFIG_HAVE_AT91_I2S_MUX_CLK)	+= clk-i2s-mux.o
>  obj-$(CONFIG_HAVE_AT91_SAM9X60_PLL)	+= clk-sam9x60-pll.o
> -obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o
> +obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o dt-compat.o
>  obj-$(CONFIG_SOC_SAM9X60) += sam9x60.o
> -obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o
> -obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o
> -obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o
> +obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o dt-compat.o
> +obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o dt-compat.o
> +obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o dt-compat.o
>  obj-$(CONFIG_SOC_SAMA7G5) += sama7g5.o
diff mbox series

Patch

diff --git a/drivers/clk/at91/Makefile b/drivers/clk/at91/Makefile
index 79301e1c1c36..89061b85e7d2 100644
--- a/drivers/clk/at91/Makefile
+++ b/drivers/clk/at91/Makefile
@@ -3,7 +3,7 @@ 
 # Makefile for at91 specific clk
 #
 
-obj-y += pmc.o sckc.o dt-compat.o
+obj-y += pmc.o sckc.o
 obj-y += clk-slow.o clk-main.o clk-pll.o clk-plldiv.o clk-master.o
 obj-y += clk-system.o clk-peripheral.o clk-programmable.o
 
@@ -15,12 +15,12 @@  obj-$(CONFIG_HAVE_AT91_H32MX)		+= clk-h32mx.o
 obj-$(CONFIG_HAVE_AT91_GENERATED_CLK)	+= clk-generated.o
 obj-$(CONFIG_HAVE_AT91_I2S_MUX_CLK)	+= clk-i2s-mux.o
 obj-$(CONFIG_HAVE_AT91_SAM9X60_PLL)	+= clk-sam9x60-pll.o
-obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o
-obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o
-obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o
-obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o
+obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o dt-compat.o
+obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o dt-compat.o
+obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o dt-compat.o
+obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o dt-compat.o
 obj-$(CONFIG_SOC_SAM9X60) += sam9x60.o
-obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o
-obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o
-obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o
+obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o dt-compat.o
+obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o dt-compat.o
+obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o dt-compat.o
 obj-$(CONFIG_SOC_SAMA7G5) += sama7g5.o