diff mbox series

mfd: rohm-bd9576: convert to i2c's .probe_new()

Message ID 20221121102454.15664-1-u.kleine-koenig@pengutronix.de
State New
Headers
Series mfd: rohm-bd9576: convert to i2c's .probe_new() |

Commit Message

Uwe Kleine-König Nov. 21, 2022, 10:24 a.m. UTC 
  The probe function doesn't make use of the i2c_device_id * parameter so
it can be trivially converted.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/mfd/rohm-bd9576.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Matti Vaittinen Nov. 21, 2022, 11:33 a.m. UTC | #1 
Thanks Uwe!

On 11/21/22 12:24, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>

> ---
>   drivers/mfd/rohm-bd9576.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
> index f37cd4f27aeb..c854ab5bcd80 100644
> --- a/drivers/mfd/rohm-bd9576.c
> +++ b/drivers/mfd/rohm-bd9576.c
> @@ -88,8 +88,7 @@ static struct regmap_irq_chip bd9576_irq_chip = {
>   	.irq_reg_stride = 1,
>   };
>   
> -static int bd957x_i2c_probe(struct i2c_client *i2c,
> -			     const struct i2c_device_id *id)
> +static int bd957x_i2c_probe(struct i2c_client *i2c)
>   {
>   	int ret;
>   	struct regmap *regmap;
> @@ -180,7 +179,7 @@ static struct i2c_driver bd957x_drv = {
>   		.name = "rohm-bd957x",
>   		.of_match_table = bd957x_of_match,
>   	},
> -	.probe = &bd957x_i2c_probe,
> +	.probe_new = &bd957x_i2c_probe,
>   };
>   module_i2c_driver(bd957x_drv);
>
Lee Jones Dec. 8, 2022, 12:37 p.m. UTC | #2 
On Mon, 21 Nov 2022, Uwe Kleine-König wrote:

> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/mfd/rohm-bd9576.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
index f37cd4f27aeb..c854ab5bcd80 100644
--- a/drivers/mfd/rohm-bd9576.c
+++ b/drivers/mfd/rohm-bd9576.c
@@ -88,8 +88,7 @@  static struct regmap_irq_chip bd9576_irq_chip = {
 	.irq_reg_stride = 1,
 };
 
-static int bd957x_i2c_probe(struct i2c_client *i2c,
-			     const struct i2c_device_id *id)
+static int bd957x_i2c_probe(struct i2c_client *i2c)
 {
 	int ret;
 	struct regmap *regmap;
@@ -180,7 +179,7 @@  static struct i2c_driver bd957x_drv = {
 		.name = "rohm-bd957x",
 		.of_match_table = bd957x_of_match,
 	},
-	.probe = &bd957x_i2c_probe,
+	.probe_new = &bd957x_i2c_probe,
 };
 module_i2c_driver(bd957x_drv);