| Message ID | 20221207162435.1001782-4-herve.codina@bootlin.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp280338wrr;
Wed, 7 Dec 2022 08:26:03 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf7DjR3O6WVaPFok6mNnXWwHv3H3xWuFbE5HvBllbpBzoG8gIgU4gw4RwGr+w8E4XQJxc5IH
X-Received: by 2002:a05:6a00:2181:b0:574:5c9e:c1f2 with SMTP id
h1-20020a056a00218100b005745c9ec1f2mr69621072pfi.52.1670430362824;
Wed, 07 Dec 2022 08:26:02 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1670430362; cv=none;
d=google.com; s=arc-20160816;
b=f4oRXV12eFr4dqFQVNJtthV+jrDmsKAkbp0pR/hZyAJhJZkxZvH6cdApIetD7/3qjQ
05Xq8B+29uuj8VC2+GR0TnlFZzwE8H3ErEkKuIbZPuru4t9U0mfL7ZaKlyKQzUPDl95A
Z4UgUd54v6SYJa6rpObAQRFxEWSsdpoFxGYue8I8VotUwFyehg4DFBtLPC6HKVroC0Oj
npliMLKF9VdamA1No5jJTj5qf+oEDd9mmyaC4Hebe0Zdh5yu4TGQt+Rt9iL2ruW74d/M
hVMEUkUcQhrznkemKDRQpromXVGeeiwYsLspgfava+qnNNdPdCSQ9/5f6E+/8lXZhXcL
h3PA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=y0zlUYLSpRM2wYy6doN2jLNpclnCDqnuIhKuhPexUHA=;
b=M8GVzxZLBTK0WrWk2tJ+r4fdW681hHgDZO5OSc4SpD4Odmlr2GPlfJNtiS9opIZBiL
uOHdDXlTvYa8wZEoik4lPIlke685NF/qCXDENX7fxIIg3Mpi86n5peVxnO3bZNI4H0IZ
u4xorey6CRqZAXOsM/0dLcdrEchBXATDUis6ixBB6TPFBCuZKXrT7JiQqho3N0fmnFbY
b5HUQp1xGWd0TmXMs4Cb15KRbsf73frT1G9drc8tY9aTYMyqPW9e4eeliUAsL9YHYl2s
G08osxG1bHOwjNRTKk0Rzau+PiNKFJSam1DAyARwl2bEUB7E4CR/bwR/r1N/sopAiiwM
W75g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YcIx80Tu;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
x141-20020a633193000000b00477c2ebfcf2si21706321pgx.65.2022.12.07.08.25.48;
Wed, 07 Dec 2022 08:26:02 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YcIx80Tu;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229849AbiLGQY5 (ORCPT <rfc822;foxyelen666@gmail.com>
+ 99 others); Wed, 7 Dec 2022 11:24:57 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48370 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229979AbiLGQYu (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 7 Dec 2022 11:24:50 -0500
Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net
[IPv6:2001:4b98:dc4:8::222])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8398D5FB83;
Wed, 7 Dec 2022 08:24:49 -0800 (PST)
Received: (Authenticated sender: herve.codina@bootlin.com)
by mail.gandi.net (Postfix) with ESMTPA id B73DC40008;
Wed, 7 Dec 2022 16:24:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1;
t=1670430288;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=y0zlUYLSpRM2wYy6doN2jLNpclnCDqnuIhKuhPexUHA=;
b=YcIx80TuiDjJEXm9SdkhbZCuZuMNq4B5HxmU8WHlg+JbX75PaQ8+QIGGFKcCbBfGPY3fiX
XtdvALu+1i+h/rQQhII4b8/78AXi23pDoy8LHtiStSXu+5tZgYoYK+ppIicq8S5Lui5nqq
rTbsTvjoJDpNBUZMwC3+BIr2bNyZLP/VM1Ao2HqSCSHaeEeRWUCTFsmliz+Ia1FIjBaeIy
wrQWoeoF1EYFpO7MAF3gRfp9uHtuP78uEPlmxKqaCOpigYa3b7+WOD+x8IcSwULDrwsKpA
IEGJh0AblSJfPVA7IM1v65yaaJ3W+n3ISO3UEu1qFxu2m6UFxmon7DbeIuXCuA==
From: Herve Codina <herve.codina@bootlin.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Herve Codina <herve.codina@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Magnus Damm <magnus.damm@gmail.com>,
Gareth Williams <gareth.williams.jx@renesas.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v3 3/9] dt-bindings: PCI: renesas,pci-rcar-gen2: 'depends-on'
is no more optional
Date: Wed, 7 Dec 2022 17:24:29 +0100
Message-Id: <20221207162435.1001782-4-herve.codina@bootlin.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221207162435.1001782-1-herve.codina@bootlin.com>
References: <20221207162435.1001782-1-herve.codina@bootlin.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1751573188422431165?=
X-GMAIL-MSGID: =?utf-8?q?1751573188422431165?=
|
| Series |
Add the Renesas USBF controller support
|
|
Commit Message
Herve Codina
Dec. 7, 2022, 4:24 p.m. UTC
The 'depends-on' property is set in involved DTS.
Move it to a required property.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
On 07/12/2022 17:24, Herve Codina wrote: > The 'depends-on' property is set in involved DTS. > > Move it to a required property. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- > Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 1 + This should be squashed with previous patch. There is no point to add property and immediately in the next patch make it required. Remember that bindings are separate from DTS. Best regards, Krzysztof
Hi Krzysztof, On Thu, 8 Dec 2022 09:26:41 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 07/12/2022 17:24, Herve Codina wrote: > > The 'depends-on' property is set in involved DTS. > > > > Move it to a required property. > > > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > > --- > > Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 1 + > > This should be squashed with previous patch. There is no point to add > property and immediately in the next patch make it required. Remember > that bindings are separate from DTS. > > Best regards, > Krzysztof > I though about make dtbs_check in case of git bisect. But, ok I will squash or perhaps remove completely this commit. It introduces a DT compatibility break adding a new mandatory property (raised by Rob on cover letter review). Is this compatibility break can be acceptable ? Best regards, Herve
On 08/12/2022 10:05, Herve Codina wrote: > Hi Krzysztof, > > On Thu, 8 Dec 2022 09:26:41 +0100 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> On 07/12/2022 17:24, Herve Codina wrote: >>> The 'depends-on' property is set in involved DTS. >>> >>> Move it to a required property. >>> >>> Signed-off-by: Herve Codina <herve.codina@bootlin.com> >>> --- >>> Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 1 + >> >> This should be squashed with previous patch. There is no point to add >> property and immediately in the next patch make it required. Remember >> that bindings are separate from DTS. >> >> Best regards, >> Krzysztof >> > > I though about make dtbs_check in case of git bisect. And what would this commit change? In Git you will have 1. dt-bindings: PCI: renesas,pci-rcar-gen2: Add depends-on for RZ/N1 SoC family 2. dt-bindings: PCI: renesas,pci-rcar-gen2: 'depends-on' is no more optional so what is the difference for git bisect? > > But, ok I will squash or perhaps remove completely this commit. > It introduces a DT compatibility break adding a new mandatory > property (raised by Rob on cover letter review). > Is this compatibility break can be acceptable ? Requiring property in bindings as a fix for something which was broken is ok. But this is independent of Linux drivers, which should not stop working. Best regards, Krzysztof
Hi Krzysztof, On Thu, 8 Dec 2022 10:46:32 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 08/12/2022 10:05, Herve Codina wrote: > > Hi Krzysztof, > > > > On Thu, 8 Dec 2022 09:26:41 +0100 > > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > > >> On 07/12/2022 17:24, Herve Codina wrote: > >>> The 'depends-on' property is set in involved DTS. > >>> > >>> Move it to a required property. > >>> > >>> Signed-off-by: Herve Codina <herve.codina@bootlin.com> > >>> --- > >>> Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 1 + > >> > >> This should be squashed with previous patch. There is no point to add > >> property and immediately in the next patch make it required. Remember > >> that bindings are separate from DTS. > >> > >> Best regards, > >> Krzysztof > >> > > > > I though about make dtbs_check in case of git bisect. > > And what would this commit change? In Git you will have > 1. dt-bindings: PCI: renesas,pci-rcar-gen2: Add depends-on for RZ/N1 SoC > family > 2. dt-bindings: PCI: renesas,pci-rcar-gen2: 'depends-on' is no more optional > > so what is the difference for git bisect? Well, today, I have: 1. dt-bindings: Add depends-on 2. dts: Add depends-on 3. dt-bindings: Move depends-on to mandatory If I squash dt-bindings commits, I am going to have: 1. dt-bindings: Add mandatory depends-on 2. dts: Add depends-on or 1. dts: Add depends-on 2. dt-bindings: Add mandatory depends-on I have not tested but if I used only the first commit in each case (git bisect): In the first case, dtbs_check is probably going to signal the missing 'depends-on' property on dts. In the second case, dtbs_check is probably going to signal the not described 'depends-on' property present in dts. > > > > > But, ok I will squash or perhaps remove completely this commit. > > It introduces a DT compatibility break adding a new mandatory > > property (raised by Rob on cover letter review). > > Is this compatibility break can be acceptable ? > > Requiring property in bindings as a fix for something which was broken > is ok. But this is independent of Linux drivers, which should not stop > working. Ok, thanks. > > Best regards, > Krzysztof > Regards, Hervé
On 08/12/2022 16:51, Herve Codina wrote: > Hi Krzysztof, > > On Thu, 8 Dec 2022 10:46:32 +0100 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> On 08/12/2022 10:05, Herve Codina wrote: >>> Hi Krzysztof, >>> >>> On Thu, 8 Dec 2022 09:26:41 +0100 >>> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: >>> >>>> On 07/12/2022 17:24, Herve Codina wrote: >>>>> The 'depends-on' property is set in involved DTS. >>>>> >>>>> Move it to a required property. >>>>> >>>>> Signed-off-by: Herve Codina <herve.codina@bootlin.com> >>>>> --- >>>>> Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 1 + >>>> >>>> This should be squashed with previous patch. There is no point to add >>>> property and immediately in the next patch make it required. Remember >>>> that bindings are separate from DTS. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> I though about make dtbs_check in case of git bisect. >> >> And what would this commit change? In Git you will have >> 1. dt-bindings: PCI: renesas,pci-rcar-gen2: Add depends-on for RZ/N1 SoC >> family >> 2. dt-bindings: PCI: renesas,pci-rcar-gen2: 'depends-on' is no more optional >> >> so what is the difference for git bisect? > > Well, today, I have: > 1. dt-bindings: Add depends-on > 2. dts: Add depends-on > 3. dt-bindings: Move depends-on to mandatory What does it mean "I have"? Patches on mailing list? But we talk about Git and I wrote you bindings are DTS are not going the same tree. > > If I squash dt-bindings commits, I am going to have: > 1. dt-bindings: Add mandatory depends-on > 2. dts: Add depends-on > or > 1. dts: Add depends-on > 2. dt-bindings: Add mandatory depends-on And how does it matter? Anyway it goes separate trees. > > I have not tested but if I used only the first commit in each > case (git bisect): It's not bisectable anyway, you cannot make it bisectable within one release. > In the first case, dtbs_check is probably going to signal the > missing 'depends-on' property on dts. > In the second case, dtbs_check is probably going to signal the > not described 'depends-on' property present in dts. And why is that even a problem? Best regards, Krzysztof
Hi Krzysztof, On Fri, 9 Dec 2022 09:06:55 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 08/12/2022 16:51, Herve Codina wrote: > > Hi Krzysztof, > > > > On Thu, 8 Dec 2022 10:46:32 +0100 > > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > > >> On 08/12/2022 10:05, Herve Codina wrote: > >>> Hi Krzysztof, > >>> > >>> On Thu, 8 Dec 2022 09:26:41 +0100 > >>> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >>> > >>>> On 07/12/2022 17:24, Herve Codina wrote: > >>>>> The 'depends-on' property is set in involved DTS. > >>>>> > >>>>> Move it to a required property. > >>>>> > >>>>> Signed-off-by: Herve Codina <herve.codina@bootlin.com> > >>>>> --- > >>>>> Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 1 + > >>>> > >>>> This should be squashed with previous patch. There is no point to add > >>>> property and immediately in the next patch make it required. Remember > >>>> that bindings are separate from DTS. > >>>> > >>>> Best regards, > >>>> Krzysztof > >>>> > >>> > >>> I though about make dtbs_check in case of git bisect. > >> > >> And what would this commit change? In Git you will have > >> 1. dt-bindings: PCI: renesas,pci-rcar-gen2: Add depends-on for RZ/N1 SoC > >> family > >> 2. dt-bindings: PCI: renesas,pci-rcar-gen2: 'depends-on' is no more optional > >> > >> so what is the difference for git bisect? > > > > Well, today, I have: > > 1. dt-bindings: Add depends-on > > 2. dts: Add depends-on > > 3. dt-bindings: Move depends-on to mandatory > > What does it mean "I have"? Patches on mailing list? But we talk about > Git and I wrote you bindings are DTS are not going the same tree. > > > > > If I squash dt-bindings commits, I am going to have: > > 1. dt-bindings: Add mandatory depends-on > > 2. dts: Add depends-on > > or > > 1. dts: Add depends-on > > 2. dt-bindings: Add mandatory depends-on > > And how does it matter? Anyway it goes separate trees. I finally understand what you mean by separate trees. And indeed, you're right, my patches split does not make any sense. According to feedbacks on this v3 series, these 3 patches will be removed in v4. Thanks for the review, Hervé
diff --git a/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml b/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml index e1221ad68465..4dd0f2f72e62 100644 --- a/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml +++ b/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml @@ -138,6 +138,7 @@ allOf: the underlying USB hosts start. required: - clock-names + - depends-on else: properties: clocks: