drm/i915: Fix documentation for intel_uncore_forcewake_put__locked

Message ID 20221207112909.2655251-1-linmq006@gmail.com
State New
Headers
Series drm/i915: Fix documentation for intel_uncore_forcewake_put__locked |

Commit Message

Miaoqian Lin Dec. 7, 2022, 11:29 a.m. UTC
  intel_uncore_forcewake_put__locked() is used to release a reference.

Fixes: a6111f7b6604 ("drm/i915: Reduce locking in execlist command submission")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/gpu/drm/i915/intel_uncore.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Rodrigo Vivi Dec. 7, 2022, 4 p.m. UTC | #1
On Wed, Dec 07, 2022 at 03:29:09PM +0400, Miaoqian Lin wrote:
> intel_uncore_forcewake_put__locked() is used to release a reference.
> 
> Fixes: a6111f7b6604 ("drm/i915: Reduce locking in execlist command submission")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and will push this right now...

> ---
>  drivers/gpu/drm/i915/intel_uncore.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 5cd423c7b646..acb40543eb32 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -819,9 +819,9 @@ void intel_uncore_forcewake_flush(struct intel_uncore *uncore,
>  }
>  
>  /**
> - * intel_uncore_forcewake_put__locked - grab forcewake domain references
> + * intel_uncore_forcewake_put__locked - release forcewake domain references
>   * @uncore: the intel_uncore structure
> - * @fw_domains: forcewake domains to get reference on
> + * @fw_domains: forcewake domains to put references
>   *
>   * See intel_uncore_forcewake_put(). This variant places the onus
>   * on the caller to explicitly handle the dev_priv->uncore.lock spinlock.
> -- 
> 2.25.1
>
  

Patch

diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index 5cd423c7b646..acb40543eb32 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -819,9 +819,9 @@  void intel_uncore_forcewake_flush(struct intel_uncore *uncore,
 }
 
 /**
- * intel_uncore_forcewake_put__locked - grab forcewake domain references
+ * intel_uncore_forcewake_put__locked - release forcewake domain references
  * @uncore: the intel_uncore structure
- * @fw_domains: forcewake domains to get reference on
+ * @fw_domains: forcewake domains to put references
  *
  * See intel_uncore_forcewake_put(). This variant places the onus
  * on the caller to explicitly handle the dev_priv->uncore.lock spinlock.