diff mbox series

[linux-next] docs: proc.rst: add softnet_stat

Message ID 202212071423496852423@zte.com.cn
State New
Headers
Series [linux-next] docs: proc.rst: add softnet_stat |

Commit Message

Yang Yang Dec. 7, 2022, 6:23 a.m. UTC 
  From: Yang Yang <yang.yang29@zte.com.cn>

Softnet_stat shows statistics of struct softnet_data of online CPUs.
Struct softnet_data manages incoming and output packets on
per-CPU queues. Notice that fastroute and cpu_collision in
softnet_stat are obsoleted, their value is always 0.

Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Reviewed-by: xu xin <xu.xin16@zte.com.cn>
Reviewed-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
 Documentation/filesystems/proc.rst | 1 +
 1 file changed, 1 insertion(+)

Comments

Bagas Sanjaya Dec. 7, 2022, 9:10 a.m. UTC | #1 
On 12/7/22 13:23, yang.yang29@zte.com.cn wrote:
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index e224b6d5b642..9d5fd9424e8b 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -1284,6 +1284,7 @@ support this. Table 1-9 lists the files and their meaning.
>   rt_cache      Routing cache
>   snmp          SNMP data
>   sockstat      Socket statistics
> + softnet_stat  Per-CPU incoming packets queues statistics of online CPUs
>   tcp           TCP  sockets
>   udp           UDP sockets
>   unix          UNIX domain sockets

Add softnet_stat to what table? I have to read the actual documentation
and found that you mean /proc/net table. Please mention that in patch
subject.

Regardless, this patch is from ZTE people, for which they have a
reputation for ignoring critical code reviews and "atypical" email
setup that needs to be fixed (try searching for `tc:"zte.com.cn" AND
f:"gregkh@linuxfoundation.org"` on LKML for details). If you can
receive this email, please hit "Reply all", "Group Reply" or similar.
Remember don't top-post, reply inline with appropriate context instead.

Thanks.
Yang Yang Dec. 7, 2022, 9:51 a.m. UTC | #2 
On 12/7/22 17:10, bagasdotme@gmail.com wrote:
> Add softnet_stat to what table? I have to read the actual documentation
> and found that you mean /proc/net table. Please mention that in patch
> subject.

OK, I will add this to subject.

> Regardless, this patch is from ZTE people, for which they have a
> reputation for ignoring critical code reviews and "atypical" email
> setup that needs to be fixed

Really sorry for that, We will try to avoid this.

Thanks.
diff mbox series

Patch

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index e224b6d5b642..9d5fd9424e8b 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -1284,6 +1284,7 @@  support this. Table 1-9 lists the files and their meaning.
  rt_cache      Routing cache
  snmp          SNMP data
  sockstat      Socket statistics
+ softnet_stat  Per-CPU incoming packets queues statistics of online CPUs
  tcp           TCP  sockets
  udp           UDP sockets
  unix          UNIX domain sockets