thermal/core/power allocator: Remove a useless include

Message ID 9adeec47cb5a8193016272d5c8bf936235c1711d.1669459337.git.christophe.jaillet@wanadoo.fr
State New
Headers
Series thermal/core/power allocator: Remove a useless include |

Commit Message

Christophe JAILLET Nov. 26, 2022, 10:42 a.m. UTC
  This file does not use rcu, so there is no point in including
<linux/rculist.h>.

Remove it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/thermal/gov_power_allocator.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Lukasz Luba Nov. 28, 2022, 7:19 a.m. UTC | #1
On 11/26/22 10:42, Christophe JAILLET wrote:
> This file does not use rcu, so there is no point in including
> <linux/rculist.h>.
> 
> Remove it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>   drivers/thermal/gov_power_allocator.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> index 2d1aeaba38a8..d5d4eae16771 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -8,7 +8,6 @@
>   
>   #define pr_fmt(fmt) "Power allocator: " fmt
>   
> -#include <linux/rculist.h>
>   #include <linux/slab.h>
>   #include <linux/thermal.h>
>   

Good catch.

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
  
Daniel Lezcano Dec. 4, 2022, 4:40 p.m. UTC | #2
On 26/11/2022 11:42, Christophe JAILLET wrote:
> This file does not use rcu, so there is no point in including
> <linux/rculist.h>.
> 
> Remove it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Applied, thanks
  

Patch

diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 2d1aeaba38a8..d5d4eae16771 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -8,7 +8,6 @@ 
 
 #define pr_fmt(fmt) "Power allocator: " fmt
 
-#include <linux/rculist.h>
 #include <linux/slab.h>
 #include <linux/thermal.h>