diff mbox series

net/atm: fix proc_mpc_write incorrect return value

Message ID 20221014020540.32114-1-cppcoffee@gmail.com
State New
Headers
Series net/atm: fix proc_mpc_write incorrect return value |

Commit Message

Xiaobo Liu Oct. 14, 2022, 2:05 a.m. UTC 
  Then the input contains '\0' or '\n', proc_mpc_write has read them,
so the return value needs +1.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
---
 net/atm/mpoa_proc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 15, 2022, 10:10 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 14 Oct 2022 10:05:40 +0800 you wrote:
> Then the input contains '\0' or '\n', proc_mpc_write has read them,
> so the return value needs +1.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> 
> Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
> 
> [...]

Here is the summary with links:
  - net/atm: fix proc_mpc_write incorrect return value
    https://git.kernel.org/netdev/net/c/d8bde3bf7f82

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/atm/mpoa_proc.c b/net/atm/mpoa_proc.c
index 829db9eba..aaf64b953 100755
--- a/net/atm/mpoa_proc.c
+++ b/net/atm/mpoa_proc.c
@@ -219,11 +219,12 @@  static ssize_t proc_mpc_write(struct file *file, const char __user *buff,
 	if (!page)
 		return -ENOMEM;
 
-	for (p = page, len = 0; len < nbytes; p++, len++) {
+	for (p = page, len = 0; len < nbytes; p++) {
 		if (get_user(*p, buff++)) {
 			free_page((unsigned long)page);
 			return -EFAULT;
 		}
+		len += 1;
 		if (*p == '\0' || *p == '\n')
 			break;
 	}