| Message ID | 20221202211940.29111-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1076706wrr;
Fri, 2 Dec 2022 13:24:52 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf5QorgJFbKOzv0FE1Xe45gesFzUIoqkgoxn2l3DIpBsskfv1X1ihxME9WOon3L4njrFgkKr
X-Received: by 2002:a17:906:43d0:b0:78d:a01b:b474 with SMTP id
j16-20020a17090643d000b0078da01bb474mr48658210ejn.8.1670016292346;
Fri, 02 Dec 2022 13:24:52 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1670016292; cv=none;
d=google.com; s=arc-20160816;
b=VCL3nvn2GHE4tz325vYWII1y60lEzXiTUEibSlcOftcWQHLPkzOpfAijIOviIe8GUu
riw1PJihhjDsh4wCNbqFfaYsanenyP1SMZGJEukEoCFzSVTSj5orjDyqI09KaAlmYB51
j0XJlNIKpWN3B7mM+KLTGUDEOqd1m9IRMAvUWDAG2DoZOM/YUu/KPNlOL1e3ylt/wUel
PaRYj+O8RK/uRmBSfncVs9hnncgznXfqEo+NYcDdRssr+ZvSm+SAPwUoTJxomqpuE8g+
/dkvRa5MEV4hAp7dwpnlvT/xFFMR7DIqrqlMDYEYsapUy6svfEI+07m15OheXwGyHLFz
+p3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=oV6byBYn0tYljp79kb76vPExm6qPuaFXLFbzIN1Gi3c=;
b=p+tnJyYRijzrV0pYQWsqa5PblGZiPI3gumxoFCc/nZqzP4EHFxf3sMgEvG9bXKEk93
1IrivZSEf0J4OPRzcsgOMut45OO2bafybxD1NWtpIRM8TgVZArzmfmnJU6UOR4vSqGAG
MR6sSfM67PiI2mI4Ddh5QX3YQiSwzblG0pYfG3AoSKHHrP/6BbL4KLB/HgFmI8yZZrZU
qzLQXoGyIVB8yhYX8edD1R35WbVsNGNTZU/FmMROHlpQnKcqS6ufV++Tbn3diPSq81Tn
BsUaR017Vspq6gYm3fTpfIGGJwCqCbaZowgdRMAMS8aXmfJuWel3NLSWZJYua4v00Fg5
mqvQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@infradead.org header.s=casper.20170209
header.b=lnJcPZFJ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
b23-20020aa7cd17000000b00459e1ce80a7si6687028edw.241.2022.12.02.13.24.28;
Fri, 02 Dec 2022 13:24:52 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@infradead.org header.s=casper.20170209
header.b=lnJcPZFJ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S234200AbiLBVUM (ORCPT <rfc822;lhua1029@gmail.com> + 99 others);
Fri, 2 Dec 2022 16:20:12 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33960 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234530AbiLBVTv (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 2 Dec 2022 16:19:51 -0500
Received: from casper.infradead.org (casper.infradead.org
[IPv6:2001:8b0:10b:1236::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 209AA9D2E6;
Fri, 2 Dec 2022 13:19:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=casper.20170209;
h=Content-Transfer-Encoding:MIME-Version:
Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
Content-Description:In-Reply-To:References;
bh=oV6byBYn0tYljp79kb76vPExm6qPuaFXLFbzIN1Gi3c=;
b=lnJcPZFJS0R/dpvl0Gq+K5lQSR
YmE2/eMHy0Y8CPju06DjtzSTvdcfzjDWl9/42ArRjqWkNLYlUnHaqldz/k/hvFkHAg0Z0I0uQplpo
TMwbvD9pjvr8iPdEv/YtwLMgRf38lM0dcer5EYpq5KuZwUMAd18+79Dza6xICzBqczHxV0nw+n+D5
QRFpFbtq5MTJJTHRY6luSsVrGWtZVWcRPCFI/GvClnINnKe7dShzFjnHj1pcGLZqdlBlTH3O+j3HP
3n6YSaFFQHFVXpp8492HMQ+jtTAfk6SER0KdDMI7FWNfw8i37o8k7R8nLjNbkez2Uz6lahb95DKdP
lTkOALHg==;
Received: from [2601:1c2:d80:3110::a2e7] (helo=casper.infradead.org)
by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
id 1p1DRp-000X5k-Sp; Fri, 02 Dec 2022 21:19:54 +0000
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Leon Romanovsky <leon@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Christoph Hellwig <hch@infradead.org>,
linux-rdma@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um@lists.infradead.org
Subject: [PATCH v2] infiniband: disable IB HW for UML
Date: Fri, 2 Dec 2022 13:19:40 -0800
Message-Id: <20221202211940.29111-1-rdunlap@infradead.org>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1751139003249325199?=
X-GMAIL-MSGID: =?utf-8?q?1751139003249325199?=
|
| Series |
[v2] infiniband: disable IB HW for UML
|
|
Commit Message
Randy Dunlap
Dec. 2, 2022, 9:19 p.m. UTC
Disable all of drivers/infiniband/hw/ for UML builds until someone
needs it and provides patches to support it.
This prevents build errors in hw/qib/qib_wc_x86_64.c.
Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Suggested-by: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: linux-rdma@vger.kernel.org
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-um@lists.infradead.org
---
v2: just disable infiniband/hw/, not all of infiniband.
drivers/infiniband/Kconfig | 2 ++
1 file changed, 2 insertions(+)
Comments
On Fri, Dec 02, 2022 at 01:19:40PM -0800, Randy Dunlap wrote: > Disable all of drivers/infiniband/hw/ for UML builds until someone > needs it and provides patches to support it. > > This prevents build errors in hw/qib/qib_wc_x86_64.c. > > Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Suggested-by: Leon Romanovsky <leon@kernel.org> > Cc: Jason Gunthorpe <jgg@nvidia.com> > Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com> > Cc: Christoph Hellwig <hch@infradead.org> > Cc: linux-rdma@vger.kernel.org > Cc: Jeff Dike <jdike@addtoit.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: linux-um@lists.infradead.org > --- > v2: just disable infiniband/hw/, not all of infiniband. > > drivers/infiniband/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) I added rdmavt to the mix and applied. https://lore.kernel.org/linux-rdma/20221130200958.25305-1-rdunlap@infradead.org/ diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig index 6ee97c898231..a5827d11e934 100644 --- a/drivers/infiniband/Kconfig +++ b/drivers/infiniband/Kconfig @@ -95,8 +95,8 @@ source "drivers/infiniband/hw/qedr/Kconfig" source "drivers/infiniband/hw/qib/Kconfig" source "drivers/infiniband/hw/usnic/Kconfig" source "drivers/infiniband/hw/vmw_pvrdma/Kconfig" -endif # !UML source "drivers/infiniband/sw/rdmavt/Kconfig" +endif # !UML source "drivers/infiniband/sw/rxe/Kconfig" source "drivers/infiniband/sw/siw/Kconfig" endif (END) > > diff -- a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig > --- a/drivers/infiniband/Kconfig > +++ b/drivers/infiniband/Kconfig > @@ -78,6 +78,7 @@ config INFINIBAND_VIRT_DMA > def_bool !HIGHMEM > > if INFINIBAND_USER_ACCESS || !INFINIBAND_USER_ACCESS > +if !UML > source "drivers/infiniband/hw/bnxt_re/Kconfig" > source "drivers/infiniband/hw/cxgb4/Kconfig" > source "drivers/infiniband/hw/efa/Kconfig" > @@ -94,6 +95,7 @@ source "drivers/infiniband/hw/qedr/Kconf > source "drivers/infiniband/hw/qib/Kconfig" > source "drivers/infiniband/hw/usnic/Kconfig" > source "drivers/infiniband/hw/vmw_pvrdma/Kconfig" > +endif # !UML > source "drivers/infiniband/sw/rdmavt/Kconfig" > source "drivers/infiniband/sw/rxe/Kconfig" > source "drivers/infiniband/sw/siw/Kconfig"
On Fri, 2 Dec 2022 13:19:40 -0800, Randy Dunlap wrote: > Disable all of drivers/infiniband/hw/ for UML builds until someone > needs it and provides patches to support it. > > This prevents build errors in hw/qib/qib_wc_x86_64.c. > > Applied, thanks! [1/1] infiniband: disable IB HW for UML https://git.kernel.org/rdma/rdma/c/323a74fc20f53c Best regards,
On 12/4/22 05:21, Leon Romanovsky wrote: > On Fri, Dec 02, 2022 at 01:19:40PM -0800, Randy Dunlap wrote: >> Disable all of drivers/infiniband/hw/ for UML builds until someone >> needs it and provides patches to support it. >> >> This prevents build errors in hw/qib/qib_wc_x86_64.c. >> >> Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Suggested-by: Leon Romanovsky <leon@kernel.org> >> Cc: Jason Gunthorpe <jgg@nvidia.com> >> Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com> >> Cc: Christoph Hellwig <hch@infradead.org> >> Cc: linux-rdma@vger.kernel.org >> Cc: Jeff Dike <jdike@addtoit.com> >> Cc: Richard Weinberger <richard@nod.at> >> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> >> Cc: Johannes Berg <johannes@sipsolutions.net> >> Cc: linux-um@lists.infradead.org >> --- >> v2: just disable infiniband/hw/, not all of infiniband. >> >> drivers/infiniband/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) > > I added rdmavt to the mix and applied. Sounds good. Thanks. > https://lore.kernel.org/linux-rdma/20221130200958.25305-1-rdunlap@infradead.org/ > > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig > index 6ee97c898231..a5827d11e934 100644 > --- a/drivers/infiniband/Kconfig > +++ b/drivers/infiniband/Kconfig > @@ -95,8 +95,8 @@ source "drivers/infiniband/hw/qedr/Kconfig" > source "drivers/infiniband/hw/qib/Kconfig" > source "drivers/infiniband/hw/usnic/Kconfig" > source "drivers/infiniband/hw/vmw_pvrdma/Kconfig" > -endif # !UML > source "drivers/infiniband/sw/rdmavt/Kconfig" > +endif # !UML > source "drivers/infiniband/sw/rxe/Kconfig" > source "drivers/infiniband/sw/siw/Kconfig" > endif > (END)
diff -- a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig --- a/drivers/infiniband/Kconfig +++ b/drivers/infiniband/Kconfig @@ -78,6 +78,7 @@ config INFINIBAND_VIRT_DMA def_bool !HIGHMEM if INFINIBAND_USER_ACCESS || !INFINIBAND_USER_ACCESS +if !UML source "drivers/infiniband/hw/bnxt_re/Kconfig" source "drivers/infiniband/hw/cxgb4/Kconfig" source "drivers/infiniband/hw/efa/Kconfig" @@ -94,6 +95,7 @@ source "drivers/infiniband/hw/qedr/Kconf source "drivers/infiniband/hw/qib/Kconfig" source "drivers/infiniband/hw/usnic/Kconfig" source "drivers/infiniband/hw/vmw_pvrdma/Kconfig" +endif # !UML source "drivers/infiniband/sw/rdmavt/Kconfig" source "drivers/infiniband/sw/rxe/Kconfig" source "drivers/infiniband/sw/siw/Kconfig"