Message ID | 1669310088-13482-6-git-send-email-renyu.zj@linux.alibaba.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3518489wrr; Thu, 24 Nov 2022 09:17:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf5q1KMOpdR7Vd83fNOj/qmL1VJL5WUPNOmThDkfgWHK0aNaaPueYpm9hS8sfzbJJIJw/m9G X-Received: by 2002:a50:f602:0:b0:469:4e4f:4827 with SMTP id c2-20020a50f602000000b004694e4f4827mr23146204edn.214.1669310273778; Thu, 24 Nov 2022 09:17:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669310273; cv=none; d=google.com; s=arc-20160816; b=0I3wE4p2MCnT/wOoFLAXIzQEYPIdkcLwU8uyoN3pSE9Wrp7j9bYCmV3HZkcDjtRnoD Xa5zYO4dPJEBBQ0BnNdcIoQ3pusiboCLOk/usrL90ceEu04AKvEs8cwhC6AdzSq/UE8c W+lU3pqAx6u0puwE/W9HPUHEk12c/mbZOGEwOZcX3vvnCanX3wYA/9YmG23IbLJ5ETju 86wda6tMY+xVtKyDZM+pS/mXef0jHtyZfuPmAsyWOSz1eL6Ifyf+SSw6mXYNprMAY0HZ UkesAUKvbflzqkCcPvl32rjVWftLAuXjRgdfEPg5PTeWiUftvbUVugVk+BJtdgfM+MoJ CPEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=GnENjVrQ0cj994x/sBgASpwMO5lVfLCh79eKApRlL9w=; b=0exjDEfIzfIsRZ13m3AbJH4/A5pSU8wZ2j40BrKn6tsIlZw2IYFNTGH543teTS035j A1T17Go5anWrecKmWTtWXbbnQCWioA7FkFPSm8nrPnvcKA/k6dvzySvHjufk6gNMyDgI DmbkmNBz0aTklkLcygneHXR9outLtg62lJR2FYqgCoQkIjQ6QfI9gkFWqIZmlACPyhH0 37wZ3y5rupvjbKz7LR8zA2Lj9Fb08PoQbIiViwDzqUUm9jW40hR2bdTm26b7D3Y899+J pUR4pmjFyofTCk7TOzPAflOyxdDSXiXlG1c77Ij7c5dC/N5RZIgs0Mq8boHfHmv5httH 1bBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne22-20020a1709077b9600b0076ed46e4440si1360077ejc.636.2022.11.24.09.17.26; Thu, 24 Nov 2022 09:17:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbiKXRPR (ORCPT <rfc822;fengqi706@gmail.com> + 99 others); Thu, 24 Nov 2022 12:15:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbiKXRPJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 24 Nov 2022 12:15:09 -0500 Received: from out199-5.us.a.mail.aliyun.com (out199-5.us.a.mail.aliyun.com [47.90.199.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2955513180B; Thu, 24 Nov 2022 09:15:07 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VVbtc8O_1669310102; Received: from j66e01291.sqa.eu95.tbsite.net(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VVbtc8O_1669310102) by smtp.aliyun-inc.com; Fri, 25 Nov 2022 01:15:02 +0800 From: Jing Zhang <renyu.zj@linux.alibaba.com> To: John Garry <john.g.garry@oracle.com>, Ian Rogers <irogers@google.com>, Xing Zhengjun <zhengjun.xing@linux.intel.com>, Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>, Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Andrew Kilroy <andrew.kilroy@arm.com>, Shuai Xue <xueshuai@linux.alibaba.com>, Zhuo Song <zhuo.song@linux.alibaba.com>, Jing Zhang <renyu.zj@linux.alibaba.com> Subject: [PATCH v3 5/6] perf vendor events arm64: Add PE utilization metrics for neoverse-n2 Date: Fri, 25 Nov 2022 01:14:47 +0800 Message-Id: <1669310088-13482-6-git-send-email-renyu.zj@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1669310088-13482-1-git-send-email-renyu.zj@linux.alibaba.com> References: <1669310088-13482-1-git-send-email-renyu.zj@linux.alibaba.com> In-Reply-To: <1668411720-3581-1-git-send-email-renyu.zj@linux.alibaba.com> References: <1668411720-3581-1-git-send-email-renyu.zj@linux.alibaba.com> X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748201534987720342?= X-GMAIL-MSGID: =?utf-8?q?1750398689823335164?= |
Series |
Add metrics for neoverse-n2
|
|
Commit Message
Jing Zhang
Nov. 24, 2022, 5:14 p.m. UTC
Add PE utilization related metrics.
Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
---
.../arch/arm64/arm/neoverse-n2/metrics.json | 45 ++++++++++++++++++++++
1 file changed, 45 insertions(+)
Comments
On Thu, Nov 24, 2022 at 9:15 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > > Add PE utilization related metrics. > > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com> > --- > .../arch/arm64/arm/neoverse-n2/metrics.json | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > index 23c7d62..7b54819 100644 > --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > @@ -189,5 +189,50 @@ > "MetricGroup": "Branch", > "MetricName": "branch_miss_pred_rate", > "ScaleUnit": "100%" > + }, > + { > + "MetricExpr": "instructions / CPU_CYCLES", > + "PublicDescription": "The average number of instructions executed for each cycle.", > + "BriefDescription": "Instructions per cycle", > + "MetricGroup": "PEutilization", > + "MetricName": "ipc" > + }, A related useful metric is percentage of peak, so if the peak IPC is 8 (usually a constant related to the number of functional units) then you can just compute the ratio of IPC with this. > + { > + "MetricExpr": "INST_RETIRED / CPU_CYCLES", > + "PublicDescription": "Architecturally executed Instructions Per Cycle (IPC)", > + "BriefDescription": "Architecturally executed Instructions Per Cycle (IPC)", The duplicated descriptions are unnecessary. Drop the public one for consistency with what we do for Intel: https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py#L299 > + "MetricGroup": "PEutilization", > + "MetricName": "retired_ipc" > + }, > + { > + "MetricExpr": "INST_SPEC / CPU_CYCLES", > + "PublicDescription": "Speculatively executed Instructions Per Cycle (IPC)", > + "BriefDescription": "Speculatively executed Instructions Per Cycle (IPC)", > + "MetricGroup": "PEutilization", > + "MetricName": "spec_ipc" > + }, > + { > + "MetricExpr": "OP_RETIRED / OP_SPEC", > + "PublicDescription": "Fraction of operations retired", > + "BriefDescription": "Fraction of operations retired", Would instructions be clearer than operations here? > + "MetricGroup": "PEutilization", > + "MetricName": "retired_rate", > + "ScaleUnit": "100%" > + }, > + { > + "MetricExpr": "1 - OP_RETIRED / OP_SPEC", Should OP_RETIRED be greater than OP_SPEC? In which case won't this metric be negative? > + "PublicDescription": "Fraction of operations wasted", > + "BriefDescription": "Fraction of operations wasted", > + "MetricGroup": "PEutilization", > + "MetricName": "wasted_rate", > + "ScaleUnit": "100%" > + }, > + { > + "MetricExpr": "OP_RETIRED / OP_SPEC * (1 - (STALL_SLOT - CPU_CYCLES) / (CPU_CYCLES * 5))", > + "PublicDescription": "Utilization of CPU", > + "BriefDescription": "Utilization of CPU", Some more detail in the description would be useful. > + "MetricGroup": "PEutilization", > + "MetricName": "cpu_utilization", > + "ScaleUnit": "100%" > } > ] > -- > 1.8.3.1 >
在 2022/12/1 上午2:58, Ian Rogers 写道: > On Thu, Nov 24, 2022 at 9:15 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: >> >> Add PE utilization related metrics. >> >> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com> >> --- >> .../arch/arm64/arm/neoverse-n2/metrics.json | 45 ++++++++++++++++++++++ >> 1 file changed, 45 insertions(+) >> >> diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> index 23c7d62..7b54819 100644 >> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> @@ -189,5 +189,50 @@ >> "MetricGroup": "Branch", >> "MetricName": "branch_miss_pred_rate", >> "ScaleUnit": "100%" >> + }, >> + { >> + "MetricExpr": "instructions / CPU_CYCLES", >> + "PublicDescription": "The average number of instructions executed for each cycle.", >> + "BriefDescription": "Instructions per cycle", >> + "MetricGroup": "PEutilization", >> + "MetricName": "ipc" >> + }, > > A related useful metric is percentage of peak, so if the peak IPC is 8 > (usually a constant related to the number of functional units) then > you can just compute the ratio of IPC with this. > Glad to discuss these with you. The peak ipc value of neoverse-n2 is 5. Maybe I should add an ipc_rate metric? >> + { >> + "MetricExpr": "INST_RETIRED / CPU_CYCLES", >> + "PublicDescription": "Architecturally executed Instructions Per Cycle (IPC)", >> + "BriefDescription": "Architecturally executed Instructions Per Cycle (IPC)", > > > The duplicated descriptions are unnecessary. Drop the public one for > consistency with what we do for Intel: > https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py#L299 > Sounds good, will do. >> + "MetricGroup": "PEutilization", >> + "MetricName": "retired_ipc" >> + }, >> + { >> + "MetricExpr": "INST_SPEC / CPU_CYCLES", >> + "PublicDescription": "Speculatively executed Instructions Per Cycle (IPC)", >> + "BriefDescription": "Speculatively executed Instructions Per Cycle (IPC)", >> + "MetricGroup": "PEutilization", >> + "MetricName": "spec_ipc" >> + }, >> + { >> + "MetricExpr": "OP_RETIRED / OP_SPEC", >> + "PublicDescription": "Fraction of operations retired", >> + "BriefDescription": "Fraction of operations retired", > > Would instructions be clearer than operations here? > operation and instruction are different. OP_RETIRED counts any operation (not instruction) that has been architecturally executed, For example, speculatively executed operations that have been abandoned for a branch mispredict will not be counted. So I think operation might be more accurate. >> + "MetricGroup": "PEutilization", >> + "MetricName": "retired_rate", >> + "ScaleUnit": "100%" >> + }, >> + { >> + "MetricExpr": "1 - OP_RETIRED / OP_SPEC", > > Should OP_RETIRED be greater than OP_SPEC? In which case won't this > metric be negative? > OP_RETIRED will not be greater than OP_SPEC. OP_SPEC counts any operation that has been speculatively executed. OP_SPEC is a superset of the OP_RETIRED event. There is a description about OP_SPEC and OP_RETIRED in this neoverse-n2 document. Link: https://documentation-service.arm.com/static/62cfe21e31ea212bb6627393?token= >> + "PublicDescription": "Fraction of operations wasted", >> + "BriefDescription": "Fraction of operations wasted", >> + "MetricGroup": "PEutilization", >> + "MetricName": "wasted_rate", >> + "ScaleUnit": "100%" >> + }, >> + { >> + "MetricExpr": "OP_RETIRED / OP_SPEC * (1 - (STALL_SLOT - CPU_CYCLES) / (CPU_CYCLES * 5))", >> + "PublicDescription": "Utilization of CPU", >> + "BriefDescription": "Utilization of CPU", > > Some more detail in the description would be useful. > Ok, I'll describe it in more detail. CPU_utilization reflects the truly effective ratio of operation executed by the CPU, which means that misprediction and stall are not included. Note that stall_slot minus cpu_cycles is a correction to the stall_slot error count. >> + "MetricGroup": "PEutilization", >> + "MetricName": "cpu_utilization", >> + "ScaleUnit": "100%" >> } >> ] >> -- >> 1.8.3.1 >>
On Thu, Dec 1, 2022 at 3:08 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > > > > 在 2022/12/1 上午2:58, Ian Rogers 写道: > > On Thu, Nov 24, 2022 at 9:15 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > >> > >> Add PE utilization related metrics. > >> > >> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com> > >> --- > >> .../arch/arm64/arm/neoverse-n2/metrics.json | 45 ++++++++++++++++++++++ > >> 1 file changed, 45 insertions(+) > >> > >> diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > >> index 23c7d62..7b54819 100644 > >> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > >> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > >> @@ -189,5 +189,50 @@ > >> "MetricGroup": "Branch", > >> "MetricName": "branch_miss_pred_rate", > >> "ScaleUnit": "100%" > >> + }, > >> + { > >> + "MetricExpr": "instructions / CPU_CYCLES", > >> + "PublicDescription": "The average number of instructions executed for each cycle.", > >> + "BriefDescription": "Instructions per cycle", > >> + "MetricGroup": "PEutilization", > >> + "MetricName": "ipc" > >> + }, > > > > A related useful metric is percentage of peak, so if the peak IPC is 8 > > (usually a constant related to the number of functional units) then > > you can just compute the ratio of IPC with this. > > > > Glad to discuss these with you. > The peak ipc value of neoverse-n2 is 5. Maybe I should add an ipc_rate metric? > > >> + { > >> + "MetricExpr": "INST_RETIRED / CPU_CYCLES", > >> + "PublicDescription": "Architecturally executed Instructions Per Cycle (IPC)", > >> + "BriefDescription": "Architecturally executed Instructions Per Cycle (IPC)", > > > > > > The duplicated descriptions are unnecessary. Drop the public one for > > consistency with what we do for Intel: > > https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py#L299 > > > > Sounds good, will do. > > >> + "MetricGroup": "PEutilization", > >> + "MetricName": "retired_ipc" > >> + }, > >> + { > >> + "MetricExpr": "INST_SPEC / CPU_CYCLES", > >> + "PublicDescription": "Speculatively executed Instructions Per Cycle (IPC)", > >> + "BriefDescription": "Speculatively executed Instructions Per Cycle (IPC)", > >> + "MetricGroup": "PEutilization", > >> + "MetricName": "spec_ipc" > >> + }, > >> + { > >> + "MetricExpr": "OP_RETIRED / OP_SPEC", > >> + "PublicDescription": "Fraction of operations retired", > >> + "BriefDescription": "Fraction of operations retired", > > > > Would instructions be clearer than operations here? > > > > operation and instruction are different. OP_RETIRED counts any operation (not instruction) > that has been architecturally executed, For example, speculatively executed operations that > have been abandoned for a branch mispredict will not be counted. So I think operation might > be more accurate. Thanks, I see this note in the N2 PMU guide: """ For PMU event definitions, some events specifically count instructions, while other events count micro-operations (which are referred to as operations). Please be aware of the use of the word "operations" or "instructions" in the event description. """ From your explanation I wasn't sure if operation was a superset of instruction that included both retired and speculated ones, or whether operation had another meaning. I don't see operation being used in the micro-operation sense elsewhere in the ARM perf json, I think micro-operation is more consistent and also clearer: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/pmu-events/arch/arm64/arm/cortex-a75/pipeline.json?h=perf/core#n27 Perhaps the description can be something like: Of all the micro-operations issued, what percentage were retired. A lower number indicates bad speculation. An alternate way to add documentation is the perf wiki's glossary: https://perf.wiki.kernel.org/index.php/Glossary I added the Neoverse N2 PMU Guide to: https://perf.wiki.kernel.org/index.php/Useful_Links#Manuals Thanks, Ian > >> + "MetricGroup": "PEutilization", > >> + "MetricName": "retired_rate", > >> + "ScaleUnit": "100%" > >> + }, > >> + { > >> + "MetricExpr": "1 - OP_RETIRED / OP_SPEC", > > > > Should OP_RETIRED be greater than OP_SPEC? In which case won't this > > metric be negative? > > > > OP_RETIRED will not be greater than OP_SPEC. OP_SPEC counts any operation that has been > speculatively executed. OP_SPEC is a superset of the OP_RETIRED event. There is a > description about OP_SPEC and OP_RETIRED in this neoverse-n2 document. > Link: https://documentation-service.arm.com/static/62cfe21e31ea212bb6627393?token= > > >> + "PublicDescription": "Fraction of operations wasted", > >> + "BriefDescription": "Fraction of operations wasted", > >> + "MetricGroup": "PEutilization", > >> + "MetricName": "wasted_rate", > >> + "ScaleUnit": "100%" > >> + }, > >> + { > >> + "MetricExpr": "OP_RETIRED / OP_SPEC * (1 - (STALL_SLOT - CPU_CYCLES) / (CPU_CYCLES * 5))", > >> + "PublicDescription": "Utilization of CPU", > >> + "BriefDescription": "Utilization of CPU", > > > > Some more detail in the description would be useful. > > > > Ok, I'll describe it in more detail. CPU_utilization reflects the truly effective ratio of operation > executed by the CPU, which means that misprediction and stall are not included. Note that stall_slot > minus cpu_cycles is a correction to the stall_slot error count. > > >> + "MetricGroup": "PEutilization", > >> + "MetricName": "cpu_utilization", > >> + "ScaleUnit": "100%" > >> } > >> ] > >> -- > >> 1.8.3.1 > >>
在 2022/12/3 上午4:05, Ian Rogers 写道: > On Thu, Dec 1, 2022 at 3:08 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: >> >> >> >> 在 2022/12/1 上午2:58, Ian Rogers 写道: >>> On Thu, Nov 24, 2022 at 9:15 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: >>>> >>>> Add PE utilization related metrics. >>>> >>>> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com> >>>> --- >>>> .../arch/arm64/arm/neoverse-n2/metrics.json | 45 ++++++++++++++++++++++ >>>> 1 file changed, 45 insertions(+) >>>> >>>> diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >>>> index 23c7d62..7b54819 100644 >>>> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >>>> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >>>> @@ -189,5 +189,50 @@ >>>> "MetricGroup": "Branch", >>>> "MetricName": "branch_miss_pred_rate", >>>> "ScaleUnit": "100%" >>>> + }, >>>> + { >>>> + "MetricExpr": "instructions / CPU_CYCLES", >>>> + "PublicDescription": "The average number of instructions executed for each cycle.", >>>> + "BriefDescription": "Instructions per cycle", >>>> + "MetricGroup": "PEutilization", >>>> + "MetricName": "ipc" >>>> + }, >>> >>> A related useful metric is percentage of peak, so if the peak IPC is 8 >>> (usually a constant related to the number of functional units) then >>> you can just compute the ratio of IPC with this. >>> >> >> Glad to discuss these with you. >> The peak ipc value of neoverse-n2 is 5. Maybe I should add an ipc_rate metric? >> >>>> + { >>>> + "MetricExpr": "INST_RETIRED / CPU_CYCLES", >>>> + "PublicDescription": "Architecturally executed Instructions Per Cycle (IPC)", >>>> + "BriefDescription": "Architecturally executed Instructions Per Cycle (IPC)", >>> >>> >>> The duplicated descriptions are unnecessary. Drop the public one for >>> consistency with what we do for Intel: >>> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py#L299 >>> >> >> Sounds good, will do. >> >>>> + "MetricGroup": "PEutilization", >>>> + "MetricName": "retired_ipc" >>>> + }, >>>> + { >>>> + "MetricExpr": "INST_SPEC / CPU_CYCLES", >>>> + "PublicDescription": "Speculatively executed Instructions Per Cycle (IPC)", >>>> + "BriefDescription": "Speculatively executed Instructions Per Cycle (IPC)", >>>> + "MetricGroup": "PEutilization", >>>> + "MetricName": "spec_ipc" >>>> + }, >>>> + { >>>> + "MetricExpr": "OP_RETIRED / OP_SPEC", >>>> + "PublicDescription": "Fraction of operations retired", >>>> + "BriefDescription": "Fraction of operations retired", >>> >>> Would instructions be clearer than operations here? >>> >> >> operation and instruction are different. OP_RETIRED counts any operation (not instruction) >> that has been architecturally executed, For example, speculatively executed operations that >> have been abandoned for a branch mispredict will not be counted. So I think operation might >> be more accurate. > > Thanks, I see this note in the N2 PMU guide: > > """ > For PMU event definitions, some events specifically count > instructions, while other events count micro-operations (which are > referred to as operations). Please be aware of the use of the word > "operations" or "instructions" in the event description. > """ > > From your explanation I wasn't sure if operation was a superset of > instruction that included both retired and speculated ones, or whether > operation had another meaning. I don't see operation being used in the > micro-operation sense elsewhere in the ARM perf json, I think > micro-operation is more consistent and also clearer: > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/pmu-events/arch/arm64/arm/cortex-a75/pipeline.json?h=perf/core#n27 > > Perhaps the description can be something like: > Of all the micro-operations issued, what percentage were retired. A > lower number indicates bad speculation. > > An alternate way to add documentation is the perf wiki's glossary: > https://perf.wiki.kernel.org/index.php/Glossary > > I added the Neoverse N2 PMU Guide to: > https://perf.wiki.kernel.org/index.php/Useful_Links#Manuals > Thanks. The operation here is micro-operation, perhaps it is more accurate to change it to micro-operation. Description of op_retired and op_spec: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/pmu-events/arch/arm64/common-and-microarch.json?h=perf/core#n315 The event of op_retired counts Micro-operation architecturally executed. The counter counts each operation counted by OP_SPEC that would be executed in a simple sequential execution of the program. The event of op_spec counts Micro-operation speculatively executed. The counter counts the number of operations executed by the processing element, including those that are executed speculatively and would not be executed in a simple sequential execution of the program. So "op_retired/op_spec" is indeed "of all the micro-operations issued, what percentage were retired". But not "a lower number indicates bad speculation". I think "retired" here means "committed". In the N2 PMU guide: """ If the branch is mispredicted, and the instructions are speculatively executed, they will not be considered architecturally executed. The Arm® Architecture Reference Manual also refers to architecturally executed instructions as “retired” or “committed”. Speculatively executed instructions that are not architecturally executed will be abandoned; that is, their results will be discarded and not counted as part of the program flow. """ > >>>> + "MetricGroup": "PEutilization", >>>> + "MetricName": "retired_rate", >>>> + "ScaleUnit": "100%" >>>> + }, >>>> + { >>>> + "MetricExpr": "1 - OP_RETIRED / OP_SPEC", >>> >>> Should OP_RETIRED be greater than OP_SPEC? In which case won't this >>> metric be negative? >>> >> >> OP_RETIRED will not be greater than OP_SPEC. OP_SPEC counts any operation that has been >> speculatively executed. OP_SPEC is a superset of the OP_RETIRED event. There is a >> description about OP_SPEC and OP_RETIRED in this neoverse-n2 document. >> Link: https://documentation-service.arm.com/static/62cfe21e31ea212bb6627393?token= >> >>>> + "PublicDescription": "Fraction of operations wasted", >>>> + "BriefDescription": "Fraction of operations wasted", >>>> + "MetricGroup": "PEutilization", >>>> + "MetricName": "wasted_rate", >>>> + "ScaleUnit": "100%" >>>> + }, >>>> + { >>>> + "MetricExpr": "OP_RETIRED / OP_SPEC * (1 - (STALL_SLOT - CPU_CYCLES) / (CPU_CYCLES * 5))", >>>> + "PublicDescription": "Utilization of CPU", >>>> + "BriefDescription": "Utilization of CPU", >>> >>> Some more detail in the description would be useful. >>> >> >> Ok, I'll describe it in more detail. CPU_utilization reflects the truly effective ratio of operation >> executed by the CPU, which means that misprediction and stall are not included. Note that stall_slot >> minus cpu_cycles is a correction to the stall_slot error count. >> >>>> + "MetricGroup": "PEutilization", >>>> + "MetricName": "cpu_utilization", >>>> + "ScaleUnit": "100%" >>>> } >>>> ] >>>> -- >>>> 1.8.3.1 >>>>
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json index 23c7d62..7b54819 100644 --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json @@ -189,5 +189,50 @@ "MetricGroup": "Branch", "MetricName": "branch_miss_pred_rate", "ScaleUnit": "100%" + }, + { + "MetricExpr": "instructions / CPU_CYCLES", + "PublicDescription": "The average number of instructions executed for each cycle.", + "BriefDescription": "Instructions per cycle", + "MetricGroup": "PEutilization", + "MetricName": "ipc" + }, + { + "MetricExpr": "INST_RETIRED / CPU_CYCLES", + "PublicDescription": "Architecturally executed Instructions Per Cycle (IPC)", + "BriefDescription": "Architecturally executed Instructions Per Cycle (IPC)", + "MetricGroup": "PEutilization", + "MetricName": "retired_ipc" + }, + { + "MetricExpr": "INST_SPEC / CPU_CYCLES", + "PublicDescription": "Speculatively executed Instructions Per Cycle (IPC)", + "BriefDescription": "Speculatively executed Instructions Per Cycle (IPC)", + "MetricGroup": "PEutilization", + "MetricName": "spec_ipc" + }, + { + "MetricExpr": "OP_RETIRED / OP_SPEC", + "PublicDescription": "Fraction of operations retired", + "BriefDescription": "Fraction of operations retired", + "MetricGroup": "PEutilization", + "MetricName": "retired_rate", + "ScaleUnit": "100%" + }, + { + "MetricExpr": "1 - OP_RETIRED / OP_SPEC", + "PublicDescription": "Fraction of operations wasted", + "BriefDescription": "Fraction of operations wasted", + "MetricGroup": "PEutilization", + "MetricName": "wasted_rate", + "ScaleUnit": "100%" + }, + { + "MetricExpr": "OP_RETIRED / OP_SPEC * (1 - (STALL_SLOT - CPU_CYCLES) / (CPU_CYCLES * 5))", + "PublicDescription": "Utilization of CPU", + "BriefDescription": "Utilization of CPU", + "MetricGroup": "PEutilization", + "MetricName": "cpu_utilization", + "ScaleUnit": "100%" } ]