diff mbox series

[v2,2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller

Message ID 20221202081647.3183870-3-uwu@icenowy.me
State New
Headers
Series Rongpin RP-H6B support (and support for GL850G) |

Commit Message

Icenowy Zheng Dec. 2, 2022, 8:16 a.m. UTC 
  The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that
features 4 downstream ports, an internal 5V-to-3.3V LDO regulator (can
be bypassed) and an external reset pin.

Add a device tree binding for its USB protocol part. The internal LDO is
not covered by this and can just be modelled as a fixed regulator.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
---
Changes in v2:
- Misc fixes suggested by Krzysztof, including property descriptions,
  single-item "items" and fixing the example's gpio property.
- Fixed $id.

 .../bindings/usb/genesys,gl850g.yaml          | 47 +++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/genesys,gl850g.yaml

Comments

Krzysztof Kozlowski Dec. 2, 2022, 9:02 a.m. UTC | #1 
On 02/12/2022 09:16, Icenowy Zheng wrote:
> The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that
> features 4 downstream ports, an internal 5V-to-3.3V LDO regulator (can
> be bypassed) and an external reset pin.
> 
> Add a device tree binding for its USB protocol part. The internal LDO is
> not covered by this and can just be modelled as a fixed regulator.
> 
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> ---
> Changes in v2:
> - Misc fixes suggested by Krzysztof, including property descriptions,
>   single-item "items" and fixing the example's gpio property.
> - Fixed $id.
> 
(...)

> +
> +examples:
> +  - |
> +    usb {
> +        dr_mode = "host";
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        hub: hub@1 {
> +            compatible = "usb5e3,608";
> +            reg = <1>;
> +            reset-gpios = <&pio 7 2>;

Use GPIO flags. What did you fix in the example?



Best regards,
Krzysztof
Icenowy Zheng Dec. 2, 2022, 4:54 p.m. UTC | #2 
在 2022-12-02星期五的 10:02 +0100，Krzysztof Kozlowski写道：
> On 02/12/2022 09:16, Icenowy Zheng wrote:
> > The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that
> > features 4 downstream ports, an internal 5V-to-3.3V LDO regulator
> > (can
> > be bypassed) and an external reset pin.
> > 
> > Add a device tree binding for its USB protocol part. The internal
> > LDO is
> > not covered by this and can just be modelled as a fixed regulator.
> > 
> > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > ---
> > Changes in v2:
> > - Misc fixes suggested by Krzysztof, including property
> > descriptions,
> >   single-item "items" and fixing the example's gpio property.
> > - Fixed $id.
> > 
> (...)
> 
> > +
> > +examples:
> > +  - |
> > +    usb {
> > +        dr_mode = "host";
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        hub: hub@1 {
> > +            compatible = "usb5e3,608";
> > +            reg = <1>;
> > +            reset-gpios = <&pio 7 2>;
> 
> Use GPIO flags. What did you fix in the example?

It used to be here, but using it needs another include, which I don't
think it necessary here.

Maybe I should just drop this line in the example?

> 
> 
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Dec. 2, 2022, 4:59 p.m. UTC | #3 
On 02/12/2022 17:54, Icenowy Zheng wrote:
> 在 2022-12-02星期五的 10:02 +0100，Krzysztof Kozlowski写道：
>> On 02/12/2022 09:16, Icenowy Zheng wrote:
>>> The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that
>>> features 4 downstream ports, an internal 5V-to-3.3V LDO regulator
>>> (can
>>> be bypassed) and an external reset pin.
>>>
>>> Add a device tree binding for its USB protocol part. The internal
>>> LDO is
>>> not covered by this and can just be modelled as a fixed regulator.
>>>
>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>> ---
>>> Changes in v2:
>>> - Misc fixes suggested by Krzysztof, including property
>>> descriptions,
>>>   single-item "items" and fixing the example's gpio property.
>>> - Fixed $id.
>>>
>> (...)
>>
>>> +
>>> +examples:
>>> +  - |
>>> +    usb {
>>> +        dr_mode = "host";
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        hub: hub@1 {
>>> +            compatible = "usb5e3,608";
>>> +            reg = <1>;
>>> +            reset-gpios = <&pio 7 2>;
>>
>> Use GPIO flags. What did you fix in the example?
> 
> It used to be here, but using it needs another include, which I don't
> think it necessary here.

The header is necessary for the flags...

> 
> Maybe I should just drop this line in the example?

It's useful. The example should be rather complete, not just compatible
and reg.

Different problem - you miss maxItems for the GPIOs.

Best regards,
Krzysztof
Icenowy Zheng Dec. 2, 2022, 5 p.m. UTC | #4 
在 2022-12-02星期五的 17:59 +0100，Krzysztof Kozlowski写道：
> On 02/12/2022 17:54, Icenowy Zheng wrote:
> > 在 2022-12-02星期五的 10:02 +0100，Krzysztof Kozlowski写道：
> > > On 02/12/2022 09:16, Icenowy Zheng wrote:
> > > > The Genesys Logic GL850G is a USB 2.0 Single TT hub controller
> > > > that
> > > > features 4 downstream ports, an internal 5V-to-3.3V LDO
> > > > regulator
> > > > (can
> > > > be bypassed) and an external reset pin.
> > > > 
> > > > Add a device tree binding for its USB protocol part. The
> > > > internal
> > > > LDO is
> > > > not covered by this and can just be modelled as a fixed
> > > > regulator.
> > > > 
> > > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > > > ---
> > > > Changes in v2:
> > > > - Misc fixes suggested by Krzysztof, including property
> > > > descriptions,
> > > >   single-item "items" and fixing the example's gpio property.
> > > > - Fixed $id.
> > > > 
> > > (...)
> > > 
> > > > +
> > > > +examples:
> > > > +  - |
> > > > +    usb {
> > > > +        dr_mode = "host";
> > > > +        #address-cells = <1>;
> > > > +        #size-cells = <0>;
> > > > +
> > > > +        hub: hub@1 {
> > > > +            compatible = "usb5e3,608";
> > > > +            reg = <1>;
> > > > +            reset-gpios = <&pio 7 2>;
> > > 
> > > Use GPIO flags. What did you fix in the example?
> > 
> > It used to be here, but using it needs another include, which I
> > don't
> > think it necessary here.
> 
> The header is necessary for the flags...
> 
> > 
> > Maybe I should just drop this line in the example?
> 
> It's useful. The example should be rather complete, not just
> compatible
> and reg.
> 
> Different problem - you miss maxItems for the GPIOs.

Okay thanks.

> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
new file mode 100644
index 000000000000..966462ca6acb
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
@@ -0,0 +1,47 @@ 
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Genesys Logic GL850G USB 2.0 hub controller
+
+maintainers:
+  - Icenowy Zheng <uwu@icenowy.me>
+
+allOf:
+  - $ref: usb-device.yaml#
+
+properties:
+  compatible:
+    enum:
+      - usb5e3,608
+
+  reg: true
+
+  reset-gpios:
+    description: GPIO controlling the RESET# pin.
+
+  vdd-supply:
+    description:
+      the regulator that provides 3.3V core power to the hub.
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    usb {
+        dr_mode = "host";
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        hub: hub@1 {
+            compatible = "usb5e3,608";
+            reg = <1>;
+            reset-gpios = <&pio 7 2>;
+        };
+    };