diff mbox series

libgccjit.h: Make the macro definition for testing gcc_jit_context_new_bitcast correctly available.

Message ID 8ce556135d6366aeb434794e7247e8ca806ea736.camel@gmail.com
State New, archived
Headers
Series libgccjit.h: Make the macro definition for testing gcc_jit_context_new_bitcast correctly available. |

Commit Message

Li, Pan2 via Gcc-patches July 23, 2022, 8:01 a.m. UTC 
  The macro definition for LIBGCCJIT_HAVE_gcc-jit_context_new_bitcast
was earlier located in the documentation comment for
gcc_jit_context_new_bitcast, making it unavailable to code that
consumed libgccjit.h. This patch moves the definition out of the
comment, making it effective.

Thanks,
Vibhav

Comments

David Malcolm July 25, 2022, 11:18 p.m. UTC | #1 
On Sat, 2022-07-23 at 13:31 +0530, Vibhav Pant via Jit wrote:
> The macro definition for LIBGCCJIT_HAVE_gcc-jit_context_new_bitcast
> was earlier located in the documentation comment for
> gcc_jit_context_new_bitcast, making it unavailable to code that
> consumed libgccjit.h. This patch moves the definition out of the
> comment, making it effective.

Good catch!

Do you have push rights to the git repo, or should I push this?

Thanks
Dave
Vibhav Pant July 30, 2022, 1:48 p.m. UTC | #2 
I don't have push rights to the repo, so this would need to be applied manually.


Thanks,
Vibhav

On Tue, Jul 26, 2022 at 4:48 AM David Malcolm <dmalcolm@redhat.com> wrote:
>
> On Sat, 2022-07-23 at 13:31 +0530, Vibhav Pant via Jit wrote:
> > The macro definition for LIBGCCJIT_HAVE_gcc-jit_context_new_bitcast
> > was earlier located in the documentation comment for
> > gcc_jit_context_new_bitcast, making it unavailable to code that
> > consumed libgccjit.h. This patch moves the definition out of the
> > comment, making it effective.
>
> Good catch!
>
> Do you have push rights to the git repo, or should I push this?
>
> Thanks
> Dave
>
David Malcolm Aug. 9, 2022, 3:39 p.m. UTC | #3 
On Sat, 2022-07-30 at 19:18 +0530, Vibhav Pant wrote:
> I don't have push rights to the repo, so this would need to be
> applied manually.

I've gone ahead and pushed your fix to trunk (for GCC 13) as r13-2004-
g9385cd9c74cf66.

I plan to also push it to the gcc 12 branch shortly (for gcc 12.2)


Thanks again for the patch.
Dave


> 
> 
> Thanks,
> Vibhav
> 
> On Tue, Jul 26, 2022 at 4:48 AM David Malcolm <dmalcolm@redhat.com>
> wrote:
> > 
> > On Sat, 2022-07-23 at 13:31 +0530, Vibhav Pant via Jit wrote:
> > > The macro definition for LIBGCCJIT_HAVE_gcc-
> > > jit_context_new_bitcast
> > > was earlier located in the documentation comment for
> > > gcc_jit_context_new_bitcast, making it unavailable to code that
> > > consumed libgccjit.h. This patch moves the definition out of the
> > > comment, making it effective.
> > 
> > Good catch!
> > 
> > Do you have push rights to the git repo, or should I push this?
> > 
> > Thanks
> > Dave
> > 
> 
>
David Malcolm Aug. 9, 2022, 11:09 p.m. UTC | #4 
On Tue, 2022-08-09 at 11:39 -0400, David Malcolm wrote:
> On Sat, 2022-07-30 at 19:18 +0530, Vibhav Pant wrote:
> > I don't have push rights to the repo, so this would need to be
> > applied manually.
> 
> I've gone ahead and pushed your fix to trunk (for GCC 13) as r13-
> 2004-
> g9385cd9c74cf66.
> 
> I plan to also push it to the gcc 12 branch shortly (for gcc 12.2)

I've now done this (as r12-8674-g92f2582f3ec7b8).

Thanks again
Dave
diff mbox series

Patch

From 13f7b010962d57a9a133b657838727486e4241c9 Mon Sep 17 00:00:00 2001
From: Vibhav Pant <vibhavp@gmail.com>
Date: Sat, 23 Jul 2022 13:18:05 +0530
Subject: [[PATCH] libgccjit.h: Make the macro definition for testing gcc_jit_context_new_bitcast correctly available.] 
 Uncomment macro definition for testing gcc_jit_context_new_bitcast support

The macro definition for LIBGCCJIT_HAVE_gcc-jit_context_new_bitcast
was earlier located in the documentation comment for
gcc_jit_context_new_bitcast, making it unavailable to code that
consumed libgccjit.h. This commit moves the definition out of the
comment, making it effective.
---
 gcc/jit/libgccjit.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/jit/libgccjit.h b/gcc/jit/libgccjit.h
index 062f06d691a..b3c389e93f6 100644
--- a/gcc/jit/libgccjit.h
+++ b/gcc/jit/libgccjit.h
@@ -1252,10 +1252,10 @@  gcc_jit_context_new_cast (gcc_jit_context *ctxt,
 			  gcc_jit_rvalue *rvalue,
 			  gcc_jit_type *type);
 
-/* Reinterpret a value as another type.
-
 #define LIBGCCJIT_HAVE_gcc_jit_context_new_bitcast
 
+/* Reinterpret a value as another type.
+
    The types must be of the same size.
 
    This API entrypoint was added in LIBGCCJIT_ABI_21; you can test for its
-- 
2.37.1