| Message ID | 20221126051002.123199-1-linux@weissschuh.net |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4464252wrr;
Fri, 25 Nov 2022 21:11:54 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf44pFeboQ9ey0tYqZzx6ZRLxbUjR27nKSqH1jwLn9YSf46JZBZhdNs+HSkqqe6N1DPw5nmy
X-Received: by 2002:a17:906:8922:b0:7bd:3aaa:466d with SMTP id
fr34-20020a170906892200b007bd3aaa466dmr3777434ejc.1.1669439514135;
Fri, 25 Nov 2022 21:11:54 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669439514; cv=none;
d=google.com; s=arc-20160816;
b=d938MDV7Qs1gmuZYbb33wfeT43a2dem6i7GE56GNYUkB9oeyANTLfGXxQZ+5dfmkUr
kXcuI47E46ti+dRASFmBokHIBK2zjUnN5FU1ytgdKk2DzRknzfHURG30JMEh5k4X/Mpk
4dqGqE/8TISLFlAA0CbRvhMVMwU7bj9ZBngbI/4UL4GEiOW75RpA25N8BUwbwK+rqFMQ
Or2jRHnWp7VVIS2CtdyfYzZ3YYmhhEYqcvME3eBY0Ni3X0yfgobZI0pOyC2YAW6VM3yv
U/W8SrFmud6ZPjkyT9XdmHz3CK3l2zzw6kDklfArPNT/XmbJfW9xhonCSVB1zw8Tv6Pt
j/UQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:dkim-signature:from;
bh=Z54oCkTQCRiChFamMxMWfotfFgdb4C7maPuTkpkFWr8=;
b=mmrTVnSXtKhJ08XAW51Vz5tB4w2ihq15z+szjCkolBmZLLA3Rnr//iSN8CDA2pyuAb
LdK9sXLInCOqzOHug0AmIiUIt0kdPOhWOwzJBUguTXCAn1wIy0imGScDcazI9feWEEgu
+dHEwAD/mLVQZfkz0V/1eXJ/7HgK1MFjKr4sPbONX7VX1MDeq34P8lLSi9Jd99377Pcx
JC3qGJtbgJ3YcDap9A8h/46HD1sL72VpSgXWhDIiR0zQ3aWcDmEJWox/R9NXCcDzjiQZ
J8jpoZufBShzr0Yq2ssGnH5N1qhs3jZlvUptzQJds9LJ1/Tg6FKmzmlTHMUyccioDGBJ
MC9w==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@weissschuh.net header.s=mail header.b=G23bT3f7;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
xb4-20020a170907070400b007be1ba9fba1si215366ejb.948.2022.11.25.21.11.30;
Fri, 25 Nov 2022 21:11:54 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=fail header.i=@weissschuh.net header.s=mail header.b=G23bT3f7;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230107AbiKZFKd (ORCPT <rfc822;zxc52fgh@gmail.com> + 99 others);
Sat, 26 Nov 2022 00:10:33 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60508 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229514AbiKZFK3 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 26 Nov 2022 00:10:29 -0500
Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 771271A839
for <linux-kernel@vger.kernel.org>;
Fri, 25 Nov 2022 21:10:28 -0800 (PST)
From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net;
s=mail; t=1669439426;
bh=bDIxcxkuTt1CVPb93jhG3KHHhCYP/VYgbfXwdy3Az4s=;
h=From:To:Cc:Subject:Date:From;
b=G23bT3f7aypq2wGM8D1gp67YAeyYSHs9EevYehqImsq914voa6TFrJbK/dCcmHoob
PxBCILTEYNeMnNd63TcdGp8wH/DZteS271vEf4/lugPSA0T5LZgkpUSSgKChvJVfBK
Rp/disrLphhMh/5YwUR5LnU+V7ZmyEeW5N65cT+Q=
To: Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russell.h.weight@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Cc: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH 1/3] firmware_loader: remove #include <generated/utsrelease.h>
Date: Sat, 26 Nov 2022 06:09:59 +0100
Message-Id: <20221126051002.123199-1-linux@weissschuh.net>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Developer-Signature: v=1; a=ed25519-sha256; t=1669439380; l=778;
i=linux@weissschuh.net; s=20211113; h=from:subject;
bh=bDIxcxkuTt1CVPb93jhG3KHHhCYP/VYgbfXwdy3Az4s=;
b=fFTES36NcD7vL27XygxIwaM3a4swpMuD3MsBDdgf6SgoftWjxKuVjdLBJA9xj+Azk1WWb37F6j3Y
2qHNLnknDUVPUzHSMqhXMgtTBjtHHS4RQGpqByVbekki4atV9mTS
X-Developer-Key: i=linux@weissschuh.net; a=ed25519;
pk=9LP6KM4vD/8CwHW7nouRBhWLyQLcK1MkP6aTZbzUlj4=
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1750534207988279106?=
X-GMAIL-MSGID: =?utf-8?q?1750534207988279106?=
|
| Series |
[1/3] firmware_loader: remove #include <generated/utsrelease.h>
|
|
Commit Message
Thomas Weißschuh
Nov. 26, 2022, 5:09 a.m. UTC
utsrelease.h is potentially generated on each build.
By removing this unused include we can get rid of some spurious
recompilations.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/base/firmware_loader/firmware.h | 2 --
1 file changed, 2 deletions(-)
base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536
Comments
On Sat, Nov 26, 2022 at 2:10 PM Thomas Weißschuh <linux@weissschuh.net> wrote: > > utsrelease.h is potentially generated on each build. > By removing this unused include we can get rid of some spurious > recompilations. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- Reviewed-by: Masahiro Yamada <masahiroy@kernel.org> > drivers/base/firmware_loader/firmware.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h > index fe77e91c38a2..bf549d6500d7 100644 > --- a/drivers/base/firmware_loader/firmware.h > +++ b/drivers/base/firmware_loader/firmware.h > @@ -9,8 +9,6 @@ > #include <linux/list.h> > #include <linux/completion.h> > > -#include <generated/utsrelease.h> > - > /** > * enum fw_opt - options to control firmware loading behaviour > * > > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536 > -- > 2.38.1 >
On 11/25/22 21:09, Thomas Weißschuh wrote: > utsrelease.h is potentially generated on each build. > By removing this unused include we can get rid of some spurious > recompilations. Reviewed-by: Russ Weight <russell.h.weight@intel.com> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- > drivers/base/firmware_loader/firmware.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h > index fe77e91c38a2..bf549d6500d7 100644 > --- a/drivers/base/firmware_loader/firmware.h > +++ b/drivers/base/firmware_loader/firmware.h > @@ -9,8 +9,6 @@ > #include <linux/list.h> > #include <linux/completion.h> > > -#include <generated/utsrelease.h> > - > /** > * enum fw_opt - options to control firmware loading behaviour > * > > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536
On Tue, Nov 29, 2022 at 10:18 AM Russ Weight <russell.h.weight@intel.com> wrote: > > > > On 11/25/22 21:09, Thomas Weißschuh wrote: > > utsrelease.h is potentially generated on each build. > > By removing this unused include we can get rid of some spurious > > recompilations. > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > > --- > > drivers/base/firmware_loader/firmware.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h > > index fe77e91c38a2..bf549d6500d7 100644 > > --- a/drivers/base/firmware_loader/firmware.h > > +++ b/drivers/base/firmware_loader/firmware.h > > @@ -9,8 +9,6 @@ > > #include <linux/list.h> > > #include <linux/completion.h> > > > > -#include <generated/utsrelease.h> > > - > > /** > > * enum fw_opt - options to control firmware loading behaviour > > * > > > > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536 > Applied to linux-kbuild. Thanks.
diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h index fe77e91c38a2..bf549d6500d7 100644 --- a/drivers/base/firmware_loader/firmware.h +++ b/drivers/base/firmware_loader/firmware.h @@ -9,8 +9,6 @@ #include <linux/list.h> #include <linux/completion.h> -#include <generated/utsrelease.h> - /** * enum fw_opt - options to control firmware loading behaviour *