[1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

Message ID 20221128214928.3531463-2-j.neuschaefer@gmx.net
State New
Headers
Series nuvoton,wpcm450-fiu binding example fixes |

Commit Message

Jonathan Neuschäfer Nov. 28, 2022, 9:49 p.m. UTC
  The nuvoton,wpcm450-fiu binding's example includes
nuvoton,wpcm450-clk.h, which has not been merged yet,
thus causing a dt_binding_check error on -next.

Fix this error by simply hardcoding the clock index in the example,
before the breakage spreads any further.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--
2.35.1
  

Comments

Krzysztof Kozlowski Nov. 29, 2022, 8:04 a.m. UTC | #1
On 28/11/2022 22:49, Jonathan Neuschäfer wrote:
> The nuvoton,wpcm450-fiu binding's example includes
> nuvoton,wpcm450-clk.h, which has not been merged yet,
> thus causing a dt_binding_check error on -next.
> 
> Fix this error by simply hardcoding the clock index in the example,
> before the breakage spreads any further.
> 
> Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
> Reported-by: Conor Dooley <conor.dooley@microchip.com>

Report came from Rob:

Reported-by: Rob Herring <robh@kernel.org>

> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index ef94803e75d90..e4162845fcc1d 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -45,14 +45,13 @@  unevaluatedProperties: false

 examples:
   - |
-    #include <dt-bindings/clock/nuvoton,wpcm450-clk.h>
     spi@c8000000 {
       compatible = "nuvoton,wpcm450-fiu";
       reg = <0xc8000000 0x1000>, <0xc0000000 0x4000000>;
       #address-cells = <1>;
       #size-cells = <0>;
       reg-names = "control", "memory";
-      clocks = <&clk WPCM450_CLK_FIU>;
+      clocks = <&clk 0>;
       nuvoton,shm = <&shm>;

       flash@0 {