Message ID | 20221128115958.4049431-21-o.rempel@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp5609451wrr; Mon, 28 Nov 2022 04:03:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf48yYjUiFyQgUcUXjbGg8EjJtQN1d0NGr76YEK8hCLEDRpwThUrXgbS+8XSJsSwxe/suODd X-Received: by 2002:a62:1507:0:b0:574:8985:109e with SMTP id 7-20020a621507000000b005748985109emr20822511pfv.56.1669637023325; Mon, 28 Nov 2022 04:03:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669637023; cv=none; d=google.com; s=arc-20160816; b=KdRuLDnZOhi8MC8forJEOuEo3+OjMedSt9LlkrQ6WDkpgDPDzHlBo9CNjCZ1floTG/ 0AtSOmeE5TupkbUHsIZaBI8cLW6PfQHr2gZktvbTRbHLC/11x17Mm2//aG2s4JptTjHj b0d2a4CgFQz5pTWH6cU+8MzCpvYfGrOE+diuigJVrWbEL4BDi1n5MC7kDvf2o+sfOH/y E3DNyQMskjZ07yOwrpKvoFMw6q+eSxFSoPjULIG+pNDlxMSUyGXkbjcA3Q9q2KxBH8CM Kp30kfOQxlSOQdklvaJ372MNk7m+xaJZunXRMmUq/Z2xmDgNzC970mBlI18QEdy+vVs+ gm9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=RBjQsgvaEh/t/pDcxkGjwwA0LbYbPR6oyZMQdk3/TZI=; b=lfylhvlkbTQPJUOGyXtuXmOuvB1s8aeu/8zt4rOUoakX1nQ5NkZguqmbqZ4+UbfO5I /wdouwNREJiJ9TSJmwBY8/CORUg8X8YvIhuX63Hfg/2HBNHQBypZzKRzu5N71bkc7Fcs LxMMjAZBAAELAdiOWArbTOxIiChXMnRaPAnrhuTyK+5Uh3NgMCzOyiq7tGnTWb1YAHuo uvuRJiUSKlrNN0ne+LW513p61AzqVZJKAf+l4DouE+qeJECmqXwGwlkmmvH10JIYAGR6 lkrzHt0jLsilUESAFNng3wpFe6hZ7jZ7knF6dhZRVuauBUYxrsS5T1ew1tCG8Of0V4lq Hn7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j38-20020a632326000000b0046b208f6affsi11777486pgj.621.2022.11.28.04.03.21; Mon, 28 Nov 2022 04:03:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbiK1MB2 (ORCPT <rfc822;gah0developer@gmail.com> + 99 others); Mon, 28 Nov 2022 07:01:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbiK1MAR (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 28 Nov 2022 07:00:17 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA32C18E09 for <linux-kernel@vger.kernel.org>; Mon, 28 Nov 2022 04:00:14 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ore@pengutronix.de>) id 1ozcnt-0003rq-HO; Mon, 28 Nov 2022 13:00:05 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1ozcnr-000o9q-Tq; Mon, 28 Nov 2022 13:00:04 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1ozcno-00Gzg4-0h; Mon, 28 Nov 2022 13:00:00 +0100 From: Oleksij Rempel <o.rempel@pengutronix.de> To: Woojung Huh <woojung.huh@microchip.com>, UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>, Vivien Didelot <vivien.didelot@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com> Cc: Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com Subject: [PATCH v1 20/26] net: dsa: microchip: make ksz8_r_sta_mac_table() static Date: Mon, 28 Nov 2022 12:59:52 +0100 Message-Id: <20221128115958.4049431-21-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221128115958.4049431-1-o.rempel@pengutronix.de> References: <20221128115958.4049431-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750741311306843726?= X-GMAIL-MSGID: =?utf-8?q?1750741311306843726?= |
Series |
net: dsa: microchip: stats64, fdb, error
|
|
Commit Message
Oleksij Rempel
Nov. 28, 2022, 11:59 a.m. UTC
It is used only in ksz8795.c, no need to export it.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/dsa/microchip/ksz8.h | 2 --
drivers/net/dsa/microchip/ksz8795.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
Comments
Hi Oleksij, On Mon, 2022-11-28 at 12:59 +0100, Oleksij Rempel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > It is used only in ksz8795.c, no need to export it. You can consider grouping patch 8, 20 and 23 into single patch. Since all adding static to function namely ksz8_r_dyn_mac_table, ksz8_r_sta_mac_table and ksz8_w_sta_mac_table. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > drivers/net/dsa/microchip/ksz8.h | 2 -- > drivers/net/dsa/microchip/ksz8795.c | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/dsa/microchip/ksz8.h > b/drivers/net/dsa/microchip/ksz8.h > index a28fa7cd4d98..ed72ec626593 100644 > --- a/drivers/net/dsa/microchip/ksz8.h > +++ b/drivers/net/dsa/microchip/ksz8.h > @@ -19,8 +19,6 @@ void ksz8_flush_dyn_mac_table(struct ksz_device > *dev, int port); > void ksz8_port_setup(struct ksz_device *dev, int port, bool > cpu_port); > int ksz8_r_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 *val); > int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val); > -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, > - struct alu_struct *alu); > void ksz8_w_sta_mac_table(struct ksz_device *dev, u16 addr, > struct alu_struct *alu); > void ksz8_r_mib_cnt(struct ksz_device *dev, int port, u16 addr, u64 > *cnt); > diff --git a/drivers/net/dsa/microchip/ksz8795.c > b/drivers/net/dsa/microchip/ksz8795.c > index 31c77e086a9d..1c08103c9f50 100644 > --- a/drivers/net/dsa/microchip/ksz8795.c > +++ b/drivers/net/dsa/microchip/ksz8795.c > @@ -456,8 +456,8 @@ static int ksz8_r_dyn_mac_table(struct ksz_device > *dev, u16 addr, u8 *mac_addr, > return ret; > } > > -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, > - struct alu_struct *alu) > +static int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, > + struct alu_struct *alu) > { > u32 data_hi, data_lo; > const u8 *shifts; > -- > 2.30.2 >
diff --git a/drivers/net/dsa/microchip/ksz8.h b/drivers/net/dsa/microchip/ksz8.h index a28fa7cd4d98..ed72ec626593 100644 --- a/drivers/net/dsa/microchip/ksz8.h +++ b/drivers/net/dsa/microchip/ksz8.h @@ -19,8 +19,6 @@ void ksz8_flush_dyn_mac_table(struct ksz_device *dev, int port); void ksz8_port_setup(struct ksz_device *dev, int port, bool cpu_port); int ksz8_r_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 *val); int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val); -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, - struct alu_struct *alu); void ksz8_w_sta_mac_table(struct ksz_device *dev, u16 addr, struct alu_struct *alu); void ksz8_r_mib_cnt(struct ksz_device *dev, int port, u16 addr, u64 *cnt); diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c index 31c77e086a9d..1c08103c9f50 100644 --- a/drivers/net/dsa/microchip/ksz8795.c +++ b/drivers/net/dsa/microchip/ksz8795.c @@ -456,8 +456,8 @@ static int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8 *mac_addr, return ret; } -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, - struct alu_struct *alu) +static int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, + struct alu_struct *alu) { u32 data_hi, data_lo; const u8 *shifts;