diff mbox series

[1/2] ASoC: qcom: lpass-sc7180: Drop unnecessary initialization in _resume()

Message ID 20221128221152.1.Ia805c688ee968fbbec7b93dc10742876fdef8024@changeid
State New
Headers
Series [1/2] ASoC: qcom: lpass-sc7180: Drop unnecessary initialization in _resume() |

Commit Message

Matthias Kaehlcke Nov. 28, 2022, 10:11 p.m. UTC 
  The initialization of the variable 'ret' in sc7180_lpass_dev_resume()
is unnecessary, as it is always assigned a few lines below. Drop the
initialization.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---

 sound/soc/qcom/lpass-sc7180.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Doug Anderson Nov. 28, 2022, 10:37 p.m. UTC | #1 
Hi,

On Mon, Nov 28, 2022 at 2:12 PM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> The initialization of the variable 'ret' in sc7180_lpass_dev_resume()
> is unnecessary, as it is always assigned a few lines below. Drop the
> initialization.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
>  sound/soc/qcom/lpass-sc7180.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Not that this needs review, but FWIW:

Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff mbox series

Patch

diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
index 9c3365ddc274..7a81e609727c 100644
--- a/sound/soc/qcom/lpass-sc7180.c
+++ b/sound/soc/qcom/lpass-sc7180.c
@@ -165,7 +165,7 @@  static int sc7180_lpass_exit(struct platform_device *pdev)
 
 static int sc7180_lpass_dev_resume(struct device *dev)
 {
-	int ret = 0;
+	int ret;
 	struct lpass_data *drvdata = dev_get_drvdata(dev);
 
 	ret = clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);