Message ID | 20221128051512.125148-1-linmengbo0689@protonmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp5451116wrr; Sun, 27 Nov 2022 21:44:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf4HmhoiW2XBB2jtvspjykeetzx5eJ1BQ79PKTI9CEaNR/LMntSlJKh9lFV/x0OjOJYt0vCB X-Received: by 2002:a17:902:c206:b0:189:502e:4ec8 with SMTP id 6-20020a170902c20600b00189502e4ec8mr23261058pll.134.1669614283190; Sun, 27 Nov 2022 21:44:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669614283; cv=none; d=google.com; s=arc-20160816; b=tYQvPSj47BYVcECIAXbZmt8W80XWAwrWlS6JKE+TFVtfGsoLtY9IqRfZlgNihOR88x aJSOyACYddEvYAlKSOZo1nDESYE3YOoKELmePeSf5mxpJ6YB0rwtZD8S80qzHhyvUqdI hSTSQR5/1T+Rd6nJXwAyHFpyAq+mDD3vj9gJRKDvq+ACHG5tx1zV7KZFNDEyPFKxwALI b8vB5aOQU2PVTrs9LX6bb69fr1PsCNvPXaM9CjJE96c2chYtm3bWn6zOy7iVSd7sErxZ +MmNIqOGQeVtsCDpma8xGLpetMIv7pJer11EPeBaRTM4DTsi9nvPW0OiTOSq9Iys1RZF K9zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :feedback-id:message-id:subject:cc:from:to:dkim-signature:date; bh=JwK03JDQ2QUDODMsSbuKaZkjunGgFXdzH7zifC5qDo4=; b=Sb8p3lparhuOlO5z9xwh9D2dtDqtIEukAW2KVOKrRnwAk7EauEFT8jiyJgA+AHpINB qWxgPBbBpR0XmjvvINanxOPHlchCmQBzB3CS02B7mGIqZBoc/68YMDYiY8U0bkKNw6Lk aYw0YOaJfjssRJcQRABBHCy750mOqLOA+kDm4IDBNY7EWArLavsb5aGX7Lgm1+Y9i/CY pjNTbVctt+g8GRd+XEJokXqJSU4OJ8CDJyJV2qaXSXjEU64jgRZEUxPTTz0kIAprCZH1 ui+R49dklYEdmLFR8oNQqw1FiMnVE5PnBd/DTZQoFNrDyUrFm/Eq6bs4lu95ym+ht8LX z57Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b="KDK3P/gy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p5-20020a170902bd0500b0017ef8bf8a91si9127163pls.439.2022.11.27.21.44.24; Sun, 27 Nov 2022 21:44:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b="KDK3P/gy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229580AbiK1FQn (ORCPT <rfc822;gah0developer@gmail.com> + 99 others); Mon, 28 Nov 2022 00:16:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiK1FQk (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 28 Nov 2022 00:16:40 -0500 Received: from mail-40138.protonmail.ch (mail-40138.protonmail.ch [185.70.40.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C10913D0D for <linux-kernel@vger.kernel.org>; Sun, 27 Nov 2022 21:16:39 -0800 (PST) Date: Mon, 28 Nov 2022 05:16:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1669612597; x=1669871797; bh=JwK03JDQ2QUDODMsSbuKaZkjunGgFXdzH7zifC5qDo4=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=KDK3P/gyr5LcYWheFBsd6Q4fiAWunLNP052PMkhDV/ea2BRQZPkeNJ1zlnI7N0ro9 M6JYMQKO7JU7j8miz4Wc5npzkaMlowVPMjWTpE/9at3BO+fdppyrJaLkMGV6hyu+o2 Pn1/x8hPYKdzP1XRMQQuv0w2b5nBHnvL6sCwdKepZu+SfiQWph7kCFhxzKtGMO4r27 b5qXSEWRLkP5w5Ki4m4h8uu1GNBVd2BgbdBWNEbYS3p1xUrItx/OCsYu2os9dpLf4n Y49WKWZflr8nMrsd/FAqBg3OZai2VeqCbgEVOg5l8ALFhDTv5EoKfqOZ5/6nthpl4e AYFUGVNujrpOQ== To: linux-kernel@vger.kernel.org From: "Lin, Meng-Bo" <linmengbo0689@protonmail.com> Cc: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Stephan Gerhold <stephan@gerhold.net>, Nikita Travkin <nikita@trvn.ru>, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: [PATCH] arm64: dts: qcom: msm8916-wingtech-wt88047: Add flash LED Message-ID: <20221128051512.125148-1-linmengbo0689@protonmail.com> Feedback-ID: 40467236:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750717466562222428?= X-GMAIL-MSGID: =?utf-8?q?1750717466562222428?= |
Series |
arm64: dts: qcom: msm8916-wingtech-wt88047: Add flash LED
|
|
Commit Message
Lin, Meng-Bo
Nov. 28, 2022, 5:16 a.m. UTC
WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree.
Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
---
.../dts/qcom/msm8916-wingtech-wt88047.dts | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
Comments
On 28/11/2022 06:16, Lin, Meng-Bo wrote: > WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> > --- > .../dts/qcom/msm8916-wingtech-wt88047.dts | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts > index 166bed05996f..a87be1d95b14 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts > +++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts > @@ -23,6 +23,20 @@ chosen { > stdout-path = "serial0"; > }; > > + flash-led-controller { > + compatible = "ocs,ocp8110"; The compatible is not documented. Checkpatch warns about it. You need to document devices before using them. Best regards, Krzysztof
Hi Krzysztof, On Mon, Nov 28, 2022 at 09:56:47AM +0100, Krzysztof Kozlowski wrote: > On 28/11/2022 06:16, Lin, Meng-Bo wrote: > > WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree. > > > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> > > --- > > .../dts/qcom/msm8916-wingtech-wt88047.dts | 22 +++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts > > index 166bed05996f..a87be1d95b14 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts > > +++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts > > @@ -23,6 +23,20 @@ chosen { > > stdout-path = "serial0"; > > }; > > > > + flash-led-controller { > > + compatible = "ocs,ocp8110"; > > The compatible is not documented. Checkpatch warns about it. You need to > document devices before using them. > Unfortunately Pavel never applied the dt-bindings patch for this - only the driver patch was applied. André already sent a kind reminder [1] and two resends [2, 3] without success. Since it's a documentation-only patch, maybe you could take it through the dt-bindings tree? Even the original version [1] still applies cleanly to linux-next. :) Thanks, Stephan [1]: https://lore.kernel.org/linux-leds/20220212180942.8241-2-git@apitzsch.eu/ [2]: https://lore.kernel.org/linux-leds/20220404161428.17175-1-git@apitzsch.eu/ [3]: https://lore.kernel.org/linux-leds/20220505185344.10067-1-git@apitzsch.eu/
On 28/11/2022 19:30, Stephan Gerhold wrote: > Hi Krzysztof, > > On Mon, Nov 28, 2022 at 09:56:47AM +0100, Krzysztof Kozlowski wrote: >> On 28/11/2022 06:16, Lin, Meng-Bo wrote: >>> WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree. >>> >>> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> >>> --- >>> .../dts/qcom/msm8916-wingtech-wt88047.dts | 22 +++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>> index 166bed05996f..a87be1d95b14 100644 >>> --- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>> +++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>> @@ -23,6 +23,20 @@ chosen { >>> stdout-path = "serial0"; >>> }; >>> >>> + flash-led-controller { >>> + compatible = "ocs,ocp8110"; >> >> The compatible is not documented. Checkpatch warns about it. You need to >> document devices before using them. >> > > Unfortunately Pavel never applied the dt-bindings patch for this - only > the driver patch was applied. André already sent a kind reminder [1] and > two resends [2, 3] without success. Since it's a documentation-only > patch, maybe you could take it through the dt-bindings tree? > I'll ping Rob. Other way is to resend. You need to keep resending (maybe together with DTS in such case) before this can go in. Best regards, Krzysztof
On 28/11/2022 22:23, Krzysztof Kozlowski wrote: > On 28/11/2022 19:30, Stephan Gerhold wrote: >> Hi Krzysztof, >> >> On Mon, Nov 28, 2022 at 09:56:47AM +0100, Krzysztof Kozlowski wrote: >>> On 28/11/2022 06:16, Lin, Meng-Bo wrote: >>>> WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree. >>>> >>>> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> >>>> --- >>>> .../dts/qcom/msm8916-wingtech-wt88047.dts | 22 +++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>>> index 166bed05996f..a87be1d95b14 100644 >>>> --- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>>> +++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>>> @@ -23,6 +23,20 @@ chosen { >>>> stdout-path = "serial0"; >>>> }; >>>> >>>> + flash-led-controller { >>>> + compatible = "ocs,ocp8110"; >>> >>> The compatible is not documented. Checkpatch warns about it. You need to >>> document devices before using them. >>> >> >> Unfortunately Pavel never applied the dt-bindings patch for this - only >> the driver patch was applied. André already sent a kind reminder [1] and >> two resends [2, 3] without success. Since it's a documentation-only >> patch, maybe you could take it through the dt-bindings tree? >> > > I'll ping Rob. Other way is to resend. You need to keep resending (maybe > together with DTS in such case) before this can go in. Applied by Rob: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=876c881f9f416f1a9071a80fb7daefe19c51186e Best regards, Krzysztof
On 28/11/2022 06:16, Lin, Meng-Bo wrote: > WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 28 Nov 2022 05:16:32 +0000, Lin, Meng-Bo wrote: > WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree. > > Applied, thanks! [1/1] arm64: dts: qcom: msm8916-wingtech-wt88047: Add flash LED commit: 8b607c57655154ce4516d5d195bd174e6f0bede0 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts index 166bed05996f..a87be1d95b14 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts @@ -23,6 +23,20 @@ chosen { stdout-path = "serial0"; }; + flash-led-controller { + compatible = "ocs,ocp8110"; + enable-gpios = <&msmgpio 31 GPIO_ACTIVE_HIGH>; + flash-gpios = <&msmgpio 32 GPIO_ACTIVE_HIGH>; + + pinctrl-names = "default"; + pinctrl-0 = <&camera_flash_default>; + + flash_led: led { + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + }; + }; + gpio-keys { compatible = "gpio-keys"; @@ -274,6 +288,14 @@ l18 { }; &msmgpio { + camera_flash_default: camera-flash-default-state { + pins = "gpio31", "gpio32"; + function = "gpio"; + + drive-strength = <2>; + bias-disable; + }; + gpio_keys_default: gpio-keys-default-state { pins = "gpio107"; function = "gpio";