| Message ID | 20221121212226.321514-1-luca@z3ntu.xyz |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1843737wrr;
Mon, 21 Nov 2022 13:29:11 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf4lft8Gbt+JW4+rahpzTjNJkdISq+/bCji0GDJW2TtyfAI3GpRv+XSgSx38kiUDSfL4i5+V
X-Received: by 2002:a17:906:7e51:b0:78d:4fcb:1303 with SMTP id
z17-20020a1709067e5100b0078d4fcb1303mr17685454ejr.182.1669066151275;
Mon, 21 Nov 2022 13:29:11 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669066151; cv=none;
d=google.com; s=arc-20160816;
b=gZQmL8C5kdl2mA3ie9T9601BquI4zG1cxMof2nJqSVXGseECx3Lhg1B1ZDz2u3lm2n
gUv9HzAe2JRKXK1LVv98W0ltqmgZr3ZY9sBk3G7bwEo1FZ2ixN4zh0SKziKcwQkXl9Yz
QnkeWJSt5yuwGZHzVxdxLZ/XmoRrHpl0BBWA4nSlMUBlbs/3zFPCCPW4++5L2t+zbW5X
7p0RZWjTB89NIeDxyRZSnVto8F/UuL7CxwW1Ug4/24fnxO86PzTIfLF2jF50aQSPOtpR
A4aQX5felSwsiZTwRgmn5CZeTx4PFg4pRe6hIJ4fsyc31oNqGXWXWY716qwpd8AR59k4
j24w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=ARuF3sjrqahN2woij3To0ZoklAQfRI7K7Tsk2E81D+Y=;
b=DeU2vk/CjQ2zoRGNWW8DUOMv4MXKBAcyC/pmchR/npNU/Cy9FJriM/mBqGNrPdLs+3
lCe5+2fQafffYj4J15Kw9JH0chjkCLFsQlyVo0otibG3TWPGSdaTi0i+NFxWRlths3SB
Nz2AHI0EUrfW/VHp3AJovk7g5fszYW/niAkjxLdX32paNFYq6errSQoOV9zUyiqM0YBv
KleVT7BB4XAImw0gz47j3AqQIPpylX5Pe+LY0Z8MESWso3BF92dhjky0jwn8ndPhc2ty
03ON4ui/9fn4fyhKdnMZ4mgD4jV9Cmk8cfdgmtHH1Pp/l7togDbIRPlGM6DvTmzaXYE1
QHeA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@z3ntu.xyz header.s=z3ntu header.b=whpoVQvD;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=z3ntu.xyz
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
t10-20020a056402524a00b004634dd8b6edsi11528555edd.296.2022.11.21.13.28.46;
Mon, 21 Nov 2022 13:29:11 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=fail header.i=@z3ntu.xyz header.s=z3ntu header.b=whpoVQvD;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=z3ntu.xyz
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230368AbiKUVWn (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others);
Mon, 21 Nov 2022 16:22:43 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46004 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229695AbiKUVWl (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 21 Nov 2022 16:22:41 -0500
Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CDCEDF53;
Mon, 21 Nov 2022 13:22:38 -0800 (PST)
Received: from g550jk.arnhem.chello.nl (unknown [62.108.10.64])
by mail.z3ntu.xyz (Postfix) with ESMTPSA id 2227ECABCB;
Mon, 21 Nov 2022 21:22:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu;
t=1669065756; bh=icGbgsxy1HEPQOcedMSGJbJlERu4+bC9CJp6D7yq+dM=;
h=From:To:Cc:Subject:Date;
b=whpoVQvD0ToIFInww8OxeGCeBHay+QtHzZAV8iFIoH1y345uUQClZlQ50NDOp1Jvx
wpIMUG87QkwFplSDVe6XbVmodEksvT/rx1n7l9DDSC+NHOQMYZT1lQ7UeVfobNUsO+
Z65OM9TjzLGl00Ik+x3rs6h0vALJvVq2HB8MJtk4=
From: Luca Weiss <luca@z3ntu.xyz>
To: linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Luca Weiss <luca@z3ntu.xyz>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] ARM: dts: msm8974: castor: Define pm8841 regulators
Date: Mon, 21 Nov 2022 22:22:25 +0100
Message-Id: <20221121212226.321514-1-luca@z3ntu.xyz>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,
FROM_SUSPICIOUS_NTLD_FP,PDS_OTHER_BAD_TLD,SPF_HELO_NONE,SPF_PASS
autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1750142708628845002?=
X-GMAIL-MSGID: =?utf-8?q?1750142708628845002?=
|
| Series |
[v2,1/2] ARM: dts: msm8974: castor: Define pm8841 regulators
|
|
Commit Message
Luca Weiss
Nov. 21, 2022, 9:22 p.m. UTC
From: Bjorn Andersson <bjorn.andersson@linaro.org> Define the pm8841 regulators under SMD/RPM, to allow the modem remoteproc to set the voltage during boot of the remote processor. Entries are just copied from the Honami dts. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Changes in v2: * new patch in this series ...-msm8974pro-sony-xperia-shinano-castor.dts | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)
Comments
On 21.11.2022 22:22, Luca Weiss wrote: > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > Define the pm8841 regulators under SMD/RPM, to allow the modem > remoteproc to set the voltage during boot of the remote processor. > > Entries are just copied from the Honami dts. I hope it was supposed to be "identical to" and not "copied and hoped it would be ok" :/ Maybe I'm a bit picky, but I suppose this is said in a misleading way.. Konrad > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > Changes in v2: > * new patch in this series > > ...-msm8974pro-sony-xperia-shinano-castor.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > index 3f45f5c5d37b..2c33f84a6e4e 100644 > --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > @@ -319,6 +319,30 @@ led@7 { > }; > > &rpm_requests { > + pm8841-regulators { > + compatible = "qcom,rpm-pm8841-regulators"; > + > + pm8841_s1: s1 { > + regulator-min-microvolt = <675000>; > + regulator-max-microvolt = <1050000>; > + }; > + > + pm8841_s2: s2 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1050000>; > + }; > + > + pm8841_s3: s3 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1050000>; > + }; > + > + pm8841_s4: s4 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1050000>; > + }; > + }; > + > pm8941-regulators { > compatible = "qcom,rpm-pm8941-regulators"; >
On Montag, 21. November 2022 23:32:22 CET Konrad Dybcio wrote: > On 21.11.2022 22:22, Luca Weiss wrote: > > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > Define the pm8841 regulators under SMD/RPM, to allow the modem > > remoteproc to set the voltage during boot of the remote processor. > > > > Entries are just copied from the Honami dts. > > I hope it was supposed to be "identical to" and not "copied and hoped it > would be ok" :/ Blame Bjorn from many years ago :P But I just double checked and in some Sony msm8974 kernel sources I have on my computer (https://github.com/rcstar6696/android_kernel_sony_msm8974 branch cm-14.1) all Sony devices have the same values these pm8841 regulators, none have it overriden from what I could find. So should be fine. Regards Luca > > Maybe I'm a bit picky, but I suppose this is said in a misleading way.. > > Konrad > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > --- > > Changes in v2: > > * new patch in this series > > > > ...-msm8974pro-sony-xperia-shinano-castor.dts | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git > > a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > > b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts index > > 3f45f5c5d37b..2c33f84a6e4e 100644 > > --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > > +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > > @@ -319,6 +319,30 @@ led@7 { > > > > }; > > > > &rpm_requests { > > > > + pm8841-regulators { > > + compatible = "qcom,rpm-pm8841-regulators"; > > + > > + pm8841_s1: s1 { > > + regulator-min-microvolt = <675000>; > > + regulator-max-microvolt = <1050000>; > > + }; > > + > > + pm8841_s2: s2 { > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1050000>; > > + }; > > + > > + pm8841_s3: s3 { > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1050000>; > > + }; > > + > > + pm8841_s4: s4 { > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1050000>; > > + }; > > + }; > > + > > > > pm8941-regulators { > > > > compatible = "qcom,rpm-pm8941-regulators";
On Mon, 21 Nov 2022 22:22:25 +0100, Luca Weiss wrote: > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > Define the pm8841 regulators under SMD/RPM, to allow the modem > remoteproc to set the voltage during boot of the remote processor. > > Entries are just copied from the Honami dts. > > [...] Applied, thanks! [1/2] ARM: dts: msm8974: castor: Define pm8841 regulators commit: a0145c557d94b3bac7c5a4545f90cfe940a226cd [2/2] ARM: dts: qcom: msm8974-*: re-add remoteproc supplies commit: 6d933c0ec1718a08b44689da0f79ac1d905db7dd Best regards,
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts index 3f45f5c5d37b..2c33f84a6e4e 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts @@ -319,6 +319,30 @@ led@7 { }; &rpm_requests { + pm8841-regulators { + compatible = "qcom,rpm-pm8841-regulators"; + + pm8841_s1: s1 { + regulator-min-microvolt = <675000>; + regulator-max-microvolt = <1050000>; + }; + + pm8841_s2: s2 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1050000>; + }; + + pm8841_s3: s3 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1050000>; + }; + + pm8841_s4: s4 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1050000>; + }; + }; + pm8941-regulators { compatible = "qcom,rpm-pm8941-regulators";