Message ID | 20221127181835.806410-1-luca@z3ntu.xyz |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp5236827wrr; Sun, 27 Nov 2022 10:23:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf64e+Zw0PYRPJNmJmYFfEF0lxEsx7jX4PGGlm2aC+YBEhwJUk3pWq/U6ro+QlWbKUVwLEbF X-Received: by 2002:a17:902:e94e:b0:188:f3b9:7156 with SMTP id b14-20020a170902e94e00b00188f3b97156mr28409896pll.76.1669573416511; Sun, 27 Nov 2022 10:23:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669573416; cv=none; d=google.com; s=arc-20160816; b=MFImoqvYSlMpWpeQoB0enQe96y+tLZsPdrzyAmbnyh0Fh+J1H2lbGsHTpwA+uimyTU GMDOziaFJDIuKzAc3y0d1/qSbZBjkMqUd6ZKPjEsOjOrMvhasHpiX5InluPSKxQvfFVB LyQf5g/mCBl7O4Wzt+v5sSihQKsm+H9tTZQ/6dHrvt0LjXzM8ckYQnDIQG+HAhgjFigr u3A0ga46j+VduBx5RzdJpT2g/sPuBTUDNRkPD6LLHn26WikEDpgtEo63kDg89QY/VeLp I/+1/+9hjr3+XdPZ1O2Kb3xtx4eWz9TD31SvEnDiHt3wzBKMZ1SsRtWcxVIhnDAqUWJD kFJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+WoQlO13EsyTxyliodWNHKgU6yY2mIUfepT8HQ9Mcaw=; b=kTmxAj8xOJMNJHJinFeA7jd6y1cZ7a0FUU7Iu8JNKsgooWH9i6ilHLePJbTemK+9Ar FxNs35+XFbi+7Y1FzurTotRe4xnsfllv3YvyT0DcT5LnizaCTUvxfY39YFoEfGJc08Zu zi5JTHaaitcfbyfjkrVaqw+rNZL6Wz9dUW1FOnmnh6FKenTN8wqnLsP4BGNOR9gdZGD1 brWeoo4j0eHGBp/ZtApFr/UMReHeTgb32s8fMhHPiyzwQ4MTg4lV9HLpeTjUILUi70b6 TYYzKrAWsUQvJTZZLb+vl1r42zD85RTFuI5AQzZSh/lReeUr7UYNiCP+0Kqzba4Z6D79 iJWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@z3ntu.xyz header.s=z3ntu header.b=aMwF6niY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=z3ntu.xyz Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d12-20020a63fd0c000000b0043ca0a1f7dasi9223312pgh.674.2022.11.27.10.23.17; Sun, 27 Nov 2022 10:23:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@z3ntu.xyz header.s=z3ntu header.b=aMwF6niY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=z3ntu.xyz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229533AbiK0STV (ORCPT <rfc822;gah0developer@gmail.com> + 99 others); Sun, 27 Nov 2022 13:19:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiK0STU (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 27 Nov 2022 13:19:20 -0500 Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2829BC0B; Sun, 27 Nov 2022 10:19:19 -0800 (PST) Received: from g550jk.arnhem.chello.nl (unknown [62.108.10.64]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 93D2FCAAFE; Sun, 27 Nov 2022 18:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1669573127; bh=te1aGjpIXAW8fSvdUbBWpIhdrJ7fXXsmXhoh/IVj0Do=; h=From:To:Cc:Subject:Date; b=aMwF6niYRfggap4nzdMlPYPNqteKrjSNjV6tUW8l6miNu4CQWipTGx3ZQB8S8wDJ1 TkB7rNGz9CwtgkMpChtKKXkeuN5GjhDu78Ky+xD/eAPbe3YCGt8aqk1O3+JcfwMDVy GswCWwPO/Ej85ce4lbKieoqV8LAzkrzZUZ3W/fmg= From: Luca Weiss <luca@z3ntu.xyz> To: linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Luca Weiss <luca@z3ntu.xyz>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device Date: Sun, 27 Nov 2022 19:18:34 +0100 Message-Id: <20221127181835.806410-1-luca@z3ntu.xyz> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD, FROM_SUSPICIOUS_NTLD_FP,PDS_OTHER_BAD_TLD,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750674614913892368?= X-GMAIL-MSGID: =?utf-8?q?1750674614913892368?= |
Series |
[1/2] dt-bindings: arm: qcom: Document oneplus,bacon device
|
|
Commit Message
Luca Weiss
Nov. 27, 2022, 6:18 p.m. UTC
Document the OnePlus One ("bacon") which is a smartphone based on the
Snapdragon 801 SoC.
Also allow msm8974 devices to use qcom,msm-id and qcom,board-id.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
On 27/11/2022 19:18, Luca Weiss wrote: > Document the OnePlus One ("bacon") which is a smartphone based on the > Snapdragon 801 SoC. > > Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 463509f0f23a..3d2cc8ae34d8 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -167,6 +167,7 @@ properties: > - enum: > - fairphone,fp2 > - lge,hammerhead > + - oneplus,bacon > - samsung,klte > - sony,xperia-amami > - sony,xperia-castor > @@ -896,6 +897,7 @@ allOf: > - qcom,apq8026 > - qcom,apq8094 > - qcom,apq8096 > + - qcom,msm8974 Someone will have to rebase: https://lore.kernel.org/linux-devicetree/20221104172122.252761-4-angelogioacchino.delregno@collabora.com/ Patch is good: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@z3ntu.xyz> wrote: > > Document the OnePlus One ("bacon") which is a smartphone based on the > Snapdragon 801 SoC. > > Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. The patch itself is good. However it raised a broader question for me. Up to now all msm8974pro devices use qcom,msm8974 as a top-level compatibility string. Should it be changed to use pro-specific one (e.g. qcom,msm8974pro)? For the patch itself: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 463509f0f23a..3d2cc8ae34d8 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -167,6 +167,7 @@ properties: > - enum: > - fairphone,fp2 > - lge,hammerhead > + - oneplus,bacon > - samsung,klte > - sony,xperia-amami > - sony,xperia-castor > @@ -896,6 +897,7 @@ allOf: > - qcom,apq8026 > - qcom,apq8094 > - qcom,apq8096 > + - qcom,msm8974 > - qcom,msm8992 > - qcom,msm8994 > - qcom,msm8996 > -- > 2.38.1 >
On 27/11/2022 22:25, Dmitry Baryshkov wrote: > On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@z3ntu.xyz> wrote: >> >> Document the OnePlus One ("bacon") which is a smartphone based on the >> Snapdragon 801 SoC. >> >> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. > > The patch itself is good. However it raised a broader question for me. > Up to now all msm8974pro devices use qcom,msm8974 as a top-level > compatibility string. Should it be changed to use pro-specific one > (e.g. qcom,msm8974pro)? Yes, makes sense. Best regards, Krzysztof
On Sun, 27 Nov 2022 at 23:30, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 27/11/2022 22:25, Dmitry Baryshkov wrote: > > On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@z3ntu.xyz> wrote: > >> > >> Document the OnePlus One ("bacon") which is a smartphone based on the > >> Snapdragon 801 SoC. > >> > >> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. > > > > The patch itself is good. However it raised a broader question for me. > > Up to now all msm8974pro devices use qcom,msm8974 as a top-level > > compatibility string. Should it be changed to use pro-specific one > > (e.g. qcom,msm8974pro)? > > Yes, makes sense. Would you make the patch?
On 27/11/2022 22:43, Dmitry Baryshkov wrote: > On Sun, 27 Nov 2022 at 23:30, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 27/11/2022 22:25, Dmitry Baryshkov wrote: >>> On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@z3ntu.xyz> wrote: >>>> >>>> Document the OnePlus One ("bacon") which is a smartphone based on the >>>> Snapdragon 801 SoC. >>>> >>>> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. >>> >>> The patch itself is good. However it raised a broader question for me. >>> Up to now all msm8974pro devices use qcom,msm8974 as a top-level >>> compatibility string. Should it be changed to use pro-specific one >>> (e.g. qcom,msm8974pro)? >> >> Yes, makes sense. > > Would you make the patch? I do not plan to. I don't know which ones are Pro which aren't. Best regards, Krzysztof
On Mon, 28 Nov 2022 at 10:34, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 27/11/2022 22:43, Dmitry Baryshkov wrote: > > On Sun, 27 Nov 2022 at 23:30, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 27/11/2022 22:25, Dmitry Baryshkov wrote: > >>> On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@z3ntu.xyz> wrote: > >>>> > >>>> Document the OnePlus One ("bacon") which is a smartphone based on the > >>>> Snapdragon 801 SoC. > >>>> > >>>> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. > >>> > >>> The patch itself is good. However it raised a broader question for me. > >>> Up to now all msm8974pro devices use qcom,msm8974 as a top-level > >>> compatibility string. Should it be changed to use pro-specific one > >>> (e.g. qcom,msm8974pro)? > >> > >> Yes, makes sense. > > > > Would you make the patch? > > I do not plan to. I don't know which ones are Pro which aren't. Ack, I'll do it then.
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 463509f0f23a..3d2cc8ae34d8 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -167,6 +167,7 @@ properties: - enum: - fairphone,fp2 - lge,hammerhead + - oneplus,bacon - samsung,klte - sony,xperia-amami - sony,xperia-castor @@ -896,6 +897,7 @@ allOf: - qcom,apq8026 - qcom,apq8094 - qcom,apq8096 + - qcom,msm8974 - qcom,msm8992 - qcom,msm8994 - qcom,msm8996