| Message ID | 20221125121905.88292-1-tianjia.zhang@linux.alibaba.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3977754wrr;
Fri, 25 Nov 2022 04:29:32 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf6yv3hLTYVdacuUNMfhZXy0M7VYb5e5SNoz8ehKoKjgTjzDEQlduv6SUZF4w+cltUS5DU8I
X-Received: by 2002:aa7:9473:0:b0:573:28c6:27fd with SMTP id
t19-20020aa79473000000b0057328c627fdmr18309902pfq.52.1669379372259;
Fri, 25 Nov 2022 04:29:32 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669379372; cv=none;
d=google.com; s=arc-20160816;
b=zr5tk/5TyZIxEYLxbCgVyR/YxW+PlKURxspsf2kq0WDYeTpRtLtEaO3nqEcix73Jb3
KNkLWQTimsfNxN3ZIa0GAY9uF8dnNm7obn4yvAEDaQv/6xajq1imWhv2RUBAW+oBylsh
ALrZagqsHh8W/NYTftlvKEO0KGQ0jifagCZBL3RuDjr5KklTuayjrxXTTrzqvLmaSMeR
8zJwDMmejxE/+PzfMjc0rOLFAcoE0U4wf0g9Ncn35KbEC6SQ5NqRdDjOVt2cud+oWudW
4Tq/LuIBqPswOSkPiOPr0v67bQHpt7AdOOuuE7Qus+NwWlaIyJLly+kn/2gJ+pjQnd5n
Xy+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=jBvGpX+y0ptuuWdzRreH8AlTlYNFYZ3spgrf+2xjD3s=;
b=LJI6vrCsAxr7V3c6BjFIRdBMQoFnBGEVzNKXZerrJDV+MOBP1oYxFkdLtxrQ5ooBpN
SsVwk7zHcegmExdnyUG+g1KI5Kg2ycH1ZgMCOaBscQNf9hCfMY6Vaa1sy+iO/vjStHhG
Qv7/v12AonmXGqK0Z4wQ6CNIWMu2+LRGI9Z/Mvo6IoURhl93STVhDLaNZ5SR/rp/RjFI
ALV7XD5C0AiM22++Q8ixA7GMEBZQBlhXVpk9pMWfciD333YYC4zI2dMhVKPml10qvt4b
yRXQCUemwrabaOmaGuHTT/k2qbQL0HY10sOCE/yprwhXqRby77R2ru52XYbgRHHM5Sjf
5Y3g==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
a17-20020aa78e91000000b00574694c97c7si3664332pfr.300.2022.11.25.04.29.18;
Fri, 25 Nov 2022 04:29:32 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229973AbiKYMTR (ORCPT <rfc822;zxc52fgh@gmail.com> + 99 others);
Fri, 25 Nov 2022 07:19:17 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43274 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229894AbiKYMTP (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 25 Nov 2022 07:19:15 -0500
Received: from out30-56.freemail.mail.aliyun.com
(out30-56.freemail.mail.aliyun.com [115.124.30.56])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6A19421B8;
Fri, 25 Nov 2022 04:19:13 -0800 (PST)
X-Alimail-AntiSpam:
AC=PASS;BC=-1|-1;BR=01201311R451e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VVfPnmv_1669378749;
Received: from localhost(mailfrom:tianjia.zhang@linux.alibaba.com
fp:SMTPD_---0VVfPnmv_1669378749)
by smtp.aliyun-inc.com;
Fri, 25 Nov 2022 20:19:11 +0800
From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Subject: [PATCH] selftests/tls: Fix tls selftests dependency to correct
algorithm
Date: Fri, 25 Nov 2022 20:19:05 +0800
Message-Id: <20221125121905.88292-1-tianjia.zhang@linux.alibaba.com>
X-Mailer: git-send-email 2.24.3 (Apple Git-128)
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,
ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1750471144533668232?=
X-GMAIL-MSGID: =?utf-8?q?1750471144533668232?=
|
| Series |
selftests/tls: Fix tls selftests dependency to correct algorithm
|
|
Commit Message
Tianjia Zhang
Nov. 25, 2022, 12:19 p.m. UTC
Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves
the SM3 and SM4 stand-alone library and the algorithm implementation for
the Crypto API into the same directory, and the corresponding relationship
of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone
library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the
algorithm implementation for the Crypto API. Therefore, it is necessary
for this module to depend on the correct algorithm.
Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory")
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: stable@vger.kernel.org # v5.19+
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
tools/testing/selftests/net/config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote: > Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves > the SM3 and SM4 stand-alone library and the algorithm implementation for > the Crypto API into the same directory, and the corresponding relationship > of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone > library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the > algorithm implementation for the Crypto API. Therefore, it is necessary > for this module to depend on the correct algorithm. > I feel a rather confused. What about below? ``` Commit <commit> moves SM3 and SM4 algorithm implementations from stand-alone library to crypto API. The corresponding configuration options for the API version (generic) are CONFIG_CRYPTO_SM3_GENERIC and CONFIG_CRYPTO_SM4_GENERIC, respectively. Replace option selected in selftests configuration from the library version to the API version. ``` > Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") > Cc: Jason A. Donenfeld <Jason@zx2c4.com> > Cc: stable@vger.kernel.org # v5.19+ > Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> > --- > tools/testing/selftests/net/config | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config > index ead7963b9bf0..bd89198cd817 100644 > --- a/tools/testing/selftests/net/config > +++ b/tools/testing/selftests/net/config > @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m > CONFIG_NET_ACT_MIRRED=m > CONFIG_BAREUDP=m > CONFIG_IPV6_IOAM6_LWTUNNEL=y > -CONFIG_CRYPTO_SM4=y > +CONFIG_CRYPTO_SM4_GENERIC=y > CONFIG_AMT=m You mean the correct algo option is CONFIG_CRYPTO_SM4_GENERIC, right?
On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote: > Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves > the SM3 and SM4 stand-alone library and the algorithm implementation for > the Crypto API into the same directory, and the corresponding relationship > of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone > library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the > algorithm implementation for the Crypto API. Therefore, it is necessary > for this module to depend on the correct algorithm. > > Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") > Cc: Jason A. Donenfeld <Jason@zx2c4.com> > Cc: stable@vger.kernel.org # v5.19+ > Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> > --- > tools/testing/selftests/net/config | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config > index ead7963b9bf0..bd89198cd817 100644 > --- a/tools/testing/selftests/net/config > +++ b/tools/testing/selftests/net/config > @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m > CONFIG_NET_ACT_MIRRED=m > CONFIG_BAREUDP=m > CONFIG_IPV6_IOAM6_LWTUNNEL=y > -CONFIG_CRYPTO_SM4=y > +CONFIG_CRYPTO_SM4_GENERIC=y > CONFIG_AMT=m > -- > 2.24.3 (Apple Git-128) > Looks the issue in this discuss https://lore.kernel.org/netdev/Y3c9zMbKsR+tcLHk@Laptop-X1/ related to your fix. Thanks Hangbin
Hi Bagas, On 11/25/22 9:18 PM, Bagas Sanjaya wrote: > On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote: >> Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves >> the SM3 and SM4 stand-alone library and the algorithm implementation for >> the Crypto API into the same directory, and the corresponding relationship >> of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone >> library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the >> algorithm implementation for the Crypto API. Therefore, it is necessary >> for this module to depend on the correct algorithm. >> > > I feel a rather confused. What about below? > > ``` > Commit <commit> moves SM3 and SM4 algorithm implementations from > stand-alone library to crypto API. The corresponding configuration > options for the API version (generic) are CONFIG_CRYPTO_SM3_GENERIC and > CONFIG_CRYPTO_SM4_GENERIC, respectively. > > Replace option selected in selftests configuration from the library version > to the API version. > ``` > Thanks, this is great, I will pick it up. >> Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") >> Cc: Jason A. Donenfeld <Jason@zx2c4.com> >> Cc: stable@vger.kernel.org # v5.19+ >> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> >> --- >> tools/testing/selftests/net/config | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config >> index ead7963b9bf0..bd89198cd817 100644 >> --- a/tools/testing/selftests/net/config >> +++ b/tools/testing/selftests/net/config >> @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m >> CONFIG_NET_ACT_MIRRED=m >> CONFIG_BAREUDP=m >> CONFIG_IPV6_IOAM6_LWTUNNEL=y >> -CONFIG_CRYPTO_SM4=y >> +CONFIG_CRYPTO_SM4_GENERIC=y >> CONFIG_AMT=m > > You mean the correct algo option is CONFIG_CRYPTO_SM4_GENERIC, right? > Yes, CONFIG_CRYPTO_SM4_GENERIC is the correct algo option. Best regards, Tianjia
Hi Hangbin, On 11/27/22 8:17 PM, Hangbin Liu wrote: > On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote: >> Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves >> the SM3 and SM4 stand-alone library and the algorithm implementation for >> the Crypto API into the same directory, and the corresponding relationship >> of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone >> library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the >> algorithm implementation for the Crypto API. Therefore, it is necessary >> for this module to depend on the correct algorithm. >> >> Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") >> Cc: Jason A. Donenfeld <Jason@zx2c4.com> >> Cc: stable@vger.kernel.org # v5.19+ >> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> >> --- >> tools/testing/selftests/net/config | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config >> index ead7963b9bf0..bd89198cd817 100644 >> --- a/tools/testing/selftests/net/config >> +++ b/tools/testing/selftests/net/config >> @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m >> CONFIG_NET_ACT_MIRRED=m >> CONFIG_BAREUDP=m >> CONFIG_IPV6_IOAM6_LWTUNNEL=y >> -CONFIG_CRYPTO_SM4=y >> +CONFIG_CRYPTO_SM4_GENERIC=y >> CONFIG_AMT=m >> -- >> 2.24.3 (Apple Git-128) >> > > Looks the issue in this discuss > https://lore.kernel.org/netdev/Y3c9zMbKsR+tcLHk@Laptop-X1/ > related to your fix. > Thanks for your information, it is indeed the same issue.I don’t know if there is a patch to fix it. If not, can this patch solve this issue? If so, can I add Reported-by or Tested-by tag? Best regards, Tianjia
On Mon, Nov 28, 2022 at 03:14:16PM +0800, Tianjia Zhang wrote: > Hi Hangbin, > > On 11/27/22 8:17 PM, Hangbin Liu wrote: > > On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote: > > > Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves > > > the SM3 and SM4 stand-alone library and the algorithm implementation for > > > the Crypto API into the same directory, and the corresponding relationship > > > of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone > > > library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the > > > algorithm implementation for the Crypto API. Therefore, it is necessary > > > for this module to depend on the correct algorithm. > > > > > > Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") > > > Cc: Jason A. Donenfeld <Jason@zx2c4.com> > > > Cc: stable@vger.kernel.org # v5.19+ > > > Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> > > > --- > > > tools/testing/selftests/net/config | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config > > > index ead7963b9bf0..bd89198cd817 100644 > > > --- a/tools/testing/selftests/net/config > > > +++ b/tools/testing/selftests/net/config > > > @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m > > > CONFIG_NET_ACT_MIRRED=m > > > CONFIG_BAREUDP=m > > > CONFIG_IPV6_IOAM6_LWTUNNEL=y > > > -CONFIG_CRYPTO_SM4=y > > > +CONFIG_CRYPTO_SM4_GENERIC=y > > > CONFIG_AMT=m > > > -- > > > 2.24.3 (Apple Git-128) > > > > > > > Looks the issue in this discuss > > https://lore.kernel.org/netdev/Y3c9zMbKsR+tcLHk@Laptop-X1/ > > related to your fix. > > > > Thanks for your information, it is indeed the same issue.I don’t know if > there is a patch to fix it. If not, can this patch solve this issue? If > so, can I add Reported-by or Tested-by tag? > Feel free to add Reported-by flag. I can't test this unless the patch merged to upstream. Thanks Hangbin
On 11/28/22 3:25 PM, Hangbin Liu wrote: > On Mon, Nov 28, 2022 at 03:14:16PM +0800, Tianjia Zhang wrote: >> Hi Hangbin, >> >> On 11/27/22 8:17 PM, Hangbin Liu wrote: >>> On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote: >>>> Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves >>>> the SM3 and SM4 stand-alone library and the algorithm implementation for >>>> the Crypto API into the same directory, and the corresponding relationship >>>> of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone >>>> library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the >>>> algorithm implementation for the Crypto API. Therefore, it is necessary >>>> for this module to depend on the correct algorithm. >>>> >>>> Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") >>>> Cc: Jason A. Donenfeld <Jason@zx2c4.com> >>>> Cc: stable@vger.kernel.org # v5.19+ >>>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> >>>> --- >>>> tools/testing/selftests/net/config | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config >>>> index ead7963b9bf0..bd89198cd817 100644 >>>> --- a/tools/testing/selftests/net/config >>>> +++ b/tools/testing/selftests/net/config >>>> @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m >>>> CONFIG_NET_ACT_MIRRED=m >>>> CONFIG_BAREUDP=m >>>> CONFIG_IPV6_IOAM6_LWTUNNEL=y >>>> -CONFIG_CRYPTO_SM4=y >>>> +CONFIG_CRYPTO_SM4_GENERIC=y >>>> CONFIG_AMT=m >>>> -- >>>> 2.24.3 (Apple Git-128) >>>> >>> >>> Looks the issue in this discuss >>> https://lore.kernel.org/netdev/Y3c9zMbKsR+tcLHk@Laptop-X1/ >>> related to your fix. >>> >> >> Thanks for your information, it is indeed the same issue.I don’t know if >> there is a patch to fix it. If not, can this patch solve this issue? If >> so, can I add Reported-by or Tested-by tag? >> > > Feel free to add Reported-by flag. I can't test this unless the patch merged > to upstream. > Thanks, I will send a v2 patch as soon as possible. Tianjia
diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index ead7963b9bf0..bd89198cd817 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m CONFIG_NET_ACT_MIRRED=m CONFIG_BAREUDP=m CONFIG_IPV6_IOAM6_LWTUNNEL=y -CONFIG_CRYPTO_SM4=y +CONFIG_CRYPTO_SM4_GENERIC=y CONFIG_AMT=m