diff mbox series

can: ctucanfd: Drop obsolete dependency on COMPILE_TEST

Message ID 20221124141604.4265225f@endymion.delvare
State New
Headers
Series can: ctucanfd: Drop obsolete dependency on COMPILE_TEST |

Commit Message

Jean Delvare Nov. 24, 2022, 1:16 p.m. UTC 
  Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Cc: Ondrej Ille <ondrej.ille@gmail.com>
---
 drivers/net/can/ctucanfd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pavel Pisa Nov. 24, 2022, 2:56 p.m. UTC | #1 
Thanks for the care. I cannot judge change on my personal opinion.
But if that is general direction even for other drivers
then I confirm the change.

On Thursday 24 of November 2022 14:16:04 Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> Cc: Ondrej Ille <ondrej.ille@gmail.com>
> ---
>  drivers/net/can/ctucanfd/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-6.0.orig/drivers/net/can/ctucanfd/Kconfig
> +++ linux-6.0/drivers/net/can/ctucanfd/Kconfig
> @@ -23,7 +23,7 @@ config CAN_CTUCANFD_PCI
>
>  config CAN_CTUCANFD_PLATFORM
>  	tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
> -	depends on HAS_IOMEM && (OF || COMPILE_TEST)
> +	depends on HAS_IOMEM && OF
>  	select CAN_CTUCANFD
>  	help
>  	  The core has been tested together with OpenCores SJA1000
Marc Kleine-Budde Nov. 25, 2022, 3:57 p.m. UTC | #2 
On 24.11.2022 15:56:38, Pavel Pisa wrote:
> Thanks for the care. I cannot judge change on my personal opinion.
> But if that is general direction even for other drivers
> then I confirm the change.

Should I convert this into a formal Acked-by: :)

Marc
Pavel Pisa Nov. 27, 2022, 8:09 a.m. UTC | #3 
On Friday 25 of November 2022 16:57:58 Marc Kleine-Budde wrote:
> On 24.11.2022 15:56:38, Pavel Pisa wrote:
> > Thanks for the care. I cannot judge change on my personal opinion.
> > But if that is general direction even for other drivers
> > then I confirm the change.
>
> Should I convert this into a formal Acked-by: :)

I you prefer formal one and agree with the change then yes.

Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Marc Kleine-Budde Nov. 30, 2022, 10:23 a.m. UTC | #4 
On 27.11.2022 09:09:57, Pavel Pisa wrote:
> On Friday 25 of November 2022 16:57:58 Marc Kleine-Budde wrote:
> > On 24.11.2022 15:56:38, Pavel Pisa wrote:
> > > Thanks for the care. I cannot judge change on my personal opinion.
> > > But if that is general direction even for other drivers
> > > then I confirm the change.
> >
> > Should I convert this into a formal Acked-by: :)
> 
> I you prefer formal one and agree with the change then yes.
> 
> Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>

Thanks, the 'b4' tool picks up the Acked-by automatically.

regards,
Marc
Marc Kleine-Budde Nov. 30, 2022, 10:26 a.m. UTC | #5 
On 24.11.2022 14:16:04, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> Cc: Ondrej Ille <ondrej.ille@gmail.com>

Applied to linux-can.

Thanks,
Marc
diff mbox series

Patch

--- linux-6.0.orig/drivers/net/can/ctucanfd/Kconfig
+++ linux-6.0/drivers/net/can/ctucanfd/Kconfig
@@ -23,7 +23,7 @@  config CAN_CTUCANFD_PCI
 
 config CAN_CTUCANFD_PLATFORM
 	tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
-	depends on HAS_IOMEM && (OF || COMPILE_TEST)
+	depends on HAS_IOMEM && OF
 	select CAN_CTUCANFD
 	help
 	  The core has been tested together with OpenCores SJA1000