Message ID | 20240228193732.3605768-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-85626-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:a1a:b0:17b:cd04:e0c6 with SMTP id 26csp190232rwa; Wed, 28 Feb 2024 12:57:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVTIv2zOYeS2t+M+ozE4nLQ0iQKCxERv9iRVyCqM4J2g9GLDiPqqumPtZBUT7zj/lXb3bpunMa0loCU9rA8pPYjPvrXTw== X-Google-Smtp-Source: AGHT+IHK7vaT1hdc4xBsqqfToXuzJckePNEEddK7o4SFlwD9KwxTGYMGdJNmWqL+TtUud4FwH0kE X-Received: by 2002:a17:906:44d:b0:a3e:b523:3a66 with SMTP id e13-20020a170906044d00b00a3eb5233a66mr70703eja.62.1709153822870; Wed, 28 Feb 2024 12:57:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709153822; cv=pass; d=google.com; s=arc-20160816; b=ko/zJJoK+1lqiybDDJdhRQQbmvzpC8p0bBSmzK3pRATBSeOOBB/strd87toaA1NJCy 077Br4QUMQrY3h0Hdaxzb9ZTYbqN1Lj3QLU8VTXjoZ/Asr77kKR1EI9gKYw9HOD0bwMV dXfW7Z0lxeXzea+18UrOTB/l17RH78upzLqIQF5lgqEViWh1kd1bDyHXA0uuGIGct5lK s649qSURqQkvQf5XGom9H7nOsoKSiMb55F9x5rbr2JWWfPJ4hIByiPofS08GSWQzAFc0 aKk2oLRLxtXnSbaiJSdS8SfOHfEAz9OhIKUBigLhjRbnAOGmGA4/SeJpaT0uNIe/yB9p ivQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=GXQWFkrgYPRvbVi5E2Oq9Ec1qb5Tc1cscX2m/ShtZe4=; fh=ZdOQmDonDot8IQSM+4Tht3Gfm0GukzFTBse4YQBEJXA=; b=BRVId0elnUm17K5vn+F7Nh1WvVQEucOFwH0p2BbkzLqVg/NHHOqnJVNBszHYFbM2o9 Aqm8xeJR7eLykEMktzSKlvKb2RTRm6RkRyBaXKqjjz4Q/PBV++GmaWtBPMJW9fViuqVU aY+gsSn5mL78EObWrXZR06cexmlkmEpF+M+7zn40DS9OSZBlVbWUqeACfl0BrRY98s3c 0vCpqHH6bv35mL0SV3onKQZUnewFsSNmzUKJok7qL1OevqW8WHhrIYxbjhDbemBNlaSH yG8XXP8TfPxMQmV8L9O6EvKeSInHVzUJEyl0iwUXsJBWnMf1Z438LqKsHZl9JUYOUQNJ 7+zQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LRMvfi4G; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-85626-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85626-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id js10-20020a17090797ca00b00a442e2954c2si159979ejc.717.2024.02.28.12.57.02 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 12:57:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85626-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LRMvfi4G; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-85626-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85626-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E26811F2813D for <ouuuleilei@gmail.com>; Wed, 28 Feb 2024 19:40:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E4E8160880; Wed, 28 Feb 2024 19:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LRMvfi4G" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4D315F316; Wed, 28 Feb 2024 19:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709149087; cv=none; b=VxEPMyYCtlrjTDh7J1FHs5n5FOWyYsG8nrWidpnRddC+Zd97v0bS/NV0an8yYiNSQLEnz7YP9Dvigg7zhetvPi5CPMq/O7n15OmLHh6+AzOq6v81ZG/GQczQJxffX3f163OhDoF6Uc9iLb3JDw+gW4imp26l7hVVKiiRBNqz1GU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709149087; c=relaxed/simple; bh=Ou+j2G4u1McDiltrMDd5BddvlU0WOmjqjYYJXBtphzc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YOWelIn7gmNLP4bweq4PTyxPEkTSSs7mVulLwHOPohyYMwUwas8wUVL7w76RfSbk07EWnyaIcDhvUIET0gp4WOSJ94YVQQUx0v3jmZ68v2zUUdV7S2nLnn6DCJcClqcUDlZvUXXZENmZTpOd3Ua+4POOzzcSHDenPncBotSPqKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LRMvfi4G; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709149085; x=1740685085; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Ou+j2G4u1McDiltrMDd5BddvlU0WOmjqjYYJXBtphzc=; b=LRMvfi4GFQxH/PI9nSxBdPOgce1vSMSAwcf/PsuBwXtBEs8c7q3FTZi/ bHxANgsIyveIu/K/YrAtcAFpgssXZZWx8XN1rPRv0zm4kxfPLbGSzzESu 2uZv4Zu7uFGzcRjB3RH85pclNbPhFf6xJ/ZE3bxetdp7lIHrQfZ3xTFSA Lp2uZQY6DhhwRvgaGO0UT6adjgIKoxmLemAjDi/b1PsMH6SYO7dwWBa0k Fr8wH5D17V5AV6/I2oa5bmEl11WjjDC97g//q0vHa0K5davE/eV6T1Kw7 Ht69uKTw1IrS4fxJCFLaP3pKgCQ2KeeiGnABaUjSLpmBHw/tvy/CInsAW A==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="14990894" X-IronPort-AV: E=Sophos;i="6.06,191,1705392000"; d="scan'208";a="14990894" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 11:38:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="937034608" X-IronPort-AV: E=Sophos;i="6.06,191,1705392000"; d="scan'208";a="937034608" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 28 Feb 2024 11:38:03 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0FAF81C5; Wed, 28 Feb 2024 21:38:01 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Mark Brown <broonie@kernel.org>, Yang Yingliang <yangyingliang@huawei.com>, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v1 1/1] spi: oc-tiny: Remove unused of_gpio.h Date: Wed, 28 Feb 2024 21:37:31 +0200 Message-ID: <20240228193732.3605768-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792177679296756310 X-GMAIL-MSGID: 1792177679296756310 |
Series |
[v1,1/1] spi: oc-tiny: Remove unused of_gpio.h
|
|
Commit Message
Andy Shevchenko
Feb. 28, 2024, 7:37 p.m. UTC
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spi-oc-tiny.c | 2 --
1 file changed, 2 deletions(-)
Comments
On Wed, Feb 28, 2024 at 09:37:31PM +0200, Andy Shevchenko wrote: > of_gpio.h is deprecated and subject to remove. > The driver doesn't use it, simply remove the unused header. Hmm... did it fall through cracks or anything should I do?
On Mon, Mar 04, 2024 at 04:42:55PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2024 at 09:37:31PM +0200, Andy Shevchenko wrote: > > of_gpio.h is deprecated and subject to remove. > > The driver doesn't use it, simply remove the unused header. > Hmm... did it fall through cracks or anything should I do? Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
diff --git a/drivers/spi/spi-oc-tiny.c b/drivers/spi/spi-oc-tiny.c index 6ea38f5e7d64..7d8c5cd680d1 100644 --- a/drivers/spi/spi-oc-tiny.c +++ b/drivers/spi/spi-oc-tiny.c @@ -184,8 +184,6 @@ static irqreturn_t tiny_spi_irq(int irq, void *dev) } #ifdef CONFIG_OF -#include <linux/of_gpio.h> - static int tiny_spi_of_probe(struct platform_device *pdev) { struct tiny_spi *hw = platform_get_drvdata(pdev);