Message ID | 91454ef9b4a12f01e13d69b675d81aff@iitb.ac.in |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-90067-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1237316dyc; Sun, 3 Mar 2024 21:54:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWYxKCuALr5l4LcTOx7olqkhZYBZ9gIl42zJZRfyCKXI49GK0Ip6E9pkFlBzyy1xIk6YJNKm1k+ZADWUJc/xorWOYAomA== X-Google-Smtp-Source: AGHT+IGgidP0cwdl7SKpzYvt0HSA6hBjucviLPT7l8sqBzpabJt/AmiI3PlsBeBRruX/I4fajQDq X-Received: by 2002:aa7:c3ce:0:b0:567:57d6:4207 with SMTP id l14-20020aa7c3ce000000b0056757d64207mr662614edr.34.1709531649498; Sun, 03 Mar 2024 21:54:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709531649; cv=pass; d=google.com; s=arc-20160816; b=lBSAK/0pA/QpzyDfUSo/JjHNPJUgRot+VOMzhq8ix+3EMjfasijsBDuF//y2us+Ls/ zl/4JBLsB9S45u+Tmkyqd87tQq/CXXJ9BOgpcJb7KgoMDf88C2hiFS/2uZ2aK/JrAjy3 eSNQbl/tdvsFEj1aiDDW5k9l30nT+9Vpp3DUMEecnfMxK7gQPZKLy6yxfHiwvNK/rWMs WwYNxD1tfzeiykrFYY9V/jtitxHvLvgdH04a05BxYER2DUZCZtGinp2pE1R4DYxZyDgG fHi6g5n3BOcTjykfZlWmQagLHrXG+GGbc3V5cykNlpddTloQryNAycJ6U6UEr27Zttfh AI9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:message-id:subject:cc:to:from:date :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature:dkim-filter; bh=xxyUZTh9GUaq4RQ4U+2C4DEWG8dxk+8pqFIqYfXsUEA=; fh=BNyvc+xeF/bDQpgKm8wzqaORw04yF1304RbZ8hGjYjc=; b=ZOXjftVd3dTTPW5QjxuN0MEz7DVj2KmhcWFgrbm/Ig/AqkMg3RnVOYaqtO7c4yxetb CD9ZpzXs9onpOJ+bL8PXbxYVxhIv8+gIAY35NoEaCFDnb3B0bfa4S3H2tzmVevRahN0v vI8mx21qNfxPPH65E1snH7Z87TJ9kTeBvZ4er3ybU/yxlEwnd9xm1k3zdhNsDE/1MwRG f9kUzDizibKqlDSUizrgAhIG2Zxvc5sB1OPwi/or4jAWyOvVAvRkCHO7QB4eOIgZNZiG Rl4LBylv7hAi0eSpSxKNzJGvXV24SPZ28kwa0zM1MBF+WSngqZ86FjuOQz0VykzDLYJ1 2Dvw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@iitb.ac.in header.s=mail header.b=ssBB4zbd; arc=pass (i=1 spf=pass spfdomain=iitb.ac.in dkim=pass dkdomain=iitb.ac.in dmarc=pass fromdomain=iitb.ac.in); spf=pass (google.com: domain of linux-kernel+bounces-90067-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90067-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iitb.ac.in Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ca22-20020aa7cd76000000b00566bfabae81si3019537edb.208.2024.03.03.21.54.09 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 21:54:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90067-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@iitb.ac.in header.s=mail header.b=ssBB4zbd; arc=pass (i=1 spf=pass spfdomain=iitb.ac.in dkim=pass dkdomain=iitb.ac.in dmarc=pass fromdomain=iitb.ac.in); spf=pass (google.com: domain of linux-kernel+bounces-90067-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90067-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=iitb.ac.in Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D2D6B1F211AF for <ouuuleilei@gmail.com>; Mon, 4 Mar 2024 05:54:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0400DD2F7; Mon, 4 Mar 2024 05:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iitb.ac.in header.i=@iitb.ac.in header.b="ssBB4zbd" Received: from smtp1.iitb.ac.in (smtpd9.iitb.ac.in [103.21.126.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E4C5BA27 for <linux-kernel@vger.kernel.org>; Mon, 4 Mar 2024 05:53:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.21.126.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709531633; cv=none; b=jSkPj3al+JQNijyhwPDkv8mP6Ku2prpOZYbC41CTocxIucpGm32RzI0fnZuklZn2Qij5WQhMvuW9iwOnINqBkwxb3mnuM0AZxnrLrgh/uU5Bzte2CfdnhGuZSR8ab/ckPAGT23awoF227EZ8qV+MzjOnV/HjrTt9tP/QpDMvY+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709531633; c=relaxed/simple; bh=h+kBNKpg6K7RtepCFQNzRMfkyN2SbsIJc7s8qriTZoc=; h=MIME-Version:Date:From:To:Cc:Subject:Message-ID:Content-Type; b=u1ukch0kvNzNLIpQH0uaEut0pxe67A8mSh/hM8ekLq6KhugFCtyjdgr16ybT7MM+Lpk5xMVGdzMEzZp34pOIDgt2Cuxwk0fj7zUl8xdgk55cKJ+oEvix2aRi3Jeki5wsUzIGARh4jmyl/1yxBj3TYviSuOqxdGT1+hseqXLpe9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=iitb.ac.in; spf=pass smtp.mailfrom=iitb.ac.in; dkim=pass (1024-bit key) header.d=iitb.ac.in header.i=@iitb.ac.in header.b=ssBB4zbd; arc=none smtp.client-ip=103.21.126.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=iitb.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iitb.ac.in Received: from ldns2.iitb.ac.in (ldns2.iitb.ac.in [10.200.12.2]) by smtp1.iitb.ac.in (Postfix) with SMTP id 11845104D0DE for <linux-kernel@vger.kernel.org>; Mon, 4 Mar 2024 11:23:44 +0530 (IST) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.iitb.ac.in 11845104D0DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iitb.ac.in; s=mail; t=1709531624; bh=h+kBNKpg6K7RtepCFQNzRMfkyN2SbsIJc7s8qriTZoc=; h=Date:From:To:Cc:Subject:From; b=ssBB4zbd4AbkulS5HsblTByt9Meyp/UyNfLpBQ9qZea/1sxd39M4RLv5fVK8NaD+A xEuHk2QQabRwJxWp+G2Jp++N3wyvzXPyYggNwv9VJQIFALjc9TRdnkOr78UY7cDBJH rqrJ5N2SjBmNzugKPveH78RxgX17n+ru3iSsmgNU= Received: (qmail 18002 invoked by uid 510); 4 Mar 2024 11:23:44 +0530 X-Qmail-Scanner-Diagnostics: from 10.200.1.25 by ldns2 (envelope-from <210100011@iitb.ac.in>, uid 501) with qmail-scanner-2.11 spamassassin: 3.4.1. mhr: 1.0. {clamdscan: 0.100.0/26337} Clear:RC:1(10.200.1.25):SA:0(0.0/7.0):. Processed in 3.489452 secs; 04 Mar 2024 11:23:44 +0530 X-Spam-Level: X-Spam-Pyzor: Reported 0 times. X-Envelope-From: 210100011@iitb.ac.in X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received: from unknown (HELO ldns2.iitb.ac.in) (10.200.1.25) by ldns2.iitb.ac.in with SMTP; 4 Mar 2024 11:23:40 +0530 Received: from wm1.iitb.ac.in (wm1.iitb.ac.in [10.200.17.1]) by ldns2.iitb.ac.in (Postfix) with ESMTP id 53C91341636; Mon, 4 Mar 2024 11:23:40 +0530 (IST) Received: from webmail-sso.iitb.ac.in (localhost [IPv6:::1]) by wm1.iitb.ac.in (Postfix) with ESMTP id 5115C608E11; Mon, 4 Mar 2024 11:23:40 +0530 (IST) Received: from [10.9.9.42] by webmail.iitb.ac.in with HTTP (HTTP/1.1 POST); Mon, 04 Mar 2024 11:23:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Date: Mon, 04 Mar 2024 11:23:40 +0530 From: Aman Sharma <210100011@iitb.ac.in> To: Gregkh <gregkh@linuxfoundation.org> Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] Staging: pi433: Updated bitrate range from datasheet Message-ID: <91454ef9b4a12f01e13d69b675d81aff@iitb.ac.in> X-Sender: 210100011@iitb.ac.in Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792573858681936018 X-GMAIL-MSGID: 1792573858681936018 |
Series |
[v2] Staging: pi433: Updated bitrate range from datasheet
|
|
Commit Message
Aman Sharma
March 4, 2024, 5:53 a.m. UTC
Updated bitrate range for FSK and OOK modulation from the RFM69
Datasheet.
The values are mentioned in Section 2.3.2 of the datasheet.
Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
---
drivers/staging/pi433/Documentation/pi433.txt | 6 ++++--
drivers/staging/pi433/TODO | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)
-* Some missing data (marked with ###) needs to be added in the
documentation
Comments
On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote: > Updated bitrate range for FSK and OOK modulation from the RFM69 Datasheet. > The values are mentioned in Section 2.3.2 of the datasheet. > > Signed-off-by: Aman Sharma<amansharma6122002@gmail.com> > --- > drivers/staging/pi433/Documentation/pi433.txt | 6 ++++-- > drivers/staging/pi433/TODO | 1 - > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/pi433/Documentation/pi433.txt > b/drivers/staging/pi433/Documentation/pi433.txt > index 4a0d34b4ad37..9ce7282ef6f8 100644 > --- a/drivers/staging/pi433/Documentation/pi433.txt > +++ b/drivers/staging/pi433/Documentation/pi433.txt > @@ -78,7 +78,8 @@ rf params: > Allowed values: 433050000...434790000 > bit_rate > bit rate used for transmission. > - Allowed values: ##### > + Allowed values (For FSK): 1200...320000 > + Allowed values (For OOK): 1200...32768 > dev_frequency > frequency deviation in case of FSK. > Allowed values: 600...500000 > @@ -169,7 +170,8 @@ rf params: > Allowed values: 433050000...434790000 > bit_rate > bit rate used for transmission. > - Allowed values: ##### > + Allowed values (For FSK): 1200...320000 > + Allowed values (For OOK): 1200...32768 > dev_frequency > frequency deviation in case of FSK. > Allowed values: 600...500000 > diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO > index 63a40bfcc67e..61ed3a1578bc 100644 > --- a/drivers/staging/pi433/TODO > +++ b/drivers/staging/pi433/TODO > @@ -2,4 +2,3 @@ > * still TODOs, annotated in the code > * currently the code introduces new IOCTLs. I'm afraid this is a bad idea. > -> Replace this with another interface, hints are welcome! > -* Some missing data (marked with ###) needs to be added in the > documentation > -- > 2.34.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote: > Updated bitrate range for FSK and OOK modulation from the RFM69 Datasheet. > The values are mentioned in Section 2.3.2 of the datasheet. Have you tested these as well? Sending untested patches is not necessarily against the rules, but it seems like maybe you have this hardware and can test it. Could you please talk about what testing you did? > > Signed-off-by: Aman Sharma<amansharma6122002@gmail.com> ^ Missing space. regards, dan carpenter
Tbh this is my first patch and I don't have the hardware to test this. I thought updating the values from the datasheet directly might be a good idea as it would be the correct range. Please correct me if there is something that I missed / need to know. On 2024-03-04 13:55, Dan Carpenter wrote: > On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote: >> Updated bitrate range for FSK and OOK modulation from the RFM69 >> Datasheet. >> The values are mentioned in Section 2.3.2 of the datasheet. > > Have you tested these as well? Sending untested patches is not > necessarily against the rules, but it seems like maybe you have this > hardware and can test it. Could you please talk about what testing you > did? > >> >> Signed-off-by: Aman Sharma<amansharma6122002@gmail.com> > ^ > Missing space. > I'll fix this if I am allowed to submit a new patch. > regards, > dan carpenter
On Mon, Mar 04, 2024 at 02:04:08PM +0530, Aman Sharma wrote: > Tbh this is my first patch and I don't have the hardware to test this. I > thought updating the values from the datasheet directly might be a good idea > as it would be the correct range. Please correct me if there is something > that I missed / need to know. > No, patch is fine. There is no downside to updating the .txt documentation in this way. I was just wondering. > On 2024-03-04 13:55, Dan Carpenter wrote: > > On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote: > > > Updated bitrate range for FSK and OOK modulation from the RFM69 > > > Datasheet. > > > The values are mentioned in Section 2.3.2 of the datasheet. > > > > Have you tested these as well? Sending untested patches is not > > necessarily against the rules, but it seems like maybe you have this > > hardware and can test it. Could you please talk about what testing you > > did? > > > > > > > > Signed-off-by: Aman Sharma<amansharma6122002@gmail.com> > > ^ > > Missing space. > > > > I'll fix this if I am allowed to submit a new patch. regards, dan carpenter
diff --git a/drivers/staging/pi433/Documentation/pi433.txt b/drivers/staging/pi433/Documentation/pi433.txt index 4a0d34b4ad37..9ce7282ef6f8 100644 --- a/drivers/staging/pi433/Documentation/pi433.txt +++ b/drivers/staging/pi433/Documentation/pi433.txt @@ -78,7 +78,8 @@ rf params: Allowed values: 433050000...434790000 bit_rate bit rate used for transmission. - Allowed values: ##### + Allowed values (For FSK): 1200...320000 + Allowed values (For OOK): 1200...32768 dev_frequency frequency deviation in case of FSK. Allowed values: 600...500000 @@ -169,7 +170,8 @@ rf params: Allowed values: 433050000...434790000 bit_rate bit rate used for transmission. - Allowed values: ##### + Allowed values (For FSK): 1200...320000 + Allowed values (For OOK): 1200...32768 dev_frequency frequency deviation in case of FSK. Allowed values: 600...500000 diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO index 63a40bfcc67e..61ed3a1578bc 100644 --- a/drivers/staging/pi433/TODO +++ b/drivers/staging/pi433/TODO @@ -2,4 +2,3 @@ * still TODOs, annotated in the code * currently the code introduces new IOCTLs. I'm afraid this is a bad idea. -> Replace this with another interface, hints are welcome!