Message ID | 20240301201837.2826172-1-samuel.holland@sifive.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-89072-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp133028dyc; Fri, 1 Mar 2024 12:18:54 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUg01Aylugh6dl1J1ujp+qkSf6TV43a9YNis3V47Ns4ca1GN9oZKD9m5rQ3qkVwlP1B9ty4enGQGem8jRljToXbYdHWGQ== X-Google-Smtp-Source: AGHT+IGl0yJtIDZLZAK1xs4zy0fKGXQNstDjAnBg6F7xB8j0kI2//dFdJQ1nn92jhdD58mA1+IDO X-Received: by 2002:a17:906:5786:b0:a43:6f6:e23d with SMTP id k6-20020a170906578600b00a4306f6e23dmr1930359ejq.38.1709324334465; Fri, 01 Mar 2024 12:18:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709324334; cv=pass; d=google.com; s=arc-20160816; b=cYEGgh6B1Xu7NN0HGwEp/o3m6pAgBG0F5fng1VS22lLsf6Dpp+u0yRg5mMhblQNvZm gLy+Ns5aHsxjK9iuoZ0aO2wrohorVKP0N3CPmOCSt+/xzJzEs+BMPX0g/Pny6DeWoG2P SyoPKizww2AZSsso4+iotS7+W63o7ydnPMgRX3FS86vtmI2Gh1350jaw6reZWmlIvYfm qvIMBtMoC8hSTjLCUuLItar3c2pqV0xZv+PtiXZyCq7hJYLJTqw4pyKn11/5T+mqwnsc BtkTe7g9Lr6xdBO0iZeVWxuzHvNpV0t+R68VyxEBACYfyUiNrIgEb2vNMHJh2d21YPP4 QGwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=LB21/Ow/29CKfiD0k0+EGFc0FZT6nL4Wg3LThQF2Bvw=; fh=PFQVM4NIeSSp5/2DyK2QUREmPN37IlD4eJjdcxMAucQ=; b=i8uYQa4fG9PyHkd6JkcE2cLM+2PleZDnurzkm4NOwC4DDeGFVfbot6dY5iABpe9vQT lI9jv5Yb9lx7i59j5iRAveOzwTV3/BYyauqAF1usQM55iCsOTdxLDDQzWkegS+9oRVLI tRp+tB0yg2AFoWAcdrA+kNX1pFaGI25hN14fC/hS6s8iZCdBvMlShrFHaj2Apv5bbePN wC7bgGx+DrkfLl9ChjBlLDSMQWThcrj0bIDxmYm+xHvPVEgrlelOPPzzaLKmL5209hjR T/NGy7jeMiBsc+4wxDXomYHdW/tCi4NScwb5IVguiCLPZE6oKzPrK6GjBjpXAZFJcKw1 fzAQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=PeJnQ3S0; arc=pass (i=1 spf=pass spfdomain=sifive.com dkim=pass dkdomain=sifive.com dmarc=pass fromdomain=sifive.com); spf=pass (google.com: domain of linux-kernel+bounces-89072-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89072-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h4-20020a1709063b4400b00a4432e5bd60si1713617ejf.848.2024.03.01.12.18.54 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 12:18:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89072-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=PeJnQ3S0; arc=pass (i=1 spf=pass spfdomain=sifive.com dkim=pass dkdomain=sifive.com dmarc=pass fromdomain=sifive.com); spf=pass (google.com: domain of linux-kernel+bounces-89072-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89072-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E3D241F25088 for <ouuuleilei@gmail.com>; Fri, 1 Mar 2024 20:18:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C534E3C6AB; Fri, 1 Mar 2024 20:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="PeJnQ3S0" Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606503C464 for <linux-kernel@vger.kernel.org>; Fri, 1 Mar 2024 20:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709324321; cv=none; b=QR2jfiTWLPI55W5uMYUGKXJgr46Mhw857jr84St2l5Nr2+aKGtxmdECHblWXfQdSFfIT1Zg/jZNkTRg3B3ay+87/K+ejuzo4IToa+1dkiBrmawgjpofwlO2eudJ9f4G0zfjlttKAIiM45bmG4ki0OTcI9UWVKqCwUWb+nxNyJu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709324321; c=relaxed/simple; bh=k8PnfdLlrbJCNs/j0R+9nMvSzfWV60dq0lhAeS4WAR8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Cu9WEC+WUCxF+ztffRvd+DX3qEwNd1VcJEGSqbUIkM3HR8d1q53oX8cwxxYm8QVhzdq/0FA+5wrnTE7gul8qg8uyHo4PILggTJo92QQwD/a6Ge8RvLGqjPnRVuDmzOBhglzicet/8QTq2C5bjNShuuoNH/Zm6RF7RE2P/1VZmlM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=PeJnQ3S0; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e55731af5cso2094463b3a.0 for <linux-kernel@vger.kernel.org>; Fri, 01 Mar 2024 12:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1709324318; x=1709929118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LB21/Ow/29CKfiD0k0+EGFc0FZT6nL4Wg3LThQF2Bvw=; b=PeJnQ3S0o6RiGQL2xjKg4U90kpuGk+8+VJ6wzwg2FyH0e3sgN37MPcyHlh0hNaBMhq lO/U3rHJ1+QxwYpp9Nykh8oKldkt2TWBSQjH4FUuhrhVz6J/RTOAwy+5HaDahQHqd7aP 9xs4lzZsfknAIOwRu4eQVAI3GXf1KZFtcgD+cdfJso2z3ZVjCL0T5+DWNWd5lCxxO6O2 fbVYG9TmBBQDE2+xV0mvUaEP4Apw9/YRv8jwqKnYj86tz8maIRPJfhTVFpY0Pg9RnUg3 MaYCsAeq0n9fLldxxyTuNeJd66IGkPKy/NU3dw21dUQCgjQhWE+1lxX3mVLAy4bDWqly RCOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709324318; x=1709929118; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LB21/Ow/29CKfiD0k0+EGFc0FZT6nL4Wg3LThQF2Bvw=; b=IZBGTfcujdvhsrWN4H45R+JKmGpvwcfxfNE4SYd/jaYhuAo+6taWIfBptozK9AW3uI qC0Jt9n9Q7gMx3uPzz++91dYUXMFVzXtmwI05J0Nx2w3H/5l7jOSaBTspUjteU7v96eq ufW3O1TWltNolSXK94bc8XjsghgDNTAaIfeBrqeBLhyeLcnM1Efupb+5gbrUOxatWjci 3JhA1tNWV1H/65pwQpBcVr7vIYHKMoIa3hvvwDjnADKwlRNH1HrGke9QT8W2UjrEQlBL 20YJ0ulo94c+TUN5HsbdMuSQyKWfb2fUFh2/J1MMrOYXhO8t+uYtDFnat5ZMGRoCAsjN pIYg== X-Forwarded-Encrypted: i=1; AJvYcCUbE7cf6/gqZ+bEH7TTGavVvoaHfARJBUQ7kLYzGsEkTAMpN0puLICnGOyroqqpQWLhEBqtmsIBY8bxW1Siy2x44cCnJI41JZ2XZZp0 X-Gm-Message-State: AOJu0YyMi0P0HFn/jmh6c7PMR5D5/4vPaA4Odur2rzPtciIany/QLJp+ xR6Tm9Nv4RNBSklHipHy/JOqjOBLby598Xq1CH9bPb/eAYYZQmJp2JHAaABll1g= X-Received: by 2002:a05:6a00:27a0:b0:6e4:f49f:bc9 with SMTP id bd32-20020a056a0027a000b006e4f49f0bc9mr3133223pfb.20.1709324318705; Fri, 01 Mar 2024 12:18:38 -0800 (PST) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id p26-20020aa79e9a000000b006e59688b828sm3364071pfq.19.2024.03.01.12.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 12:18:38 -0800 (PST) From: Samuel Holland <samuel.holland@sifive.com> To: linux-riscv@lists.infradead.org Cc: Samuel Holland <samuel.holland@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Alexandre Ghiti <alexghiti@rivosinc.com>, Andrew Jones <ajones@ventanamicro.com>, Anup Patel <apatel@ventanamicro.com>, Dylan Jhong <dylan@andestech.com>, Jisheng Zhang <jszhang@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Sergey Matyukevich <sergey.matyukevich@syntacore.com>, linux-kernel@vger.kernel.org Subject: [PATCH] riscv: mm: Fix prototype to avoid discarding const Date: Fri, 1 Mar 2024 12:18:32 -0800 Message-ID: <20240301201837.2826172-1-samuel.holland@sifive.com> X-Mailer: git-send-email 2.43.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792356473005402360 X-GMAIL-MSGID: 1792356473005402360 |
Series |
riscv: mm: Fix prototype to avoid discarding const
|
|
Commit Message
Samuel Holland
March 1, 2024, 8:18 p.m. UTC
__flush_tlb_range() does not modify the provided cpumask, so its cmask
parameter can be pointer-to-const. This avoids the unsafe cast of
cpu_online_mask.
Fixes: 54d7431af73e ("riscv: Add support for BATCHED_UNMAP_TLB_FLUSH")
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
---
arch/riscv/mm/tlbflush.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Fri, Mar 01, 2024 at 12:18:32PM -0800, Samuel Holland wrote: > __flush_tlb_range() does not modify the provided cpumask, so its cmask > parameter can be pointer-to-const. This avoids the unsafe cast of > cpu_online_mask. > > Fixes: 54d7431af73e ("riscv: Add support for BATCHED_UNMAP_TLB_FLUSH") > Signed-off-by: Samuel Holland <samuel.holland@sifive.com> > --- > > arch/riscv/mm/tlbflush.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c > index 893566e004b7..07d743f87b3f 100644 > --- a/arch/riscv/mm/tlbflush.c > +++ b/arch/riscv/mm/tlbflush.c > @@ -99,7 +99,7 @@ static void __ipi_flush_tlb_range_asid(void *info) > local_flush_tlb_range_asid(d->start, d->size, d->stride, d->asid); > } > > -static void __flush_tlb_range(struct cpumask *cmask, unsigned long asid, > +static void __flush_tlb_range(const struct cpumask *cmask, unsigned long asid, > unsigned long start, unsigned long size, > unsigned long stride) > { > @@ -200,7 +200,7 @@ void flush_tlb_range(struct vm_area_struct *vma, unsigned long start, > > void flush_tlb_kernel_range(unsigned long start, unsigned long end) > { > - __flush_tlb_range((struct cpumask *)cpu_online_mask, FLUSH_TLB_NO_ASID, > + __flush_tlb_range(cpu_online_mask, FLUSH_TLB_NO_ASID, > start, end - start, PAGE_SIZE); > } > > -- > 2.43.1 > Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c index 893566e004b7..07d743f87b3f 100644 --- a/arch/riscv/mm/tlbflush.c +++ b/arch/riscv/mm/tlbflush.c @@ -99,7 +99,7 @@ static void __ipi_flush_tlb_range_asid(void *info) local_flush_tlb_range_asid(d->start, d->size, d->stride, d->asid); } -static void __flush_tlb_range(struct cpumask *cmask, unsigned long asid, +static void __flush_tlb_range(const struct cpumask *cmask, unsigned long asid, unsigned long start, unsigned long size, unsigned long stride) { @@ -200,7 +200,7 @@ void flush_tlb_range(struct vm_area_struct *vma, unsigned long start, void flush_tlb_kernel_range(unsigned long start, unsigned long end) { - __flush_tlb_range((struct cpumask *)cpu_online_mask, FLUSH_TLB_NO_ASID, + __flush_tlb_range(cpu_online_mask, FLUSH_TLB_NO_ASID, start, end - start, PAGE_SIZE); }