diff mbox series

usb: dwc3: core: Add DWC31 version 2.00a controller

Message ID 20240301213554.7850-1-quic_wcheng@quicinc.com
State New
Headers
Series usb: dwc3: core: Add DWC31 version 2.00a controller |

Commit Message

Wesley Cheng March 1, 2024, 9:35 p.m. UTC 
  Add revision value for identifying DWC31 version 2.00a based controllers.

Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
---
 drivers/usb/dwc3/core.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg KH March 1, 2024, 9:45 p.m. UTC | #1 
On Fri, Mar 01, 2024 at 01:35:54PM -0800, Wesley Cheng wrote:
> Add revision value for identifying DWC31 version 2.00a based controllers.
> 
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
>  drivers/usb/dwc3/core.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index df544ec730d2..f3bbbc1947bd 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1259,6 +1259,7 @@ struct dwc3 {
>  #define DWC31_REVISION_170A	0x3137302a
>  #define DWC31_REVISION_180A	0x3138302a
>  #define DWC31_REVISION_190A	0x3139302a
> +#define DWC31_REVISION_200A	0x3230302a

What code uses this define?

Why add a define that is not used?

confused,

greg k-h
Wesley Cheng March 1, 2024, 10:47 p.m. UTC | #2 
Hi Greg,

On 3/1/2024 1:45 PM, Greg KH wrote:
> On Fri, Mar 01, 2024 at 01:35:54PM -0800, Wesley Cheng wrote:
>> Add revision value for identifying DWC31 version 2.00a based controllers.
>>
>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
>> ---
>>   drivers/usb/dwc3/core.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index df544ec730d2..f3bbbc1947bd 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -1259,6 +1259,7 @@ struct dwc3 {
>>   #define DWC31_REVISION_170A	0x3137302a
>>   #define DWC31_REVISION_180A	0x3138302a
>>   #define DWC31_REVISION_190A	0x3139302a
>> +#define DWC31_REVISION_200A	0x3230302a
> 
> What code uses this define?
> 

Don't think there is anything within the DWC3 core that would be 
different specifically for 2.00a versus previous revisions. (so far)

> Why add a define that is not used?
> 

There is a running list of all the DWC3 revisions.  Not all of them are 
being used, so my understanding was that we're just keeping track of all 
possible version values that can be read from the DWC3 version HW 
register.  If this is the not the case, maybe we can just leave this out 
until we find a need to add it.

Thanks
Wesley Cheng
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index df544ec730d2..f3bbbc1947bd 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1259,6 +1259,7 @@  struct dwc3 {
 #define DWC31_REVISION_170A	0x3137302a
 #define DWC31_REVISION_180A	0x3138302a
 #define DWC31_REVISION_190A	0x3139302a
+#define DWC31_REVISION_200A	0x3230302a
 
 #define DWC32_REVISION_ANY	0x0
 #define DWC32_REVISION_100A	0x3130302a