Message ID | 20240229-b4-for-v6-9-am65-beagleplay-ethernet-reset-v1-1-b3e4b33378bd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-87072-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp518010dyb; Thu, 29 Feb 2024 08:28:52 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWKRypLjkKMmXV6iK+GTeP/4zz1fJyBeaz6kbPANWMQJL9rwXoEbxb0cxnNAdSftor4XZ71u2mdoWikmLKDw7YN3p/uqg== X-Google-Smtp-Source: AGHT+IHggIWgjVZfvjTC8OBMRYadZXKFj3mzY+qVUZxazr0RwZ6WtAusppMQLAgEa1ea+X9+IkMC X-Received: by 2002:a62:ceca:0:b0:6e5:5116:2cb5 with SMTP id y193-20020a62ceca000000b006e551162cb5mr3779405pfg.15.1709224132278; Thu, 29 Feb 2024 08:28:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709224132; cv=pass; d=google.com; s=arc-20160816; b=a6LSlU6sK2zOACNHQ+DznI+EuHn12yodFohRIMjDdjLtsDECAXmMDxnwFrtBcCO1G8 DSDUE2Io8mARGXknX2iaVFai5H7NbH9eFhQgPHfH2RGTnwTdDdv82e4GWF/PCSX7jWDT saFVJJqSozip5sYcEbnIRDbJWMdK2jIhhb8lzNUz+AlFPdIZOwY3JtLy1Qu8T5o0nX+B K5mLSJGq7GUoHlY5lbExtUfVHfQdXkosYWBmyz1Y5sCJQDI6IPDzAJM4NAPFls2TfF/E TVTjhp9BJ5QPntfcmLmNP1kbVb9/NGpamYTIbbfr2/s/PUP8Jd4xAXSotjCWw5jVfMrb 2XMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=EUknNh1v/yUpbpDzrcYHpiOVQ8RCc22W5ZT3Xb41kBk=; fh=QGDb3Ha7qIS2Nz8WC0op/c5g7xTAiyiFW6x0OjjFI8w=; b=Vln7+v9N1AEZ2Xm4SzL86ZkxPDyaEw/HrfWZeegQ7Swub2vmlT5KDfxwJe9cP1WqKE 08KkpEMrTGMEDj8j9/XA8u+SrzAO1tjbsrjkmQY62uwbc+EI0h+kEeYDHVB+DCjfjLFX YGsEba1FD2ijUgbS/haWZCTMScyCYZ6TgU94zM4fLo/LqQtegoojV203bYkiaiTHMDFH wZzFXhMxaM1bun/Kl/OQz1cYaQdZxSu19wXPUK/I6LDjuayYGjGAPbnNHwmNfTk/EKmK EsHJ9ur40Sr849b21NDrNSVmhd4FnG4SzFG3HdQ0BMh+nEUvd8DU1lj5K66miletarsI bm2w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GZLgHfHd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-87072-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87072-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id v14-20020aa799ce000000b006e55f68d906si1538412pfi.319.2024.02.29.08.28.52 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 08:28:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87072-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GZLgHfHd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-87072-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87072-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 01BE428977D for <ouuuleilei@gmail.com>; Thu, 29 Feb 2024 16:28:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1FF7716062B; Thu, 29 Feb 2024 16:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GZLgHfHd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 267F26CBF7; Thu, 29 Feb 2024 16:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709223933; cv=none; b=for3YRKMW2tTI9C7DE/lyDmcs0d67qoHul+28CVEkBzABa+tarCSWbnHfRcuGNpVvTIchm0OqEIuu4T4dmu60bGEvyFCLZayk+Ck5GV/OFxEzrH5j2h+sb+uGQaJqmYCodWDs9AWyV0ryVDVo+po+x7UaOd16DuOrcsFGwG1a3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709223933; c=relaxed/simple; bh=4V6OlYJLg2D2ADjTGoW0ZIdepDQib6cN9BnQe1KUkgs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=JCo52qIJePbn8e2k6faIoPGlqAO590WulPvjPx/SDbNogLiLSDimBy8CV17JbixL486G6nlRPScD9lPSadZHWkAI3haQu8g9xltuLC6684kDsjpDNWlIwcc+KiQ4M2/6koW8d048H23Q2nOGf0esH0T+bE10Qa7SUsr87M5jgrM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GZLgHfHd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4AC6C43390; Thu, 29 Feb 2024 16:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709223932; bh=4V6OlYJLg2D2ADjTGoW0ZIdepDQib6cN9BnQe1KUkgs=; h=From:Date:Subject:To:Cc:From; b=GZLgHfHdzSDZATOabNXnku51/DMdtbXNqg834eIQlRHMbJQpyTu6bJ0it32ln7Czg L05lK4XjI5X4JlUOw13U9MsSSddCRxXuNu1mFijtMjYA6QMf26fWcR44aYpKnFUEft +O5itxPPnZy1pM3Nf3/V04FkkolCy/vhv2lY9OPlNORMnvte+FWgVDJCiZ85TvgqZz xPX8FAQcIGtYdOYBKG4PWvaxXI1qPqoLvwStoGVw5X+Rz3th/LsfwuGM5W6IeX+9PW pfoCnrnCDf4UZqwXi7Npfyv2vJYmTFhPUEddeEV0AjWcUya6DQQ1g8Ju3k3FxraEe2 u0sv5w3ZU+xAQ== From: Roger Quadros <rogerq@kernel.org> Date: Thu, 29 Feb 2024 18:25:15 +0200 Subject: [PATCH] arm: dts: ti: beagleplay: Fix Ethernet PHY RESET GPIOs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240229-b4-for-v6-9-am65-beagleplay-ethernet-reset-v1-1-b3e4b33378bd@kernel.org> X-B4-Tracking: v=1; b=H4sIAOqv4GUC/x2NwQqDMBAFf0X23IUYom36K8VD0r7ogo2yEWkR/ 72hl4G5zBxUoIJC9+YgxS5FllylvTT0nEIewfKqTtZYZ6z1HB2nRXnv2XN49x1HhHHGOocvY5u gGRsrSqXxt2SvLsXUdlSDqyLJ5z97DOf5A+0w5wt8AAAA To: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: srk@ti.com, s-vadapalli@ti.com, r-gunasekaran@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Roger Quadros <rogerq@kernel.org> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=2613; i=rogerq@kernel.org; h=from:subject:message-id; bh=4V6OlYJLg2D2ADjTGoW0ZIdepDQib6cN9BnQe1KUkgs=; b=owEBbQKS/ZANAwAIAdJaa9O+djCTAcsmYgBl4K/5VGgg0Szc8M2O7/ORpqD/Is7v/MAK0hNAO yZN9iblCjmJAjMEAAEIAB0WIQRBIWXUTJ9SeA+rEFjSWmvTvnYwkwUCZeCv+QAKCRDSWmvTvnYw kzl2D/9BPFAtmkgiacpXSs1V3058PyDLc+ehcKlCemroF4/f1teoqbZVV617xHmdgtCQgmlstNC JBAlD2bzSDeM3X+Lb5/6X1bVqDripAj6Co8mhJAE9BumkI0Vdi2kVel/H+tqQkwlCnzOHYT/Gfj 9sYYYXxP+IBJSkIqTw+QzLNqD24ya0wDNEj4LrYeqoBqsslyDKNN/tc4qyi6dWx0MH940sg2PUX qi/1pBxm7Cj0t5ddFkOeI7T2wsyGWfV2LrnnBSKvx0tht9DV0R1oWlPqL131uIv6oMpfuh0RB2M E+JFpytxkdL5YEpQKSLTWt+GRYDUWKBgvUW6w0LeGKvAAlgH2qdsmebSwQZ5NdIiHbJm8eAsfbJ 9sIuvLQAwk05bXyoJLPJKj5ja68OCqoPF2hxU0qQ9PY9JoXi+MJ2wMxdIePPzn/M/bW6kESnb5B 3qSD8/A6blQhAmwMEX0V356MuSYYN/dbl3jlWH/HNh9+37GELCz5QLwmodKlJKiHCDvJ1UVhOD/ PLrIhVWmFyB5OMTbCRQYvRG3qsORdw3b9ORDhtU6qlXsClRfmazCqcD0OmdJ3Gkf/EJw+LcJjJv Ox55dQtwV+5Y9KJvkc2MUj17IaEaSQTKI9sxhegOortp/djLKE/z8oXQgGHOaHD2lf0NIV1Hg4k 4gJ84c1Rye+34fg== X-Developer-Key: i=rogerq@kernel.org; a=openpgp; fpr=412165D44C9F52780FAB1058D25A6BD3BE763093 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792251403931128441 X-GMAIL-MSGID: 1792251403931128441 |
Series |
arm: dts: ti: beagleplay: Fix Ethernet PHY RESET GPIOs
|
|
Commit Message
Roger Quadros
Feb. 29, 2024, 4:25 p.m. UTC
The RESET GPIO pinmux should be part of MDIO bus node
so that they can be in the right state before the PHY
can be probed via MDIO bus scan.
Add GPIO reset for the Gigabit Ethernet PHY. As per
RTL8211F datasheet, reset assert width is 10ms and
PHY registers can be access accessed after 50ms of
reset deassert.
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
---
base-commit: bbef42084cc170cbfc035bf784f2ff055c939d7e
change-id: 20240229-b4-for-v6-9-am65-beagleplay-ethernet-reset-098f274fbf15
Best regards,
Comments
On 29/02/2024 18:25, Roger Quadros wrote: > The RESET GPIO pinmux should be part of MDIO bus node > so that they can be in the right state before the PHY > can be probed via MDIO bus scan. > > Add GPIO reset for the Gigabit Ethernet PHY. As per > RTL8211F datasheet, reset assert width is 10ms and > PHY registers can be access accessed after 50ms of > reset deassert. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > index a34e0df2ab86..77240cf3ae4d 100644 > --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > @@ -292,6 +292,8 @@ mdio0_pins_default: mdio0-default-pins { > pinctrl-single,pins = < > AM62X_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AD24) MDIO0_MDC */ > AM62X_IOPAD(0x015c, PIN_INPUT, 0) /* (AB22) MDIO0_MDIO */ > + AM62X_IOPAD(0x003c, PIN_INPUT, 7) /* (M25) GPMC0_AD0.GPIO0_15 */ This should be PIN_OUTPUT. Will fix in next spin. > + AM62X_IOPAD(0x018c, PIN_OUTPUT, 7) /* (AC21) RGMII2_RD2.GPIO1_5 */ > >; > }; > > @@ -383,7 +385,6 @@ AM62X_IOPAD(0x017c, PIN_INPUT, 1) /* (AD22) RGMII2_RX_CTL.RMII2_RX_ER */ > AM62X_IOPAD(0x016c, PIN_INPUT, 1) /* (Y18) RGMII2_TD0.RMII2_TXD0 */ > AM62X_IOPAD(0x0170, PIN_INPUT, 1) /* (AA18) RGMII2_TD1.RMII2_TXD1 */ > AM62X_IOPAD(0x0164, PIN_INPUT, 1) /* (AA19) RGMII2_TX_CTL.RMII2_TX_EN */ > - AM62X_IOPAD(0x018c, PIN_OUTPUT, 7) /* (AC21) RGMII2_RD2.GPIO1_5 */ > AM62X_IOPAD(0x0190, PIN_INPUT, 7) /* (AE22) RGMII2_RD3.GPIO1_6 */ > AM62X_IOPAD(0x01f0, PIN_OUTPUT, 5) /* (A18) EXT_REFCLK1.CLKOUT0 */ > >; > @@ -597,6 +598,9 @@ &cpsw3g_mdio { > > cpsw3g_phy0: ethernet-phy@0 { > reg = <0>; > + reset-gpios = <&main_gpio0 15 GPIO_ACTIVE_LOW>; > + reset-assert-us = <10000>; > + reset-deassert-us = <50000>; > }; > > cpsw3g_phy1: ethernet-phy@1 { > @@ -615,7 +619,7 @@ &main_gpio0 { > "USR0", "USR1", "USR2", "USR3", "", "", "USR4", /* 3-9 */ > "EEPROM_WP", /* 10 */ > "CSI2_CAMERA_GPIO1", "CSI2_CAMERA_GPIO2", /* 11-12 */ > - "CC1352P7_BOOT", "CC1352P7_RSTN", "", "", "", /* 13-17 */ > + "CC1352P7_BOOT", "CC1352P7_RSTN", "GBE_RSTN", "", "", /* 13-17 */ > "USR_BUTTON", "", "", "", "", "", "", "", "", /* 18-26 */ > "", "", "", "", "", "", "", "", "", "HDMI_INT", /* 27-36 */ > "", "VDD_WLAN_EN", "", "", "WL_IRQ", "GBE_INTN",/* 37-42 */ > > --- > base-commit: bbef42084cc170cbfc035bf784f2ff055c939d7e > change-id: 20240229-b4-for-v6-9-am65-beagleplay-ethernet-reset-098f274fbf15 > > Best regards,
On 01/03/2024 22:58, Roger Quadros wrote: > > > On 29/02/2024 18:25, Roger Quadros wrote: >> The RESET GPIO pinmux should be part of MDIO bus node >> so that they can be in the right state before the PHY >> can be probed via MDIO bus scan. >> >> Add GPIO reset for the Gigabit Ethernet PHY. As per >> RTL8211F datasheet, reset assert width is 10ms and >> PHY registers can be access accessed after 50ms of >> reset deassert. >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> >> --- >> arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >> index a34e0df2ab86..77240cf3ae4d 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >> @@ -292,6 +292,8 @@ mdio0_pins_default: mdio0-default-pins { >> pinctrl-single,pins = < >> AM62X_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AD24) MDIO0_MDC */ >> AM62X_IOPAD(0x015c, PIN_INPUT, 0) /* (AB22) MDIO0_MDIO */ >> + AM62X_IOPAD(0x003c, PIN_INPUT, 7) /* (M25) GPMC0_AD0.GPIO0_15 */ > > This should be PIN_OUTPUT. > Will fix in next spin. Actually PIN_INPUT is correct else we won't be able to read the correct GPIO pin status on gpio read. I observe this issue on u-boot at least. > >> + AM62X_IOPAD(0x018c, PIN_OUTPUT, 7) /* (AC21) RGMII2_RD2.GPIO1_5 */ This one needs to be fixed to PIN_INPUT. >> >; >> }; >> >> @@ -383,7 +385,6 @@ AM62X_IOPAD(0x017c, PIN_INPUT, 1) /* (AD22) RGMII2_RX_CTL.RMII2_RX_ER */ >> AM62X_IOPAD(0x016c, PIN_INPUT, 1) /* (Y18) RGMII2_TD0.RMII2_TXD0 */ >> AM62X_IOPAD(0x0170, PIN_INPUT, 1) /* (AA18) RGMII2_TD1.RMII2_TXD1 */ >> AM62X_IOPAD(0x0164, PIN_INPUT, 1) /* (AA19) RGMII2_TX_CTL.RMII2_TX_EN */ >> - AM62X_IOPAD(0x018c, PIN_OUTPUT, 7) /* (AC21) RGMII2_RD2.GPIO1_5 */ >> AM62X_IOPAD(0x0190, PIN_INPUT, 7) /* (AE22) RGMII2_RD3.GPIO1_6 */ >> AM62X_IOPAD(0x01f0, PIN_OUTPUT, 5) /* (A18) EXT_REFCLK1.CLKOUT0 */ >> >; >> @@ -597,6 +598,9 @@ &cpsw3g_mdio { >> >> cpsw3g_phy0: ethernet-phy@0 { >> reg = <0>; >> + reset-gpios = <&main_gpio0 15 GPIO_ACTIVE_LOW>; >> + reset-assert-us = <10000>; >> + reset-deassert-us = <50000>; >> }; >> >> cpsw3g_phy1: ethernet-phy@1 { >> @@ -615,7 +619,7 @@ &main_gpio0 { >> "USR0", "USR1", "USR2", "USR3", "", "", "USR4", /* 3-9 */ >> "EEPROM_WP", /* 10 */ >> "CSI2_CAMERA_GPIO1", "CSI2_CAMERA_GPIO2", /* 11-12 */ >> - "CC1352P7_BOOT", "CC1352P7_RSTN", "", "", "", /* 13-17 */ >> + "CC1352P7_BOOT", "CC1352P7_RSTN", "GBE_RSTN", "", "", /* 13-17 */ >> "USR_BUTTON", "", "", "", "", "", "", "", "", /* 18-26 */ >> "", "", "", "", "", "", "", "", "", "HDMI_INT", /* 27-36 */ >> "", "VDD_WLAN_EN", "", "", "WL_IRQ", "GBE_INTN",/* 37-42 */ >> >> --- >> base-commit: bbef42084cc170cbfc035bf784f2ff055c939d7e >> change-id: 20240229-b4-for-v6-9-am65-beagleplay-ethernet-reset-098f274fbf15 >> >> Best regards, >
Hi Roger, On 02/03/24 02:59, Roger Quadros wrote: > > > On 01/03/2024 22:58, Roger Quadros wrote: >> >> >> On 29/02/2024 18:25, Roger Quadros wrote: >>> The RESET GPIO pinmux should be part of MDIO bus node >>> so that they can be in the right state before the PHY >>> can be probed via MDIO bus scan. >>> >>> Add GPIO reset for the Gigabit Ethernet PHY. As per >>> RTL8211F datasheet, reset assert width is 10ms and >>> PHY registers can be access accessed after 50ms of >>> reset deassert. >>> >>> Signed-off-by: Roger Quadros <rogerq@kernel.org> >>> --- >>> arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >>> index a34e0df2ab86..77240cf3ae4d 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >>> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >>> @@ -292,6 +292,8 @@ mdio0_pins_default: mdio0-default-pins { >>> pinctrl-single,pins = < >>> AM62X_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AD24) MDIO0_MDC */ >>> AM62X_IOPAD(0x015c, PIN_INPUT, 0) /* (AB22) MDIO0_MDIO */ >>> + AM62X_IOPAD(0x003c, PIN_INPUT, 7) /* (M25) GPMC0_AD0.GPIO0_15 */ >> >> This should be PIN_OUTPUT. >> Will fix in next spin. > > Actually PIN_INPUT is correct else we won't be able to read the correct GPIO pin status > on gpio read. > I observe this issue on u-boot at least. > >> >>> + AM62X_IOPAD(0x018c, PIN_OUTPUT, 7) /* (AC21) RGMII2_RD2.GPIO1_5 */ > > This one needs to be fixed to PIN_INPUT. While at it, please fix the $subject prefix: arm64: dts: ti: beagleplay: ... Do we need a Fixes: Tag too? > >>> >; >>> }; >>> >>> @@ -383,7 +385,6 @@ AM62X_IOPAD(0x017c, PIN_INPUT, 1) /* (AD22) RGMII2_RX_CTL.RMII2_RX_ER */ >>> AM62X_IOPAD(0x016c, PIN_INPUT, 1) /* (Y18) RGMII2_TD0.RMII2_TXD0 */ >>> AM62X_IOPAD(0x0170, PIN_INPUT, 1) /* (AA18) RGMII2_TD1.RMII2_TXD1 */ >>> AM62X_IOPAD(0x0164, PIN_INPUT, 1) /* (AA19) RGMII2_TX_CTL.RMII2_TX_EN */ >>> - AM62X_IOPAD(0x018c, PIN_OUTPUT, 7) /* (AC21) RGMII2_RD2.GPIO1_5 */ >>> AM62X_IOPAD(0x0190, PIN_INPUT, 7) /* (AE22) RGMII2_RD3.GPIO1_6 */ >>> AM62X_IOPAD(0x01f0, PIN_OUTPUT, 5) /* (A18) EXT_REFCLK1.CLKOUT0 */ >>> >; >>> @@ -597,6 +598,9 @@ &cpsw3g_mdio { >>> >>> cpsw3g_phy0: ethernet-phy@0 { >>> reg = <0>; >>> + reset-gpios = <&main_gpio0 15 GPIO_ACTIVE_LOW>; >>> + reset-assert-us = <10000>; >>> + reset-deassert-us = <50000>; >>> }; >>> >>> cpsw3g_phy1: ethernet-phy@1 { >>> @@ -615,7 +619,7 @@ &main_gpio0 { >>> "USR0", "USR1", "USR2", "USR3", "", "", "USR4", /* 3-9 */ >>> "EEPROM_WP", /* 10 */ >>> "CSI2_CAMERA_GPIO1", "CSI2_CAMERA_GPIO2", /* 11-12 */ >>> - "CC1352P7_BOOT", "CC1352P7_RSTN", "", "", "", /* 13-17 */ >>> + "CC1352P7_BOOT", "CC1352P7_RSTN", "GBE_RSTN", "", "", /* 13-17 */ >>> "USR_BUTTON", "", "", "", "", "", "", "", "", /* 18-26 */ >>> "", "", "", "", "", "", "", "", "", "HDMI_INT", /* 27-36 */ >>> "", "VDD_WLAN_EN", "", "", "WL_IRQ", "GBE_INTN",/* 37-42 */ >>> >>> --- >>> base-commit: bbef42084cc170cbfc035bf784f2ff055c939d7e >>> change-id: 20240229-b4-for-v6-9-am65-beagleplay-ethernet-reset-098f274fbf15 >>> >>> Best regards, >> >
diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts index a34e0df2ab86..77240cf3ae4d 100644 --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts @@ -292,6 +292,8 @@ mdio0_pins_default: mdio0-default-pins { pinctrl-single,pins = < AM62X_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AD24) MDIO0_MDC */ AM62X_IOPAD(0x015c, PIN_INPUT, 0) /* (AB22) MDIO0_MDIO */ + AM62X_IOPAD(0x003c, PIN_INPUT, 7) /* (M25) GPMC0_AD0.GPIO0_15 */ + AM62X_IOPAD(0x018c, PIN_OUTPUT, 7) /* (AC21) RGMII2_RD2.GPIO1_5 */ >; }; @@ -383,7 +385,6 @@ AM62X_IOPAD(0x017c, PIN_INPUT, 1) /* (AD22) RGMII2_RX_CTL.RMII2_RX_ER */ AM62X_IOPAD(0x016c, PIN_INPUT, 1) /* (Y18) RGMII2_TD0.RMII2_TXD0 */ AM62X_IOPAD(0x0170, PIN_INPUT, 1) /* (AA18) RGMII2_TD1.RMII2_TXD1 */ AM62X_IOPAD(0x0164, PIN_INPUT, 1) /* (AA19) RGMII2_TX_CTL.RMII2_TX_EN */ - AM62X_IOPAD(0x018c, PIN_OUTPUT, 7) /* (AC21) RGMII2_RD2.GPIO1_5 */ AM62X_IOPAD(0x0190, PIN_INPUT, 7) /* (AE22) RGMII2_RD3.GPIO1_6 */ AM62X_IOPAD(0x01f0, PIN_OUTPUT, 5) /* (A18) EXT_REFCLK1.CLKOUT0 */ >; @@ -597,6 +598,9 @@ &cpsw3g_mdio { cpsw3g_phy0: ethernet-phy@0 { reg = <0>; + reset-gpios = <&main_gpio0 15 GPIO_ACTIVE_LOW>; + reset-assert-us = <10000>; + reset-deassert-us = <50000>; }; cpsw3g_phy1: ethernet-phy@1 { @@ -615,7 +619,7 @@ &main_gpio0 { "USR0", "USR1", "USR2", "USR3", "", "", "USR4", /* 3-9 */ "EEPROM_WP", /* 10 */ "CSI2_CAMERA_GPIO1", "CSI2_CAMERA_GPIO2", /* 11-12 */ - "CC1352P7_BOOT", "CC1352P7_RSTN", "", "", "", /* 13-17 */ + "CC1352P7_BOOT", "CC1352P7_RSTN", "GBE_RSTN", "", "", /* 13-17 */ "USR_BUTTON", "", "", "", "", "", "", "", "", /* 18-26 */ "", "", "", "", "", "", "", "", "", "HDMI_INT", /* 27-36 */ "", "VDD_WLAN_EN", "", "", "WL_IRQ", "GBE_INTN",/* 37-42 */