Message ID | 20240222-x1e80100-display-refactor-connector-v2-1-bd4197dfceab@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-76832-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp40584dyb; Thu, 22 Feb 2024 08:08:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV5qOCkU2ElWmjZig43EnFkCQxbLevRYktdnN8GVwPGXC2lIX6Mq+mWOBk1rh/LF38oycqvX3P2YAQd1iaKGEm8LSHcIw== X-Google-Smtp-Source: AGHT+IFNKQM+HDUbZWiU9MLmud8bmPiEJoA+aW4kGsiBkhV5rQpM7+80oFGd2pY/PKqzWweD7imO X-Received: by 2002:a17:902:f608:b0:1dc:4649:43df with SMTP id n8-20020a170902f60800b001dc464943dfmr3430159plg.16.1708618083837; Thu, 22 Feb 2024 08:08:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708618083; cv=pass; d=google.com; s=arc-20160816; b=Rqn8uU6/MP+AJUurjop0GXEEdtZBQ926uGlDRsmciofZRhiJ/sbpkb3qN1KjPhbVKv vBBqERyv95TAArhnd270OmC6Znipokx2RajklHjzg2E//zipC73uF8rLD62CwoanIudR Rfg5UYrZXK6D8FdAeVpFYL1y4WLuoFfvzxgd7SAno/tXoc9eVB6C1GMYP0BY0gjdiMbQ 86c5hwQ4wDa3FlwFW8paZr32J2dPlb8RhE1JfAmwX/Ma6Rrm7fzM06DCCE7A4rZPrbqQ ComC05VLLhbzVstQEfPSyGEE4CIciffBBoCcyd8U64ZHH4Ef8N4FPcHiPdA4Otfqe9t5 5F4w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=E/qRBGuntVpmUEzLsJY9ZgDe9uMSJ+xK+pvUdRKBs80=; fh=zUa0i64VWengp3jXMcE9JNkDnq25Ei/Y43X9YtDcp5s=; b=lvoEBksg7W5WIzlTnxIP1CFvW9VG9NPT1DdXDRogM5BO7ygx/idfPRQBPzrPYO/L/n FrXkP6weqw1/z5V7f0JXtQVYO6qF7UPeS5f1W+p5mfctQYV7yWXydzHTids6OXR/RNUU 3+FeiGqvnamL7UwMdjgFP0asGaYnmIATtZn86hIgFCLUraOOnA8Bkk8//FFx6D4G7XKO zSeEcqzRaeotZzg5HfyPMHqybnfkw94ZR+NqZbXGcN6CE7pi3nprD1PpT9o9McN4FMSW TPXvD/cHk+NUIMjd+uDEB8bflKmlD+rrjwDIVu8/gZrenN5kTv5Kr80MuQLRQx0nzHM+ mZzQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DY0XJ066; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-76832-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76832-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x5-20020a170902a38500b001dc4a8abc0dsi1619010pla.532.2024.02.22.08.08.03 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 08:08:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76832-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DY0XJ066; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-76832-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76832-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C3F66B23821 for <ouuuleilei@gmail.com>; Thu, 22 Feb 2024 15:57:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 06634155A34; Thu, 22 Feb 2024 15:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DY0XJ066" Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD711552FD for <linux-kernel@vger.kernel.org>; Thu, 22 Feb 2024 15:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708617325; cv=none; b=DigbGZlV+CGDMzuvCqvw5K8icag6lD1lDkVUc7qu6OeWYB93TaqOrQ++iMxPL70ILRJ/yGovoTXKSrjIQNUeRZJjGdMCpO5QOj4lwWw35eJKfEtwbFPSKhYltHpSFu8GUJqc0KZthAclFYZxl4vV0J9aZ9LmyLNgVFPMPYleFsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708617325; c=relaxed/simple; bh=Dgy4bpUuD1DREK8e21cUFvAnpbWONI5ldnxfYKMR5OM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZvksjeWnxvaeKTVnk8iGbgusLSll8+N8nBDTBa45du3aTx2T5sMmuW96iLXpb6I4ZPbjO78BOh2MXM4C8KfKCP4rh3LqBS5/H2UhMjVk61SuGzdyot5q1xTFS2l7fI8EvSogppDvO587Jx0G7s96sEqC9OK74k/He9FnflbAb1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DY0XJ066; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5655c7dd3b1so3326a12.0 for <linux-kernel@vger.kernel.org>; Thu, 22 Feb 2024 07:55:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708617322; x=1709222122; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E/qRBGuntVpmUEzLsJY9ZgDe9uMSJ+xK+pvUdRKBs80=; b=DY0XJ066AfvRj3f1eMJAXQcCxwcKgjOtNikrLXir1UFMYpBEWxvBsDYpBelSmii40b SYE6jfOuNq8NMN5H2W2Q6m4kmMND4C61eWA4ehYmeWVGnYiGZz0+oHmHDsWuAJ9jBudX DyY1wv05QTFHw9KxcmYzu4v0zBFrUHYJOwltx6HGhSf7db+Y5OcZHgz/sIEXTxLBX4bH uLAaxiymOeiP921f8zBDVXGv6kC7GpFrGJjGWvk4id4bdWsuYEKIf2uA8vPRM+bo++Xx MwRK1A0v/N2WYi4OwZUF8U4T1e/rzbs9U4HZplcISABxrCfCAQJRfZ1CEak2slesLTrn Fsfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708617322; x=1709222122; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E/qRBGuntVpmUEzLsJY9ZgDe9uMSJ+xK+pvUdRKBs80=; b=nbA9RaDKS3cboYyJsw8DIHPNXMGhwKYFOcWHfYZBMGYUvCrdP0r0AHBdz+sm4AmfK7 xjeu9lFS+RX+R1AJuRfId9IoWgkSoZsVu19Q9IVPUrEaOtol/uVFoMngXGzzpjdUPSIb gTVJxVhI6N+oZ41FK5xOrzl7GKWl4wV8YICmnGHVCEfYKwbgLHMYKsDHSVjjKP/pFDnr qGUvEhEeYZLtqvqJUDt8QYTrt6nEtHCJFL79r2tmh2tEJ4j8PA2u9t7wJm55lU5nVRss V/jkmxbuo7t8wik0ojmPqZLCqKsio5fb0he7zCWQDnIru2UdJ/3HmZ+yQUtX0NkmT1SP UALQ== X-Forwarded-Encrypted: i=1; AJvYcCVgMNE8BOl/kMeAl38fJ6nbqrkpPal3dPRBtRLRO/wNsFuT/si6Hw5iIR+LMMSwkggGeTEIdBwGXNAmNJO8ndwNqVnpgJq3KUKdUhzz X-Gm-Message-State: AOJu0YyajUbZfTuK3k9usxys8O/BVVObkodN/KmGYg3hHd6D/72pfgml Mb1IpZ34foEaTKKC0g3oQOTGCIKKQS3ensoWCcOyLWH+9TW4BvoLBCIiaMCwLLU= X-Received: by 2002:a05:6402:2021:b0:565:2e3d:d019 with SMTP id ay1-20020a056402202100b005652e3dd019mr2162738edb.4.1708617322526; Thu, 22 Feb 2024 07:55:22 -0800 (PST) Received: from [127.0.1.1] ([188.24.162.93]) by smtp.gmail.com with ESMTPSA id v7-20020aa7dbc7000000b00564e489ce9asm1924247edt.12.2024.02.22.07.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 07:55:22 -0800 (PST) From: Abel Vesa <abel.vesa@linaro.org> Date: Thu, 22 Feb 2024 17:55:06 +0200 Subject: [PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240222-x1e80100-display-refactor-connector-v2-1-bd4197dfceab@linaro.org> References: <20240222-x1e80100-display-refactor-connector-v2-0-bd4197dfceab@linaro.org> In-Reply-To: <20240222-x1e80100-display-refactor-connector-v2-0-bd4197dfceab@linaro.org> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, Marijn Suijten <marijn.suijten@somainline.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Kuogee Hsieh <quic_khsieh@quicinc.com>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Johan Hovold <johan@kernel.org> Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org> X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1194; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=Dgy4bpUuD1DREK8e21cUFvAnpbWONI5ldnxfYKMR5OM=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBl125jCxw4MKZFiUZh/ZMZdfvjY3Y2ijItoeR8X VZAumqDoGKJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZdduYwAKCRAbX0TJAJUV VlncD/9HrYnh9zrnKbDIebEbauG+1baUus8l4qSrbAb3Ntl5fGjkgkHqpD0pJVXqSEEjIfuopAk OLIagSfkQ190FupimhKKkBGDvpAVfTolpJufGbLXwcfaZ424E6QMJX4oaCklqX8b06EfyGF9aMN We96I77voVT4JkfrOyCAT8G/sCjah2cpGEO9nYywBm1XvKB5wFwa4hqHxgiqG/XjHCDPhIIrQei Mqp8WclHbx4jmx+jQc8ylDL9ojoPcBaqsRF870nfQl8kSRDE/BUhI+E0Rt+eX4hDu0o9ILclAzT pyDbEm4VkcYK6hQaK8Juz7+tAM7ysu9C2FGghCehIutP6NCafWW9JYuMBdZ3EV4Ha+Ia7QDI6Vt CLGQesCQwn6fXf9L5rjPvbbGKj1CpB/dJDB6yE33Ox0+6VyQeQ6V8Unds3DZ7eY7LKWnhvqqVb6 kAiBZ0mtQYB3b44nQ9Gq+gQbcfsXCQAZj/anTDfqncIblK4rWG/jIegTi23oZTK33r6UjD3Pl2T 39Wy/JhacD0bK8ACs4kXk0nIcR2/lNLiTUh9N3rRhT5wt8NUJoj0tB+wVf2Yk5Urs8EBYvRj1Ne XhniW6npGnqpE5q60USEHV7Cgd+R/i/xrSGqCgnd3fR5ZAWsL810t0lsC2RdK7OAap+JgQuHxbn tt1FGK0P8RVK+Qw== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791615915876940240 X-GMAIL-MSGID: 1791615915876940240 |
Series |
drm/msm/dp: Rework the eDP/DP modes and add support for X1E80100
|
|
Commit Message
Abel Vesa
Feb. 22, 2024, 3:55 p.m. UTC
Add the X1E80100 to the list of compatibles and document the is-edp
flag. The controllers are expected to operate in DP mode by default,
and this flag can be used to select eDP mode.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On Thu, 22 Feb 2024 at 17:55, Abel Vesa <abel.vesa@linaro.org> wrote: > > Add the X1E80100 to the list of compatibles and document the is-edp > flag. The controllers are expected to operate in DP mode by default, > and this flag can be used to select eDP mode. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Rob, Krzysztof, Connor, gracious ping for the review. It would be really nice to merge this patchset during the next cycle. It also unbreaks several other patches. > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index ae53cbfb2193..ed11852e403d 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -27,6 +27,7 @@ properties: > - qcom,sdm845-dp > - qcom,sm8350-dp > - qcom,sm8650-dp > + - qcom,x1e80100-dp > - items: > - enum: > - qcom,sm8150-dp > @@ -73,6 +74,11 @@ properties: > - description: phy 0 parent > - description: phy 1 parent > > + is-edp: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Tells the controller to switch to eDP mode > + > phys: > maxItems: 1 > > > -- > 2.34.1 >
On 24/02/2024 23:34, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 17:55, Abel Vesa <abel.vesa@linaro.org> wrote: >> >> Add the X1E80100 to the list of compatibles and document the is-edp >> flag. The controllers are expected to operate in DP mode by default, >> and this flag can be used to select eDP mode. >> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > Rob, Krzysztof, Connor, gracious ping for the review. It would be > really nice to merge this patchset during the next cycle. It also > unbreaks several other patches. That's not a netdev... or do you have the same subsystem profile expecting reviews *from everyone* within two days? Best regards, Krzysztof
On 22/02/2024 16:55, Abel Vesa wrote: > Add the X1E80100 to the list of compatibles and document the is-edp > flag. The controllers are expected to operate in DP mode by default, > and this flag can be used to select eDP mode. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index ae53cbfb2193..ed11852e403d 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -27,6 +27,7 @@ properties: > - qcom,sdm845-dp > - qcom,sm8350-dp > - qcom,sm8650-dp > + - qcom,x1e80100-dp > - items: > - enum: > - qcom,sm8150-dp > @@ -73,6 +74,11 @@ properties: > - description: phy 0 parent > - description: phy 1 parent > > + is-edp: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Tells the controller to switch to eDP mode DP controller cannot be edp, so property "is-edp" is confusing. Probably you want to choose some phy mode, so you should rather use "phy-mode" property. I am sure we've been here... Anyway, if you define completely new property without vendor prefix, that's a generic property, so you need to put it in some common schema for all Display Controllers, not only Qualcomm. Best regards, Krzysztof
On Sun, Feb 25, 2024 at 12:34:34AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 17:55, Abel Vesa <abel.vesa@linaro.org> wrote: > > > > Add the X1E80100 to the list of compatibles and document the is-edp > > flag. The controllers are expected to operate in DP mode by default, > > and this flag can be used to select eDP mode. > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > Rob, Krzysztof, Connor, gracious ping for the review. It would be > really nice to merge this patchset during the next cycle. It also > unbreaks several other patches. The only thing that speeds up my review is reviewing whatever is ahead of this patch in the queue[1]. Rob [1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/
On Tue, Feb 27, 2024 at 04:45:25PM +0100, Krzysztof Kozlowski wrote: > On 22/02/2024 16:55, Abel Vesa wrote: > > Add the X1E80100 to the list of compatibles and document the is-edp > > flag. The controllers are expected to operate in DP mode by default, > > and this flag can be used to select eDP mode. > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index ae53cbfb2193..ed11852e403d 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -27,6 +27,7 @@ properties: > > - qcom,sdm845-dp > > - qcom,sm8350-dp > > - qcom,sm8650-dp > > + - qcom,x1e80100-dp > > - items: > > - enum: > > - qcom,sm8150-dp > > @@ -73,6 +74,11 @@ properties: > > - description: phy 0 parent > > - description: phy 1 parent > > > > + is-edp: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Tells the controller to switch to eDP mode > > > DP controller cannot be edp, so property "is-edp" is confusing. Probably > you want to choose some phy mode, so you should rather use "phy-mode" > property. I am sure we've been here... phy-mode belongs in the phy node though. Not that you couldn't look in the phy node and see, but everyone likes all the properties they need nicely packaged up in their driver's node. > Anyway, if you define completely new property without vendor prefix, > that's a generic property, so you need to put it in some common schema > for all Display Controllers, not only Qualcomm. I'm trying to unsee what the driver is doing... Hard-coding the connector type and some instance indices. Uhhhh! I'm sure I'm to blame for rejecting those in DT. I've suggested connector nodes in the past. More generally, whatever is attached at the other end (as it could be a bridge rather than a connector) knows what mode is needed. It's simple negotiation. Each end presents what they support. You take the union of the list(s) and get the mode. If there's more than one, then the kernel or user gets to choose. Qualcomm is not the only one with this problem. Solve it for everyone... Rob
On 24-02-27 16:45:25, Krzysztof Kozlowski wrote: > On 22/02/2024 16:55, Abel Vesa wrote: > > Add the X1E80100 to the list of compatibles and document the is-edp > > flag. The controllers are expected to operate in DP mode by default, > > and this flag can be used to select eDP mode. > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index ae53cbfb2193..ed11852e403d 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -27,6 +27,7 @@ properties: > > - qcom,sdm845-dp > > - qcom,sm8350-dp > > - qcom,sm8650-dp > > + - qcom,x1e80100-dp > > - items: > > - enum: > > - qcom,sm8150-dp > > @@ -73,6 +74,11 @@ properties: > > - description: phy 0 parent > > - description: phy 1 parent > > > > + is-edp: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Tells the controller to switch to eDP mode > > > DP controller cannot be edp, so property "is-edp" is confusing. Probably > you want to choose some phy mode, so you should rather use "phy-mode" > property. I am sure we've been here... phy-mode in controller node or in the phy node? > > Anyway, if you define completely new property without vendor prefix, > that's a generic property, so you need to put it in some common schema > for all Display Controllers, not only Qualcomm. I can re-spin with qcom,is-edp if that's better. > > > Best regards, > Krzysztof >
On Fri, 1 Mar 2024 at 19:52, Rob Herring <robh@kernel.org> wrote: > > On Tue, Feb 27, 2024 at 04:45:25PM +0100, Krzysztof Kozlowski wrote: > > On 22/02/2024 16:55, Abel Vesa wrote: > > > Add the X1E80100 to the list of compatibles and document the is-edp > > > flag. The controllers are expected to operate in DP mode by default, > > > and this flag can be used to select eDP mode. > > > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > > --- > > > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > index ae53cbfb2193..ed11852e403d 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > @@ -27,6 +27,7 @@ properties: > > > - qcom,sdm845-dp > > > - qcom,sm8350-dp > > > - qcom,sm8650-dp > > > + - qcom,x1e80100-dp > > > - items: > > > - enum: > > > - qcom,sm8150-dp > > > @@ -73,6 +74,11 @@ properties: > > > - description: phy 0 parent > > > - description: phy 1 parent > > > > > > + is-edp: > > > + $ref: /schemas/types.yaml#/definitions/flag > > > + description: > > > + Tells the controller to switch to eDP mode > > > > > > DP controller cannot be edp, so property "is-edp" is confusing. Probably > > you want to choose some phy mode, so you should rather use "phy-mode" > > property. I am sure we've been here... > > phy-mode belongs in the phy node though. Not that you couldn't look in > the phy node and see, but everyone likes all the properties they need > nicely packaged up in their driver's node. > > > Anyway, if you define completely new property without vendor prefix, > > that's a generic property, so you need to put it in some common schema > > for all Display Controllers, not only Qualcomm. Is there a generic schema for DisplayPort controllers? I think there is none at this point. We can probably add it, declaring is-edp property, link-frequencies, etc. However Mediatek already uses a different option to specify supported link frequencies. > > I'm trying to unsee what the driver is doing... Hard-coding the > connector type and some instance indices. Uhhhh! I'm sure I'm to blame > for rejecting those in DT. Once this patchset is accepted (in this or that or whatever else form), we will cleanup most of those hardcoded types. > > I've suggested connector nodes in the past. More generally, whatever is > attached at the other end (as it could be a bridge rather than a > connector) knows what mode is needed. It's simple negotiation. Each end > presents what they support. You take the union of the list(s) and get > the mode. If there's more than one, then the kernel or user gets to > choose. It's not that easy. First, probing of the bridge chain differs slightly depending on whether the controller is eDP or DP controller. eDP should use AUX BUS, while DP (currently) doesn't use it. More importantly, error conditions differ too. For example, in the DP case it is perfectly fine to have nothing attached to the controller. It just means that the display chain needs no additional handling and the HPD pin will be handled by the controller itself. In the eDP case if neither a panel nor a bridge are attached, it is considered to be an error and thus the driver will return probe error. > Qualcomm is not the only one with this problem. Solve it for everyone...
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index ae53cbfb2193..ed11852e403d 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -27,6 +27,7 @@ properties: - qcom,sdm845-dp - qcom,sm8350-dp - qcom,sm8650-dp + - qcom,x1e80100-dp - items: - enum: - qcom,sm8150-dp @@ -73,6 +74,11 @@ properties: - description: phy 0 parent - description: phy 1 parent + is-edp: + $ref: /schemas/types.yaml#/definitions/flag + description: + Tells the controller to switch to eDP mode + phys: maxItems: 1