diff mbox series

[v3,1/4] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains requirement

Message ID 20240228-asrc_8qxp-v3-1-d4d5935fd3aa@nxp.com
State New
Headers
Series arm64: dts: imx8qxp add asrc and sai |

Commit Message

Frank Li Feb. 28, 2024, 7:14 p.m. UTC 
  Add power-domains property for asrc and spdif.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml | 3 +++
 Documentation/devicetree/bindings/sound/fsl,spdif.yaml    | 3 +++
 2 files changed, 6 insertions(+)

Comments

Krzysztof Kozlowski Feb. 29, 2024, 9:44 a.m. UTC | #1 
On 28/02/2024 20:14, Frank Li wrote:
> Add power-domains property for asrc and spdif.

Why?

You keep adding this all over the tree without explanations. Why
suddenly old hardware became part of power domain?

Best regards,
Krzysztof
Frank Li March 1, 2024, 4:01 a.m. UTC | #2 
On Thu, Feb 29, 2024 at 10:44:20AM +0100, Krzysztof Kozlowski wrote:
> On 28/02/2024 20:14, Frank Li wrote:
> > Add power-domains property for asrc and spdif.
> 
> Why?

i.MX8QXP i.MX8DXL and i.MX8QM need it.

> 
> You keep adding this all over the tree without explanations. Why
> suddenly old hardware became part of power domain?

This part upstreamed earlier than dts part. Because dependency eDMAv3 have
not upstreamed for the long time. I just upstreamed eDMAv3 support
recently. So I can start upstream dts part. So I find binding doc missed it
when do dtb_check.

Frank

> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski March 1, 2024, 6:30 a.m. UTC | #3 
On 01/03/2024 05:01, Frank Li wrote:
> On Thu, Feb 29, 2024 at 10:44:20AM +0100, Krzysztof Kozlowski wrote:
>> On 28/02/2024 20:14, Frank Li wrote:
>>> Add power-domains property for asrc and spdif.
>>
>> Why?
> 
> i.MX8QXP i.MX8DXL and i.MX8QM need it.

Where is it explained in the commit msg? What about other devices/variants?


Best regards,
Krzysztof
Frank Li March 1, 2024, 3:42 p.m. UTC | #4 
On Fri, Mar 01, 2024 at 07:30:10AM +0100, Krzysztof Kozlowski wrote:
> On 01/03/2024 05:01, Frank Li wrote:
> > On Thu, Feb 29, 2024 at 10:44:20AM +0100, Krzysztof Kozlowski wrote:
> >> On 28/02/2024 20:14, Frank Li wrote:
> >>> Add power-domains property for asrc and spdif.
> >>
> >> Why?
> > 
> > i.MX8QXP i.MX8DXL and i.MX8QM need it.
> 
> Where is it explained in the commit msg? What about other devices/variants?

I will add it. These patches are for imx8qxp\imx8dxl\imx8qm only. If other
platform have problem, it should be fixed by new patch. 

> 
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski March 4, 2024, 3:05 p.m. UTC | #5 
On 01/03/2024 16:42, Frank Li wrote:
> On Fri, Mar 01, 2024 at 07:30:10AM +0100, Krzysztof Kozlowski wrote:
>> On 01/03/2024 05:01, Frank Li wrote:
>>> On Thu, Feb 29, 2024 at 10:44:20AM +0100, Krzysztof Kozlowski wrote:
>>>> On 28/02/2024 20:14, Frank Li wrote:
>>>>> Add power-domains property for asrc and spdif.
>>>>
>>>> Why?
>>>
>>> i.MX8QXP i.MX8DXL and i.MX8QM need it.
>>
>> Where is it explained in the commit msg? What about other devices/variants?
> 
> I will add it. These patches are for imx8qxp\imx8dxl\imx8qm only. If other
> platform have problem, it should be fixed by new patch. 

I would assume more responsible approach from NXP, not just "their
problem", but anyway that's not what the comment is. Why do you say all
the variants have power domains in one commit, but now in email says
that they might not have? All your patches are vague in this aspect.

Best regards,
Krzysztof
Frank Li March 4, 2024, 3:39 p.m. UTC | #6 
On Mon, Mar 04, 2024 at 04:05:07PM +0100, Krzysztof Kozlowski wrote:
> On 01/03/2024 16:42, Frank Li wrote:
> > On Fri, Mar 01, 2024 at 07:30:10AM +0100, Krzysztof Kozlowski wrote:
> >> On 01/03/2024 05:01, Frank Li wrote:
> >>> On Thu, Feb 29, 2024 at 10:44:20AM +0100, Krzysztof Kozlowski wrote:
> >>>> On 28/02/2024 20:14, Frank Li wrote:
> >>>>> Add power-domains property for asrc and spdif.
> >>>>
> >>>> Why?
> >>>
> >>> i.MX8QXP i.MX8DXL and i.MX8QM need it.
> >>
> >> Where is it explained in the commit msg? What about other devices/variants?
> > 
> > I will add it. These patches are for imx8qxp\imx8dxl\imx8qm only. If other
> > platform have problem, it should be fixed by new patch. 
> 
> I would assume more responsible approach from NXP, not just "their
> problem", but anyway that's not what the comment is. Why do you say all
> the variants have power domains in one commit, but now in email says
> that they might not have? All your patches are vague in this aspect.

I am not means "their problem". What's I said is one patch just fix one
thing. If need additional fix,  I can create a new patches. I have not said
all need power domains specifically. If there are some words that let me
think all variant need power domain, please let me where, I can improve it.

Frank
> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
index bfef2fcb75b14..98616507e3c10 100644
--- a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
+++ b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
@@ -74,6 +74,9 @@  properties:
       - const: asrck_f
       - const: spba
 
+  power-domains:
+    maxItems: 1
+
   fsl,asrc-rate:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: The mutual sample rate used by DPCM Back Ends
diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
index 1d64e8337aa4b..82430f1d5e5a2 100644
--- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
+++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
@@ -86,6 +86,9 @@  properties:
       registers. Set this flag for HCDs with big endian descriptors and big
       endian registers.
 
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg