diff mbox series

scsi: efct: Fix possible memleak in efct_device_init()

Message ID 20221111074046.57061-1-chenzhongjin@huawei.com
State New
Headers
Series scsi: efct: Fix possible memleak in efct_device_init() |

Commit Message

Chen Zhongjin Nov. 11, 2022, 7:40 a.m. UTC 
  In efct_device_init(), when efct_scsi_reg_fc_transport() fails,
efct_scsi_tgt_driver_exit() is not called to release memory for
efct_scsi_tgt_driver_init() and causes memleak:

unreferenced object 0xffff8881020ce000 (size 2048):
  comm "modprobe", pid 465, jiffies 4294928222 (age 55.872s)
  backtrace:
    [<0000000021a1ef1b>] kmalloc_trace+0x27/0x110
    [<000000004c3ed51c>] target_register_template+0x4fd/0x7b0 [target_core_mod]
    [<00000000f3393296>] efct_scsi_tgt_driver_init+0x18/0x50 [efct]
    [<00000000115de533>] 0xffffffffc0d90011
    [<00000000d608f646>] do_one_initcall+0xd0/0x4e0
    [<0000000067828cf1>] do_init_module+0x1cc/0x6a0
    ...

Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
---
 drivers/scsi/elx/efct/efct_driver.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin K. Petersen Nov. 26, 2022, 12:19 a.m. UTC | #1 
Chen,

> In efct_device_init(), when efct_scsi_reg_fc_transport() fails,
> efct_scsi_tgt_driver_exit() is not called to release memory for
> efct_scsi_tgt_driver_init() and causes memleak:

Applied to 6.2/scsi-staging, thanks!
Martin K. Petersen Dec. 1, 2022, 3:45 a.m. UTC | #2 
On Fri, 11 Nov 2022 15:40:46 +0800, Chen Zhongjin wrote:

> In efct_device_init(), when efct_scsi_reg_fc_transport() fails,
> efct_scsi_tgt_driver_exit() is not called to release memory for
> efct_scsi_tgt_driver_init() and causes memleak:
> 
> unreferenced object 0xffff8881020ce000 (size 2048):
>   comm "modprobe", pid 465, jiffies 4294928222 (age 55.872s)
>   backtrace:
>     [<0000000021a1ef1b>] kmalloc_trace+0x27/0x110
>     [<000000004c3ed51c>] target_register_template+0x4fd/0x7b0 [target_core_mod]
>     [<00000000f3393296>] efct_scsi_tgt_driver_init+0x18/0x50 [efct]
>     [<00000000115de533>] 0xffffffffc0d90011
>     [<00000000d608f646>] do_one_initcall+0xd0/0x4e0
>     [<0000000067828cf1>] do_init_module+0x1cc/0x6a0
>     ...
> 
> [...]

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: efct: Fix possible memleak in efct_device_init()
      https://git.kernel.org/mkp/scsi/c/bb0cd225dd37
diff mbox series

Patch

diff --git a/drivers/scsi/elx/efct/efct_driver.c b/drivers/scsi/elx/efct/efct_driver.c
index b08fc8839808..49fd2cfed70c 100644
--- a/drivers/scsi/elx/efct/efct_driver.c
+++ b/drivers/scsi/elx/efct/efct_driver.c
@@ -42,6 +42,7 @@  efct_device_init(void)
 
 	rc = efct_scsi_reg_fc_transport();
 	if (rc) {
+		efct_scsi_tgt_driver_exit();
 		pr_err("failed to register to FC host\n");
 		return rc;
 	}