Message ID | 20240229134724.1353903-3-christophe.roullier@foss.st.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-86775-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp404987dyb; Thu, 29 Feb 2024 05:49:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVNlKl1ofpAtciT8gsTA9EVWnUBwB10SgI2xCzZIGiTP/xevm1KWZeFK+nl3DDNnk4E7Ey1nMqkdnxpWI6/debS6SSZcg== X-Google-Smtp-Source: AGHT+IFv/xfQFCYUFCrRbjStBNRfI90yEONNsalgX7jzQrM9LwfvyCSIaczd+A3+khMw76fIf7LC X-Received: by 2002:a17:903:25d6:b0:1dc:226d:d85f with SMTP id jc22-20020a17090325d600b001dc226dd85fmr2032118plb.69.1709214565743; Thu, 29 Feb 2024 05:49:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709214565; cv=pass; d=google.com; s=arc-20160816; b=hzMc9Hiqwh9eImgkzKbHvFfsC0oVNeJ/OHctAlh9BYLvyBEkVGYovVdrdtAZo27IQy OlQbf3jNW8xYnz/ilLj+lEYJTyhUfkBJmxNi8/VQzdCXkVbiRl2OCXtrfv7azKCwWH4J AahhplXung4LYYVs2Z+v/nKCLBOTXLlU6pKnr2Kevtc329sVM9vc1l54GBbBxCtzxayG Y8M5c0ujVmSvm0cPEP83z3sB9NUgHKNy+57/r77quQjIY80DF8626UMdqZn6i59CpLzM YcAXEiF7pjiPOah+sWuQS7CmzkwcpBTwi6jHdmarh9tiAgCEcyiFkGne+nI1UDqUZun4 LN7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=PNmumkbr1ax1y/K5cCKHgfDeQwZWzifckds6A8d+eoY=; fh=Nrq3/ZyqAmcldX4TnYQJDytRSUiD1vJeQNniXh+eWjo=; b=Gb24F6xzG5XcOnxdRkucokfFlNryxBM8+hY0W5SpKgI4GvQKhAbbjAjGboCLuX+m2+ /zvLDZL8+BNFQIAnD0lrgahqsPBGospRmDz/ZuIKeUGOW9RiQq8WGGVE7Q8KisZPBWOa HWwA6uUKPDLfCmC7CJ32Ilkwd6tJvIhR/ImtBcsxwWmWRzvGeZZFU6tarIfNGflY0ad4 eE1dv9vcWRuraqdk22y1vuhfsFto0J1RyYOfg6sCFdZ2bn67QOo2cNfohiUQxn0kbhwN 6Zh+8Zbg70MaDtKv2kIciOTEkeKZhnaY6qZvPo3IIfn30EzNwgmqOoNFhzrk7eLiGUI2 wXLA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=Bc6+frUR; arc=pass (i=1 spf=pass spfdomain=foss.st.com dkim=pass dkdomain=foss.st.com dmarc=pass fromdomain=foss.st.com); spf=pass (google.com: domain of linux-kernel+bounces-86775-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86775-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x5-20020a170902ec8500b001dc88bed194si1379841plg.21.2024.02.29.05.49.25 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 05:49:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-86775-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=Bc6+frUR; arc=pass (i=1 spf=pass spfdomain=foss.st.com dkim=pass dkdomain=foss.st.com dmarc=pass fromdomain=foss.st.com); spf=pass (google.com: domain of linux-kernel+bounces-86775-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86775-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 34211B222AF for <ouuuleilei@gmail.com>; Thu, 29 Feb 2024 13:49:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE97212EBD1; Thu, 29 Feb 2024 13:49:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="Bc6+frUR" Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 344BA62808; Thu, 29 Feb 2024 13:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709214545; cv=none; b=EmEuRxgwHSgqGMcueXDuodAOWVdLVG2i78DvzBqUtWAkeRdDlVncEBhgavTuYGqpSKtxSd1kKAP9mmAHGbeGTUCMbXq4YklM7hynm/XN7OgQXIKZ+thetwRowsv6RcyWOzcT7P16RaxF30JFhNMaNmuWVCHkVDQK1HRzNiNc1Hk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709214545; c=relaxed/simple; bh=PT6thhGwV8a6x/GJTFO6n9c0DQeUab0GqSnmK+Ht/AQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rqu9g+7TrsdD6OwUkxFHljrdbmK7DNx9PRQj5rOeCr1UTxtbfzzRkj6bRxWc6WsarjveQi7S/Z2gzNHH5lTZCH0kiTYEjS09KIrxcuDZpBRi+qNgiN9BIla3xX/i/yz0yA/PStavVfOkUvdOxMBqp8TeP6VxSIe7lb8kOq5nMZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=Bc6+frUR; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41TAIv8s014612; Thu, 29 Feb 2024 14:48:30 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= selector1; bh=PNmumkbr1ax1y/K5cCKHgfDeQwZWzifckds6A8d+eoY=; b=Bc 6+frURoIYZspnY4pIeyq+iflh2eouJ+SzFfev2qkSuIJyxatB9naEvbs7m4D78CM jB1qBrXJbPzHRMzYnFdzhU36u6VHlt3jx0Du38pcWLGpNR7C6HHmD74rgIq7f2FP 3yNv6eP65PHxYcrhpQe7S4YvYImglmRS2/U4x50h9KTMbZNZ52VQJtgGZAkiF4Zw rta2/UkaY1HbReeW8NbSlI2u5i78gXIotYqCCF8Y+jhrz9nK08HeGn57qUkl/zBX mBJDUwEl0Lmt3Yce75WZcdzEXFKmfUU8ZKD2Gvu1eICGBco6FzV06Kvio1j5RiNq DzX2confWhFZDmRDAbVg== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3whf4bjr35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Feb 2024 14:48:30 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 2D63C4002D; Thu, 29 Feb 2024 14:48:27 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 277CD26C46B; Thu, 29 Feb 2024 14:47:46 +0100 (CET) Received: from localhost (10.201.21.128) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 29 Feb 2024 14:47:45 +0100 From: Christophe Roullier <christophe.roullier@foss.st.com> To: "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Richard Cochran <richardcochran@gmail.com>, Jose Abreu <joabreu@synopsys.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Christophe Roullier <christophe.roullier@foss.st.com> CC: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH 2/2] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32 Date: Thu, 29 Feb 2024 14:47:24 +0100 Message-ID: <20240229134724.1353903-3-christophe.roullier@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240229134724.1353903-1-christophe.roullier@foss.st.com> References: <20240229134724.1353903-1-christophe.roullier@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-29_02,2024-02-29_01,2023-05-22_02 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792241372229957272 X-GMAIL-MSGID: 1792241372229957272 |
Series |
Add properties in dwmac-stm32 documentation
|
|
Commit Message
Christophe Roullier
Feb. 29, 2024, 1:47 p.m. UTC
Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz
This property can be used with RMII phy without cristal 50Mhz and when we
want to select RCC clock instead of ETH_REF_CLK
Can be used also with RGMII phy with no cristal and we select RCC clock
instead of ETH_CLK125
This new property replace st,eth-clk-sel and st,eth-ref-clk-sel
Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com>
---
Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
Comments
On 29/02/2024 14:47, Christophe Roullier wrote: > Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz > This property can be used with RMII phy without cristal 50Mhz and when we > want to select RCC clock instead of ETH_REF_CLK > Can be used also with RGMII phy with no cristal and we select RCC clock > instead of ETH_CLK125 > This new property replace st,eth-clk-sel and st,eth-ref-clk-sel You miss full stops everywhere. What I don't get is why you decided to deprecate above - no explanation why. Also no implementation and nothing here mentions that you document existing property, but commit msg actually suggests adding new property. If new, then where is any user of this in following patch? Best regards, Krzysztof
On Thu, Feb 29, 2024 at 02:47:24PM +0100, Christophe Roullier wrote: > Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz > This property can be used with RMII phy without cristal 50Mhz and when we > want to select RCC clock instead of ETH_REF_CLK > Can be used also with RGMII phy with no cristal and we select RCC clock > instead of ETH_CLK125 > This new property replace st,eth-clk-sel and st,eth-ref-clk-sel That is obvious from the diff. What is not obvious is why we need a new property and what is the problem with the existing ones. > > Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> > --- > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > index 80937b28fa046..fda23c07c1cad 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > @@ -85,12 +85,21 @@ properties: > phy-supply: > description: PHY regulator > > + st,ext-phyclk: > + description: > + set this property in RMII mode when you have PHY without crystal 50MHz and want to > + select RCC clock instead of ETH_REF_CLK. OR in RGMII mode when you want to select > + RCC clock instead of ETH_CLK125. > + type: boolean > + > st,eth-clk-sel: > + deprecated: true > description: > set this property in RGMII PHY when you want to select RCC clock instead of ETH_CLK125. > type: boolean > > st,eth-ref-clk-sel: > + deprecated: true > description: > set this property in RMII mode when you have PHY without crystal 50MHz and want to > select RCC clock instead of ETH_REF_CLK. > -- > 2.25.1 >
diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml index 80937b28fa046..fda23c07c1cad 100644 --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml @@ -85,12 +85,21 @@ properties: phy-supply: description: PHY regulator + st,ext-phyclk: + description: + set this property in RMII mode when you have PHY without crystal 50MHz and want to + select RCC clock instead of ETH_REF_CLK. OR in RGMII mode when you want to select + RCC clock instead of ETH_CLK125. + type: boolean + st,eth-clk-sel: + deprecated: true description: set this property in RGMII PHY when you want to select RCC clock instead of ETH_CLK125. type: boolean st,eth-ref-clk-sel: + deprecated: true description: set this property in RMII mode when you have PHY without crystal 50MHz and want to select RCC clock instead of ETH_REF_CLK.