[net-next,v6,07/11] dt-bindings: net: hisi-femac: replace deprecated phy-mode with recommended phy-connection-type
Message ID | 20240228-net-v6-7-6d78d3d598c1@outlook.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-84727-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp3222946dyb; Wed, 28 Feb 2024 01:06:27 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVzMtcKbc7cI8Dv2Xp8tVHdxxgOF4Fh3DWDQK5Xk+60dr7Y6dEMpQ/MjooW8iB0T4PYOHbX0gKfbcO2ehpkOC4paEnEVw== X-Google-Smtp-Source: AGHT+IHvsK0YiKSUzdn3xxDQXY18ZdD+ryMGQY4UqxnhVTAvEaONOX/3sWvRyQSNMCPvsXBUgiE9 X-Received: by 2002:ad4:5bc7:0:b0:68f:ef81:dbb5 with SMTP id t7-20020ad45bc7000000b0068fef81dbb5mr5055625qvt.26.1709111187453; Wed, 28 Feb 2024 01:06:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709111187; cv=pass; d=google.com; s=arc-20160816; b=VYVlDadSJq+u3mRwumvrMV17FY3XJvPZe4noFgB0R9I4xD4hFyk7pTiH4HGSywp4Hx M6902Z6zP/HvVrot4bBbdATAcAHxI35t1zYkyh1/CTmQ3SsSiR+ItTF5s4lFeyPcmDiR OHhEZVU9tLn65vtDO5GlKlvFa05rxcwdYrOAgH/YRZRSXRdqQKbU8XavZ1+wHoql1X+a tG2f3vlPm5+sV6JA5fv+P3pnRmSrxi6pdvM5wG4VpGiQeuvnpmcA9dXPHVgJYK7sNYBs ia3H16GlKJ8I4ZOBKw50HJhWhV0l9HNiucZiBl5ZTVOn4PyS74fVQEbCHDy3uZsII1j8 x34A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:date:from:dkim-signature; bh=umGP5U47qksgTgkiHqqMmT2FjpmfsdTi5Asp0L4Au8w=; fh=xf53zEEwO8UfwqXA8rNDXb86USgBpvamfpvPadu/NTs=; b=cVrxGIlh8xuwVKizN6ngwGD4iX0fMIiJ34DcwSnNzgQ4sZoYwcXl68cojuA3GrSUgb J49gyAIznd7I63rbr35JWWgbYTempwoqcEmpwnFYyv1+JWAHXBnnPNt+RgKqwnpULCdW bGPFz8hdnWszG1aaR7b5FFqm8GzisLBLbOsZK1/Kb0AqeIOPoDp9kxHIzAKxJeqLiAU+ 9HIuE8Uxy1gQccGqcrQDmmMvRBeXYK6DPQ/oqZpfwS66X2z91oHeVEQiGNlrGuy7wI1A MK00K6cso3MJSeXdo/zmf2QBt4NbCCs9wYi4grixjMEXAW/4V6WcFVewSw/EVCpyFJts 2qGQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TxXoc0Eo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-84727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84727-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ge7-20020a05621427c700b0068fa7211a44si9220865qvb.3.2024.02.28.01.06.27 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 01:06:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TxXoc0Eo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-84727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84727-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3DB1B1C213BB for <ouuuleilei@gmail.com>; Wed, 28 Feb 2024 09:06:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6869481AB; Wed, 28 Feb 2024 09:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TxXoc0Eo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D22531A83; Wed, 28 Feb 2024 09:02:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709110947; cv=none; b=dg56972apL/Ju2Dl7501nxLLVC4iUby264Fll14zjAF1w3YOwmjh56TpcnRjCJmljah5pYZ18qHMK7PfgVKeRRijUTDmGmGrk+97vFQdIu/8PXkgB1LxGeERusGnnoxtdshWXDBo0EQS6Lr6YaufiVyCz6L0YPMDVQM1M8ur89U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709110947; c=relaxed/simple; bh=AwiWhyYYPQ6J5Nsxc1RcXcfAeBDJwdSxCWFxnx8UpOE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L0iQA0MYenj0Gbf3zVvAlU+cIRbwAODbT3FbVCA2D3mwIhh2hjIjSczcx82BmsDHwn5Ti8TWKeIBGWHKgtuycdq7BR0aqPl54lXoCk/GDTP6cv9PB3q3jMBTbQvlNJgmI0KYDtSC2EJKZF00JL3lX8vHACnM3DWgM52XE9VLtVU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TxXoc0Eo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id EB21EC4167E; Wed, 28 Feb 2024 09:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709110947; bh=AwiWhyYYPQ6J5Nsxc1RcXcfAeBDJwdSxCWFxnx8UpOE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=TxXoc0EoB29C+ytOFAg+pPsjhb+xBC0jvwepynh3cX7mMnlIg5/h8qEs8K0KZkxjP 2oO4igRgVtceE5KwMf8iTNccByS9bufsyICws3sA4d9+amE09GLLlO5+OEoFyIB2Dy +ZVG7UlY9xRxAkHfugCqz8wjENQeT8C0VUq3VBpLygLXSYU2MQR6KNi+7JK7RJtuVo GEIfuP9rXJlH5lr2rUD07ZmGwyjdC+emCItOn6G2uiniqFbG77v4/o1TcRGTzKqXwt 4aO2y/aMM1H/bRAiArLEkyDLjY0iYxAoz2Om4zYD+ZcwTRA71XtsWHC+ThbqBRMlnY xv5arJzybeZHw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB361C54E55; Wed, 28 Feb 2024 09:02:26 +0000 (UTC) From: Yang Xiwen via B4 Relay <devnull+forbidden405.outlook.com@kernel.org> Date: Wed, 28 Feb 2024 17:02:31 +0800 Subject: [PATCH net-next v6 07/11] dt-bindings: net: hisi-femac: replace deprecated phy-mode with recommended phy-connection-type Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240228-net-v6-7-6d78d3d598c1@outlook.com> References: <20240228-net-v6-0-6d78d3d598c1@outlook.com> In-Reply-To: <20240228-net-v6-0-6d78d3d598c1@outlook.com> To: Yisen Zhuang <yisen.zhuang@huawei.com>, Salil Mehta <salil.mehta@huawei.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Yang Xiwen <forbidden405@outlook.com> X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1709110945; l=1121; i=forbidden405@outlook.com; s=20240228; h=from:subject:message-id; bh=UkM6cazLUUcGm7V+UelgyTmRZYNnC9CwRUbl7j+gA44=; b=f5Z5JfMhFzIZrioziMkhpJB/CbSksX9sZDGw/4dP0dQYJHzTEaL2jb0GFBOtYQQ1738WyKZ4X GWICiPgPUFOCNGnp3xFLFHiUbPWx0lzBribGIcCjE8z3ivD+rsr8FPV X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=KAWv6ZzFsT54MGllOczJgFiWB+DuayEmyn24iiVVThU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20240228 with auth_id=136 X-Original-From: Yang Xiwen <forbidden405@outlook.com> Reply-To: <forbidden405@outlook.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792132972104098674 X-GMAIL-MSGID: 1792132972104098674 |
Series |
net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles
|
|
Commit Message
Yang Xiwen via B4 Relay
Feb. 28, 2024, 9:02 a.m. UTC
From: Yang Xiwen <forbidden405@outlook.com> The old property "phy-mode" should be replaced with the latest "phy-connection-type". Signed-off-by: Yang Xiwen <forbidden405@outlook.com> --- Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > The old property "phy-mode" should be replaced with the latest > "phy-connection-type". Why? The old property is not deprecated. Best regards, Krzysztof
On 2/29/2024 4:08 PM, Krzysztof Kozlowski wrote: > On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote: >> From: Yang Xiwen <forbidden405@outlook.com> >> >> The old property "phy-mode" should be replaced with the latest >> "phy-connection-type". > > Why? The old property is not deprecated. The old property is just a $ref to the new property. While at it, i would like to update it as well. Since there is no real user in mainline yet, this update does not need to keep dts sync. I would expect it(the old property) to be deprecated in the future. > > > > Best regards, > Krzysztof >
On 29/02/2024 09:12, Yang Xiwen wrote: > On 2/29/2024 4:08 PM, Krzysztof Kozlowski wrote: >> On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote: >>> From: Yang Xiwen <forbidden405@outlook.com> >>> >>> The old property "phy-mode" should be replaced with the latest >>> "phy-connection-type". >> >> Why? The old property is not deprecated. > > The old property is just a $ref to the new property. While at it, i > would like to update it as well. It does not mean which property is preferred. Please provide some context why this change should be done. > > Since there is no real user in mainline yet, this update does not need > to keep dts sync. I would expect it(the old property) to be deprecated > in the future. Best regards, Krzysztof
On Wed, Feb 28, 2024 at 05:02:31PM +0800, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > The old property "phy-mode" should be replaced with the latest > "phy-connection-type". In practice, phy-mode is typically used, and phy-connection-type is not used much. All new user tend to be phy-mode. ~/linux$ grep -r phy-mode arch/* | wc 1561 6258 113122 ~/linux$ grep -r phy-connection-type arch/* | wc 372 1489 28981 Most of the phy-connection-type appear in PowerPC. ~/linux$ grep -r phy-connection-type arch/powerpc/* | wc 247 990 18335 It was the early adopter of DT, long before ARM. The DT standard of the time, which PowerPC followed, said to use phy-connection-type. When ARM started using DT, it did not follow the standard too well, and phy-mode got used a lot. Officially, phy-mode is deprecated because it is not part of the standard. But practice does not always follow the standard. So both are O.K, all the generic code accepts both, and there is no real reason to change. Andrew
diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml index ba207f2c9ae4..6c5888897876 100644 --- a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml @@ -66,7 +66,7 @@ required: - clocks - resets - reset-names - - phy-mode + - phy-connection-type - phy-handle - hisilicon,phy-reset-delays-us @@ -83,7 +83,7 @@ examples: resets = <&crg 0xec 0>, <&crg 0xec 3>; reset-names = "mac", "phy"; mac-address = [00 00 00 00 00 00]; - phy-mode = "mii"; + phy-connection-type = "mii"; phy-handle = <&fephy>; hisilicon,phy-reset-delays-us = <10000 20000 20000>; };