[1/6] arm64: dts: qcom: msm8996: fix sound card reset line polarity

Message ID 20221027074652.1044235-1-dmitry.torokhov@gmail.com
State New
Headers
Series [1/6] arm64: dts: qcom: msm8996: fix sound card reset line polarity |

Commit Message

Dmitry Torokhov Oct. 27, 2022, 7:46 a.m. UTC
  When resetting the block, the reset line is being driven low and then
high, which means that the line in DTS should be annotated as "active
low". It will become important when wcd9335 driver will be converted
to gpiod API that respects declared line polarities.

Fixes: f3eb39a55a1f ("arm64: dts: db820c: Add sound card support")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Bjorn Andersson Nov. 7, 2022, 3:12 a.m. UTC | #1
On Thu, 27 Oct 2022 00:46:47 -0700, Dmitry Torokhov wrote:
> When resetting the block, the reset line is being driven low and then
> high, which means that the line in DTS should be annotated as "active
> low". It will become important when wcd9335 driver will be converted
> to gpiod API that respects declared line polarities.
> 
> 

Applied, thanks!

[1/6] arm64: dts: qcom: msm8996: fix sound card reset line polarity
      commit: 76d21ffc5d425bf7ea9888652c49d7dbda15f356
[3/6] arm64: dts: qcom: sm8250-mtp: fix reset line polarity
      commit: 15d9fcbb3e6e8420c7d1ae331405780c5d9c1c25
[4/6] arm64: dts: qcom: sc7280: fix codec reset line polarity for CRD 3.0/3.1
      commit: 1caf66104c02d327a2467a69ab18fb24b44e9715
[5/6] arm64: dts: qcom: sc7280: fix codec reset line polarity for CRD 1.0/2.0
      commit: b8f298d4f69d82119ac0d22809a17c80b1f188d1

Best regards,
  
Mark Brown Nov. 25, 2022, 9:28 p.m. UTC | #2
On Thu, 27 Oct 2022 00:46:47 -0700, Dmitry Torokhov wrote:
> When resetting the block, the reset line is being driven low and then
> high, which means that the line in DTS should be annotated as "active
> low". It will become important when wcd9335 driver will be converted
> to gpiod API that respects declared line polarities.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[2/6] ASoC: dt-bindings: wcd9335: fix reset line polarity in example
      commit: 34cb111f8a7b98b5fec809dd194003bca20ef1b2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 5ff8de3e3de7..d5271718d03c 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -3354,7 +3354,7 @@  wcd9335: codec@1,0 {
 					interrupt-names = "intr1", "intr2";
 					interrupt-controller;
 					#interrupt-cells = <1>;
-					reset-gpios = <&tlmm 64 GPIO_ACTIVE_HIGH>;
+					reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
 
 					slim-ifc-dev = <&tasha_ifd>;