Message ID | 20240223-yuv-v2-7-aa6be2827bb7@bootlin.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-78240-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp525012dyb; Fri, 23 Feb 2024 03:40:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVT4tVkVidiKjKrvmZjEo1hJP6LLqjgzFTa6mNY/sEkCoQVlE6VQxoVIwFouLo1anKnZFGgaUYscNvZM9iSoQsKYmvuhA== X-Google-Smtp-Source: AGHT+IH8h/y3iB5YyaBi6FzPKFHhIskvNJnv2uFhdz46NKGIII2cmtrTBWDxBwSx1sR39kpIv4eZ X-Received: by 2002:a17:902:ec8a:b0:1db:bd10:7855 with SMTP id x10-20020a170902ec8a00b001dbbd107855mr1825344plg.9.1708688430225; Fri, 23 Feb 2024 03:40:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708688430; cv=pass; d=google.com; s=arc-20160816; b=pVBQk2skZERG1DzQFeg5Mtmm2QkDjThugTX+KokXG/NxXmnyhJsQJN8G7P+pccN8Ty SIhCiCe1MhV7nK+/WD+AkRgjzui0d3ru4KY88/bu4w8R29pocl1UG0WU02W+LFyIv9yJ 2sENtDB7fCtx4vpwQ/fIhDCDSdQJ5QqVHeuPqHyqUVV7kq9veKVEwccMw0+rjjUT/Qt8 eu6IeHFnDpI+GYfrpM472z4RGFOYhp0O6Ut3BLgmqaENiUHl4S9YyCDhSUTrqqa21m4m aF45UbuIycD2HJV2is7EUF/GkdmvzGSOW3W6SJJDUNKkvXFFqbT0K0bz9wfJFGww5DkG zlhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=hFcELKdEH2CqVcdv8HdPB42K6t4+ILioqNSm5RowIZQ=; fh=iHhInxAKO971yxjXRXHdZ2xJcC9kj/+DtynTqxKEQCo=; b=y5igePbIqBfedzmKmheg+zC2JOtwcz2LICRXJz2/B8CdnAUbtCnSh3gvMU1O9YvuXY XKrkMiPFAppOOyoEWcIEbCbtv1TCKcLip1+RFS05uLb7aBzrFKGgbxZz3pPlTiXQsB7f cH94UqQC8GJZ9d6KIlv4AlD5sTV4W1PeSvZ1cPPwQM2WzCb0Qh71CRWwqYNY+vLH4KDB fRlh9bf2UZOT5jIWT5c/j7F67EIDYry9dtzuQy2+2XXxRyjgnxWZV3Y9gKLngl4thdqT GF91/2tyuN0gdC2MPAjT/7nA/0lu2gBHDJDyYKMLF3j49E/vIU87oDwPtNP8vs3zWT1A v3YA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=HtFNrbhf; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-78240-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78240-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id f12-20020a17090274cc00b001dc4aa1df42si3148578plt.208.2024.02.23.03.40.30 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 03:40:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78240-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=HtFNrbhf; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-78240-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78240-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CCF3528214B for <ouuuleilei@gmail.com>; Fri, 23 Feb 2024 11:40:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD0487F496; Fri, 23 Feb 2024 11:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="HtFNrbhf" Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FED97AE72 for <linux-kernel@vger.kernel.org>; Fri, 23 Feb 2024 11:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708688275; cv=none; b=EjA92QhtcgXFN8NoXpJaJXM1d7O9hQLJmfFmUo3IKgUAEqf4qsv66QwjfOHyuPijkWQKZX3J7YZgiQQSErhZdc1APpdeyV06zXRQlzjIu/BkRPVAql7YNfncwE8TKYOl8/nmpQCpqkdyUMpiB8HSeGVsEq8tadTHmSUff5IUbkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708688275; c=relaxed/simple; bh=WtbjyPm53hzNlCoTEu2tMOVKVRGjW9BjcslmdMUrI3M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hEzbGlbBseO5/wQzzHs8HJCF7VjlIv8Wj9VnXZS63ZGaLaUTdI3f8FdeqnoiA51dRFA9a6KbeQLiqA5lDdSx5juImjczahPLt14hNBVU9Y7gUCWZsG+p1JyzZD7CWshfoYYhPOXJWP7ourf5wq/kFu142WBJ+6cG6yH8OK1fcb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=HtFNrbhf; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 27C7C40003; Fri, 23 Feb 2024 11:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708688269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hFcELKdEH2CqVcdv8HdPB42K6t4+ILioqNSm5RowIZQ=; b=HtFNrbhfDTpPlBwtHxSzSJxfEuq60WAuKXwJdaBo4hgsGgF9pVnGIs4W6S/CCfKmRkX3sr T7Oy1/0CvQKzqaJd+qmXeCT1CLwsV445vJjMNlaVUEjI++41G6V9EN/Cn1Ojqd4nxXIB0q v3roSWFKsqAwDU2izoNYqK914PrP4QvxsIdng2QzwHqZp2G4gkk8rBGUOShtdXuuGwz98A 5pfULL3Ug8pViDa9o0i4ZrxsCnOIBV310u0UNT6RTXEutJ4j+BUd0HU3FwxepJiUMLzDLg 8VAbt5o/ZFlbTDA26x2BK+qdI6pRaxLRsS9pgbVM2JuEQvQ9ITu+06VEiO/vaQ== From: Louis Chauvet <louis.chauvet@bootlin.com> Date: Fri, 23 Feb 2024 12:37:27 +0100 Subject: [PATCH v2 7/9] drm/vkms: Add range and encoding properties to pixel_read function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240223-yuv-v2-7-aa6be2827bb7@bootlin.com> References: <20240223-yuv-v2-0-aa6be2827bb7@bootlin.com> In-Reply-To: <20240223-yuv-v2-0-aa6be2827bb7@bootlin.com> To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>, Melissa Wen <melissa.srw@gmail.com>, =?utf-8?q?Ma=C3=ADra_Canal?= <mairacanal@riseup.net>, Haneen Mohammed <hamohammed.sa@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, arthurgrillo@riseup.net, Jonathan Corbet <corbet@lwn.net> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, Louis Chauvet <louis.chauvet@bootlin.com> X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1160; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=vFKwJ9LvmL6TH9o/eb/NeXNgMqZMacWZ1OBVcb0LDIk=; b=owEBbQKS/ZANAwAIASCtLsZbECziAcsmYgBl2IOFEKpQWR6TBGduFZetzzNzHuB0JsIH2jSYFHsu mR2gtDqJAjMEAAEIAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCZdiDhQAKCRAgrS7GWxAs4t1WD/ 4m2QsP5UU2cuakyMhmNFSmNzFkI9oUIHva7vKKVeTCVGzIyFx7qkJsa2LztVpJU+YY4X3dOFf0P7fq E5sdSreH46Md9PH894Ylu0e1GRUdOwslCKi9ws9tWQhg/R9fOfkUe2ldJ4Kdf+Z2zwjxP9Df98VNHx dIqJbVXy8/nrxS4OhfrbExGTttViu1E5+POdQGUvytHhF/uGfK8E1yvq0pr1R/N6wKIsJf4Wr+a87h Riur741OnNdH4sY5SOdLVrxvQy/rDjZm5BMzb19Yy53GAHp8a/LyNMlgl19LickQMT1Dhv1ORi1/dg ND/qQnuf2rlXrOXfukGp2TsnfofMxrNmlNB9gqti5LY7jS7XmSB1BKCyKGaxjYJ8psj8BtZ8i2eRZS gdztDTq5b2A14qtGfw+myJiR3EqTOtOZZ2i1iwdVvzTix0CzolL2BvXLRQGtSQ7tbftVrBJpeZgspU lkRHWAZy9VWIhgGCWQVIiicah6F2BGuYePSW3Bg7iRjHZl8s/KopaD5OzTrLOWuPMa5S13vLmJtMfJ sa48mt/o5WqikFBwGUTVcpc9J6QVEsiyKUPGLdfAKjWUYc9edxstCuL2bXgjUegLUOTyi7MGxMuS/g 7hNGx4kTABgx7EceXKcHRMRLLRS3bAl4NDoKqo2/cFRvyzyyX2q1DE+bwF1A== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-GND-Sasl: louis.chauvet@bootlin.com X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791689679567817408 X-GMAIL-MSGID: 1791689679567817408 |
Series |
drm/vkms: Reimplement line-per-line pixel conversion for plane reading
|
|
Commit Message
Louis Chauvet
Feb. 23, 2024, 11:37 a.m. UTC
From: Arthur Grillo <arthurgrillo@riseup.net> Create range and encoding properties. This should be noop, as none of the conversion functions need those properties. Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> [Louis Chauvet: retained only relevant parts] Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> --- drivers/gpu/drm/vkms/vkms_plane.c | 9 +++++++++ 1 file changed, 9 insertions(+)
Comments
On Fri, 23 Feb 2024 12:37:27 +0100 Louis Chauvet <louis.chauvet@bootlin.com> wrote: > From: Arthur Grillo <arthurgrillo@riseup.net> > > Create range and encoding properties. This should be noop, as none of > the conversion functions need those properties. None of the conversion function needs this? How can one say so? The previous patch is making use of them already, AFAICT? How is this a noop? Is it not exposing new UAPI from VKMS? Thanks, pq > > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > [Louis Chauvet: retained only relevant parts] > Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> > --- > drivers/gpu/drm/vkms/vkms_plane.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > index 427ca67c60ce..95dfde297377 100644 > --- a/drivers/gpu/drm/vkms/vkms_plane.c > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > @@ -228,5 +228,14 @@ struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev, > drm_plane_create_rotation_property(&plane->base, DRM_MODE_ROTATE_0, > DRM_MODE_ROTATE_MASK | DRM_MODE_REFLECT_MASK); > > + drm_plane_create_color_properties(&plane->base, > + BIT(DRM_COLOR_YCBCR_BT601) | > + BIT(DRM_COLOR_YCBCR_BT709) | > + BIT(DRM_COLOR_YCBCR_BT2020), > + BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | > + BIT(DRM_COLOR_YCBCR_FULL_RANGE), > + DRM_COLOR_YCBCR_BT601, > + DRM_COLOR_YCBCR_FULL_RANGE); > + > return plane; > } >
(same as for PATCHv2 6/9, I took the patch from Arthur with no modifications) Le 26/02/24 - 14:23, Pekka Paalanen a écrit : > On Fri, 23 Feb 2024 12:37:27 +0100 > Louis Chauvet <louis.chauvet@bootlin.com> wrote: > > > From: Arthur Grillo <arthurgrillo@riseup.net> > > > > Create range and encoding properties. This should be noop, as none of > > the conversion functions need those properties. > > None of the conversion function needs this? How can one say so? > The previous patch is making use of them already, AFAICT? It's my fault, I mixed the commits (in Arthur's series, "Add range..." was before "Add YUV support"), but for me it makes no sens to have the color property without the support in the driver. Maybe it's better just to merge "Add range..." with "Add YUV support"? > How is this a noop? Is it not exposing new UAPI from VKMS? It's not a no-op from userspace, but from the driver side, yes. Kind regards, Louis Chauvet > Thanks, > pq > > > > > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > > [Louis Chauvet: retained only relevant parts] > > Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> > > --- > > drivers/gpu/drm/vkms/vkms_plane.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > > index 427ca67c60ce..95dfde297377 100644 > > --- a/drivers/gpu/drm/vkms/vkms_plane.c > > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > > @@ -228,5 +228,14 @@ struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev, > > drm_plane_create_rotation_property(&plane->base, DRM_MODE_ROTATE_0, > > DRM_MODE_ROTATE_MASK | DRM_MODE_REFLECT_MASK); > > > > + drm_plane_create_color_properties(&plane->base, > > + BIT(DRM_COLOR_YCBCR_BT601) | > > + BIT(DRM_COLOR_YCBCR_BT709) | > > + BIT(DRM_COLOR_YCBCR_BT2020), > > + BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | > > + BIT(DRM_COLOR_YCBCR_FULL_RANGE), > > + DRM_COLOR_YCBCR_BT601, > > + DRM_COLOR_YCBCR_FULL_RANGE); > > + > > return plane; > > } > > >
On Tue, 27 Feb 2024 16:02:10 +0100 Louis Chauvet <louis.chauvet@bootlin.com> wrote: > (same as for PATCHv2 6/9, I took the patch from Arthur with no > modifications) > > Le 26/02/24 - 14:23, Pekka Paalanen a écrit : > > On Fri, 23 Feb 2024 12:37:27 +0100 > > Louis Chauvet <louis.chauvet@bootlin.com> wrote: > > > > > From: Arthur Grillo <arthurgrillo@riseup.net> > > > > > > Create range and encoding properties. This should be noop, as none of > > > the conversion functions need those properties. > > > > None of the conversion function needs this? How can one say so? > > The previous patch is making use of them already, AFAICT? > > It's my fault, I mixed the commits (in Arthur's series, "Add range..." was > before "Add YUV support"), but for me it makes no sens to have the color > property without the support in the driver. Ah, so if there was no YUV support, these properties would never affect anything. Ok, I see where that is coming from. > > Maybe it's better just to merge "Add range..." with "Add YUV support"? > > > How is this a noop? Is it not exposing new UAPI from VKMS? > > It's not a no-op from userspace, but from the driver side, yes. If it all is already hooked up and handled in the driver, then say just that? "Now that the driver internally handles these quantization ranges and YUV encoding matrices, expose the UAPI for setting them." And fix the commit summary line too, nothing "pixel_read" here. Thanks, pq > > Kind regards, > Louis Chauvet > > > Thanks, > > pq > > > > > > > > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > > > [Louis Chauvet: retained only relevant parts] > > > Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> > > > --- > > > drivers/gpu/drm/vkms/vkms_plane.c | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > > > index 427ca67c60ce..95dfde297377 100644 > > > --- a/drivers/gpu/drm/vkms/vkms_plane.c > > > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > > > @@ -228,5 +228,14 @@ struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev, > > > drm_plane_create_rotation_property(&plane->base, DRM_MODE_ROTATE_0, > > > DRM_MODE_ROTATE_MASK | DRM_MODE_REFLECT_MASK); > > > > > > + drm_plane_create_color_properties(&plane->base, > > > + BIT(DRM_COLOR_YCBCR_BT601) | > > > + BIT(DRM_COLOR_YCBCR_BT709) | > > > + BIT(DRM_COLOR_YCBCR_BT2020), > > > + BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | > > > + BIT(DRM_COLOR_YCBCR_FULL_RANGE), > > > + DRM_COLOR_YCBCR_BT601, > > > + DRM_COLOR_YCBCR_FULL_RANGE); > > > + > > > return plane; > > > } > > > > > > > >
Le 29/02/24 - 14:24, Pekka Paalanen a écrit : > On Tue, 27 Feb 2024 16:02:10 +0100 > Louis Chauvet <louis.chauvet@bootlin.com> wrote: > > > (same as for PATCHv2 6/9, I took the patch from Arthur with no > > modifications) > > > > Le 26/02/24 - 14:23, Pekka Paalanen a écrit : > > > On Fri, 23 Feb 2024 12:37:27 +0100 > > > Louis Chauvet <louis.chauvet@bootlin.com> wrote: > > > > > > > From: Arthur Grillo <arthurgrillo@riseup.net> > > > > > > > > Create range and encoding properties. This should be noop, as none of > > > > the conversion functions need those properties. > > > > > > None of the conversion function needs this? How can one say so? > > > The previous patch is making use of them already, AFAICT? > > > > It's my fault, I mixed the commits (in Arthur's series, "Add range..." was > > before "Add YUV support"), but for me it makes no sens to have the color > > property without the support in the driver. > > Ah, so if there was no YUV support, these properties would never affect > anything. Ok, I see where that is coming from. > > > > > Maybe it's better just to merge "Add range..." with "Add YUV support"? > > > > > How is this a noop? Is it not exposing new UAPI from VKMS? > > > > It's not a no-op from userspace, but from the driver side, yes. > > If it all is already hooked up and handled in the driver, then say just > that? > > "Now that the driver internally handles these quantization ranges and YUV > encoding matrices, expose the UAPI for setting them." > > And fix the commit summary line too, nothing "pixel_read" here. Ack Kind regards, Louis Chauvet > Thanks, > pq > > > > > Kind regards, > > Louis Chauvet > > > > > Thanks, > > > pq > > > > > > > > > > > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > > > > [Louis Chauvet: retained only relevant parts] > > > > Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> > > > > --- > > > > drivers/gpu/drm/vkms/vkms_plane.c | 9 +++++++++ > > > > 1 file changed, 9 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > > > > index 427ca67c60ce..95dfde297377 100644 > > > > --- a/drivers/gpu/drm/vkms/vkms_plane.c > > > > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > > > > @@ -228,5 +228,14 @@ struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev, > > > > drm_plane_create_rotation_property(&plane->base, DRM_MODE_ROTATE_0, > > > > DRM_MODE_ROTATE_MASK | DRM_MODE_REFLECT_MASK); > > > > > > > > + drm_plane_create_color_properties(&plane->base, > > > > + BIT(DRM_COLOR_YCBCR_BT601) | > > > > + BIT(DRM_COLOR_YCBCR_BT709) | > > > > + BIT(DRM_COLOR_YCBCR_BT2020), > > > > + BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | > > > > + BIT(DRM_COLOR_YCBCR_FULL_RANGE), > > > > + DRM_COLOR_YCBCR_BT601, > > > > + DRM_COLOR_YCBCR_FULL_RANGE); > > > > + > > > > return plane; > > > > } > > > > > > > > > > > > > >
diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c index 427ca67c60ce..95dfde297377 100644 --- a/drivers/gpu/drm/vkms/vkms_plane.c +++ b/drivers/gpu/drm/vkms/vkms_plane.c @@ -228,5 +228,14 @@ struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev, drm_plane_create_rotation_property(&plane->base, DRM_MODE_ROTATE_0, DRM_MODE_ROTATE_MASK | DRM_MODE_REFLECT_MASK); + drm_plane_create_color_properties(&plane->base, + BIT(DRM_COLOR_YCBCR_BT601) | + BIT(DRM_COLOR_YCBCR_BT709) | + BIT(DRM_COLOR_YCBCR_BT2020), + BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | + BIT(DRM_COLOR_YCBCR_FULL_RANGE), + DRM_COLOR_YCBCR_BT601, + DRM_COLOR_YCBCR_FULL_RANGE); + return plane; }