diff mbox series

[v4,1/2] dt-bindings: arm: aspeed: add ASUS X4TF board

Message ID 20240229090913.1892215-1-Kelly_Hung@asus.com
State New
Headers
Series [v4,1/2] dt-bindings: arm: aspeed: add ASUS X4TF board |

Commit Message

Kelly Hung Feb. 29, 2024, 9:09 a.m. UTC 
  Document the new compatibles used on ASUS X4TF.

Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>

---
Changes in v4:
- The new compatible is a BMC for a ASUS X4TF server which use a ast2600-a3 chip,
so correct string to asus,x4tf-bmc.
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Feb. 29, 2024, 10:21 a.m. UTC | #1 
On 29/02/2024 10:09, Kelly Hung wrote:
> Document the new compatibles used on ASUS X4TF.
> 
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
> 
> ---
> Changes in v4:
> - The new compatible is a BMC for a ASUS X4TF server which use a ast2600-a3 chip,
> so correct string to asus,x4tf-bmc.

And what happened with the rest of my message? Did you read it?

Best regards,
Krzysztof
Kelly Hung(洪嘉莉) Feb. 29, 2024, 11:18 a.m. UTC | #2 
Hi, Krzysztof,

I also confused, if I lost all from v1 to v4 change log? If the answer is yes, I had added them in v5.

I follow example and modify my changelogs,  https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L736
---
V4 -> V5: Update all changelog from v1 to v5.
V3 -> V4: The new compatible is a BMC for a ASUS X4TF server which use a ast2600-a3 chip, so correct string to asus,x4tf-bmc.
V2 -> V3: Add a label to indicate it is new compatible for bmc.
V1 -> V2: Remove blank in front of the string x4tf.
---

Thanks for help.
Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Thursday, February 29, 2024 6:21 PM
To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; openbmc@lists.ozlabs.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>; AllenYY Hsu(許幼岳) <AllenYY_Hsu@asus.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board

External email : Ensure your email is secure before opening links and attachments.

On 29/02/2024 10:09, Kelly Hung wrote:
> Document the new compatibles used on ASUS X4TF.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
>
> ---
> Changes in v4:
> - The new compatible is a BMC for a ASUS X4TF server which use a
> ast2600-a3 chip, so correct string to asus,x4tf-bmc.

And what happened with the rest of my message? Did you read it?

Best regards,
Krzysztof


<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.

For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
Krzysztof Kozlowski Feb. 29, 2024, 12:01 p.m. UTC | #3 
On 29/02/2024 12:18, Kelly Hung(洪嘉莉) wrote:
> Hi, Krzysztof,
> 
> I also confused, if I lost all from v1 to v4 change log? If the answer is yes, I had added them in v5.

I asked to add proper tags and gave you link to exact paragraph
explaining this.

Open the email and inline, not top-posting, answer to each sentence you
find there. You were ignoring all them and not responding...

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 749ee54a3..0047eb4ab 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -74,6 +74,7 @@  properties:
               - ampere,mtmitchell-bmc
               - aspeed,ast2600-evb
               - aspeed,ast2600-evb-a1
+              - asus,x4tf-bmc
               - facebook,bletchley-bmc
               - facebook,cloudripper-bmc
               - facebook,elbert-bmc