Message ID | 20240228141140.3530612-2-devarsht@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-85166-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp3377459dyb; Wed, 28 Feb 2024 06:21:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVeaDfd2pMl51ADiOuVHqJbVmEXfeqsfZbtFa7FNPVRZQOPu6CDAMN1jgSfQUf/7M5dxxyqObGXQ+xTwPjEcMVqWuoSxA== X-Google-Smtp-Source: AGHT+IHgQLI/WiOwfHGuv6kyFqzlghSATRXcgxojIVo5/9twxvrANdL+M3IgUHZAYG7HSLjmaJNU X-Received: by 2002:a17:906:34cd:b0:a3f:870:535c with SMTP id h13-20020a17090634cd00b00a3f0870535cmr8623414ejb.44.1709130096929; Wed, 28 Feb 2024 06:21:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709130096; cv=pass; d=google.com; s=arc-20160816; b=IIWNLCxpkBCpYkChNUjZqAh2nNPai0Le8ppisGwLlgLqmggskhTdHdUyvNtPG/ucqA uPDEX+H/X4ZNA3AOB3Whj6UGmB+7PIRsZpAWUeIOMExOJAGMHUhviXtPKah+nOTzG++o 0swIe5DgXdHNEpH3/8cXsiyYo6WB3jC2r+t9Bd2k+nh8xDk0u9J7GEI/czN8lwgGuqgK rq+o/IoohvWa6D2FqHm0fnotpQcWZyokkFpYvVyjuicJkPxlIiXwYI0N0WV5v8wq+psb bhT4MyWyR2066GW1IRO5fUdFQG1WusX7VReD7OdGGGpufm0HpC6s7pAP9WD54mTs91hp hRqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=IT8XEVQG/kJaqCfmfcvv+AZqAoLsgRgjNcwT4BYBxsw=; fh=bzbCCYPiJdChBDH3fjd+V2d5sXEkxSBqD03Ybhk7/eY=; b=W6c8pAbDv4t01Vieiqu+DU0/Zz6+FgQbyerTLQjVdi5iS++7lLQP4mg/t0nFCfjVSh pD+l1yzGgUt0HIiVunAcx4h4hd1DtelJ+IQOe9XkzGQuQFCqmwKoNL5qHGN17v3yLucv /yHhcACl3R1qxuXcAk83lcHIjp9QdzlBLAd2Rlp27m9yT3wWa9peot8M9Nls+tx1fSCp eQGi7u3mhHzw+odgaQ5tK+u2UvVDC8wKi7IUtAaeYPRvsBi769SkQY+tRxRHVM5kUOpE uXRjElmOHxIf63+rutWtecVtQOEg4jpzgB3NdT77qyK+4ICOtrH8u2FNd6PJpuKqDqaX z+Fg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=qOYnZm7J; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-85166-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85166-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id i3-20020a17090671c300b00a4412a7140fsi330343ejk.129.2024.02.28.06.21.36 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 06:21:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85166-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=qOYnZm7J; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-85166-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85166-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DCA8A1F26DE2 for <ouuuleilei@gmail.com>; Wed, 28 Feb 2024 14:13:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 643CB15AAAA; Wed, 28 Feb 2024 14:12:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="qOYnZm7J" Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E435159578; Wed, 28 Feb 2024 14:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709129522; cv=none; b=AerFoIOv5KYiQNlYSceldfGoOFFxrcA+0UIAcJingkCAkkLdsdFcvyHfcFda/3zY23OO3/3vQobG5bdxyCpr941O92DLWoPw+PAy4g7CfUZb1ja4K0rSI7qTy4mrmOvmES+uE3b+i1FDHziOvd48pdoXKiamRUcCii76IpWl1Wk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709129522; c=relaxed/simple; bh=7JOxFAQXwKasJvKfA6zXE+JDmpR4X2slnwAlBAbT+Tc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TE7XAjIydmN67ZimxCetFy25TyCbPftj4I0e+ikGxIU6TOg2CxGXY3k2gD5oJ3TXeOz/EG6SQ5b40CfK1GnNVJ3PjifF3xB4UuG5+cdg1BeJhlS8mFEX+qQBDd/1zekCqtECCzk2nOzy/A5n74d4Wk8h0WIRAGqDnNu2YVp1+oU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=qOYnZm7J; arc=none smtp.client-ip=198.47.19.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 41SEBhrb100505; Wed, 28 Feb 2024 08:11:43 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1709129503; bh=IT8XEVQG/kJaqCfmfcvv+AZqAoLsgRgjNcwT4BYBxsw=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=qOYnZm7JQsleAhPi70Cbq/kXs061kc5SWeIzcmBThgwF3uRmJu85l93QODEsJjLsv 54TfC0HpUm/LrkgSX5KHdImH6kjhC6jFGXGfVynHjC5ZQFLtr0en/qsoOwpC7DNRoy LTM65cCLnErfxuEzKdEVoTiZMTRuU4pQPuVWvl60= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 41SEBhIB129669 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Feb 2024 08:11:43 -0600 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 28 Feb 2024 08:11:43 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 28 Feb 2024 08:11:43 -0600 Received: from localhost (ti.dhcp.ti.com [172.24.227.95] (may be forged)) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 41SEBgGf060302; Wed, 28 Feb 2024 08:11:42 -0600 From: Devarsh Thakkar <devarsht@ti.com> To: <mchehab@kernel.org>, <robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <hverkuil-cisco@xs4all.nl>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <benjamin.gaignard@collabora.com>, <sebastian.fricke@collabora.com> CC: <laurent.pinchart@ideasonboard.com>, <praneeth@ti.com>, <nm@ti.com>, <vigneshr@ti.com>, <a-bhatia1@ti.com>, <j-luthra@ti.com>, <b-brnich@ti.com>, <detheridge@ti.com>, <p-mantena@ti.com>, <vijayp@ti.com>, <devarsht@ti.com>, <andrzej.p@collabora.com>, <nicolas@ndufresne.ca>, <afd@ti.com>, <milkfafa@gmail.com> Subject: [PATCH v6 1/3] media: dt-bindings: Add Imagination E5010 JPEG Encoder Date: Wed, 28 Feb 2024 19:41:38 +0530 Message-ID: <20240228141140.3530612-2-devarsht@ti.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240228141140.3530612-1-devarsht@ti.com> References: <20240228141140.3530612-1-devarsht@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792152800341113131 X-GMAIL-MSGID: 1792152800341113131 |
Series |
Add V4L2 M2M Driver for E5010 JPEG Encoder
|
|
Commit Message
Devarsh Thakkar
Feb. 28, 2024, 2:11 p.m. UTC
Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented as stateful V4L2 M2M driver. The device supports baseline encoding with two different quantization tables and compression ratio as demanded. Minimum resolution supported is 64x64 and Maximum resolution supported is 8192x8192. [1]: AM62A TRM (Section 7.6 is for JPEG Encoder) Link: https://www.ti.com/lit/pdf/spruj16 Co-developed-by: David Huang <d-huang@ti.com> Signed-off-by: David Huang <d-huang@ti.com> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> Reviewed-by: Rob Herring <robh@kernel.org> --- V2: No change V3: - Add vendor specific compatible - Update reg names - Update clocks to 1 - Fix dts example with proper naming V4: - Use ti-specific compatible ti,am62a-jpeg-enc as secondary one - Update commit message and title - Remove clock-names as only single clock V5: - Add Reviewed-By tag V6: - No change .../bindings/media/img,e5010-jpeg-enc.yaml | 75 +++++++++++++++++++ MAINTAINERS | 5 ++ 2 files changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
Comments
Hey Devarsh, On 28.02.2024 19:41, Devarsh Thakkar wrote: >Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented >as stateful V4L2 M2M driver. > >The device supports baseline encoding with two different quantization >tables and compression ratio as demanded. > >Minimum resolution supported is 64x64 and Maximum resolution supported is >8192x8192. > >[1]: AM62A TRM (Section 7.6 is for JPEG Encoder) >Link: https://www.ti.com/lit/pdf/spruj16 > >Co-developed-by: David Huang <d-huang@ti.com> >Signed-off-by: David Huang <d-huang@ti.com> >Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >Reviewed-by: Rob Herring <robh@kernel.org> hmmm when did Rob give his reviewed by on this patch? (As this is not a DT binding I find that odd) And where is the Reviewed by tag from Benjamin that he provided on V5? Greetings, Sebastian >--- >V2: No change >V3: >- Add vendor specific compatible >- Update reg names >- Update clocks to 1 >- Fix dts example with proper naming >V4: > - Use ti-specific compatible ti,am62a-jpeg-enc as secondary one > - Update commit message and title > - Remove clock-names as only single clock >V5: > - Add Reviewed-By tag >V6: > - No change > > .../bindings/media/img,e5010-jpeg-enc.yaml | 75 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml > >diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >new file mode 100644 >index 000000000000..085020cb9e61 >--- /dev/null >+++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >@@ -0,0 +1,75 @@ >+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >+%YAML 1.2 >+--- >+$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml# >+$schema: http://devicetree.org/meta-schemas/core.yaml# >+ >+title: Imagination E5010 JPEG Encoder >+ >+maintainers: >+ - Devarsh Thakkar <devarsht@ti.com> >+ >+description: | >+ The E5010 is a JPEG encoder from Imagination Technologies implemented on >+ TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422 >+ inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to >+ 8Kx8K resolution. >+ >+properties: >+ compatible: >+ oneOf: >+ - items: >+ - const: ti,am62a-jpeg-enc >+ - const: img,e5010-jpeg-enc >+ - const: img,e5010-jpeg-enc >+ >+ reg: >+ items: >+ - description: The E5010 core register region >+ - description: The E5010 mmu register region >+ >+ reg-names: >+ items: >+ - const: core >+ - const: mmu >+ >+ power-domains: >+ maxItems: 1 >+ >+ resets: >+ maxItems: 1 >+ >+ clocks: >+ maxItems: 1 >+ >+ interrupts: >+ maxItems: 1 >+ >+required: >+ - compatible >+ - reg >+ - reg-names >+ - interrupts >+ - clocks >+ >+additionalProperties: false >+ >+examples: >+ - | >+ #include <dt-bindings/soc/ti,sci_pm_domain.h> >+ #include <dt-bindings/interrupt-controller/arm-gic.h> >+ #include <dt-bindings/interrupt-controller/irq.h> >+ >+ soc { >+ #address-cells = <2>; >+ #size-cells = <2>; >+ jpeg-encoder@fd20000 { >+ compatible = "img,e5010-jpeg-enc"; >+ reg = <0x00 0xfd20000 0x00 0x100>, >+ <0x00 0xfd20200 0x00 0x200>; >+ reg-names = "core", "mmu"; >+ clocks = <&k3_clks 201 0>; >+ power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>; >+ interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; >+ }; >+ }; >diff --git a/MAINTAINERS b/MAINTAINERS >index e1475ca38ff2..6b34ee8d92b5 100644 >--- a/MAINTAINERS >+++ b/MAINTAINERS >@@ -10572,6 +10572,11 @@ S: Maintained > F: Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml > F: drivers/auxdisplay/img-ascii-lcd.c > >+IMGTEC JPEG ENCODER DRIVER >+M: Devarsh Thakkar <devarsht@ti.com> >+S: Supported >+F: Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >+ > IMGTEC IR DECODER DRIVER > S: Orphan > F: drivers/media/rc/img-ir/ >-- >2.39.1 >
Hi Sebastian, Thanks for the review. On 29/02/24 15:56, Sebastian Fricke wrote: > Hey Devarsh, > > On 28.02.2024 19:41, Devarsh Thakkar wrote: >> Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented >> as stateful V4L2 M2M driver. >> >> The device supports baseline encoding with two different quantization >> tables and compression ratio as demanded. >> >> Minimum resolution supported is 64x64 and Maximum resolution supported is >> 8192x8192. >> >> [1]: AM62A TRM (Section 7.6 is for JPEG Encoder) >> Link: https://www.ti.com/lit/pdf/spruj16 >> >> Co-developed-by: David Huang <d-huang@ti.com> >> Signed-off-by: David Huang <d-huang@ti.com> >> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >> Reviewed-by: Rob Herring <robh@kernel.org> > > hmmm when did Rob give his reviewed by on this patch? (As this is not a > DT binding I find that odd) [PATCH v6 1/3] media: dt-bindings: Add Imagination E5010 JPEG Encoder : This is indeed the dt-binding patch. Also As shared in version history it is at V4 where Rob Herring added a Reviewed-By as seen here [0] > And where is the Reviewed by tag from Benjamin that he provided on V5? > As captured in patch version history here [1] I thought to remove the Reviewed-By since the Reviewed-By tag was on V5 and with V6 the driver got updated with some changes to handle reported sparse warnings and so I have asked Benjamin to check the range-diff and help with a quick review again if possible. Kindly let me know if I missed something or anything needs to be done from my end. [0] : https://lore.kernel.org/all/170716378412.295212.11603162949482063011.robh@kernel.org/ [1] : https://lore.kernel.org/all/20240228141140.3530612-4-devarsht@ti.com/ Regards Devarsh > Greetings, > Sebastian > >> --- >> V2: No change >> V3: >> - Add vendor specific compatible >> - Update reg names >> - Update clocks to 1 >> - Fix dts example with proper naming >> V4: >> - Use ti-specific compatible ti,am62a-jpeg-enc as secondary one >> - Update commit message and title >> - Remove clock-names as only single clock >> V5: >> - Add Reviewed-By tag >> V6: >> - No change >> >> .../bindings/media/img,e5010-jpeg-enc.yaml | 75 +++++++++++++++++++ >> MAINTAINERS | 5 ++ >> 2 files changed, 80 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >> b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >> new file mode 100644 >> index 000000000000..085020cb9e61 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >> @@ -0,0 +1,75 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Imagination E5010 JPEG Encoder >> + >> +maintainers: >> + - Devarsh Thakkar <devarsht@ti.com> >> + >> +description: | >> + The E5010 is a JPEG encoder from Imagination Technologies implemented on >> + TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422 >> + inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to >> + 8Kx8K resolution. >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - const: ti,am62a-jpeg-enc >> + - const: img,e5010-jpeg-enc >> + - const: img,e5010-jpeg-enc >> + >> + reg: >> + items: >> + - description: The E5010 core register region >> + - description: The E5010 mmu register region >> + >> + reg-names: >> + items: >> + - const: core >> + - const: mmu >> + >> + power-domains: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/soc/ti,sci_pm_domain.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/interrupt-controller/irq.h> >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + jpeg-encoder@fd20000 { >> + compatible = "img,e5010-jpeg-enc"; >> + reg = <0x00 0xfd20000 0x00 0x100>, >> + <0x00 0xfd20200 0x00 0x200>; >> + reg-names = "core", "mmu"; >> + clocks = <&k3_clks 201 0>; >> + power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>; >> + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + }; >> diff --git a/MAINTAINERS b/MAINTAINERS >> index e1475ca38ff2..6b34ee8d92b5 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -10572,6 +10572,11 @@ S: Maintained >> F: Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml >> F: drivers/auxdisplay/img-ascii-lcd.c >> >> +IMGTEC JPEG ENCODER DRIVER >> +M: Devarsh Thakkar <devarsht@ti.com> >> +S: Supported >> +F: Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >> + >> IMGTEC IR DECODER DRIVER >> S: Orphan >> F: drivers/media/rc/img-ir/ >> -- >> 2.39.1 >>
On 29/02/2024 11:26, Sebastian Fricke wrote: > Hey Devarsh, > > On 28.02.2024 19:41, Devarsh Thakkar wrote: >> Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented >> as stateful V4L2 M2M driver. >> >> The device supports baseline encoding with two different quantization >> tables and compression ratio as demanded. >> >> Minimum resolution supported is 64x64 and Maximum resolution supported is >> 8192x8192. >> >> [1]: AM62A TRM (Section 7.6 is for JPEG Encoder) >> Link: https://www.ti.com/lit/pdf/spruj16 >> >> Co-developed-by: David Huang <d-huang@ti.com> >> Signed-off-by: David Huang <d-huang@ti.com> >> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >> Reviewed-by: Rob Herring <robh@kernel.org> > > hmmm when did Rob give his reviewed by on this patch? (As this is not a > DT binding I find that odd) This is a DT binding, which is clearly expressed in subject prefix (proper one) and the patch contents. Best regards, Krzysztof
Hey Devarsh, On 29.02.2024 16:50, Devarsh Thakkar wrote: >Hi Sebastian, > >Thanks for the review. > >On 29/02/24 15:56, Sebastian Fricke wrote: >> Hey Devarsh, >> >> On 28.02.2024 19:41, Devarsh Thakkar wrote: >>> Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented >>> as stateful V4L2 M2M driver. >>> >>> The device supports baseline encoding with two different quantization >>> tables and compression ratio as demanded. >>> >>> Minimum resolution supported is 64x64 and Maximum resolution supported is >>> 8192x8192. >>> >>> [1]: AM62A TRM (Section 7.6 is for JPEG Encoder) >>> Link: https://www.ti.com/lit/pdf/spruj16 >>> >>> Co-developed-by: David Huang <d-huang@ti.com> >>> Signed-off-by: David Huang <d-huang@ti.com> >>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >>> Reviewed-by: Rob Herring <robh@kernel.org> >> >> hmmm when did Rob give his reviewed by on this patch? (As this is not a >> DT binding I find that odd) > >[PATCH v6 1/3] media: dt-bindings: Add Imagination E5010 JPEG Encoder : This >is indeed the dt-binding patch. Also As shared in version history it is at V4 >where Rob Herring added a Reviewed-By as seen here [0] > >> And where is the Reviewed by tag from Benjamin that he provided on V5? >> > >As captured in patch version history here [1] I thought to remove the >Reviewed-By since the Reviewed-By tag was on V5 and with V6 the driver got >updated with some changes to handle reported sparse warnings and so I have >asked Benjamin to check the range-diff and help with a quick review again if >possible. > >Kindly let me know if I missed something or anything needs to be done from my end. Yes thanks I was a bit too swift to write here, sorry for the noise. We'll have a look. Greetings, Sebastian > >[0] : >https://lore.kernel.org/all/170716378412.295212.11603162949482063011.robh@kernel.org/ >[1] : https://lore.kernel.org/all/20240228141140.3530612-4-devarsht@ti.com/ > > >Regards >Devarsh >>> --- >>> V2: No change >>> V3: >>> - Add vendor specific compatible >>> - Update reg names >>> - Update clocks to 1 >>> - Fix dts example with proper naming >>> V4: >>> - Use ti-specific compatible ti,am62a-jpeg-enc as secondary one >>> - Update commit message and title >>> - Remove clock-names as only single clock >>> V5: >>> - Add Reviewed-By tag >>> V6: >>> - No change >>> >>> .../bindings/media/img,e5010-jpeg-enc.yaml | 75 +++++++++++++++++++ >>> MAINTAINERS | 5 ++ >>> 2 files changed, 80 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>> b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>> new file mode 100644 >>> index 000000000000..085020cb9e61 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>> @@ -0,0 +1,75 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Imagination E5010 JPEG Encoder >>> + >>> +maintainers: >>> + - Devarsh Thakkar <devarsht@ti.com> >>> + >>> +description: | >>> + The E5010 is a JPEG encoder from Imagination Technologies implemented on >>> + TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422 >>> + inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to >>> + 8Kx8K resolution. >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - items: >>> + - const: ti,am62a-jpeg-enc >>> + - const: img,e5010-jpeg-enc >>> + - const: img,e5010-jpeg-enc >>> + >>> + reg: >>> + items: >>> + - description: The E5010 core register region >>> + - description: The E5010 mmu register region >>> + >>> + reg-names: >>> + items: >>> + - const: core >>> + - const: mmu >>> + >>> + power-domains: >>> + maxItems: 1 >>> + >>> + resets: >>> + maxItems: 1 >>> + >>> + clocks: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - reg-names >>> + - interrupts >>> + - clocks >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include <dt-bindings/soc/ti,sci_pm_domain.h> >>> + #include <dt-bindings/interrupt-controller/arm-gic.h> >>> + #include <dt-bindings/interrupt-controller/irq.h> >>> + >>> + soc { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + jpeg-encoder@fd20000 { >>> + compatible = "img,e5010-jpeg-enc"; >>> + reg = <0x00 0xfd20000 0x00 0x100>, >>> + <0x00 0xfd20200 0x00 0x200>; >>> + reg-names = "core", "mmu"; >>> + clocks = <&k3_clks 201 0>; >>> + power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>; >>> + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; >>> + }; >>> + }; >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index e1475ca38ff2..6b34ee8d92b5 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -10572,6 +10572,11 @@ S: Maintained >>> F: Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml >>> F: drivers/auxdisplay/img-ascii-lcd.c >>> >>> +IMGTEC JPEG ENCODER DRIVER >>> +M: Devarsh Thakkar <devarsht@ti.com> >>> +S: Supported >>> +F: Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>> + >>> IMGTEC IR DECODER DRIVER >>> S: Orphan >>> F: drivers/media/rc/img-ir/ >>> -- >>> 2.39.1 >>>
On 29.02.2024 13:16, Krzysztof Kozlowski wrote: >On 29/02/2024 11:26, Sebastian Fricke wrote: >> Hey Devarsh, >> >> On 28.02.2024 19:41, Devarsh Thakkar wrote: >>> Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented >>> as stateful V4L2 M2M driver. >>> >>> The device supports baseline encoding with two different quantization >>> tables and compression ratio as demanded. >>> >>> Minimum resolution supported is 64x64 and Maximum resolution supported is >>> 8192x8192. >>> >>> [1]: AM62A TRM (Section 7.6 is for JPEG Encoder) >>> Link: https://www.ti.com/lit/pdf/spruj16 >>> >>> Co-developed-by: David Huang <d-huang@ti.com> >>> Signed-off-by: David Huang <d-huang@ti.com> >>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >>> Reviewed-by: Rob Herring <robh@kernel.org> >> >> hmmm when did Rob give his reviewed by on this patch? (As this is not a >> DT binding I find that odd) > >This is a DT binding, which is clearly expressed in subject prefix >(proper one) and the patch contents. Yup sorry for the noise, I confused the two patches. > >Best regards, >Krzysztof Greetings, Sebastian
Hi Sebastian, On 29/02/24 19:00, Sebastian Fricke wrote: > Hey Devarsh, > > On 29.02.2024 16:50, Devarsh Thakkar wrote: >> Hi Sebastian, >> >> Thanks for the review. >> >> On 29/02/24 15:56, Sebastian Fricke wrote: >>> Hey Devarsh, >>> >>> On 28.02.2024 19:41, Devarsh Thakkar wrote: >>>> Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented >>>> as stateful V4L2 M2M driver. >>>> >>>> The device supports baseline encoding with two different quantization >>>> tables and compression ratio as demanded. >>>> >>>> Minimum resolution supported is 64x64 and Maximum resolution supported is >>>> 8192x8192. >>>> >>>> [1]: AM62A TRM (Section 7.6 is for JPEG Encoder) >>>> Link: https://www.ti.com/lit/pdf/spruj16 >>>> >>>> Co-developed-by: David Huang <d-huang@ti.com> >>>> Signed-off-by: David Huang <d-huang@ti.com> >>>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >>>> Reviewed-by: Rob Herring <robh@kernel.org> >>> >>> hmmm when did Rob give his reviewed by on this patch? (As this is not a >>> DT binding I find that odd) >> >> [PATCH v6 1/3] media: dt-bindings: Add Imagination E5010 JPEG Encoder : This >> is indeed the dt-binding patch. Also As shared in version history it is at V4 >> where Rob Herring added a Reviewed-By as seen here [0] >> >>> And where is the Reviewed by tag from Benjamin that he provided on V5? >>> >> >> As captured in patch version history here [1] I thought to remove the >> Reviewed-By since the Reviewed-By tag was on V5 and with V6 the driver got >> updated with some changes to handle reported sparse warnings and so I have >> asked Benjamin to check the range-diff and help with a quick review again if >> possible. >> >> Kindly let me know if I missed something or anything needs to be done from >> my end. > > Yes thanks I was a bit too swift to write here, sorry for the noise. > We'll have a look. > Sorry for the back and forth, but on the hindsight and re-looking at the kernel patch guidelines [0] they suggest that Reviewed-By tag should only be removed if substantial changes were made in further revisions. So looks to me in-fact it was a mistake on my part to remove the Reviewed-by considering the change made in the following patch series was not a substantial one as seen in the range-diff [1]. Considering this, just wanted to check with you if it's possible for you to consider the Reviewed-by tag : `Reviewed-by: Benjamin Gaignard <benjamin.gaignard@collabora.com` if it helps consolidate things faster to get this series in given we are close to final RC's ? [0]: https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes:~:text=changed%20substantially [1]: https://gist.github.com/devarsht/c89180ac2b0d2814614f2b59d0705c19 Regards Devarsh > > Greetings, > Sebastian > >> >> [0] : >> https://lore.kernel.org/all/170716378412.295212.11603162949482063011.robh@kernel.org/ >> [1] : https://lore.kernel.org/all/20240228141140.3530612-4-devarsht@ti.com/ >> >> >> Regards >> Devarsh >>>> --- >>>> V2: No change >>>> V3: >>>> - Add vendor specific compatible >>>> - Update reg names >>>> - Update clocks to 1 >>>> - Fix dts example with proper naming >>>> V4: >>>> - Use ti-specific compatible ti,am62a-jpeg-enc as secondary one >>>> - Update commit message and title >>>> - Remove clock-names as only single clock >>>> V5: >>>> - Add Reviewed-By tag >>>> V6: >>>> - No change >>>> >>>> .../bindings/media/img,e5010-jpeg-enc.yaml | 75 +++++++++++++++++++ >>>> MAINTAINERS | 5 ++ >>>> 2 files changed, 80 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>> b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>> new file mode 100644 >>>> index 000000000000..085020cb9e61 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>> @@ -0,0 +1,75 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Imagination E5010 JPEG Encoder >>>> + >>>> +maintainers: >>>> + - Devarsh Thakkar <devarsht@ti.com> >>>> + >>>> +description: | >>>> + The E5010 is a JPEG encoder from Imagination Technologies implemented on >>>> + TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422 >>>> + inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to >>>> + 8Kx8K resolution. >>>> + >>>> +properties: >>>> + compatible: >>>> + oneOf: >>>> + - items: >>>> + - const: ti,am62a-jpeg-enc >>>> + - const: img,e5010-jpeg-enc >>>> + - const: img,e5010-jpeg-enc >>>> + >>>> + reg: >>>> + items: >>>> + - description: The E5010 core register region >>>> + - description: The E5010 mmu register region >>>> + >>>> + reg-names: >>>> + items: >>>> + - const: core >>>> + - const: mmu >>>> + >>>> + power-domains: >>>> + maxItems: 1 >>>> + >>>> + resets: >>>> + maxItems: 1 >>>> + >>>> + clocks: >>>> + maxItems: 1 >>>> + >>>> + interrupts: >>>> + maxItems: 1 >>>> + >>>> +required: >>>> + - compatible >>>> + - reg >>>> + - reg-names >>>> + - interrupts >>>> + - clocks >>>> + >>>> +additionalProperties: false >>>> + >>>> +examples: >>>> + - | >>>> + #include <dt-bindings/soc/ti,sci_pm_domain.h> >>>> + #include <dt-bindings/interrupt-controller/arm-gic.h> >>>> + #include <dt-bindings/interrupt-controller/irq.h> >>>> + >>>> + soc { >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + jpeg-encoder@fd20000 { >>>> + compatible = "img,e5010-jpeg-enc"; >>>> + reg = <0x00 0xfd20000 0x00 0x100>, >>>> + <0x00 0xfd20200 0x00 0x200>; >>>> + reg-names = "core", "mmu"; >>>> + clocks = <&k3_clks 201 0>; >>>> + power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>; >>>> + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; >>>> + }; >>>> + }; >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index e1475ca38ff2..6b34ee8d92b5 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -10572,6 +10572,11 @@ S: Maintained >>>> F: Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml >>>> F: drivers/auxdisplay/img-ascii-lcd.c >>>> >>>> +IMGTEC JPEG ENCODER DRIVER >>>> +M: Devarsh Thakkar <devarsht@ti.com> >>>> +S: Supported >>>> +F: Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>> + >>>> IMGTEC IR DECODER DRIVER >>>> S: Orphan >>>> F: drivers/media/rc/img-ir/ >>>> -- >>>> 2.39.1 >>>>
Hey Devarsh, On 01.03.2024 22:02, Devarsh Thakkar wrote: >Hi Sebastian, > >On 29/02/24 19:00, Sebastian Fricke wrote: >> Hey Devarsh, >> >> On 29.02.2024 16:50, Devarsh Thakkar wrote: >>> Hi Sebastian, >>> >>> Thanks for the review. >>> >>> On 29/02/24 15:56, Sebastian Fricke wrote: >>>> Hey Devarsh, >>>> >>>> On 28.02.2024 19:41, Devarsh Thakkar wrote: >>>>> Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented >>>>> as stateful V4L2 M2M driver. >>>>> >>>>> The device supports baseline encoding with two different quantization >>>>> tables and compression ratio as demanded. >>>>> >>>>> Minimum resolution supported is 64x64 and Maximum resolution supported is >>>>> 8192x8192. >>>>> >>>>> [1]: AM62A TRM (Section 7.6 is for JPEG Encoder) >>>>> Link: https://www.ti.com/lit/pdf/spruj16 >>>>> >>>>> Co-developed-by: David Huang <d-huang@ti.com> >>>>> Signed-off-by: David Huang <d-huang@ti.com> >>>>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >>>>> Reviewed-by: Rob Herring <robh@kernel.org> >>>> >>>> hmmm when did Rob give his reviewed by on this patch? (As this is not a >>>> DT binding I find that odd) >>> >>> [PATCH v6 1/3] media: dt-bindings: Add Imagination E5010 JPEG Encoder : This >>> is indeed the dt-binding patch. Also As shared in version history it is at V4 >>> where Rob Herring added a Reviewed-By as seen here [0] >>> >>>> And where is the Reviewed by tag from Benjamin that he provided on V5? >>>> >>> >>> As captured in patch version history here [1] I thought to remove the >>> Reviewed-By since the Reviewed-By tag was on V5 and with V6 the driver got >>> updated with some changes to handle reported sparse warnings and so I have >>> asked Benjamin to check the range-diff and help with a quick review again if >>> possible. >>> >>> Kindly let me know if I missed something or anything needs to be done from >>> my end. >> >> Yes thanks I was a bit too swift to write here, sorry for the noise. >> We'll have a look. >> > >Sorry for the back and forth, but on the hindsight and re-looking at the >kernel patch guidelines [0] they suggest that Reviewed-By tag should only be >removed if substantial changes were made in further revisions. > >So looks to me in-fact it was a mistake on my part to remove the Reviewed-by >considering the change made in the following patch series was not a >substantial one as seen in the range-diff [1]. > >Considering this, just wanted to check with you if it's possible for you to >consider the Reviewed-by tag : >`Reviewed-by: Benjamin Gaignard <benjamin.gaignard@collabora.com` >if it helps consolidate things faster to get this series in given we are close >to final RC's ? Yup I think we can keep it as the changes are very minor. Otherwise the series is pretty much good to go, I'll prepare the PR asap. Greetings, Sebastian > >[0]: >https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes:~:text=changed%20substantially > >[1]: https://gist.github.com/devarsht/c89180ac2b0d2814614f2b59d0705c19 > >Regards >Devarsh > >> >> Greetings, >> Sebastian >> >>> >>> [0] : >>> https://lore.kernel.org/all/170716378412.295212.11603162949482063011.robh@kernel.org/ >>> [1] : https://lore.kernel.org/all/20240228141140.3530612-4-devarsht@ti.com/ >>> >>> >>> Regards >>> Devarsh >>>>> --- >>>>> V2: No change >>>>> V3: >>>>> - Add vendor specific compatible >>>>> - Update reg names >>>>> - Update clocks to 1 >>>>> - Fix dts example with proper naming >>>>> V4: >>>>> - Use ti-specific compatible ti,am62a-jpeg-enc as secondary one >>>>> - Update commit message and title >>>>> - Remove clock-names as only single clock >>>>> V5: >>>>> - Add Reviewed-By tag >>>>> V6: >>>>> - No change >>>>> >>>>> .../bindings/media/img,e5010-jpeg-enc.yaml | 75 +++++++++++++++++++ >>>>> MAINTAINERS | 5 ++ >>>>> 2 files changed, 80 insertions(+) >>>>> create mode 100644 >>>>> Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>>> b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>>> new file mode 100644 >>>>> index 000000000000..085020cb9e61 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>>> @@ -0,0 +1,75 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Imagination E5010 JPEG Encoder >>>>> + >>>>> +maintainers: >>>>> + - Devarsh Thakkar <devarsht@ti.com> >>>>> + >>>>> +description: | >>>>> + The E5010 is a JPEG encoder from Imagination Technologies implemented on >>>>> + TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422 >>>>> + inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to >>>>> + 8Kx8K resolution. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + oneOf: >>>>> + - items: >>>>> + - const: ti,am62a-jpeg-enc >>>>> + - const: img,e5010-jpeg-enc >>>>> + - const: img,e5010-jpeg-enc >>>>> + >>>>> + reg: >>>>> + items: >>>>> + - description: The E5010 core register region >>>>> + - description: The E5010 mmu register region >>>>> + >>>>> + reg-names: >>>>> + items: >>>>> + - const: core >>>>> + - const: mmu >>>>> + >>>>> + power-domains: >>>>> + maxItems: 1 >>>>> + >>>>> + resets: >>>>> + maxItems: 1 >>>>> + >>>>> + clocks: >>>>> + maxItems: 1 >>>>> + >>>>> + interrupts: >>>>> + maxItems: 1 >>>>> + >>>>> +required: >>>>> + - compatible >>>>> + - reg >>>>> + - reg-names >>>>> + - interrupts >>>>> + - clocks >>>>> + >>>>> +additionalProperties: false >>>>> + >>>>> +examples: >>>>> + - | >>>>> + #include <dt-bindings/soc/ti,sci_pm_domain.h> >>>>> + #include <dt-bindings/interrupt-controller/arm-gic.h> >>>>> + #include <dt-bindings/interrupt-controller/irq.h> >>>>> + >>>>> + soc { >>>>> + #address-cells = <2>; >>>>> + #size-cells = <2>; >>>>> + jpeg-encoder@fd20000 { >>>>> + compatible = "img,e5010-jpeg-enc"; >>>>> + reg = <0x00 0xfd20000 0x00 0x100>, >>>>> + <0x00 0xfd20200 0x00 0x200>; >>>>> + reg-names = "core", "mmu"; >>>>> + clocks = <&k3_clks 201 0>; >>>>> + power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>; >>>>> + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; >>>>> + }; >>>>> + }; >>>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>>> index e1475ca38ff2..6b34ee8d92b5 100644 >>>>> --- a/MAINTAINERS >>>>> +++ b/MAINTAINERS >>>>> @@ -10572,6 +10572,11 @@ S: Maintained >>>>> F: Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml >>>>> F: drivers/auxdisplay/img-ascii-lcd.c >>>>> >>>>> +IMGTEC JPEG ENCODER DRIVER >>>>> +M: Devarsh Thakkar <devarsht@ti.com> >>>>> +S: Supported >>>>> +F: Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml >>>>> + >>>>> IMGTEC IR DECODER DRIVER >>>>> S: Orphan >>>>> F: drivers/media/rc/img-ir/ >>>>> -- >>>>> 2.39.1 >>>>>
diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml new file mode 100644 index 000000000000..085020cb9e61 --- /dev/null +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml @@ -0,0 +1,75 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Imagination E5010 JPEG Encoder + +maintainers: + - Devarsh Thakkar <devarsht@ti.com> + +description: | + The E5010 is a JPEG encoder from Imagination Technologies implemented on + TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422 + inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to + 8Kx8K resolution. + +properties: + compatible: + oneOf: + - items: + - const: ti,am62a-jpeg-enc + - const: img,e5010-jpeg-enc + - const: img,e5010-jpeg-enc + + reg: + items: + - description: The E5010 core register region + - description: The E5010 mmu register region + + reg-names: + items: + - const: core + - const: mmu + + power-domains: + maxItems: 1 + + resets: + maxItems: 1 + + clocks: + maxItems: 1 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - reg-names + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/soc/ti,sci_pm_domain.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + jpeg-encoder@fd20000 { + compatible = "img,e5010-jpeg-enc"; + reg = <0x00 0xfd20000 0x00 0x100>, + <0x00 0xfd20200 0x00 0x200>; + reg-names = "core", "mmu"; + clocks = <&k3_clks 201 0>; + power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>; + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index e1475ca38ff2..6b34ee8d92b5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10572,6 +10572,11 @@ S: Maintained F: Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml F: drivers/auxdisplay/img-ascii-lcd.c +IMGTEC JPEG ENCODER DRIVER +M: Devarsh Thakkar <devarsht@ti.com> +S: Supported +F: Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml + IMGTEC IR DECODER DRIVER S: Orphan F: drivers/media/rc/img-ir/