Message ID | 20240228062813.1007138-2-horatiu.vultur@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-84561-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp3167908dyb; Tue, 27 Feb 2024 22:31:52 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVa9TmhKoCsXSaKn4+lwmTiqGKsdGCxz0CwGA+0CKVRUK1sf2kJL8w6IQeHGis/sy8ijgEC9oMCyGaVzZAXupuAntmAlw== X-Google-Smtp-Source: AGHT+IGePGyHY3tbG4WsQJg2dfuYmsNLAGHoIwn6ZJvZbGOhA49jBl/b22eN12Ijmw8I298YYTY/ X-Received: by 2002:a05:6a00:2316:b0:6e4:8313:171b with SMTP id h22-20020a056a00231600b006e48313171bmr17975337pfh.23.1709101912328; Tue, 27 Feb 2024 22:31:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709101912; cv=pass; d=google.com; s=arc-20160816; b=jZ0JqwYh/v3sOiRAZ3x7xpoJbGXOgxw3ZRTVu++HaUR24i7QDCgQIkSvyM9SDscEge tXlgwTw3LKk30xcT5gqJSvK6BF5s1EkzgJDG+BMDl50r0vlPT3gyeO8vIuh7wbXk+dWG K4tU1ed3qGfaDu8IBQUpdVQaW7mF2y6gjxYSVPRznFhEOa1nPxaDE0DK+tu+cWTqkKwN u3m6LsPQcTu6HgCPhyVJ7vrCkrhTGgq/SGyXyDpwjzGY075p+F6Jo1M6tvUsA22KGAas JbMsDYjo1S2xHU5VFchLg4+4o7QJtl3ludIxQ/Oy+VNj35vv8jTTVuGPYQjzur4ztoKe xvCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=dIt/c+Tbfm/gyXtw+O2SKLGzkLfNhGRxoWu0DBW/8io=; fh=4QsgaxB/D4vgvZDOyD4hOqL7/0PF6ZqevOrk8yprrqs=; b=t8xBR3bvVjJLJptGL7XeynUmsZQOeK3XvFWXgBC3hG+HqrajDl7S47OlkL4RUHoj6O 52V09HAVAQPY1BAkro4EY0l72h0si6DiSPV/BKvL2oqLHmmtL4rV6mQUIbcTX+UXYVUK qwCxl47opxnCQub4i1IajgsIsLaz17sWkJp5bIfsA0wfuKANYtrEGwOMcCPdXy2TFCaI Q9UmNXgx47XJspw5/TNsdYY+FFnFjSFqT93PNd2XMtuD5oxizMiMKDTjY/BhIUSQzRYu aNllYTHps5wpSSxgBnwLxyn9MIUlP7PZf/eDsaAziiYGYne1hNczGE4CZNYjGoGc2Qqq 6SiQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=XY3v6iB3; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-84561-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84561-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id v7-20020aa799c7000000b006e568580af7si339160pfi.111.2024.02.27.22.31.52 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 22:31:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84561-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=XY3v6iB3; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-84561-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84561-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C6982289670 for <ouuuleilei@gmail.com>; Wed, 28 Feb 2024 06:31:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC36523749; Wed, 28 Feb 2024 06:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="XY3v6iB3" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E76D21E501; Wed, 28 Feb 2024 06:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709101838; cv=none; b=gwyGag/1KCEapp7mwXiT8nIcVylW1P/E+WVwrpssfM+Pc3maKnFS9ia19Rm9vJgEHnQf9MOBy2HhD5/JsQMFSTkJQS6ClB280bBpzipKHCo+rATMzd+ODsY4Gpsxq324oq7yF71Lkvg0gK23YbJ5h5HOA6A+gs2vfFCXCmGta/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709101838; c=relaxed/simple; bh=5zgtvBb7ybGOTydt2Y9kLwJt/b4q5aA+RidLp5++cRE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KdRguY0WBiceU7pVyOKGKvmTVNQUsizagCVAEzIotmFc3AizIYGBW73VqVSRfPkEP9n5Qf/GHzX3pXwwNqmn3tOy4EEq5+Kgcste+/wd8KKz+ngJfFqKh/X/a3A7cVHkWL7KjVi0aABVZbGufa2O0n6Yyvb3HYGF5uBTvhPE4N4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=XY3v6iB3; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1709101837; x=1740637837; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5zgtvBb7ybGOTydt2Y9kLwJt/b4q5aA+RidLp5++cRE=; b=XY3v6iB3THpVPlwDcG2WiRyYL8JhtEhSa8CEx8MVpATCxtdjQbJ9uk/5 g4QqtiqIsT6PGOnR9uj/TiaNnPFA4H+ZkGU9Y6AGaCNxSEcae5A6ocA/H A8h5LIgazX/tDZ8lh+u4Yg1Cl1aytrrfAtJfAs5PS20ktFKwJT21oQPS8 yOIJR/CkOb6Bh9VQdqIz09cAdegYM6nH+CJE1YEpzemQ3Iu7sZaGwWiI3 WvX4vl5K09KbujUuI+cX1cuOX3vh4TQobLcu79E4pftDxa1pkBa/zU0dx d7lYs6KtOxKXYtM0S8WdGc+a6Eoc56V+eTP8zidUv2Tbly9n9fzekT0kE g==; X-CSE-ConnectionGUID: WwtfXDcGT3ekg/b+aiH4Eg== X-CSE-MsgGUID: vk/89F6YQJOYQKdIPkjbaA== X-IronPort-AV: E=Sophos;i="6.06,190,1705388400"; d="scan'208";a="247685634" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2024 23:30:35 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 23:30:06 -0700 Received: from DEN-DL-M31836.microsemi.net (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Tue, 27 Feb 2024 23:30:04 -0700 From: Horatiu Vultur <horatiu.vultur@microchip.com> To: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com> CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>, Horatiu Vultur <horatiu.vultur@microchip.com> Subject: [PATCH net-next 1/2] net: phy: micrel: lan8814 led errata Date: Wed, 28 Feb 2024 07:28:12 +0100 Message-ID: <20240228062813.1007138-2-horatiu.vultur@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240228062813.1007138-1-horatiu.vultur@microchip.com> References: <20240228062813.1007138-1-horatiu.vultur@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792123247032452369 X-GMAIL-MSGID: 1792123247032452369 |
Series |
net: phy: micrel: lan8814 erratas
|
|
Commit Message
Horatiu Vultur
Feb. 28, 2024, 6:28 a.m. UTC
Lan8814 phy led behavior is not correct. It was noticed that the led
still remains ON when the cable is unplugged while there was traffic
passing at that time.
The fix consists in clearing bit 10 of register 0x38, in this way the
led behaviour is correct and gets OFF when there is no link.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/phy/micrel.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
Comments
On 28.02.2024 07:28, Horatiu Vultur wrote: > Lan8814 phy led behavior is not correct. It was noticed that the led > still remains ON when the cable is unplugged while there was traffic > passing at that time. > > The fix consists in clearing bit 10 of register 0x38, in this way the > led behaviour is correct and gets OFF when there is no link. > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> > --- > drivers/net/phy/micrel.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 9b69735819896..5a0cc89eaebdd 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -114,6 +114,9 @@ > #define LAN8814_INTR_CTRL_REG_POLARITY BIT(1) > #define LAN8814_INTR_CTRL_REG_INTR_ENABLE BIT(0) > > +#define LAN8814_EEE_STATE 0x38 > +#define LAN8814_EEE_STATE_MASK2P5P BIT(10) > + > /* Represents 1ppm adjustment in 2^32 format with > * each nsec contains 4 clock cycles. > * The value is calculated as following: (1/1000000)/((2^-32)/4) > @@ -3288,6 +3291,19 @@ static int lan8814_release_coma_mode(struct phy_device *phydev) > return 0; > } > > +static void lan8814_errata_fixes(struct phy_device *phydev) This name is too generic IMO. Maybe: lan8814_clear_2psp_bit > +{ > + u16 val; > + > + /* It was noticed that when traffic is passing through the PHY and the > + * cable is removed then the LED was still one even though there is no > + * link > + */ > + val = lanphy_read_page_reg(phydev, 2, LAN8814_EEE_STATE); > + val &= ~LAN8814_EEE_STATE_MASK2P5P; > + lanphy_write_page_reg(phydev, 2, LAN8814_EEE_STATE, val); > +} > + > static int lan8814_probe(struct phy_device *phydev) > { > const struct kszphy_type *type = phydev->drv->driver_data; > @@ -3323,6 +3339,7 @@ static int lan8814_probe(struct phy_device *phydev) > } > > lan8814_ptp_init(phydev); > + lan8814_errata_fixes(phydev); > > return 0; > }
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 9b69735819896..5a0cc89eaebdd 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -114,6 +114,9 @@ #define LAN8814_INTR_CTRL_REG_POLARITY BIT(1) #define LAN8814_INTR_CTRL_REG_INTR_ENABLE BIT(0) +#define LAN8814_EEE_STATE 0x38 +#define LAN8814_EEE_STATE_MASK2P5P BIT(10) + /* Represents 1ppm adjustment in 2^32 format with * each nsec contains 4 clock cycles. * The value is calculated as following: (1/1000000)/((2^-32)/4) @@ -3288,6 +3291,19 @@ static int lan8814_release_coma_mode(struct phy_device *phydev) return 0; } +static void lan8814_errata_fixes(struct phy_device *phydev) +{ + u16 val; + + /* It was noticed that when traffic is passing through the PHY and the + * cable is removed then the LED was still one even though there is no + * link + */ + val = lanphy_read_page_reg(phydev, 2, LAN8814_EEE_STATE); + val &= ~LAN8814_EEE_STATE_MASK2P5P; + lanphy_write_page_reg(phydev, 2, LAN8814_EEE_STATE, val); +} + static int lan8814_probe(struct phy_device *phydev) { const struct kszphy_type *type = phydev->drv->driver_data; @@ -3323,6 +3339,7 @@ static int lan8814_probe(struct phy_device *phydev) } lan8814_ptp_init(phydev); + lan8814_errata_fixes(phydev); return 0; }