Message ID | 20221125083114.67e7f83c@endymion.delvare |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3829722wrr; Thu, 24 Nov 2022 23:36:07 -0800 (PST) X-Google-Smtp-Source: AA0mqf42ftE+c1XNm3nZb/IJW28mXMqM1Q3vwzT7/fko25DgC2pne2OXi4vhNN6RtuWySrvKkox0 X-Received: by 2002:a62:648a:0:b0:572:76dd:3756 with SMTP id y132-20020a62648a000000b0057276dd3756mr17940996pfb.9.1669361766830; Thu, 24 Nov 2022 23:36:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669361766; cv=none; d=google.com; s=arc-20160816; b=F84O8Y4Stx9aJ5Zov4FAxfb2YzySKeoo+83VKK7/NWmPQUcvvqaprQDS9ERi9TIE4e QFT/DQOZH1Y/AMAAwLwMWr/X2CUUyJ1ll+3cCIFxI+9P73COtXsLHKmVQuVikQSBSzgt AtQAGlsm6Mh1AWW/GbrI9zgXmEU8DoyHNrDpNPVByU+uCac4Z2ClfdyYfSdqtAU+mJqa jOMcSSiH74bZuY8wBgXd5MmGdyQB7vo4U8LBJ/rzibyIqILo2BLzicV2ZHKt7L07hUz2 afpSma+Op38QX86dFwgCPotSnS0eSRZoxp1hYYDklyG1nLFHjvCmkGomOoXeeY2N74Rb VzDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=1ImTHg8wp1YuWBD1u/zKh5wMZcbvJBeWeRc4u2kWfZ0=; b=TvpvWmQ0cZewZPEsT7JIoJdicbyULD4X0MeLAY5X3rkush050ef0bQLaiBf0Gop8HZ 9o8wZ3XnguHtBn5VY68vAxAC5OrnHzdPYBPjX31d/ux6Mosd3wZl79SDLdeudyS0faWK FralX3pSDPMc/fx0PM+2AGtQxVloesakVYw4TnPU0Sf5lRxX7SnHPwDtQPpL9QQtTf96 0hUAyxENp/+6B9AeAnJabmSxmrUD2HBauH7A0DUbDwEWII23+fmxmBlAp7aFTgmAVXjb /NzUEz7wehKc183Xy20ILUKdhqAsqwT1iV+QiF0RZJTcId2QGkG+gS4M+TtlfM2TOeoc knkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=KZ5zA6j6; dkim=neutral (no key) header.i=@suse.de header.b="Ckc/7vyN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a63544d000000b004774a855372si3342856pgm.694.2022.11.24.23.35.52; Thu, 24 Nov 2022 23:36:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=KZ5zA6j6; dkim=neutral (no key) header.i=@suse.de header.b="Ckc/7vyN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbiKYHbY (ORCPT <rfc822;zxc52fgh@gmail.com> + 99 others); Fri, 25 Nov 2022 02:31:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbiKYHbU (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 25 Nov 2022 02:31:20 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AD332EF22; Thu, 24 Nov 2022 23:31:17 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 15EE31FD6A; Fri, 25 Nov 2022 07:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669361476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1ImTHg8wp1YuWBD1u/zKh5wMZcbvJBeWeRc4u2kWfZ0=; b=KZ5zA6j6enxVMk9kJL/P2SkmkBHJI6x3TixF7VexpB2x+/wUKjQ0uxkUpo2/OpkjEHPTvo 4CDsYBLXB/KPZ9xIUcMFQWK62791iWHlfAF6a87RPBvPR7LMRoc0S6YvGx6dLkvm5rmhTC uxFtMSfn7cosRM14SrOvLDgHDnA5q+w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669361476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1ImTHg8wp1YuWBD1u/zKh5wMZcbvJBeWeRc4u2kWfZ0=; b=Ckc/7vyNb4POxJJZBB3qajXdQwMTz3NSSyoTvMIrAd5UMnq41pisSgTZPWUqGPBZtzYng4 Qdht/XBPh/KyhqAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E351E1361C; Fri, 25 Nov 2022 07:31:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +hTeNUNvgGN7DQAAMHmgww (envelope-from <jdelvare@suse.de>); Fri, 25 Nov 2022 07:31:15 +0000 Date: Fri, 25 Nov 2022 08:31:14 +0100 From: Jean Delvare <jdelvare@suse.de> To: linux-spi@vger.kernel.org Cc: LKML <linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org> Subject: [PATCH] spi: cadence: Drop obsolete dependency on COMPILE_TEST Message-ID: <20221125083114.67e7f83c@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750452683900796787?= X-GMAIL-MSGID: =?utf-8?q?1750452683900796787?= |
Series |
spi: cadence: Drop obsolete dependency on COMPILE_TEST
|
|
Commit Message
Jean Delvare
Nov. 25, 2022, 7:31 a.m. UTC
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Mark Brown <broonie@kernel.org>
---
drivers/spi/Kconfig | 2 +-
drivers/spi/spi-cadence-xspi.c | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
Comments
On Fri, 25 Nov 2022 08:31:14 +0100, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is no longer needed. > > It is actually better to always build such drivers with OF enabled, > so that the test builds are closer to how each driver will actually be > built on its intended target. Building them without OF may not test > much as the compiler will optimize out potentially large parts of the > code. In the worst case, this could even pop false positive warnings. > Dropping COMPILE_TEST here improves the quality of our testing and > avoids wasting time on non-existent issues. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: cadence: Drop obsolete dependency on COMPILE_TEST commit: 9c512e476b0bf8b4f22982eac82db7ff7cc08f73 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
--- linux-6.0.orig/drivers/spi/Kconfig +++ linux-6.0/drivers/spi/Kconfig @@ -241,7 +241,7 @@ config SPI_CADENCE_QUADSPI config SPI_CADENCE_XSPI tristate "Cadence XSPI controller" - depends on (OF || COMPILE_TEST) && HAS_IOMEM + depends on OF && HAS_IOMEM depends on SPI_MEM help Enable support for the Cadence XSPI Flash controller. --- linux-6.0.orig/drivers/spi/spi-cadence-xspi.c +++ linux-6.0/drivers/spi/spi-cadence-xspi.c @@ -609,7 +609,6 @@ static int cdns_xspi_probe(struct platfo return 0; } -#ifdef CONFIG_OF static const struct of_device_id cdns_xspi_of_match[] = { { .compatible = "cdns,xspi-nor", @@ -617,9 +616,6 @@ static const struct of_device_id cdns_xs { /* end of table */} }; MODULE_DEVICE_TABLE(of, cdns_xspi_of_match); -#else -#define cdns_xspi_of_match NULL -#endif /* CONFIG_OF */ static struct platform_driver cdns_xspi_platform_driver = { .probe = cdns_xspi_probe,