diff mbox series

dma-contiguous: remove debug code to removed CONFIG_CMA_DEBUG

Message ID 20240207143825.986-1-lukas.bulwahn@gmail.com
State New
Headers
Series dma-contiguous: remove debug code to removed CONFIG_CMA_DEBUG |

Commit Message

Lukas Bulwahn Feb. 7, 2024, 2:38 p.m. UTC 
  Commit acc2f3e42d4a ("mm/cma: drop CONFIG_CMA_DEBUG") removes the config
CMA_DEBUG and the debug code in cma.c, but misses debug code in
kernel/dma/contiguous.c.

Remove this dead code from this removed config option.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Andrew, please pick this minor clean-up patch of top of the commit above.

 kernel/dma/contiguous.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Anshuman Khandual Feb. 8, 2024, 4:01 a.m. UTC | #1 
On 2/7/24 20:08, Lukas Bulwahn wrote:
> Commit acc2f3e42d4a ("mm/cma: drop CONFIG_CMA_DEBUG") removes the config
> CMA_DEBUG and the debug code in cma.c, but misses debug code in
> kernel/dma/contiguous.c.
> 
> Remove this dead code from this removed config option.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Andrew, please pick this minor clean-up patch of top of the commit above.
> 
>  kernel/dma/contiguous.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
> index f005c66f378c..055da410ac71 100644
> --- a/kernel/dma/contiguous.c
> +++ b/kernel/dma/contiguous.c
> @@ -37,12 +37,6 @@
>  
>  #define pr_fmt(fmt) "cma: " fmt
>  
> -#ifdef CONFIG_CMA_DEBUG
> -#ifndef DEBUG
> -#  define DEBUG
> -#endif
> -#endif
> -
>  #include <asm/page.h>
>  
>  #include <linux/memblock.h>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Christoph Hellwig Feb. 27, 2024, 3:44 p.m. UTC | #2 
Thanks,

added to the dma-mapping for-next branch.
Lukas Bulwahn Feb. 27, 2024, 6:23 p.m. UTC | #3 
On Tue, Feb 27, 2024 at 4:44 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Thanks,
>
> added to the dma-mapping for-next branch.
>

Christoph, please drop this patch in your for-next branch if possible.

Andrew has picked this patch already and squashed it together with the
commit "mm/cma: drop CONFIG_CMA_DEBUG" in the mm tree. So, you do not
need to add it anymore.

Lukas
Christoph Hellwig Feb. 27, 2024, 6:44 p.m. UTC | #4 
On Tue, Feb 27, 2024 at 07:23:36PM +0100, Lukas Bulwahn wrote:
> On Tue, Feb 27, 2024 at 4:44 PM Christoph Hellwig <hch@lst.de> wrote:
> >
> > Thanks,
> >
> > added to the dma-mapping for-next branch.
> >
> 
> Christoph, please drop this patch in your for-next branch if possible.
> 
> Andrew has picked this patch already and squashed it together with the
> commit "mm/cma: drop CONFIG_CMA_DEBUG" in the mm tree. So, you do not
> need to add it anymore.

Ok, I'll drop it.
diff mbox series

Patch

diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
index f005c66f378c..055da410ac71 100644
--- a/kernel/dma/contiguous.c
+++ b/kernel/dma/contiguous.c
@@ -37,12 +37,6 @@ 
 
 #define pr_fmt(fmt) "cma: " fmt
 
-#ifdef CONFIG_CMA_DEBUG
-#ifndef DEBUG
-#  define DEBUG
-#endif
-#endif
-
 #include <asm/page.h>
 
 #include <linux/memblock.h>