Message ID | 20240226-bench-vkms-v1-1-515ef91b11c8@riseup.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-82297-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2323108dyb; Mon, 26 Feb 2024 12:43:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVQdJxwEjeeEbD9Sqfh4xm/xWJbMdswVbtrcb89HFdZX99ao1TdBLSiw12AeyhbKGb/Uknf1QWZOgI/zUD2kMybCA9BWw== X-Google-Smtp-Source: AGHT+IFADA/k5vn/U00nC/pE9Qzb4AE7ystdSsjRoKd5F1Qj22kUCmp1GSd7P7WsnP2LjkuPZ5+i X-Received: by 2002:a2e:9999:0:b0:2d2:65ff:3b78 with SMTP id w25-20020a2e9999000000b002d265ff3b78mr4758594lji.35.1708980183436; Mon, 26 Feb 2024 12:43:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708980183; cv=pass; d=google.com; s=arc-20160816; b=nw8VFpS80DU7cUtLTFGdg0UxlUwF/RtgpAYDVMbDzEEF9BHWFbIMX0uatAZPszksBr Qle/f0ygCyxCj8ckJlXEm2xkDw0DLSdBENobDKZ4GBI7+xAaKvEC6rr4DAJv19+qfnb+ yqJi/fH1BZua8151qOJDD4SPoQ7zM3kUCZGbronfJi0a3iPLG4guYjZc7BVC7FXWLqPq bnvNQ4v2RGyGLw8CCtvJZ2XKvkapiWB6aenmT2qDhsICuybT+UW8fXrR9qLemu52iuRV PWtcA+BTotuw38oRFGxJx1/sUgdor/Sqq5w+TwYPCh872HcUvfhus61fZ3vs+DGzU3rV ZuGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=lwCBzQT2NKt/TaEejd/OfGYBEftOrY9HiA0MzzixRLA=; fh=C79rJ9tF7fHlqIoMmgzpZG6Q3KkXuVkedd1JpU7e0EI=; b=UsS7bXi3wp6BhuW02KVitGSNDURuZ4FT4uqQCZR5qct/qvKoZv0/Cpk1JuMdTj39Pb b/FFxRGre7MZ6BxFhKTNmiZssx6L5fhD4KJCefa1Pgne0ERlqgkyyTiMQnSc9mpuS2gK KExRr+hlTbtaopSgNHAh/etfG8BExSQABOLZm5xesTL3lAm2ks21VfBtKjApoSJmgFvo 2S7rCED/AYWTSu++tJ1BhiqJZBUVZVpcam2IatCnx0F1aD5wWnQxcdYgP4DL5kLWtez7 mmSojkveZdSCv6zY63WyUE/WT3Ug2WVD5IvYgFzFaa4FnTGLRznmTSAvKiiYq+DyDIeO QFiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@riseup.net header.s=squak header.b=eJKJaNiO; arc=pass (i=1 spf=pass spfdomain=riseup.net dkim=pass dkdomain=riseup.net dmarc=pass fromdomain=riseup.net); spf=pass (google.com: domain of linux-kernel+bounces-82297-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82297-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=riseup.net Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a96-20020a509ee9000000b00565b455aaf5si76562edf.633.2024.02.26.12.43.03 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 12:43:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82297-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@riseup.net header.s=squak header.b=eJKJaNiO; arc=pass (i=1 spf=pass spfdomain=riseup.net dkim=pass dkdomain=riseup.net dmarc=pass fromdomain=riseup.net); spf=pass (google.com: domain of linux-kernel+bounces-82297-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82297-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=riseup.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0F7741F236B6 for <ouuuleilei@gmail.com>; Mon, 26 Feb 2024 20:43:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 78B99131E23; Mon, 26 Feb 2024 20:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b="eJKJaNiO" Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46AD8199B8; Mon, 26 Feb 2024 20:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.252.153.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708980148; cv=none; b=NPNg+zbXh5yKPiXRC9R2R73EgYuvQbKwe118oFEjxZ/HIU3yX1k6iyoHR2Cy7Z7Z8syaRx1yF00+hgnpcxKBVRAsVF0jUEMHq2QNk+HAAtNgviyZ3FMt2Z08S/q+wxaagOBtc5BWiGKGc6j9a6DjQhCNbi8CipHB8NzOwfU1RA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708980148; c=relaxed/simple; bh=f2j+Sd5wJcy3Yy1n0NkWtL6bNbfHHQrqDFOhVY0x1k8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=ZbFTHKw1VTUJA+BYeYEbT4UDtIufw7Dky+MmgW4PA/c0JPMeDyr2owfDKvCdafOezTqkVSCh8ta1p8nOalCDy283yZdymqNMNDP/Ie1NTtmUCXfclMAhBhEf5WeK33DNi+u54Bk4qP3F0SzCtG8qr+HjAn/bjmmzlbtbDdUIXAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net; spf=pass smtp.mailfrom=riseup.net; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b=eJKJaNiO; arc=none smtp.client-ip=198.252.153.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riseup.net Received: from fews01-sea.riseup.net (fews01-sea-pn.riseup.net [10.0.1.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4TkCGn1mkXzDqW9; Mon, 26 Feb 2024 20:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1708980145; bh=f2j+Sd5wJcy3Yy1n0NkWtL6bNbfHHQrqDFOhVY0x1k8=; h=From:Date:Subject:To:Cc:From; b=eJKJaNiOEN9yQrggyt8qHJPDQBSeGfSeu+XmODTsDxvhyE+cJeaJFHA6SBX99rUUp SOGaGwDpB1o1yEQENJXM38tn5foDMlQy0cr3VJ5fCEtcwXnl/VzZCyrqOmY04xjCy6 FxNkvHjZ1QPrjIszOMkpTRGHaHRUMvAkcV4V8f/I= X-Riseup-User-ID: 5C435D2CB39E271D201AEA1B972B596A08179232E5392308FFFB717330863423 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews01-sea.riseup.net (Postfix) with ESMTPSA id 4TkCGh2RgTzJn68; Mon, 26 Feb 2024 20:42:19 +0000 (UTC) From: Arthur Grillo <arthurgrillo@riseup.net> Date: Mon, 26 Feb 2024 17:42:11 -0300 Subject: [PATCH] drm/vkms: Add information on how to benchmark Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240226-bench-vkms-v1-1-515ef91b11c8@riseup.net> X-B4-Tracking: v=1; b=H4sIAKL33GUC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIxMDIyMz3aTUvOQM3bLs3GJd0ySLJPPExCQjU9NUJaCGgqLUtMwKsGHRsbW 1AGPd0U9cAAAA To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>, Melissa Wen <melissa.srw@gmail.com>, =?utf-8?q?Ma=C3=ADra_Canal?= <mairacanal@riseup.net>, Haneen Mohammed <hamohammed.sa@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Jonathan Corbet <corbet@lwn.net>, Pekka Paalanen <pekka.paalanen@collabora.com> Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Arthur Grillo <arthurgrillo@riseup.net> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791995604503196183 X-GMAIL-MSGID: 1791995604503196183 |
Series |
drm/vkms: Add information on how to benchmark
|
|
Commit Message
Arthur Grillo
Feb. 26, 2024, 8:42 p.m. UTC
Now that we have a defined benchmark for testing the driver, add
documentation on how to run it.
Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
---
Documentation/gpu/vkms.rst | 6 ++++++
1 file changed, 6 insertions(+)
---
base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f
change-id: 20240226-bench-vkms-5b8b7aab255e
Best regards,
Comments
On Mon, 26 Feb 2024 17:42:11 -0300 Arthur Grillo <arthurgrillo@riseup.net> wrote: > Now that we have a defined benchmark for testing the driver, add > documentation on how to run it. > > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > --- > Documentation/gpu/vkms.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst > index ba04ac7c2167..6d07f79f77ff 100644 > --- a/Documentation/gpu/vkms.rst > +++ b/Documentation/gpu/vkms.rst > @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: > sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" > sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip > > +If you are developing features that may affect performance, you can run the kms_fb_stress s/can/must/ > +benchmark:: before and after, and report the numbers. > + > + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" > + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress Do people need to run both commands? Anyway, a good idea. Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com> Thanks, pq > + > TODO > ==== > > > --- > base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f > change-id: 20240226-bench-vkms-5b8b7aab255e > > Best regards,
On 27/02/24 06:19, Pekka Paalanen wrote: > On Mon, 26 Feb 2024 17:42:11 -0300 > Arthur Grillo <arthurgrillo@riseup.net> wrote: > >> Now that we have a defined benchmark for testing the driver, add >> documentation on how to run it. >> >> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> >> --- >> Documentation/gpu/vkms.rst | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst >> index ba04ac7c2167..6d07f79f77ff 100644 >> --- a/Documentation/gpu/vkms.rst >> +++ b/Documentation/gpu/vkms.rst >> @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: >> sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" >> sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip >> >> +If you are developing features that may affect performance, you can run the kms_fb_stress > > s/can/must/ > >> +benchmark:: > > before and after, and report the numbers. Did you mean to write the benchmarks logs here? > >> + >> + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" >> + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress > > Do people need to run both commands? No, they don't, just two options. Best Regards, ~Arthur Grillo > > Anyway, a good idea. > > Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com> > > > Thanks, > pq > >> + >> TODO >> ==== >> >> >> --- >> base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f >> change-id: 20240226-bench-vkms-5b8b7aab255e >> >> Best regards, >
On Tue, 27 Feb 2024 08:44:52 -0300 Arthur Grillo <arthurgrillo@riseup.net> wrote: > On 27/02/24 06:19, Pekka Paalanen wrote: > > On Mon, 26 Feb 2024 17:42:11 -0300 > > Arthur Grillo <arthurgrillo@riseup.net> wrote: > > > >> Now that we have a defined benchmark for testing the driver, add > >> documentation on how to run it. > >> > >> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > >> --- > >> Documentation/gpu/vkms.rst | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst > >> index ba04ac7c2167..6d07f79f77ff 100644 > >> --- a/Documentation/gpu/vkms.rst > >> +++ b/Documentation/gpu/vkms.rst > >> @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: > >> sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" > >> sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip > >> > >> +If you are developing features that may affect performance, you can run the kms_fb_stress > > > > s/can/must/ > > > >> +benchmark:: > > > > before and after, and report the numbers. > > Did you mean to write the benchmarks logs here? I mean people should be required tell their before and after numbers in either commit message (my preference) or in series cover letter (if benchmarking commits is not useful). With the addition of YUV support in VKMS, maybe the benchmark needs to start printing YUV numbers separately as a new case. Thanks, pq > > > > >> + > >> + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" > >> + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress > > > > Do people need to run both commands? > > No, they don't, just two options. > > Best Regards, > ~Arthur Grillo > > > > > Anyway, a good idea. > > > > Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com> > > > > > > Thanks, > > pq > > > >> + > >> TODO > >> ==== > >> > >> > >> --- > >> base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f > >> change-id: 20240226-bench-vkms-5b8b7aab255e > >> > >> Best regards, > >
On 27/02/24 08:55, Pekka Paalanen wrote: > On Tue, 27 Feb 2024 08:44:52 -0300 > Arthur Grillo <arthurgrillo@riseup.net> wrote: > >> On 27/02/24 06:19, Pekka Paalanen wrote: >>> On Mon, 26 Feb 2024 17:42:11 -0300 >>> Arthur Grillo <arthurgrillo@riseup.net> wrote: >>> >>>> Now that we have a defined benchmark for testing the driver, add >>>> documentation on how to run it. >>>> >>>> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> >>>> --- >>>> Documentation/gpu/vkms.rst | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst >>>> index ba04ac7c2167..6d07f79f77ff 100644 >>>> --- a/Documentation/gpu/vkms.rst >>>> +++ b/Documentation/gpu/vkms.rst >>>> @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: >>>> sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" >>>> sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip >>>> >>>> +If you are developing features that may affect performance, you can run the kms_fb_stress >>> >>> s/can/must/ >>> >>>> +benchmark:: >>> >>> before and after, and report the numbers. >> >> Did you mean to write the benchmarks logs here? > > I mean people should be required tell their before and after numbers in > either commit message (my preference) or in series cover letter (if > benchmarking commits is not useful). > > With the addition of YUV support in VKMS, maybe the benchmark needs to With the upcoming addition, I've sent a patch to arbitrarily change the formats on the benchmark via command-line options. It's not adding a new case, but maybe just this could already help. https://lore.kernel.org/all/20240226-kms_fb_stress-dev-v1-0-1c14942b1244@riseup.net/ Best Regards, ~Arthur Grillo > start printing YUV numbers separately as a new case. > > > Thanks, > pq > >> >>> >>>> + >>>> + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" >>>> + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress >>> >>> Do people need to run both commands? >> >> No, they don't, just two options. >> >> Best Regards, >> ~Arthur Grillo >> >>> >>> Anyway, a good idea. >>> >>> Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com> >>> >>> >>> Thanks, >>> pq >>> >>>> + >>>> TODO >>>> ==== >>>> >>>> >>>> --- >>>> base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f >>>> change-id: 20240226-bench-vkms-5b8b7aab255e >>>> >>>> Best regards, >>> >
On Tue, 27 Feb 2024 09:29:58 -0300 Arthur Grillo <arthurgrillo@riseup.net> wrote: > On 27/02/24 08:55, Pekka Paalanen wrote: > > On Tue, 27 Feb 2024 08:44:52 -0300 > > Arthur Grillo <arthurgrillo@riseup.net> wrote: > > > >> On 27/02/24 06:19, Pekka Paalanen wrote: > >>> On Mon, 26 Feb 2024 17:42:11 -0300 > >>> Arthur Grillo <arthurgrillo@riseup.net> wrote: > >>> > >>>> Now that we have a defined benchmark for testing the driver, add > >>>> documentation on how to run it. > >>>> > >>>> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > >>>> --- > >>>> Documentation/gpu/vkms.rst | 6 ++++++ > >>>> 1 file changed, 6 insertions(+) > >>>> > >>>> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst > >>>> index ba04ac7c2167..6d07f79f77ff 100644 > >>>> --- a/Documentation/gpu/vkms.rst > >>>> +++ b/Documentation/gpu/vkms.rst > >>>> @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: > >>>> sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" > >>>> sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip > >>>> > >>>> +If you are developing features that may affect performance, you can run the kms_fb_stress > >>> > >>> s/can/must/ > >>> > >>>> +benchmark:: > >>> > >>> before and after, and report the numbers. > >> > >> Did you mean to write the benchmarks logs here? > > > > I mean people should be required tell their before and after numbers in > > either commit message (my preference) or in series cover letter (if > > benchmarking commits is not useful). > > > > With the addition of YUV support in VKMS, maybe the benchmark needs to > > With the upcoming addition, I've sent a patch to arbitrarily change the > formats on the benchmark via command-line options. It's not adding a new > case, but maybe just this could already help. > > https://lore.kernel.org/all/20240226-kms_fb_stress-dev-v1-0-1c14942b1244@riseup.net/ In that case you would need to document exactly what command line options to use, and ask people to report the numbers of each test case. That works. Alternatively or additionally, the test cases could be built in to the benchmark, and it just reports numbers for all of them in a single invocation. Then people running the standard benchmark do not need to worry about getting the command line options right, or running multiple cases. And reviewers do not need to ask to re-run with the correct options. I suppose rotations might get added, too. Or maybe you'd provide a script that covers all the standard performance test cases? Thanks, pq > > start printing YUV numbers separately as a new case. > > > > > > Thanks, > > pq > > > >> > >>> > >>>> + > >>>> + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" > >>>> + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress > >>> > >>> Do people need to run both commands? > >> > >> No, they don't, just two options. > >> > >> Best Regards, > >> ~Arthur Grillo > >> > >>> > >>> Anyway, a good idea. > >>> > >>> Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com> > >>> > >>> > >>> Thanks, > >>> pq > >>> > >>>> + > >>>> TODO > >>>> ==== > >>>> > >>>> > >>>> --- > >>>> base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f > >>>> change-id: 20240226-bench-vkms-5b8b7aab255e > >>>> > >>>> Best regards, > >>> > >
Le 27/02/24 - 15:26, Pekka Paalanen a écrit : > On Tue, 27 Feb 2024 09:29:58 -0300 > Arthur Grillo <arthurgrillo@riseup.net> wrote: > > > On 27/02/24 08:55, Pekka Paalanen wrote: > > > On Tue, 27 Feb 2024 08:44:52 -0300 > > > Arthur Grillo <arthurgrillo@riseup.net> wrote: > > > > > >> On 27/02/24 06:19, Pekka Paalanen wrote: > > >>> On Mon, 26 Feb 2024 17:42:11 -0300 > > >>> Arthur Grillo <arthurgrillo@riseup.net> wrote: > > >>> > > >>>> Now that we have a defined benchmark for testing the driver, add > > >>>> documentation on how to run it. > > >>>> > > >>>> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > > >>>> --- > > >>>> Documentation/gpu/vkms.rst | 6 ++++++ > > >>>> 1 file changed, 6 insertions(+) > > >>>> > > >>>> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst > > >>>> index ba04ac7c2167..6d07f79f77ff 100644 > > >>>> --- a/Documentation/gpu/vkms.rst > > >>>> +++ b/Documentation/gpu/vkms.rst > > >>>> @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: > > >>>> sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" > > >>>> sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip > > >>>> > > >>>> +If you are developing features that may affect performance, you can run the kms_fb_stress > > >>> > > >>> s/can/must/ > > >>> > > >>>> +benchmark:: > > >>> > > >>> before and after, and report the numbers. > > >> > > >> Did you mean to write the benchmarks logs here? > > > > > > I mean people should be required tell their before and after numbers in > > > either commit message (my preference) or in series cover letter (if > > > benchmarking commits is not useful). > > > > > > With the addition of YUV support in VKMS, maybe the benchmark needs to > > > > With the upcoming addition, I've sent a patch to arbitrarily change the > > formats on the benchmark via command-line options. It's not adding a new > > case, but maybe just this could already help. > > > > https://lore.kernel.org/all/20240226-kms_fb_stress-dev-v1-0-1c14942b1244@riseup.net/ > > In that case you would need to document exactly what command line > options to use, and ask people to report the numbers of each test > case. > > That works. Alternatively or additionally, the test cases could be > built in to the benchmark, and it just reports numbers for all of them > in a single invocation. Then people running the standard benchmark do > not need to worry about getting the command line options right, or > running multiple cases. And reviewers do not need to ask to re-run with > the correct options. > > I suppose rotations might get added, too. > > Or maybe you'd provide a script that covers all the standard > performance test cases? I agree with Pekka, it would be nice to have a simple "bench everything" tool. Like kms_rotation is a test for all rotations, kms_plane for color conversions... kms_fb_test can run a few combinations (rgb+norotation, rgb+yuv, rgb+rotation...) and report a "global result" (this way it's easy to spot a regression not related directly to your changes). I don't know the IGT benchmark API, but I think there is a way to create "sub-benchmarks" so you can run a specific benchmark when developping and the whole thing before pushing your series. Kind regards, Louis Chauvet > > Thanks, > pq > > > > start printing YUV numbers separately as a new case. > > > > > > > > > Thanks, > > > pq > > > > > >> > > >>> > > >>>> + > > >>>> + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" > > >>>> + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress > > >>> > > >>> Do people need to run both commands? > > >> > > >> No, they don't, just two options. > > >> > > >> Best Regards, > > >> ~Arthur Grillo > > >> > > >>> > > >>> Anyway, a good idea. > > >>> > > >>> Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com> > > >>> > > >>> > > >>> Thanks, > > >>> pq > > >>> > > >>>> + > > >>>> TODO > > >>>> ==== > > >>>> > > >>>> > > >>>> --- > > >>>> base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f > > >>>> change-id: 20240226-bench-vkms-5b8b7aab255e > > >>>> > > >>>> Best regards, > > >>> > > > >
On 27/02/24 12:02, Louis Chauvet wrote: > Le 27/02/24 - 15:26, Pekka Paalanen a écrit : >> On Tue, 27 Feb 2024 09:29:58 -0300 >> Arthur Grillo <arthurgrillo@riseup.net> wrote: >> >>> On 27/02/24 08:55, Pekka Paalanen wrote: >>>> On Tue, 27 Feb 2024 08:44:52 -0300 >>>> Arthur Grillo <arthurgrillo@riseup.net> wrote: >>>> >>>>> On 27/02/24 06:19, Pekka Paalanen wrote: >>>>>> On Mon, 26 Feb 2024 17:42:11 -0300 >>>>>> Arthur Grillo <arthurgrillo@riseup.net> wrote: >>>>>> >>>>>>> Now that we have a defined benchmark for testing the driver, add >>>>>>> documentation on how to run it. >>>>>>> >>>>>>> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> >>>>>>> --- >>>>>>> Documentation/gpu/vkms.rst | 6 ++++++ >>>>>>> 1 file changed, 6 insertions(+) >>>>>>> >>>>>>> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst >>>>>>> index ba04ac7c2167..6d07f79f77ff 100644 >>>>>>> --- a/Documentation/gpu/vkms.rst >>>>>>> +++ b/Documentation/gpu/vkms.rst >>>>>>> @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: >>>>>>> sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" >>>>>>> sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip >>>>>>> >>>>>>> +If you are developing features that may affect performance, you can run the kms_fb_stress >>>>>> >>>>>> s/can/must/ >>>>>> >>>>>>> +benchmark:: >>>>>> >>>>>> before and after, and report the numbers. >>>>> >>>>> Did you mean to write the benchmarks logs here? >>>> >>>> I mean people should be required tell their before and after numbers in >>>> either commit message (my preference) or in series cover letter (if >>>> benchmarking commits is not useful). >>>> >>>> With the addition of YUV support in VKMS, maybe the benchmark needs to >>> >>> With the upcoming addition, I've sent a patch to arbitrarily change the >>> formats on the benchmark via command-line options. It's not adding a new >>> case, but maybe just this could already help. >>> >>> https://lore.kernel.org/all/20240226-kms_fb_stress-dev-v1-0-1c14942b1244@riseup.net/ >> >> In that case you would need to document exactly what command line >> options to use, and ask people to report the numbers of each test >> case. >> >> That works. Alternatively or additionally, the test cases could be >> built in to the benchmark, and it just reports numbers for all of them >> in a single invocation. Then people running the standard benchmark do >> not need to worry about getting the command line options right, or >> running multiple cases. And reviewers do not need to ask to re-run with >> the correct options. >> >> I suppose rotations might get added, too. >> >> Or maybe you'd provide a script that covers all the standard >> performance test cases? > > I agree with Pekka, it would be nice to have a simple "bench everything" > tool. Like kms_rotation is a test for all rotations, kms_plane for color > conversions... kms_fb_test can run a few combinations (rgb+norotation, > rgb+yuv, rgb+rotation...) and report a "global result" (this way it's easy > to spot a regression not related directly to your changes). > > I don't know the IGT benchmark API, but I think there is a way to create > "sub-benchmarks" so you can run a specific benchmark when developping and > the whole thing before pushing your series. > > Kind regards, > Louis Chauvet > Thank you guys for the ideas! I'm going to work on something along on those lines, having combinations of formats, rotations and whatever property that might be useful for stress testing the driver. Maybe query the driver for the supported properties (e.g. what formats and rotations it supports) and do many/all possible combinations. Best Regards, ~Arthur Grillo >> >> Thanks, >> pq >> >>>> start printing YUV numbers separately as a new case. >>>> >>>> >>>> Thanks, >>>> pq >>>> >>>>> >>>>>> >>>>>>> + >>>>>>> + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" >>>>>>> + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress >>>>>> >>>>>> Do people need to run both commands? >>>>> >>>>> No, they don't, just two options. >>>>> >>>>> Best Regards, >>>>> ~Arthur Grillo >>>>> >>>>>> >>>>>> Anyway, a good idea. >>>>>> >>>>>> Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com> >>>>>> >>>>>> >>>>>> Thanks, >>>>>> pq >>>>>> >>>>>>> + >>>>>>> TODO >>>>>>> ==== >>>>>>> >>>>>>> >>>>>>> --- >>>>>>> base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f >>>>>>> change-id: 20240226-bench-vkms-5b8b7aab255e >>>>>>> >>>>>>> Best regards, >>>>>> >>>> >> > > >
diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index ba04ac7c2167..6d07f79f77ff 100644 --- a/Documentation/gpu/vkms.rst +++ b/Documentation/gpu/vkms.rst @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run the entire test:: sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device "sys:/sys/devices/platform/vkms" sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/tests/kms_flip --run-subtest basic-plain-flip +If you are developing features that may affect performance, you can run the kms_fb_stress +benchmark:: + + sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/platform/vkms" + sudo IGT_DEVICE="sys:/sys/devices/platform/vkms" ./build/benchmarks/kms_fb_stress + TODO ====